Re: [PATCH v7 8/8] drivers: net: macb: add fu740 support

2021-09-27 Thread Bin Meng
Hi, On Thu, Apr 22, 2021 at 5:14 PM Green Wan wrote: > > From: David Abdurachmanov > > Add fu740 support to macb ethernet driver > > There is a PLL HW quirk in FU740. The VSC8541XMV-02 specification > requires 125 +/-0.0125 Mhz. But the most close value can be output > by PLL is 125.125 MHz and

[PATCH 00/25] Fix some non-NULL terminated strings in the networking subsystem

2021-09-27 Thread Vladimir Oltean
This series is the result of a small patching spree, which started off by noticing some truncation that might take place when setting the MDIO bus name in one driver, and then looked at what other drivers do, and then. Vladimir Oltean (25): arch: powerpc: mpc85xx: ensure mdiodev->name is

[PATCH 05/25] net: bcm-sf2: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-27 Thread Vladimir Oltean
strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more

[PATCH 11/25] net: lpc32xx: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-27 Thread Vladimir Oltean
strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more

[PATCH 21/25] scripts: ensure the cocci script for miiphy_register does not leave NULL-unterminated strings

2021-09-27 Thread Vladimir Oltean
strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more

[PATCH 10/25] net: ftmac110: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-27 Thread Vladimir Oltean
strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more

[PATCH 19/25] net: qe: uec: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-27 Thread Vladimir Oltean
strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more

[PATCH 08/25] net: enetc: ensure imdio.name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-27 Thread Vladimir Oltean
strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more

[PATCH 14/25] net: dsa: felix: ensure mii_bus->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-27 Thread Vladimir Oltean
strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more

Please pull u-boot-marvell/master

2021-09-27 Thread Stefan Roese
Hi Tom, please pull these 2 Marvell MVEBU related fixes: - turris_omnia: fix leaked mtd device (Marek) - phy: marvell: cp110: Fix SATA invert polarity (Denis) Here

[PATCH 02/25] board: gdsys: a38x: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-27 Thread Vladimir Oltean
strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more

[PATCH 07/25] net: ep93xx: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-27 Thread Vladimir Oltean
strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more

[PATCH 06/25] net: eepro100: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-27 Thread Vladimir Oltean
strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more

[PATCH 01/25] arch: powerpc: mpc85xx: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-27 Thread Vladimir Oltean
strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more

[PATCH 03/25] net: armada100_fec: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-27 Thread Vladimir Oltean
strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more

[PATCH 04/25] net: at91_emac: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-27 Thread Vladimir Oltean
strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more

[PATCH 20/25] net: mdio-uclass: rewrite dm_mdio_post_probe using strlcpy

2021-09-27 Thread Vladimir Oltean
dm_mdio_post_probe used to be vulnerable after truncation, but has been patched by commit 398e7512d8d7 ("net: Fix Covarity Defect 244093"). Nonetheless, we can use strlcpy like the rest of the code base now, which yields the same result. Signed-off-by: Vladimir Oltean --- net/mdio-uclass.c | 2

[PATCH 22/25] net: dsa: felix: check return code of mdio_alloc and mdio_register

2021-09-27 Thread Vladimir Oltean
These functions can return errors, it's best to catch them and trigger the driver unwind code path. Signed-off-by: Vladimir Oltean --- drivers/net/mscc_eswitch/felix_switch.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/mscc_eswitch/felix_switch.c

[PATCH 25/25] scripts: ensure the cocci script for miiphy_register does not leak the MDIO bus

2021-09-27 Thread Vladimir Oltean
When mdio_register fails, mdio_free should be called on the mdiodev that was previously allocated with mdio_alloc. Signed-off-by: Vladimir Oltean --- scripts/coccinelle/net/mdio_register.cocci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 16/25] net: sh_eth: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-27 Thread Vladimir Oltean
strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more

[PATCH 24/25] arch: powerpc: mpc85xx: free MDIO bus if mdio_register fails

2021-09-27 Thread Vladimir Oltean
If mdio_register fails, it is nice to not leave behind dangling allocated memory. Signed-off-by: Vladimir Oltean --- arch/powerpc/cpu/mpc85xx/ether_fcc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/cpu/mpc85xx/ether_fcc.c

Re: [PATCH] board: rpi: always set fdt_addr if provided by firmware

2021-09-27 Thread Oleksandr Suvorov
Hello Matthias, On Mon, Sep 27, 2021 at 3:01 PM Matthias Brugger wrote: > > Hi Oleksandr, > > Thanks for your patch. > > There was the very same patch posted already, please follow-up in that thread > for any comments from your side: >

[PATCH] usb: xhci: reset endpoint on USB stall

2021-09-27 Thread Stefan Agner
There are devices which cause a USB stall when trying to read strings. Specifically Arduino Mega R3 stalls when trying to read the product string. The stall currently remains unhandled, and subsequent retries submit new transfers on a stopped endpoint which ultimately cause a crash in abort_td():

Re: [PATCH] efi_driver: fix a wrong cast

2021-09-27 Thread Heinrich Schuchardt
On 9/27/21 6:30 AM, AKASHI Takahiro wrote: struct efi_driver_binding_protocol, i.e. bp, is not the first element in struct efi_driver_binding_extended_protocol. So the casting: struct efi_driver_binding_extended_protocol *bp = (struct

Re: [PATCH] board: rpi: always set fdt_addr if provided by firmware

2021-09-27 Thread Matthias Brugger
Hi Oleksandr, Thanks for your patch. There was the very same patch posted already, please follow-up in that thread for any comments from your side: https://patchwork.ozlabs.org/project/uboot/patch/20210512123945.25649-1-m.salv...@koansoftware.com/ Regards, Matthias On 25/09/2021 12:22,

[PATCH 09/25] net: mcdmafec: ensure bus->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-27 Thread Vladimir Oltean
strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more

[PATCH 13/25] net: mpc8xx_fec: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-27 Thread Vladimir Oltean
strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more

[PATCH 17/25] net: smc911x: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-27 Thread Vladimir Oltean
strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more

[PATCH 12/25] net: macb: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-27 Thread Vladimir Oltean
strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more

[PATCH 15/25] net: mvgbe: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-27 Thread Vladimir Oltean
strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more

[PATCH 23/25] net: dsa: ensure port names are NULL-terminated after DSA_PORT_NAME_LENGTH truncation

2021-09-27 Thread Vladimir Oltean
strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass DSA_PORT_NAME_LENGTH - 1 and a previously zero-initialized destination string, but this is more

[PATCH 18/25] net: davinci_emac: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-27 Thread Vladimir Oltean
strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more

Re: [PATCH] nvme: Enable FUA

2021-09-27 Thread Stefan Agner
On 2021-09-26 11:12, Jon Lin wrote: > Most NVME devcies maintain data in internal cache for an uncertain > times, and u-boot has no method to force NVME to flush cache. > So this patch adds FUA to avoid data loss caused by power off after data > programming. Maybe worth mentioning that FUA stands

[PATCH 1/2] ARM: DRA7: Enable OPP_HIGH for DSPEVE and IVA voltage domains

2021-09-27 Thread Amjad Ouled-Ameur
Enable the OPP_HIGH configuration for DSPEVE and IVA voltage domains by default for various TI DRA7xx and AM57xx boards. This is being done to meet the performance needs of 1080p MultiMedia usecases and other DSP usecases. These domains do not support DVFS and the kernel will continue to run at

[PATCH 2/2] ARM: DRA7: Enable OPP_HIGH for GPU voltage domain

2021-09-27 Thread Amjad Ouled-Ameur
Enable the OPP_HIGH configuration for GPU voltage domain by default for various TI DRA7xx and AM57xx boards. This is being done to meet the performance needs of 1080p GFX/MultiMedia usecases. This domain does not support DVFS and the kernel will continue to run at the boot OPP chosen here. Based

[PATCH 0/2] ARM: DRA7: Enable OPP_HIGH for GPU, DSPEVE and IVA voltage domains

2021-09-27 Thread Amjad Ouled-Ameur
This patchset enables the OPP_HIGH configuration for GPU, DSPEVE and IVA voltage domains by default for various TI DRA7xx and AM57xx boards. This is being done to meet the performance needs of 1080p MultiMedia usecases Amjad Ouled-Ameur (2): ARM: DRA7: Enable OPP_HIGH for DSPEVE and IVA voltage

[PATCH 2/3] board: arm: Remove OF_PRIOR_STAGE

2021-09-27 Thread Ilias Apalodimas
At some point back in 2018 prior_stage_fdt_address and OF_PRIOR_STAGE got introduced, in order to support a DTB handed over by an earlier stage boo loader. However we have another option in the Kconfig (OF_BOARD) which has identical semantics. So let's remove the option in an effort to simplify

[PATCH 1/3] treewide: Remove OF_PRIOR_STAGE from RISC-V boards

2021-09-27 Thread Ilias Apalodimas
At some point back in 2018 prior_stage_fdt_address and OF_PRIOR_STAGE got introduced, in order to support a DTB handed over by an earlier stage boo loader. However we have another option in the Kconfig (OF_BOARD) which has identical semantics. On RISC-V boards which during their startup, some

[PATCH 3/3] treewide: Remove OF_PRIOR_STAGE

2021-09-27 Thread Ilias Apalodimas
The previous patches removed OF_PRIOR_STAGE from the last consumers of the Kconfig option. Cleanup any references to it in documentation, code and configuration options. Signed-off-by: Ilias Apalodimas --- dts/Kconfig | 11 ++- include/fdtdec.h| 4

Re: [PATCH] clk: versal: Enable only GATE type clocks

2021-09-27 Thread Michal Simek
On 9/27/21 10:11 AM, Ashok Reddy Soma wrote: > From: T Karthik Reddy > > Clocks should be enabled or disabled only if they are of GATE type > clocks. If they are not of GATE type clocks, don't touch them. > > Signed-off-by: T Karthik Reddy > Signed-off-by: Ashok Reddy Soma > --- > >

Re: [PATCH v3 3/3] arm: mvebu: Initial ESPRESSOBin-Ultra board support

2021-09-27 Thread Luka Kovacic
Hello Pali, > Hello Luka! Do you need some help with this? I wasn't able to get to this yet, as I am working on something else right now and will circle back to the ESPRESSOBin-Ultra shortly. Kind regards, Luka

Re: [PATCH v2 1/3] efi_loader: add SMBIOS table measurement

2021-09-27 Thread Ilias Apalodimas
Hi Simon, [...] > > > > - remove unnecessary const qualifier from smbios_string() > > > > - create non-const version of next_header() > > > > > > > > include/efi_loader.h | 2 + > > > > include/efi_tcg2.h| 15 > > > > include/smbios.h | 17 +++- > > > >

Re: [PATCH] efi_driver: fix a wrong cast

2021-09-27 Thread AKASHI Takahiro
On Mon, Sep 27, 2021 at 09:48:54AM +0200, Heinrich Schuchardt wrote: > > > On 9/27/21 6:30 AM, AKASHI Takahiro wrote: > > struct efi_driver_binding_protocol, i.e. bp, is not the first element > > in struct efi_driver_binding_extended_protocol. > > So the casting: > > struct

Re: [PATCH] nvme: Enable FUA

2021-09-27 Thread Jon Lin
On 2021/9/27 20:28, Stefan Agner wrote: On 2021-09-26 11:12, Jon Lin wrote: Most NVME devcies maintain data in internal cache for an uncertain times, and u-boot has no method to force NVME to flush cache. So this patch adds FUA to avoid data loss caused by power off after data programming.

GSuit limit for recipients

2021-09-27 Thread Oleksandr Suvorov
Dear community, This weekend I tried to post (using patman) a patch set that should have been sent to 120 recipients (a lot of files were changed). I've got an error from the Gmail SMTP server: 4.5.3 Your message has too many recipients. For more information regarding 4.5.3 Google's sending

Re: Pull request for efi-2021-10-rc5

2021-09-27 Thread Tom Rini
On Sun, Sep 26, 2021 at 07:55:27AM +0200, Heinrich Schuchardt wrote: > The following changes since commit 8284d6f838684cfa6e3303a447deb38027c5d7f0: > > Merge branch '2021-09-24-assorted-minor-updates' (2021-09-24 14:28:54 > -0400) > > are available in the Git repository at: > >

Re: Please pull u-boot-marvell/master

2021-09-27 Thread Tom Rini
On Mon, Sep 27, 2021 at 12:58:43PM +0200, Stefan Roese wrote: > Hi Tom, > > please pull these 2 Marvell MVEBU related fixes: > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: Bug in board/logicpd/omap3som/omap3logic.h ???

2021-09-27 Thread Adam Ford
On Mon, Sep 27, 2021 at 9:49 AM Tom Rini wrote: > > On Mon, Sep 27, 2021 at 04:45:01PM +0200, Wolfgang Denk wrote: > > > Dear Adam, > > > > commit 25e4ff45b17 "ARM: omap3_logic: Enable OMAP EHCI support for > > SOM-LV Boards" added (among other things) these lines: > > > > ... > > 243

[PATCH v2 01/18] Create a new boot/ directory

2021-09-27 Thread Simon Glass
Quite a lot of the code in common/relates to booting and images. Before adding more it seems like a good time to move the code into its own directory. Most files with 'boot' or 'image' in them are moved, except: - autoboot.c which relates to U-Boot automatically running a script - bootstage.c

[PATCH v2 04/18] pxe: Move do_getfile() into the context

2021-09-27 Thread Simon Glass
Rather than having a global variable, pass the function as part of the context. Signed-off-by: Simon Glass --- (no changes since v1) cmd/pxe.c | 10 -- cmd/pxe_utils.c | 9 - cmd/pxe_utils.h | 20 +--- cmd/sysboot.c | 20 ++-- 4 files

[PATCH v2 06/18] pxe: Tidy up the is_pxe global

2021-09-27 Thread Simon Glass
Move this into the context to avoid a global variable. Also rename it since the current name does not explain what it actually affects. Signed-off-by: Simon Glass --- (no changes since v1) cmd/pxe.c | 6 ++ cmd/pxe_utils.c | 13 +++-- cmd/pxe_utils.h | 8 +---

[PATCH v2 17/18] doc: Move distro boot doc to rST

2021-09-27 Thread Simon Glass
Move this over to the new rST format. Signed-off-by: Simon Glass --- (no changes since v1) doc/{README.distro => develop/distro.rst} | 177 ++ doc/develop/index.rst | 1 + 2 files changed, 80 insertions(+), 98 deletions(-) rename doc/{README.distro

[PATCH v2 15/18] pxe: Return the file size from the getfile() function

2021-09-27 Thread Simon Glass
It is pretty strange that the pxe code uses the 'filesize' environment variable find the size of a file it has just read. Partly this is because it uses the command-line interpreter to parse its request to load the file. As a first step towards unwinding this, return it directly from the

Re: [PATCH 2/4] dm: hash: Add new UCLASS_HASH support

2021-09-27 Thread Alex G.
On 9/23/21 9:49 PM, Simon Glass wrote:> On Thu, 16 Sept 2021 at 09:43, Alex G. wrote: On 7/29/21 8:08 PM, Chia-Wei Wang wrote: + +enum HASH_ALGO hash_algo_lookup_by_name(const char *name) string -> hash_lookup_algo() -> ops struct Is the current way to do things.

Re: [PATCH v5 05/29] hash: Use Kconfig to enable hashing in host tools and SPL

2021-09-27 Thread Alex G.
Hi Simon On 9/25/21 8:43 PM, Simon Glass wrote: At present when building host tools, we force CONFIG_SHAxxx to be enabled regardless of the board Kconfig setting. This is done in the image.h header file. For SPL we currently just assume the algorithm is desired if U-Boot proper enables it.

[PATCH v2 1/2] nvme: Enable FUA

2021-09-27 Thread Jon Lin
Most NVME devcies maintain data in internal cache for an uncertain times, and u-boot has no method to force NVME to flush cache. So this patch adds FUA to avoid data loss caused by power off after data programming. Signed-off-by: Jon Lin Reviewed-by: Stefan Agner --- (no changes since v1)

[PATCH v2 2/2] nvme: Fix error in nvme_setup_prps

2021-09-27 Thread Jon Lin
Consulting to "NVM Express® Base Specification, revision 2.0". If more PRP List pages are required, then the last entry of the PRP List contains the Page Base Address of the next PRP List page. The next PRP List page shall be memory page aligned. Signed-off-by: Jon Lin --- (no changes since

[ANN] U-Boot v2021.10-rc5 released

2021-09-27 Thread Tom Rini
Hey all, It is release day and here is v2021.10-rc5. At this point we're a week out from the release. I know of the series here: https://patchwork.ozlabs.org/project/uboot/list/?series=263618=* to restore mtd naming of nor%d to fix a regression within "mtd" for NOR flashes. I think everyone is

Re: Two jobs at once on denx-vulcan?

2021-09-27 Thread Tom Rini
On Fri, Sep 24, 2021 at 05:36:31PM -0600, Simon Glass wrote: > Hi Tom, > > On Fri, 24 Sept 2021 at 08:55, Tom Rini wrote: > > > > On Fri, Sep 24, 2021 at 08:38:49AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Fri, 24 Sept 2021 at 08:20, Tom Rini wrote: > > > > > > > > On Fri, Sep 24,

Re: [PATCH v2 3/3] efi_loader: add DeployedMode and AuditMode variable measurement

2021-09-27 Thread Ilias Apalodimas
On Tue, 21 Sept 2021 at 10:17, Masahisa Kojima wrote: > > This commit adds the DeployedMode and AuditMode variable > measurement required in TCG PC Client PFP Spec. > > Signed-off-by: Masahisa Kojima > --- > > (no changes since v1) > > lib/efi_loader/efi_tcg2.c | 47

[PATCH v2 16/18] pxe: Refactor sysboot to have one helper

2021-09-27 Thread Simon Glass
The only difference between the three helpers is the filesystem type. Factor this out and call the filesystem functions directly, instead of through the command-line interpreter. This allows the file size to be obtained directly, instead of via an environment variable. We cannot do the same thing

[PATCH v2 13/18] lib: Add tests for simple_itoa()

2021-09-27 Thread Simon Glass
Add test and a comment for this function. Signed-off-by: Simon Glass --- (no changes since v1) include/vsprintf.h | 13 - test/print_ut.c| 17 + 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/include/vsprintf.h b/include/vsprintf.h index

[PATCH v2 14/18] lib: Add a function to convert a string to a hex value

2021-09-27 Thread Simon Glass
Add an xtoa() function, similar to itoa() but for hex instead. Signed-off-by: Simon Glass --- (no changes since v1) include/vsprintf.h | 16 ++-- lib/vsprintf.c | 20 ++-- test/print_ut.c| 24 3 files changed, 56 insertions(+), 4

[PATCH v2 10/18] pxe: Move common parsing coding into pxe_util

2021-09-27 Thread Simon Glass
Both the syslinux and pxe commands use essentially the same code to parse and run extlinux.conf files. Move this into a common function. Signed-off-by: Simon Glass --- (no changes since v1) boot/pxe_utils.c| 20 cmd/pxe.c | 15 --- cmd/sysboot.c

Re: Status of the various RISC-V specification and policy

2021-09-27 Thread Palmer Dabbelt
On Tue, 21 Sep 2021 17:20:17 PDT (-0700), ati...@atishpatra.org wrote: Hi All, Please find the below email from Stephano about the freeze announcement for various RISC-V specifications that will be part of privilege specification v1.12. All the review discussions are happening in the isa-dev

Re: [PATCH] usb: xhci: reset endpoint on USB stall

2021-09-27 Thread Marek Vasut
On 9/27/21 2:42 PM, Stefan Agner wrote: There are devices which cause a USB stall when trying to read strings. Specifically Arduino Mega R3 stalls when trying to read the product string. The stall currently remains unhandled, and subsequent retries submit new transfers on a stopped endpoint

Re: Bug in board/logicpd/omap3som/omap3logic.h ???

2021-09-27 Thread Wolfgang Denk
Dear Adam, In message you wrote: > > > > > > commit 25e4ff45b17 "ARM: omap3_logic: Enable OMAP EHCI support for > > > SOM-LV Boards" added (among other things) these lines: > > > > > > ... > > > 243 MUX_VAL(CP(MCSPI2_SOMI),(IEN | PTD | DIS | M0)); > > > /*HSUSB2_DATA5*/

Bug in board/logicpd/omap3som/omap3logic.h ???

2021-09-27 Thread Wolfgang Denk
Dear Adam, commit 25e4ff45b17 "ARM: omap3_logic: Enable OMAP EHCI support for SOM-LV Boards" added (among other things) these lines: ... 243 MUX_VAL(CP(MCSPI2_SOMI),(IEN | PTD | DIS | M0)); /*HSUSB2_DATA5*/ 244 MUX_VAL(CP(MCSPI2_CS0), (IEN | PTD | EN |

[PATCH v2 00/18] pxe: Refactoring to tidy up and prepare for bootflow

2021-09-27 Thread Simon Glass
This collects together the patches previously sent relating to PXE. Firstly, it moves the boot code out of common/ and into a new boot/ directory. This helps to collect these related files in one place, as common/ is quite large. Secondly, it provides patache so clean up the PXE code and

[PATCH v2 09/18] pxe: Tidy up code style a little in pxe_utils

2021-09-27 Thread Simon Glass
There are a few more blank lines than makes sense for readability. Also free() handles a NULL pointer so drop the pointless checks. Signed-off-by: Simon Glass --- (no changes since v1) boot/pxe_utils.c | 66 ++-- 1 file changed, 13 insertions(+), 53

[PATCH v2 12/18] pxe: Drop get_bootfile_path()

2021-09-27 Thread Simon Glass
This function no longer makes sense, since it is pretty easy to prepend the boot directory to the filename. Drop it and update its only caller. Signed-off-by: Simon Glass --- (no changes since v1) boot/pxe_utils.c| 53 + include/pxe_utils.h | 3

[PATCH v2 11/18] pxe: Clean up the use of bootfile

2021-09-27 Thread Simon Glass
The 'bootfile' environment variable is read in the bowels of pxe_util to provide a directory to which all loaded files are relative. This is not obvious from the API to PXE and it is strange to make the caller set an environment variable rather than pass this as a parameter. The code is also

[PATCH v2 18/18] pxe: Allow calling the pxe_get logic directly

2021-09-27 Thread Simon Glass
Refactor this code so that we can call the 'pxe get' command without going through the command-line interpreter. This makes it easier to get the information we need, without going through environment variables. Signed-off-by: Simon Glass --- Changes in v2: - Rebase to -next - Split out from the

Re: [PATCH 0/2] ARM: DRA7: Enable OPP_HIGH for GPU, DSPEVE and IVA voltage domains

2021-09-27 Thread Suman Anna
Hi Amjad, On 9/27/21 7:34 AM, Amjad Ouled-Ameur wrote: > This patchset enables the OPP_HIGH configuration for GPU, DSPEVE and IVA > voltage domains by default for various TI DRA7xx and AM57xx boards. This > is being done to meet the performance needs of 1080p MultiMedia usecases > > Amjad

Re: [PATCH 0/2] ARM: DRA7: Enable OPP_HIGH for GPU, DSPEVE and IVA voltage domains

2021-09-27 Thread Tom Rini
On Mon, Sep 27, 2021 at 09:43:01AM -0500, Suman Anna wrote: > Hi Amjad, > > On 9/27/21 7:34 AM, Amjad Ouled-Ameur wrote: > > This patchset enables the OPP_HIGH configuration for GPU, DSPEVE and IVA > > voltage domains by default for various TI DRA7xx and AM57xx boards. This > > is being done to

Re: Bug in board/logicpd/omap3som/omap3logic.h ???

2021-09-27 Thread Tom Rini
On Mon, Sep 27, 2021 at 04:45:01PM +0200, Wolfgang Denk wrote: > Dear Adam, > > commit 25e4ff45b17 "ARM: omap3_logic: Enable OMAP EHCI support for > SOM-LV Boards" added (among other things) these lines: > > ... > 243 MUX_VAL(CP(MCSPI2_SOMI),(IEN | PTD | DIS | M0)); >

Please pull u-boot-dm/next

2021-09-27 Thread Simon Glass
Hi Tom, This is for the -next branch. https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/9260 The following changes since commit bb38d77ca779cc8bdad3d4ceb6cecc687f4987c2: vexpress_ca9x4: Add missing SYS_LOAD_ADDR (2021-09-24 22:12:35 -0400) are available in the Git repository

[PATCH v2 03/18] pxe: Use a context pointer

2021-09-27 Thread Simon Glass
At present the PXE functions pass around a pointer to command-table entry which is very strange. It is only needed in a few places and it is odd to pass around a data structure from another module in this way. For bootmethod we will need to provide some context information when reading files.

[PATCH v2 08/18] pxe: Tidy up some comments in pxe_utils

2021-09-27 Thread Simon Glass
Some of these functions are a big vague in the comments. Tidy them up a bit. Signed-off-by: Simon Glass --- (no changes since v1) boot/pxe_utils.c | 189 ++- 1 file changed, 138 insertions(+), 51 deletions(-) diff --git a/boot/pxe_utils.c

[PATCH v2 07/18] pxe: Move pxe_utils files

2021-09-27 Thread Simon Glass
Move the header file into the main include/ directory so we can use it from the bootmethod code. Move the C file into boot/ since it relates to booting. Signed-off-by: Simon Glass --- (no changes since v1) boot/Makefile| 3 +++ {cmd => boot}/pxe_utils.c| 0 cmd/Makefile

[PATCH v2 02/18] pxe: Move API comments to the header files

2021-09-27 Thread Simon Glass
Put the function comments in the header file so that the full API can we examined in one place. Expand the comments to cover parameters and return values. Signed-off-by: Simon Glass --- (no changes since v1) cmd/pxe_utils.c | 45 - cmd/pxe_utils.h | 77

[PATCH v2 05/18] pxe: Add a userdata field to the context

2021-09-27 Thread Simon Glass
Allow the caller to provide some info which is passed back to the readfile() method. Signed-off-by: Simon Glass --- (no changes since v1) cmd/pxe.c | 4 ++-- cmd/pxe_utils.c | 3 ++- cmd/pxe_utils.h | 6 +- cmd/sysboot.c | 2 +- 4 files changed, 10 insertions(+), 5 deletions(-)

[PATCH 1/4] WS cleanup: remove trailing empty lines

2021-09-27 Thread Wolfgang Denk
Signed-off-by: Wolfgang Denk --- arch/arm/cpu/arm926ejs/cache.c| 1 - arch/arm/cpu/armv7/psci-common.c | 1 - arch/arm/cpu/armv8/hisilicon/pinmux.c | 2 -- arch/arm/cpu/armv8/xen/hypercall.S

[PATCH 3/4] WS cleanup: remove trailing white space

2021-09-27 Thread Wolfgang Denk
Signed-off-by: Wolfgang Denk --- Licenses/lgpl-2.0.txt | 2 +- Makefile | 4 ++-- arch/arm/include/asm/arch-am33xx/cpu.h| 2 +- arch/arm/lib/lib1funcs.S | 6 +++---

[PATCH 0/4] White Space cleanup

2021-09-27 Thread Wolfgang Denk
The following is an attempt of a minimal-invasive white space cleaup. It performs the following actions: - Remove empty lines at the end of a file - Remove white space at the end of lines - Remove excessive empty lines: there is almost never a good reason to have more than 2 consecutive empty

[PATCH 2/4] WS cleanup: remove excessive empty lines

2021-09-27 Thread Wolfgang Denk
Signed-off-by: Wolfgang Denk --- README| 1 - arch/arm/mach-mvebu/serdes/a38x/high_speed_env_spec.c | 2 -- arch/xtensa/include/asm/arch-dc232b/core.h| 2 -- arch/xtensa/include/asm/arch-dc232b/tie-asm.h | 4

Re: [PATCH v5 05/29] hash: Use Kconfig to enable hashing in host tools and SPL

2021-09-27 Thread Simon Glass
Hi Alex, On Mon, 27 Sept 2021 at 09:53, Alex G. wrote: > > Hi Simon > > On 9/25/21 8:43 PM, Simon Glass wrote: > > At present when building host tools, we force CONFIG_SHAxxx to be enabled > > regardless of the board Kconfig setting. This is done in the image.h > > header file. > > > > For SPL

Re: [PATCH v5 02/29] kconfig: Add tools support to CONFIG_IS_ENABLED()

2021-09-27 Thread Alex G.
On 9/25/21 8:43 PM, Simon Glass wrote: At present we must separately test for the host build for many options, since we force them to be enabled. For example, CONFIG_FIT is always enabled in the host tools, even if CONFIG_FIT is not enabled by the board itself. It would be more convenient if

Re: Status of the various RISC-V specification and policy

2021-09-27 Thread Mark Himelstein
the words in this document : https://wiki.riscv.org/plugins/servlet/mobile?contentId=13098230#content/view/13098230 make it very clear when changes are allowed or not and likely or not. if you think the verbiage is somehow ambiguous please help us make it better. Mark sent from a

[PATCH] ARM: omap3_logic: Cleanup usage of MUX_VAL

2021-09-27 Thread Adam Ford
The macro called MUX_VAL generates a writel instruction with semicolon at the end. This table was written to use semicolons, however one was missed: MUX_VAL(CP(SYS_BOOT2), (IEN | PTD | DIS | M4))/* GPIO_4 */ Since the extra semicolon is unnecessary with the use of the macro, remove

Re: [PATCH v5 05/29] hash: Use Kconfig to enable hashing in host tools and SPL

2021-09-27 Thread Alex G.
On 9/27/21 11:06 AM, Simon Glass wrote: Hi Alex, On Mon, 27 Sept 2021 at 09:53, Alex G. wrote: Hi Simon On 9/25/21 8:43 PM, Simon Glass wrote: At present when building host tools, we force CONFIG_SHAxxx to be enabled regardless of the board Kconfig setting. This is done in the image.h

[PATCH] drivers: ddr: lc_common_dimm_params.c : Fix Divison by zero issue

2021-09-27 Thread Maninder Singh
Adds check for mclk_ps variable before calculating caslat_actual. Verified changes on lx2160ardb board. Signed-off-by: Maninder Singh --- drivers/ddr/fsl/lc_common_dimm_params.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/ddr/fsl/lc_common_dimm_params.c

Re: [PATCH v5 02/29] kconfig: Add tools support to CONFIG_IS_ENABLED()

2021-09-27 Thread Masahiro Yamada
On Tue, Sep 28, 2021 at 1:11 AM Alex G. wrote: > > > > On 9/25/21 8:43 PM, Simon Glass wrote: > > At present we must separately test for the host build for many options, > > since we force them to be enabled. For example, CONFIG_FIT is always > > enabled in the host tools, even if CONFIG_FIT is

Re: [PATCH v2 1/3] efi_loader: add SMBIOS table measurement

2021-09-27 Thread Simon Glass
Hi Ilias, On Mon, 27 Sept 2021 at 02:52, Ilias Apalodimas wrote: > > Hi Simon, > > [...] > > > > > > - remove unnecessary const qualifier from smbios_string() > > > > > - create non-const version of next_header() > > > > > > > > > > include/efi_loader.h | 2 + > > > > >

Re: [PATCH 2/4] dm: hash: Add new UCLASS_HASH support

2021-09-27 Thread Simon Glass
Hi Alex, On Mon, 27 Sept 2021 at 09:37, Alex G. wrote: > > On 9/23/21 9:49 PM, Simon Glass wrote:> On Thu, 16 Sept 2021 at 09:43, > Alex G. wrote: > >> On 7/29/21 8:08 PM, Chia-Wei Wang wrote: > > >>> + > >>> +enum HASH_ALGO hash_algo_lookup_by_name(const char *name) > >> > >> string ->

Re: Please pull u-boot-dm/next

2021-09-27 Thread Tom Rini
On Mon, Sep 27, 2021 at 08:58:17AM -0600, Simon Glass wrote: > Hi Tom, > > This is for the -next branch. > > https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/9260 > > > > The following changes since commit bb38d77ca779cc8bdad3d4ceb6cecc687f4987c2: > > vexpress_ca9x4: Add

Re: [PATCH 2/3] board: arm: Remove OF_PRIOR_STAGE

2021-09-27 Thread Simon Glass
On Mon, 27 Sept 2021 at 00:48, Ilias Apalodimas wrote: > > At some point back in 2018 prior_stage_fdt_address and OF_PRIOR_STAGE got > introduced, in order to support a DTB handed over by an earlier stage boo > loader. However we have another option in the Kconfig (OF_BOARD) which has >

Re: [PATCH 3/5] misc: Add Apple DART driver

2021-09-27 Thread Simon Glass
Hi Mark, On Sun, 26 Sept 2021 at 14:53, Mark Kettenis wrote: > > > From: Simon Glass > > Date: Mon, 20 Sep 2021 19:11:25 -0600 > > Hi Simon, > > > [..] > > > > > > > +static int apple_dart_bind(struct udevice *dev) > > > > > +{ > > > > > + void *base; > > > > > + int sid, i; > > > >

Re: [PATCH 1/3] treewide: Remove OF_PRIOR_STAGE from RISC-V boards

2021-09-27 Thread Simon Glass
On Mon, 27 Sept 2021 at 00:48, Ilias Apalodimas wrote: > > At some point back in 2018 prior_stage_fdt_address and OF_PRIOR_STAGE got > introduced, in order to support a DTB handed over by an earlier stage boo > loader. However we have another option in the Kconfig (OF_BOARD) which has >

Re: [PATCH 3/4] WS cleanup: remove trailing white space

2021-09-27 Thread Simon Glass
On Mon, 27 Sept 2021 at 09:43, Wolfgang Denk wrote: > nit: commit message > Signed-off-by: Wolfgang Denk > --- > Licenses/lgpl-2.0.txt | 2 +- > Makefile | 4 ++-- > arch/arm/include/asm/arch-am33xx/cpu.h| 2 +- >

  1   2   >