Re: [PATCH v2 02/39] efi: Add a separate maintainer entry for the app

2021-10-18 Thread Heinrich Schuchardt
On 9/25/21 2:30 AM, Simon Glass wrote: Separate this out slightly from the payload, with a new entry. We might consider renaming EFI PAYLOAD to EFI LOADER, but that would require quite a lot of file changes. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt --- Changes in v2:

Re: [PATCH v2 05/39] x86: Show some EFI info with the bdinfo command

2021-10-18 Thread Heinrich Schuchardt
On 9/25/21 2:30 AM, Simon Glass wrote: It is useful to see some basic EFI info with the command as it forms part of the information about a board. Add a hook for this and show the table address as a start. While here, fix an invalid cast in setup_efi_info(). Note that this function is using a

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-18 Thread Simon Glass
Hi Wolfgang, On Mon, 18 Oct 2021 at 08:10, Wolfgang Denk wrote: > > Dear Tom, > > In message <20211018133728.GQ7964@bill-the-cat> you wrote: > > > > > And please see also my comments about changing the autostart > > > functionality for the user. > > > > Perhaps we should just make "+" an illegal

Re: [PATCH] pxe_utils: Fix arguments to x86 zboot

2021-10-18 Thread Simon Glass
Hi Zhaofeng, On Sat, 16 Oct 2021 at 00:16, Zhaofeng Li wrote: > > bootm and zboot accept different arguments: > > > bootm [addr [arg ...]] > >- boot application image stored in memory > >passing arguments 'arg ...'; when booting a Linux kernel, > >'arg' can be the address of

Re: [PATCH v3 12/13] env: Simplify env_match() and inline into env_get_f()

2021-10-18 Thread Simon Glass
On Sun, 17 Oct 2021 at 09:37, Marek Behún wrote: > > From: Marek Behún > > In the past the env_match() function was used to match envs with > - name, i.e. string "name" > - variable assignment, i.e. string "name=other_value" > > The latter is not the case anymore, since the env_match() function

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-18 Thread Simon Glass
Hi Wolfgang, On Mon, 18 Oct 2021 at 05:59, Wolfgang Denk wrote: > > Dear Simon, > > In message > you > wrote: > > > > > I really think your fixed filename proposal does not work well in > > > reality. The file name should be Kconfig configurable. See [1] > > > for details. > > > > > > [1]

Re: [PATCH v7 0/7] env: Allow environment in text files

2021-10-18 Thread Simon Glass
Hi Wolfgang, On Mon, 18 Oct 2021 at 06:07, Wolfgang Denk wrote: > > Dear Simon, > > In message <20211016003339.723169-1-...@chromium.org> you wrote: > > > > Add a feature that brings in a .env file associated with the board > > config, if present. To use it, create a file board/.env or > > use

[PATCH v8 7/8] doc: Improve environment documentation

2021-10-18 Thread Simon Glass
Make various updates suggested during review of the rST conversion. Signed-off-by: Simon Glass Suggested-by: Wolfgang Denk --- (no changes since v7) Changes in v7: - A few more tweaks Changes in v6: - Move all updates to a separate patch - More updates and improvements Changes in v5: -

Re: [PATCH] xilinx: zynqmp: Use CONFIG_SPL_FS_LOAD_PAYLOAD_NAME

2021-10-18 Thread Oleksandr Suvorov
On Mon, Oct 18, 2021 at 3:02 PM Michal Simek wrote: > > There is no need to use u-boot.itb as name when this is already recorded in > CONFIG_SPL_FS_LOAD_PAYLOAD_NAME macro. > > Signed-off-by: Michal Simek Reviewed-by: Oleksandr Suvorov > --- > > board/xilinx/zynqmp/zynqmp.c | 15

Re: [PATCH v2 06/39] x86: Tidy up global_data pointer for 64-bit

2021-10-18 Thread Heinrich Schuchardt
On 9/25/21 2:30 AM, Simon Glass wrote: Add an extern declaration so that it is possible to use this macro in files other than the one that defines it. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt --- (no changes since v1) arch/x86/cpu/x86_64/cpu.c | 3 +++

Re: [PATCH v2 07/39] efi: Add a script for building and testing U-Boot on UEFI

2021-10-18 Thread Heinrich Schuchardt
On 9/25/21 2:30 AM, Simon Glass wrote: It is quite complicating to run U-Boot on qemu since we have four Nits: %s/complicating/complicated/ %/qemu/QEMU/ different builds and they must use different versions of qemu and the QEMU UEFI binaries. Add a script to help. Signed-off-by:

[PATCH v8 3/8] doc: Move environment documentation to rST

2021-10-18 Thread Simon Glass
Move this from the README to rST format. Drop i2cfast since it is obviously obsolete and breaks the formatting. Other changes and improvements are in a following patch. Signed-off-by: Simon Glass --- (no changes since v6) Changes in v6: - Move all updates to a separate patch Changes in v5: -

[PATCH v8 5/8] sandbox: Use a text-based environment

2021-10-18 Thread Simon Glass
Use a text file for the environment instead of the #define settings. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to use a text-based environment for sandbox board/sandbox/sandbox.env | 25 + include/configs/sandbox.h | 29

[PATCH v8 0/8] env: Allow environment in text files

2021-10-18 Thread Simon Glass
One barrier to completing the 7-year-long Kconfig migration is that the default environment is implemented using ad-hoc CONFIG options. At present U-Boot environment variables, and thus scripts, are defined by CONFIG_EXTRA_ENV_SETTINGS. It is not really feasible to move the environment to Kconfig

[PATCH v8 1/8] binman: Allow timeout to occur in the image or its section

2021-10-18 Thread Simon Glass
At present testThreadTimeout() assumes that the expected timeout happens first when building the section, but it can just as easily happen at the top-level image. Update the test to cope with both. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/ftest.py | 3 +-- 1 file

Re: [PATCH v2 07/39] efi: Add a script for building and testing U-Boot on UEFI

2021-10-18 Thread Simon Glass
Hi Heinrich, On Mon, 18 Oct 2021 at 11:35, Heinrich Schuchardt wrote: > > On 9/25/21 2:30 AM, Simon Glass wrote: > > It is quite complicating to run U-Boot on qemu since we have four > > Nits: > %s/complicating/complicated/ %/qemu/QEMU/ > > > different builds and they must use different

[PATCH v8 2/8] sandbox: Drop distro_boot

2021-10-18 Thread Simon Glass
This is a complicated set of #defines and it is painful to convert to a text file. We can (once pending patches are applied) provide the same functionality with bootmethod. Drop this for sandbox to allow conversion to a text-file environment. Signed-off-by: Simon Glass --- (no changes since v1)

Re: [PATCH v2 04/39] x86: Create a new header for EFI

2021-10-18 Thread Heinrich Schuchardt
On 9/25/21 2:30 AM, Simon Glass wrote: The setup routines are called from zimage but don't really belong in the zimage header. Add a new EFI header to house these. Add comments so it is clear what the functions do. Note that these functions are x86-specific. The zimage business is not used on

[PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-18 Thread Simon Glass
At present U-Boot environment variables, and thus scripts, are defined by CONFIG_EXTRA_ENV_SETTINGS. It is painful to add large amounts of text to this file and dealing with quoting and newlines is harder than it should be. It would be better if we could just type the script into a text file and

[PATCH v8 8/8] bootm: Tidy up use of autostart env var

2021-10-18 Thread Simon Glass
This has different semantics in different places. Go with the bootm method and put it in a common function so that the behaviour is consistent in U-Boot. Update the docs. To be clear, this changes the way that 'bootelf' and standalone boot work. Before, if autostart was set to "fred" or "YES",

[PATCH v8 6/8] doc: Mention CONFIG_DEFAULT_ENV_FILE

2021-10-18 Thread Simon Glass
Add mention of this option this it does a similar thing to the text environment. Suggested-by: Rasmus Villemoes Signed-off-by: Simon Glass --- Changes in v8: - Fix ambiguity about what is ignored Changes in v7: - Add new patch to explain the relationship with DEFAULT_ENV_FILE

Re: How to compile u-boot with debug option?

2021-10-18 Thread Jaehoon Chung
On 10/19/21 11:21 AM, Chan Kim wrote: > Hello, > > > > With these commands, > > make ARCH=arm CROSS_COMPILE=aarch64-none-elf- qemu_arm64_defconfig > > make ARCH=arm CROSS_COMPILE=aarch64-none-elf- > > I see only u-boot.bin. How can I make u-boot.elf with debug info? > > I found >

[PATCH] ARM: stm32: Enable DFU SF support on DHSOM

2021-10-18 Thread Marek Vasut
All the STM32MP1 based DHSOM have SPI NOR from which they boot, enable DFU_SF support to make it possible to expose that SPI NOR via the DFU. Signed-off-by: Marek Vasut Cc: Patrice Chotard Cc: Patrick Delaunay --- configs/stm32mp15_dhcom_basic_defconfig | 1 +

RE: How to compile u-boot with debug option?

2021-10-18 Thread Chan Kim
Hello, Jaehoon and all, I tried setting in menuconfig TOOLS_DEBUG but no change. It's strainge, when I add "V=1" in the make command, I can see the commands run during the make. The cc command has -g options, a typical command being like this : aarch64-none-elf-gcc

Re: [PATCH] xilinx: zynqmp: Handle fallthrough statement properly

2021-10-18 Thread Oleksandr Suvorov
On Mon, Oct 18, 2021 at 2:30 PM Michal Simek wrote: > > Now intentional fallthrough in switch-case should be labelled that's why > convert comment. > > Signed-off-by: Michal Simek Reviewed-by: Oleksandr Suvorov > --- > > board/xilinx/zynqmp/zynqmp.c | 2 +- > 1 file changed, 1 insertion(+),

Re: [PATCH v3 12/13] env: Simplify env_match() and inline into env_get_f()

2021-10-18 Thread Marek Behún
> Reviewed-by: Simon Glass Simon, thanks. Will you be taking this through your tree or should I change delegate to Tom? Marek

Stack overflows in ubifs_findfile

2021-10-18 Thread Kostya Kortchinsky
Greetings, There appears to be a few stack overflows in ubifs_findfile as present in: https://github.com/u-boot/u-boot/blob/d990f7d75d3dcf45a9220abc900495f00792f414/fs/ubifs/ubifs.c#L468 Namely: - strcpy @

Re: [PATCH v3] sandbox: Remove OF_HOSTFILE

2021-10-18 Thread Tom Rini
On Mon, Oct 18, 2021 at 04:50:33PM -0400, Tom Rini wrote: > On Fri, Oct 15, 2021 at 11:42:40AM +0300, Ilias Apalodimas wrote: > > > OF_HOSTFILE is used on sandbox configs only. Although it's pretty > > unique and rarely causes confusion, we are better of having simpler > > config options for

How to compile u-boot with debug option?

2021-10-18 Thread Chan Kim
Hello, With these commands, make ARCH=arm CROSS_COMPILE=aarch64-none-elf- qemu_arm64_defconfig make ARCH=arm CROSS_COMPILE=aarch64-none-elf- I see only u-boot.bin. How can I make u-boot.elf with debug info? I found https://lists.denx.de/pipermail/u-boot/2005-May/010240.html and tried

[PATCH v3 2/2] nvme: Fix error in nvme_setup_prps

2021-10-18 Thread Jon Lin
Consulting to "NVM Express® Base Specification, revision 2.0". If more PRP List pages are required, then the last entry of the PRP List contains the Page Base Address of the next PRP List page. The next PRP List page shall be memory page aligned. Signed-off-by: Jon Lin Reviewed-by: Shawn Lin

[PATCH v3 1/2] nvme: Enable FUA

2021-10-18 Thread Jon Lin
Most NVME devcies maintain data in internal cache for an uncertain times, and u-boot has no method to force NVME to flush cache. So this patch adds FUA to avoid data loss caused by power off after data programming. Signed-off-by: Jon Lin Reviewed-by: Stefan Agner --- Changes in v3: Only

Re: [PATCH v3] sandbox: Remove OF_HOSTFILE

2021-10-18 Thread Tom Rini
On Fri, Oct 15, 2021 at 11:42:40AM +0300, Ilias Apalodimas wrote: > OF_HOSTFILE is used on sandbox configs only. Although it's pretty > unique and rarely causes confusion, we are better of having simpler > config options for the DTB. > > So let's replace that with the existing OF_BOARD.

Re: [PATCH 2/2] dt-bindings: u-boot: Add an initial binding for config

2021-10-18 Thread Rob Herring
On Wed, Oct 13, 2021 at 11:33 AM Simon Glass wrote: > > " > Hi Rob, > > On Tue, 12 Oct 2021 at 09:05, Rob Herring wrote: > > > > On Tue, Oct 12, 2021 at 8:41 AM Simon Glass wrote: > > > > > > Hi Rob, > > > > > > On Mon, 4 Oct 2021 at 13:30, Rob Herring wrote: > > > > > > > > On Sun, Oct 03,

Re: [PATCH] mmc: arm_pl180_mmci: Enable HWFC for specific versions of MCI

2021-10-18 Thread Jaehoon Chung
Hi, +Cc Peng, On 10/18/21 8:33 PM, Usama Arif wrote: > There are 4 registers (PERIPHID{0-3}) that contain the ID of MCI. > For MMCs' with peripheral id 0x02041180 and 0x03041180, H/W flow control > needs to be enabled for multi block writes (MMC CMD 18). > > Signed-off-by: Usama Arif >

Re: [PATCH v2 24/39] efi: serial: Support arrow keys

2021-10-18 Thread Heinrich Schuchardt
On 9/25/21 2:30 AM, Simon Glass wrote: At present only the backspace key is supported in U-Boot, when running as an EFI app. Add support for arrows, home and end as well, to make the CLI more friendly. Signed-off-by: Simon Glass --- (no changes since v1) drivers/serial/serial_efi.c | 11

Re: [PATCH v3 13/18] lib: Add tests for simple_itoa()

2021-10-18 Thread art
Reviewed-by: Artem Lapkin

Re: [PATCH v3 02/18] pxe: Move API comments to the header files

2021-10-18 Thread art
OK Reviewed and Tested on -master Mon 18 Oct 2021 04:40:29 PM CST Reviewed-by: Artem Lapkin Tested-by: Artem Lapkin

Re: [PATCH v3 11/18] pxe: Clean up the use of bootfile

2021-10-18 Thread art
OK its really needed! Reviewed and Tested on -master Mon 18 Oct 2021 04:40:29 PM CST Reviewed-by: Artem Lapkin Tested-by: Artem Lapkin

Re: [PATCH v3 03/18] pxe: Use a context pointer

2021-10-18 Thread art
OK nice Reviewed and Tested on -master Mon 18 Oct 2021 04:40:29 PM CST Reviewed-by: Artem Lapkin Tested-by: Artem Lapkin

Re: [PATCH v3 06/18] pxe: Tidy up the is_pxe global

2021-10-18 Thread art
OK nice Reviewed and Tested on -master Mon 18 Oct 2021 04:40:29 PM CST Reviewed-by: Artem Lapkin Tested-by: Artem Lapkin

Re: [PATCH v3 07/18] pxe: Move pxe_utils files

2021-10-18 Thread art
OK Reviewed and Tested on -master Mon 18 Oct 2021 04:40:29 PM CST Reviewed-by: Artem Lapkin Tested-by: Artem Lapkin

Re: [PATCH v3 08/18] pxe: Tidy up some comments in pxe_utils

2021-10-18 Thread art
OK Reviewed and Tested on -master Mon 18 Oct 2021 04:40:29 PM CST Reviewed-by: Artem Lapkin Tested-by: Artem Lapkin

Re: [PATCH v3 01/18] Create a new boot/ directory

2021-10-18 Thread art
OK Reviewed and Tested on -master Mon 18 Oct 2021 04:40:29 PM CST Reviewed-by: Artem Lapkin Tested-by: Artem Lapkin

Re: [PATCH v3 05/18] pxe: Add a userdata field to the context

2021-10-18 Thread art
OK nice Reviewed and Tested on -master Mon 18 Oct 2021 04:40:29 PM CST Reviewed-by: Artem Lapkin Tested-by: Artem Lapkin

Re: [PATCH v3 04/18] pxe: Move do_getfile() into the context

2021-10-18 Thread art
OK nice Reviewed and Tested on -master Mon 18 Oct 2021 04:40:29 PM CST Reviewed-by: Artem Lapkin Tested-by: Artem Lapkin

Re: [PATCH v3 09/18] pxe: Tidy up code style a little in pxe_utils

2021-10-18 Thread art
OK Reviewed and Tested on -master Mon 18 Oct 2021 04:40:29 PM CST Reviewed-by: Artem Lapkin Tested-by: Artem Lapkin

Re: [PATCH v3 10/18] pxe: Move common parsing coding into pxe_util

2021-10-18 Thread art
OK Reviewed and Tested on -master Mon 18 Oct 2021 04:40:29 PM CST Reviewed-by: Artem Lapkin Tested-by: Artem Lapkin

Re: [PATCH v3 12/18] pxe: Drop get_bootfile_path()

2021-10-18 Thread art
OK Reviewed and Tested on -master Mon 18 Oct 2021 04:40:29 PM CST Reviewed-by: Artem Lapkin Tested-by: Artem Lapkin

[PATCH] xilinx: zynqmp: Handle fallthrough statement properly

2021-10-18 Thread Michal Simek
Now intentional fallthrough in switch-case should be labelled that's why convert comment. Signed-off-by: Michal Simek --- board/xilinx/zynqmp/zynqmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/xilinx/zynqmp/zynqmp.c b/board/xilinx/zynqmp/zynqmp.c index

[PATCH] riscv: Avoid io read/write cause wrong result

2021-10-18 Thread Nick Hu
io read/write may cause wrong result because they may read/write data from/to register instead of memory. Add 'volatile' to avoid it. Signed-off-by: Nick Hu --- arch/riscv/include/asm/io.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

[PATCH v4 1/4] mtd: spi-nor: macronix: add support for Macronix Octal

2021-10-18 Thread JaimeLiao
Follow patch "f6adec1af4b2f5d3012480c6cdce7743b74a6156" for adding Macronix flash in Octal DTR mode. Enable Octal DTR mode with 20 dummy cycles to allow running at the maximum supported frequency. -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7841/MX25LM51245G,%203V,%20512Mb,%20v1.1.pdf

[PATCH] image.h: make image_sign_info.fit point to const

2021-10-18 Thread Hannu Lounento
The data blob apparently does not need to be modified through the fit field of the image_sign_info struct so make it point to const to avoid the need to cast away constness in functions that assign a pointer to const data to the field. fit_image_setup_verify already had to cast away constness as

[PATCH v4 0/4] Add octal DTR support for Macronix flash

2021-10-18 Thread JaimeLiao
This series add support for Macronix octal DTR flash, add flag for Softreset with "INVERT" command extension type on boot and follow linux kernel to enable 4byte opcode when possible. v4: Add flag SPI_NOR_BOOT_SOFT_RESET_EXT_INVERT to seperate command extension types. Replace ifdef with

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-18 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > I really think your fixed filename proposal does not work well in > > reality. The file name should be Kconfig configurable. See [1] > > for details. > > > > [1] https://lists.denx.de/pipermail/u-boot/2021-October/462668.html > > Yes I saw that but I

Re: [PATCH v7 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-18 Thread Wolfgang Denk
Dear Simon, In message <20211015183321.v7.3.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> you wrote: > > Add a feature that brings in a .env file associated with the board > config, if present. To use it, create a file in a board//env > directory called .env (or common.env if you want the

[PATCH v4 4/4] mtd: spi-nor-core: Add support for Macronix Octal flash

2021-10-18 Thread JaimeLiao
Adding Macronix Octal flash for Octal DTR support. The octaflash series can be divided into the following types: MX25 series : Serial NOR Flash. MX66 series : Serial NOR Flash with stacked die.(Size larger than 1Gb) LM/UM series : Up to 250MHz clock frequency with both DTR/STR operation. LW/UW

[PATCH v4 2/4] mtd: spi-nor-core: Adding different type of command extension in Soft Reset

2021-10-18 Thread JaimeLiao
Power-on-Reset is a method to restore flash back to 1S-1S-1S mode from 8D-8D-8D in the begging of probe. Command extension type is not standardized across flash vendors in DTR mode. For suiting different vendor flash devices, adding a flag to seperate types for soft reset on boot.

[PATCH v4 3/4] mtd: spi-nor-core: set 4byte opcode when possible

2021-10-18 Thread JaimeLiao
Following linux kernel to check address width and 4byte flag to enable 4byte opcode setting. Signed-off-by: JaimeLiao --- drivers/mtd/spi/spi-nor-core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/mtd/spi/spi-nor-core.c b/drivers/mtd/spi/spi-nor-core.c index

[PATCH] mtd: spi-nor-ids: Add SECT_4K to mt25qu512a

2021-10-18 Thread Kris Chaplin
The mt25qu512a supports 4K or 64K sectors, so adding SECT_4K to enable 4K sector usage. Datasheet: https://media-www.micron.com/-/media/client/global/documents/products/data-sheet/nor-flash/serial-nor/n25q/n25q_512mb_1ce_3v_65nm.pdf Tested on Intel n5x hardware with QSPI carrier card

[PATCH] mtd: spi-nor-ids: Add is25lp512 and is25wp512 devices

2021-10-18 Thread Kris Chaplin
Add is25lp512 and is25wp512 devices to spi-nor id table Tested on Intel n5x hardware with QSPI carrier card Signed-off-by: Kris Chaplin Tested-by: Kris Chaplin --- drivers/mtd/spi/spi-nor-ids.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/mtd/spi/spi-nor-ids.c

[PATCH] mmc: arm_pl180_mmci: Enable HWFC for specific versions of MCI

2021-10-18 Thread Usama Arif
There are 4 registers (PERIPHID{0-3}) that contain the ID of MCI. For MMCs' with peripheral id 0x02041180 and 0x03041180, H/W flow control needs to be enabled for multi block writes (MMC CMD 18). Signed-off-by: Usama Arif Change-Id: Icc79e352db6305c232527c4a432f17b7a30fec8e ---

[PATCH] xilinx: zynqmp: Use CONFIG_SPL_FS_LOAD_PAYLOAD_NAME

2021-10-18 Thread Michal Simek
There is no need to use u-boot.itb as name when this is already recorded in CONFIG_SPL_FS_LOAD_PAYLOAD_NAME macro. Signed-off-by: Michal Simek --- board/xilinx/zynqmp/zynqmp.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/board/xilinx/zynqmp/zynqmp.c

Re: [PATCH v7 0/7] env: Allow environment in text files

2021-10-18 Thread Wolfgang Denk
Dear Simon, In message <20211016003339.723169-1-...@chromium.org> you wrote: > > Add a feature that brings in a .env file associated with the board > config, if present. To use it, create a file board/.env or > use CONFIG_ENV_SOURCE_FILE to set a filename. That should be board//.env , right?

Re: [PATCH v2] env: mmc: Add support for redundant env in both eMMC boot partitions

2021-10-18 Thread Marek Vasut
On 10/18/21 4:02 AM, Jaehoon Chung wrote: Hi Marek, Hi, On 10/18/21 2:23 AM, Marek Vasut wrote: Currently the MMC environment driver supports storing redundant environment only in one eMMC partition at different offsets. This is sub-optimal, since if this one boot partition is erased, both

Re: [PATCH v3 15/18] pxe: Return the file size from the getfile() function

2021-10-18 Thread art
OK will be usefull Reviewed and Tested on -master Mon 18 Oct 2021 04:40:29 PM CST Reviewed-by: Artem Lapkin Tested-by: Artem Lapkin

Re: [PATCH v3 14/18] lib: Add a function to convert a string to a hex value

2021-10-18 Thread art
OK will be usefull Reviewed and Tested on -master Mon 18 Oct 2021 04:40:29 PM CST Reviewed-by: Artem Lapkin Tested-by: Artem Lapkin

Re: [PATCH v3 16/18] pxe: Refactor sysboot to have one helper

2021-10-18 Thread art
OK is clear Reviewed and Tested on -master Mon 18 Oct 2021 04:40:29 PM CST Reviewed-by: Artem Lapkin Tested-by: Artem Lapkin

Re: [PATCH v3 17/18] doc: Move distro boot doc to rST

2021-10-18 Thread art
OK Reviewed on -master Mon 18 Oct 2021 04:40:29 PM CST Reviewed-by: Artem Lapkin

Re: [PATCH v3 18/18] pxe: Allow calling the pxe_get logic directly

2021-10-18 Thread art
OK nice its will be usefull Reviewed and Tested on -master Mon 18 Oct 2021 04:40:29 PM CST Reviewed-by: Artem Lapkin Tested-by: Artem Lapkin

i.MX LPDDR4 Firmware

2021-10-18 Thread Heiko Thiery
Hi all, I see that in the NXP firmware-imx package different versions of the LPDDR4 train firmware is included but I cannot find a Release Note or something else that describes the differences. Does anyone know what is the correct version to be used? Here is the content of the latest NXP

Re: [PATCH 1/2] firmware: zynqmp: Handle errors from ipi_req properly

2021-10-18 Thread Adrian Fiergolski
On 15.10.2021 16:57, Michal Simek wrote: > There are multiple errors what can happen in ipi_req but they are not > propagated properly. That's why propage all error properly. > > Signed-off-by: Michal Simek Reviewed-by: Adrian Fiergolski Thanks, Adrian > --- > >

Re: [PATCH 2/2] firmware: zynqmp: fix write to an uninitialised pointer in ipi_req()

2021-10-18 Thread Adrian Fiergolski
On 15.10.2021 16:57, Michal Simek wrote: > When a caller is not interested in the returned message, the ret_payload > pointer is set to NULL in the u-boot-sources. In this case, under EL3, the > memory from address 0x0 would be overwritten by ipi_req() with the returned > IPI message, damaging the

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-18 Thread Tom Rini
On Mon, Oct 18, 2021 at 04:10:34PM +0200, Wolfgang Denk wrote: > Dear Tom, > > In message <20211018133728.GQ7964@bill-the-cat> you wrote: > > > > > And please see also my comments about changing the autostart > > > functionality for the user. > > > > Perhaps we should just make "+" an illegal

Re: [PATCH v7 5/7] doc: Mention CONFIG_DEFAULT_ENV_FILE

2021-10-18 Thread Wolfgang Denk
Dear Simon, In message <20211016003339.723169-4-...@chromium.org> you wrote: > Add mention of this option this it does a similar thing to the text > environment. > > Suggested-by: Rasmus Villemoes > > Signed-off-by: Simon Glass ... > +The format is the same as accepted by the mkenvimage tool:

Re: Broken build with disabling OpenSSL crypto

2021-10-18 Thread Alex G.
On 10/15/21 3:30 PM, Pali Rohár wrote: On Friday 15 October 2021 09:35:43 Alex G. wrote: On 10/15/21 6:34 AM, Pali Rohár wrote: On Wednesday 06 October 2021 17:05:24 Alex G. wrote: Hi Jernej, On 10/6/21 4:27 PM, Jernej Škrabec wrote: Hi everyone! Commit cb9faa6f98ae ("tools: Use a single

Re: [PATCH v3 1/4] tools: Separate image types which depend on OpenSSL

2021-10-18 Thread Alex G.
On 10/14/21 10:19 PM, Samuel Holland wrote: Some image types (kwbimage and mxsimage) always depend on OpenSSL, so they can only be included in mkimage when TOOLS_LIBCRYPTO is selected. Use Makefile logic to conditionally link the files. When building for platforms which use those image types,

Re: Pull request: u-boot-rockchip-20211015

2021-10-18 Thread Tom Rini
On Mon, Oct 18, 2021 at 09:11:03AM +0800, Kever Yang wrote: > Hi Tom, > > Please pull the rockchip fixes: > - Fix for Rockchip mmc HS400 mode; > - Fix for px30 board Odroid Go; > - rockchip_sfc update; > - rk3568 clk update; > - doc fix; > > Gitlab ci: >

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-18 Thread Tom Rini
On Mon, Oct 18, 2021 at 01:58:57PM +0200, Wolfgang Denk wrote: > Dear Simon, > > In message > you > wrote: > > > > > I really think your fixed filename proposal does not work well in > > > reality. The file name should be Kconfig configurable. See [1] > > > for details. > > > > > > [1]

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-18 Thread Wolfgang Denk
Dear Tom, In message <20211018133728.GQ7964@bill-the-cat> you wrote: > > > And please see also my comments about changing the autostart > > functionality for the user. > > Perhaps we should just make "+" an illegal character in the variable > name, for consistency? And break backward

Re: [PATCH v2 00/39] efi: Improvements to U-Boot running on top of UEFI

2021-10-18 Thread Simon Glass
Hi Heinrich, On Fri, 24 Sept 2021 at 18:31, Simon Glass wrote: > > At present U-Boot can be built as an EFI app, but it is really just for > testing, with very few features. Instead, the payload build is used for > booting on top of UEFI, where U-Boot takes over the machine immediately > and