Re: [PATCH] doc: Remove obsolete README.440-DDR-performance file

2021-10-21 Thread Stefan Roese
On 21.10.21 08:11, Thomas Huth wrote: On 21/10/2021 08.00, Thomas Huth wrote: On 21/10/2021 07.16, Stefan Roese wrote: On 21.10.21 00:32, Heinrich Schuchardt wrote: On 10/19/21 9:25 AM, Thomas Huth wrote: The PPC 440 support has been removed in commit 98f705c9ce ("powerpc: remove 4xx

Re: [PATCH] xilinx: zynqmp: Use CONFIG_SPL_FS_LOAD_PAYLOAD_NAME

2021-10-21 Thread Michal Simek
On 10/18/21 14:02, Michal Simek wrote: There is no need to use u-boot.itb as name when this is already recorded in CONFIG_SPL_FS_LOAD_PAYLOAD_NAME macro. Signed-off-by: Michal Simek --- board/xilinx/zynqmp/zynqmp.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-)

Re: [PATCH] arm: a37xx: pci: Fix condition for CRS response

2021-10-21 Thread Stefan Roese
On 19.10.21 11:05, Pali Rohár wrote: As stated in comment above the code, CRS response can be returned to OS only for 4-byte PCI_VENDOR_ID config read request. So fix the code. Fixes: 1d7ad68559e2 ("arm: a37xx: pci: Handle propagation of CRSSVE bit from PCIe Root Port") Signed-off-by: Pali

Re: [PATCH v3 1/3] efi_loader: add SMBIOS table measurement

2021-10-21 Thread Masahisa Kojima
On Thu, 21 Oct 2021 at 09:17, Heinrich Schuchardt wrote: > > On 10/1/21 1:18 PM, Masahisa Kojima wrote: > > TCG PC Client spec requires to measure the SMBIOS > > I guess you mean the "TCG PC Client Platform Firmware Profile > Specification"? Please, provide the full name in the commit message.

Re: [PATCH] ARM: imx8m: support env in fat and ext4

2021-10-21 Thread Oleksandr Suvorov
On Wed, Oct 20, 2021 at 10:17 PM Ricardo Salveti wrote: > > Change boot device logic to also allow environment stored in fat and in > ext4 when booting from SD or from eMMC. > > As the boot device check for SD and for eMMC was depending on > ENV_IS_IN_MMC being defined, change the ifdef blocks at

Re: [PATCH V2 6/7] imx: imx8mq use common imximage.cfg

2021-10-21 Thread Stefano Babic
Hi Peng, On 08.10.21 06:05, Peng Fan (OSS) wrote: From: Peng Fan After all these board switch to binman, we could use common imximage.cfg Signed-off-by: Peng Fan --- arch/arm/mach-imx/imx8m/imximage.cfg | 12 +++- board/freescale/imx8mq_evk/imximage.cfg | 11 ---

[PATCH] xilinx: zynqmp: Save multiboot as variable

2021-10-21 Thread Michal Simek
Save multiboot register as u-boot variable. And use it as primary source for composing dfu_alt_info for capsule update. If variable is not defined Signed-off-by: Michal Simek --- board/xilinx/zynqmp/zynqmp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] tools: imx8m_image: Support ddr3 firmware

2021-10-21 Thread Stefano Babic
On 14.10.21 14:14, Ariel D'Alessandro wrote: +Cc Sebastien, Frieder, Baruch, Adding you as you were involved in this file commit log. Any comments on this simple patch? On 9/30/21 10:31 AM, Ariel D'Alessandro wrote: Some boards use ddr3, not ddr4, so we need to check ddr3 firmware. Some

[RFC PATCH] tools: kwbimage: Allow to disable compilation of kwbimage on non-mvebu platforms

2021-10-21 Thread Pali Rohár
kwbimage depends on libcrypto. 32-bit mvebu platforms (except Orion and Discovery, which are not in mach-mvebu) require kwimage for building SPL. Some users want to compile u-boot tools without libcrypto. Therefore add a new symbol CONFIG_TOOLS_KWBIMAGE which controls compilation of kwbimage and

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Wolfgang Denk
Dear Simon, In message <20211019164418.v9.3.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> you wrote: > At present U-Boot environment variables, and thus scripts, are defined > by CONFIG_EXTRA_ENV_SETTINGS. It is painful to add large amounts of text > to this file and dealing with quoting

Re: [PATCH v1 0/2] board: toradex: improve env badblock management for NAND variant boards

2021-10-21 Thread Stefano Babic
Hi Francesco, On 01.09.21 09:48, Francesco Dolcini wrote: Use the complete 512kb (4 blocks) nand partition reserved for u-boot environment instead of just the first block, this allows the module to have a working environment even if 3 blocks are bad. Francesco Dolcini (2):

Re: [PATCH 2/2] firmware: zynqmp: fix write to an uninitialised pointer in ipi_req()

2021-10-21 Thread Michal Simek
On 10/15/21 16:57, Michal Simek wrote: When a caller is not interested in the returned message, the ret_payload pointer is set to NULL in the u-boot-sources. In this case, under EL3, the memory from address 0x0 would be overwritten by ipi_req() with the returned IPI message, damaging the

Re: [PATCH] xilinx: zynqmp: Handle fallthrough statement properly

2021-10-21 Thread Michal Simek
On 10/18/21 13:30, Michal Simek wrote: Now intentional fallthrough in switch-case should be labelled that's why convert comment. Signed-off-by: Michal Simek --- board/xilinx/zynqmp/zynqmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/xilinx/zynqmp/zynqmp.c

Re: [PATCH v2 0/9] usb: dwc3: add Layerscape SoC support

2021-10-21 Thread Michael Walle
Hi Bin, Marek suggested to add you. Unfortunately, get_maintainer.pl doesn't mention you. You can find the whole thread here: https://lore.kernel.org/u-boot/20211015131525.721323-1-mich...@walle.cc/ Am 2021-10-15 15:15, schrieb Michael Walle: Primarily, this will add support for peripheral

Re: [PATCH] tools: termios_linux.h: Fix tcsendbreak() implementation

2021-10-21 Thread Stefan Roese
On 21.10.21 07:36, Stefan Roese wrote: On 06.10.21 14:30, Pali Rohár wrote: There are two Linux ioctls which implements tcsendbreak() functionality: TCSBRK and TCSBRKP TCSBRK with non-zero parameter implements tcdrain() and with zero parameter implements tcsendbreak() for duration of 0.25s.

Re: [PATCH] cmd: tlv_eeprom

2021-10-21 Thread Stefan Roese
On 21.10.21 07:36, Stefan Roese wrote: On 12.09.21 09:25, sven.auha...@voleatech.de wrote: From: Sven Auhagen The function show_eeprom is missing int i if debug is enabled. Signed-off-by: Sven Auhagen Reviewed-by: Stefan Roese Applied to u-boot-marvell/master Thanks, Stefan Thanks,

Re: [PATCH v1 2/2] x86: edison: Don't take SD card detect pin into consideration

2021-10-21 Thread Andy Shevchenko
On Thu, Oct 21, 2021 at 12:41 AM Ferry Toth wrote: > Op 15-10-2021 om 19:11 schreef Andy Shevchenko: > > There are two PCB designs in the wild which use the opposite > > signaling for SD card detect. This makes U-Boot working in one case > > and failing in the other. Quirk this out by

Re: [PATCH v3 1/3] efi_loader: add SMBIOS table measurement

2021-10-21 Thread Heinrich Schuchardt
On 10/21/21 10:38, Masahisa Kojima wrote: On Thu, 21 Oct 2021 at 09:17, Heinrich Schuchardt wrote: On 10/1/21 1:18 PM, Masahisa Kojima wrote: TCG PC Client spec requires to measure the SMBIOS I guess you mean the "TCG PC Client Platform Firmware Profile Specification"? Please, provide

Re: [PATCH] arm64: zynqmp: Add support for DLC21 (Smartlynq+) board

2021-10-21 Thread Michal Simek
On 10/14/21 19:07, Michal Simek wrote: DLC21 is used as fast jtag cable. The patch adds support for this board from PS perspective. The most interesting part on the board is seps525 oled display. Also i2c, gpio, ethernet, uart, SD and eMMC are tested. Signed-off-by: Michal Simek ---

Please pull u-boot-marvell/master

2021-10-21 Thread Stefan Roese
Hi Tom, please pull this next batch of Marvell MVEBU related patches: - Turris MOX and Omnia changes, mostly moving to Kconfig (Marek) - a37xx: pci: Misc smaller fixes (Pali) - cmd: tlv_eeprom: Fix building with DEBUG enabled

Re: [PATCH 2/2] dt-bindings: u-boot: Add an initial binding for config

2021-10-21 Thread Mark Kettenis
> From: Simon Glass > Date: Wed, 20 Oct 2021 16:44:41 -0600 > > Hi Rob, > > On Mon, 18 Oct 2021 at 16:26, Rob Herring wrote: > > > > On Wed, Oct 13, 2021 at 11:33 AM Simon Glass wrote: > > > > > > " > > > Hi Rob, > > > > > > On Tue, 12 Oct 2021 at 09:05, Rob Herring wrote: > > > > > > > >

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Wolfgang Denk
Dear Tom, In message <20211019163000.GI7964@bill-the-cat> you wrote: > > I'm not sure I like saying the operator is "=+" rather than "+=" because > "=+" is a less commonly seen operator and tends to be an alternative > appends for special cases / side-effects / position in parsing. I fully

Re: [PATCH] net: gem: Disable broadcast setting

2021-10-21 Thread Michal Simek
On 10/15/21 15:03, Michal Simek wrote: There is no need for GEM to accepts broadcast packets because they are not handled by u-boot anyway. That's why use HW IP feature and don't waste time on these packats which will be dropped anyway. Signed-off-by: Michal Simek ---

Re: [PATCH 1/2] firmware: zynqmp: Handle errors from ipi_req properly

2021-10-21 Thread Michal Simek
On 10/15/21 16:57, Michal Simek wrote: There are multiple errors what can happen in ipi_req but they are not propagated properly. That's why propage all error properly. Signed-off-by: Michal Simek --- drivers/firmware/firmware-zynqmp.c | 6 +- 1 file changed, 5 insertions(+), 1

Re: [PATCH] ARM: stm32: Enable DFU SF support on DHSOM

2021-10-21 Thread Patrick DELAUNAY
On 10/19/21 5:03 AM, Marek Vasut wrote: All the STM32MP1 based DHSOM have SPI NOR from which they boot, enable DFU_SF support to make it possible to expose that SPI NOR via the DFU. Signed-off-by: Marek Vasut Cc: Patrice Chotard Cc: Patrick Delaunay ---

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > Wait saying we'll add "+SOMETHING" is a common case? > > Yes we have places where we add to env vars depending on CONFIG settings. Yes, but how many places are there where the appended value starts with a '+' ? > The way I have this, is it fairly

[PATCH 1/1] smbios: amend the description of smbios_string()

2021-10-21 Thread Heinrich Schuchardt
Add a warning that this function only works for strings preceding the first non-string field. Signed-off-by: Heinrich Schuchardt --- include/smbios.h | 4 1 file changed, 4 insertions(+) diff --git a/include/smbios.h b/include/smbios.h index aa6b6f3849..b7a1b8e412 100644 ---

Re: [PATCH 1/1] arm64: zynqmp: allow overriding board name

2021-10-21 Thread Michal Simek
On 10/20/21 17:25, Liam Beguin wrote: There is no need to use zynqmp name as SYS_BOARD for all boards. The patch is adding an option to change it. Signed-off-by: Liam Beguin --- arch/arm/mach-zynqmp/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-zynqmp/Kconfig

Re: [PATCH v3 12/16] Layerscape: Add crypto node in device tree

2021-10-21 Thread Michael Walle
Hi, > LS(1021/1012/1028/1043/1046/1088/2088), LX2160 - updated device tree > > Signed-off-by: Gaurav Jain > Reviewed-by: Priyanka Jain > --- > [..] > > diff --git a/arch/arm/dts/fsl-ls1028a.dtsi b/arch/arm/dts/fsl-ls1028a.dtsi > index 50f9b527cd..c2a156ea8e 100644 > ---

Re: [PATCH] arm: dts: imx8mp: Delete default clocks for clock controller node

2021-10-21 Thread Stefano Babic
Hi Peng, On 15.09.21 05:01, Peng Fan (OSS) wrote: On 2021/8/17 14:32, Ye Li wrote: Since SPL has initialized clocks for bus and core. We don't need to set the default clocks for clock controller node. Signed-off-by: Ye Li ---   arch/arm/dts/imx8mp-u-boot.dtsi | 3 +++   1 file changed, 3

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > > var++=fred > > > > > > is unambiguous but very confusing. I think it would be better to disallow > > > + > > > > It's neither unambiguous nor confusing. It is assigning to "var++". > > What? Can you read that again? Did so, but didn't get what you

Re: CRC32 endianess

2021-10-21 Thread Michal Simek
Hi, On 10/20/21 14:40, Wouter Joris wrote: Dear U-boot maintainers, I'm working on an Xilinx Zynqmp project ( Checkout tag xilinx-v2019.1 ) (ARM Cortex A53 ) and I'm facing an endianess mix-up. I'm no C-code guru, so I hope you'll

Re: [PATCH] arm64: zynqmp: Fix sgmii clock input freq for p-a2197

2021-10-21 Thread Michal Simek
On 10/15/21 14:48, Michal Simek wrote: Input frequency for sgmii is 125MHz on all Xilinx designs. Signed-off-by: Michal Simek --- arch/arm/dts/zynqmp-p-a2197-00-revA.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/zynqmp-p-a2197-00-revA.dts

[PATCH] arm64: zynqmp: Replace comma by semicolon

2021-10-21 Thread Michal Simek
Fix issue reported by checkpatch.pl WARNING: Possible comma where semicolon could be used #499: FILE: board/xilinx/zynqmp/zynqmp.c:499: + size = ALIGN(CONFIG_SYS_MALLOC_LEN + total_size, MMU_SECTION_SIZE), + reg = lmb_alloc(, size, MMU_SECTION_SIZE); Signed-off-by: Michal Simek ---

Re: [PATCH] arm: mvebu: Add missing "if SPL"

2021-10-21 Thread Stefan Roese
On 15.10.21 16:54, Tom Rini wrote: We can only select SPL_SKIP_LOWLEVEL_INIT if SPL is enabled, otherwise we get a warning about unmet dependencies on platforms that don't use SPL. Fixes: cf47a8cf8f7e ("arm: mvebu: Select SPL_SKIP_LOWLEVEL_INIT on ARMADA_32BIT") Cc: Stefan Roese

Re: [PATCH u-boot-marvell 00/12] Small Turris MOX and Omnia changes

2021-10-21 Thread Stefan Roese
On 09.10.21 19:33, Marek Behún wrote: From: Marek Behún Hi Stefan, these are some small changes for Turris Omnia and MOX, mainly moving options from board config header to Kconfig, but also some other. Two patchs are touching other mvebu boards. Marek Marek Behún (12): arm: mvebu:

Re: [PATCH] arm: a37xx: pci: Do not allow setting bars on PCI Bridge

2021-10-21 Thread Stefan Roese
On 12.10.21 13:19, Pali Rohár wrote: PCI Bridge which represents Aardvark PCIe Root Port does not have configurable bars. So ensure that write operation to bars registers on PCI Bridge is noop and bars registers always contain zero address which indicates that bars are unsupported. After this

[PATCH] arm: dts: stm32mp15: alignment with v5.15-rc6

2021-10-21 Thread Patrick Delaunay
Device tree alignment with Linux kernel v5.15-rc6 - Set {bitclock,frame}-master phandles on ST DKx - Add coprocessor detach mbox on stm32mp15x-dkx boards - Add coprocessor detach mbox on stm32mp157c-ed1 board Signed-off-by: Patrick Delaunay --- arch/arm/dts/stm32mp157c-ed1.dts | 4 ++--

Re: [PATCH v1 0/2] board: toradex: improve env badblock management for NAND variant boards

2021-10-21 Thread Francesco Dolcini
Hello Stefano, On Thu, Oct 21, 2021 at 12:16:33PM +0200, Stefano Babic wrote: > On 01.09.21 09:48, Francesco Dolcini wrote: > > > > Use the complete 512kb (4 blocks) nand partition reserved for u-boot > > environment instead of just the first block, this allows the module > > to have a working

Re: [PATCH v6 2/2] board: kontron: pitx-imx8m: Add Kontron pitx-imx8m board support

2021-10-21 Thread Stefano Babic
Hi Heiko, On 14.10.21 20:08, Heiko Thiery wrote: The Kontron pitx-imx8m is an NXP i.MX8MQ based board in the pITX form factor. There is still something using binman that does not work with CI. Without CI, we load all firmware including signed_hdmi_imx8m.bin. But on CI, file is not loaded,

Re: [PATCH v3 1/3] efi_loader: add SMBIOS table measurement

2021-10-21 Thread Masahisa Kojima
is On Thu, 21 Oct 2021 at 22:04, Heinrich Schuchardt wrote: > > > > On 10/21/21 14:52, Masahisa Kojima wrote: > > On Thu, 21 Oct 2021 at 17:49, Heinrich Schuchardt > > wrote: > >> > >> > >> > >> On 10/21/21 10:38, Masahisa Kojima wrote: > >>> On Thu, 21 Oct 2021 at 09:17, Heinrich Schuchardt

Re: Please pull u-boot-marvell/master

2021-10-21 Thread Tom Rini
On Thu, Oct 21, 2021 at 09:53:56AM +0200, Stefan Roese wrote: > Hi Tom, > > please pull this next batch of Marvell MVEBU related patches: > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] xilinx: zynqmp: Save multiboot as variable

2021-10-21 Thread Oleksandr Suvorov
On Thu, Oct 21, 2021 at 9:59 AM Michal Simek wrote: > > Save multiboot register as u-boot variable. And use it as primary source > for composing dfu_alt_info for capsule update. If variable is not defined > > Signed-off-by: Michal Simek > --- > > board/xilinx/zynqmp/zynqmp.c | 4 +++- > 1 file

Re: [PATCH 2/3] buildman: Detect Kconfig loops

2021-10-21 Thread Tom Rini
On Tue, Oct 19, 2021 at 09:43:24PM -0600, Simon Glass wrote: > Hex and int Kconfig options are supposed to have defaults. This is so we > can configure U-Boot without having to enter particular values for the > items that don't have specific values in the board's defconfig file. That's not true.

Re: [PATCH v3 1/3] efi_loader: add SMBIOS table measurement

2021-10-21 Thread Masahisa Kojima
On Thu, 21 Oct 2021 at 17:49, Heinrich Schuchardt wrote: > > > > On 10/21/21 10:38, Masahisa Kojima wrote: > > On Thu, 21 Oct 2021 at 09:17, Heinrich Schuchardt > > wrote: > >> > >> On 10/1/21 1:18 PM, Masahisa Kojima wrote: > >>> TCG PC Client spec requires to measure the SMBIOS > >> > >> I

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-21 Thread Marek Behún
BTW, wouldn't it be enough to simply imply TOOLS_LIBCRYPTO for mvebu platform in Kconfig?

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Marek Behún
Hello, On Thu, 21 Oct 2021 15:06:51 +0200 Wolfgang Denk wrote: > I confirm that '+=' looks better. But '+=" is technically broken. a bit of my opinion: I think =+ will confuse far more people than + as last character of var name working weirdly. But I also think that + should be supported as

Re: [PATCH] doc: Remove obsolete README.440-DDR-performance file

2021-10-21 Thread Thomas Huth
On 21/10/2021 08.00, Thomas Huth wrote: On 21/10/2021 07.16, Stefan Roese wrote: On 21.10.21 00:32, Heinrich Schuchardt wrote: On 10/19/21 9:25 AM, Thomas Huth wrote: The PPC 440 support has been removed in commit 98f705c9ce ("powerpc: remove 4xx support") already, so this file is certainly

Re: [PATCH] doc: Remove obsolete doc/README.nand-boot-ppc440

2021-10-21 Thread Thomas Huth
On 21/10/2021 07.20, Stefan Roese wrote: The PPC440 support has been removed in commit 98f705c9ce ("powerpc: remove 4xx support"). This patch removes this obsolete file as well. Signed-off-by: Stefan Roese Cc: Heinrich Schuchardt Cc: Thomas Huth --- doc/README.nand-boot-ppc440 | 60

Re: [PATCH] doc: Remove obsolete README.440-DDR-performance file

2021-10-21 Thread Thomas Huth
On 21/10/2021 07.16, Stefan Roese wrote: On 21.10.21 00:32, Heinrich Schuchardt wrote: On 10/19/21 9:25 AM, Thomas Huth wrote: The PPC 440 support has been removed in commit 98f705c9ce ("powerpc: remove 4xx support") already, so this file is certainly not required anymore. Signed-off-by:

Re: [PATCH] arm: dts: sun50i-h6-orangepi-3: disable aldo2 regulator

2021-10-21 Thread Andre Przywara
On Wed, 20 Oct 2021 21:31:09 +0300 Maxim Karasev wrote: Hi Maxim, > Hi. Thanks for explanation, I'm new to mailing lists, so I appreciate this. > > Also I'm happy to hear that any work is done to address that issue. > > >I was thinking about adding a TF-A build option that would skip

Re: [PATCH v3 1/3] efi_loader: add SMBIOS table measurement

2021-10-21 Thread Heinrich Schuchardt
On 10/21/21 14:52, Masahisa Kojima wrote: On Thu, 21 Oct 2021 at 17:49, Heinrich Schuchardt wrote: On 10/21/21 10:38, Masahisa Kojima wrote: On Thu, 21 Oct 2021 at 09:17, Heinrich Schuchardt wrote: On 10/1/21 1:18 PM, Masahisa Kojima wrote: TCG PC Client spec requires to measure the

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Marek Behún
On Thu, 21 Oct 2021 15:25:37 +0200 Marek Behún wrote: > Hello, > > On Thu, 21 Oct 2021 15:06:51 +0200 > Wolfgang Denk wrote: > > > I confirm that '+=' looks better. But '+=" is technically broken. > > a bit of my opinion: > I think =+ will confuse far more people than + as last character

Re: [PATCH v9 0/7] env: Allow environment in text files

2021-10-21 Thread Tom Rini
On Tue, Oct 19, 2021 at 04:44:15PM -0600, Simon Glass wrote: > One barrier to completing the 7-year-long Kconfig migration is that > the default environment is implemented using ad-hoc CONFIG options. > At present U-Boot environment variables, and thus scripts, are defined > by

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Tom Rini
On Thu, Oct 21, 2021 at 11:50:02AM +0200, Wolfgang Denk wrote: > Dear Simon, > > In message > <20211019164418.v9.3.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> you > wrote: > > At present U-Boot environment variables, and thus scripts, are defined > > by CONFIG_EXTRA_ENV_SETTINGS. It is

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-21 Thread Pali Rohár
On Thursday 21 October 2021 15:00:48 Marek Behún wrote: > BTW, wouldn't it be enough to simply imply TOOLS_LIBCRYPTO for mvebu > platform in Kconfig? FYI https://lore.kernel.org/u-boot/20211021093304.25399-1-p...@kernel.org/ (forgot to CC)

Re: [PATCH v6 2/2] board: kontron: pitx-imx8m: Add Kontron pitx-imx8m board support

2021-10-21 Thread Stefano Babic
On 21.10.21 15:17, Heiko Thiery wrote: Hi Stefano, Am Do., 21. Okt. 2021 um 13:31 Uhr schrieb Stefano Babic : Hi Heiko, On 14.10.21 20:08, Heiko Thiery wrote: The Kontron pitx-imx8m is an NXP i.MX8MQ based board in the pITX form factor. There is still something using binman that does

Re: [PATCH] stm32mp: stm32prog: Normalise newlines

2021-10-21 Thread Patrick DELAUNAY
On 10/13/21 11:56 AM, William Grant wrote: The missing trailing newline could confuse check-config.sh if the definition of an option was on the first line of the next file that find(1) happened to return. Signed-off-by: William Grant --- arch/arm/mach-stm32mp/cmd_stm32prog/Kconfig | 3 +--

Re: [PATCH v6 2/2] board: kontron: pitx-imx8m: Add Kontron pitx-imx8m board support

2021-10-21 Thread Heiko Thiery
Hi Stefano, Am Do., 21. Okt. 2021 um 13:31 Uhr schrieb Stefano Babic : > > Hi Heiko, > > On 14.10.21 20:08, Heiko Thiery wrote: > > The Kontron pitx-imx8m is an NXP i.MX8MQ based board in the pITX > > form factor. > > > > There is still something using binman that does not work with CI. >

[PATCH 5/7] imx8mp_evk: Remove EQoS PHY reset codes

2021-10-21 Thread sbabic
> Since we uses the DTS and PHY reset gpio in EQoS driver to do the > reset, remove the duplicated codes from board file. > Signed-off-by: Ye Li Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- = DENX

[PATCH 3/7] arm: dts: imx8mp-evk: Enable the EQoS ethernet port

2021-10-21 Thread sbabic
> i.MX8MP EVK has two ethernet ports. Add relevant nodes and properties > for EQoS port to the EVK DTS file. > In -u-boot.dtsi, change the u-boot eqos compatible string, add PHY > reset gpio and remove assigned clocks as not supported in CCF. > Signed-off-by: Ye Li Applied to u-boot-imx, master,

[PATCH] arm: dts: imx8mp: Delete default clocks for clock controller node

2021-10-21 Thread sbabic
> Since SPL has initialized clocks for bus and core. We don't need to > set the default clocks for clock controller node. > Signed-off-by: Ye Li > Tested-by: Teresa Remmet > Tested-by: Andrey Zhizhikin > Acked-by: Peng Fan Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic

[PATCH 4/7] imx8mp_evk: Fix incorrect cascade for FEC and EQOS setup

2021-10-21 Thread sbabic
> The setup functions should be independent for two ethernet controllers > Signed-off-by: Ye Li Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, Managing Director:

[PATCH 7/7] imx8mp_evk: Enable the DWC EQoS iMX driver

2021-10-21 Thread sbabic
> Enable the EQoS i.MX driver in defconfig, also enable the PHYLIB > to facilitate the case that only has FEC enabled. > Signed-off-by: Ye Li Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- = DENX

Re: Pull request: u-boot-imx u-boot-imx-20211020

2021-10-21 Thread Tom Rini
On Wed, Oct 20, 2021 at 02:48:40PM +0200, Stefano Babic wrote: > Hi Tom, > > this is a first PR for u-boot-imx. I have still a lot of patches in queue, > so a second PR will follow. Simon's patches to improve buildman are merged > here (thanks, else I had no idea how to discover the cause of

Re: [PATCH v3 12/16] Layerscape: Add crypto node in device tree

2021-10-21 Thread Tom Rini
On Thu, Oct 21, 2021 at 09:07:42AM +0200, Michael Walle wrote: > Hi, > > > LS(1021/1012/1028/1043/1046/1088/2088), LX2160 - updated device tree > > > > Signed-off-by: Gaurav Jain > > Reviewed-by: Priyanka Jain > > --- > > [..] > > > > diff --git a/arch/arm/dts/fsl-ls1028a.dtsi

Re: [PULL] u-boot-riscv/master

2021-10-21 Thread Tom Rini
On Wed, Oct 20, 2021 at 03:14:00PM +0800, Leo Liang wrote: > Hi Tom, > > The following changes since commit fb1018106a7bbb1a0d723029f6760b1b1b4d306d: > > Merge branch '2021-10-19-assorted-changes' (2021-10-19 20:45:12 -0400) > > are available in the Git repository at: > >

Re: [PATCH v3 12/16] Layerscape: Add crypto node in device tree

2021-10-21 Thread Vladimir Oltean
On Thu, Oct 21, 2021 at 07:50:46AM -0400, Tom Rini wrote: > On Thu, Oct 21, 2021 at 09:07:42AM +0200, Michael Walle wrote: > > Hi, > > > > > LS(1021/1012/1028/1043/1046/1088/2088), LX2160 - updated device tree > > > > > > Signed-off-by: Gaurav Jain > > > Reviewed-by: Priyanka Jain > > > --- >

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-21 Thread Marek Behún
Hi Samuel, On Wed, 20 Oct 2021 09:14:11 -0500 Samuel Holland wrote: > Andre is correct. No version of this patch makes *any* change to *any* > in-tree defconfig build, because TOOLS_LIBCRYPTO=y in all defconfigs. > Even if I was to accept your assertion that it hides a possible error on >

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Wolfgang Denk
Dear Tom, In message <20211021122325.GX7964@bill-the-cat> you wrote: > > Do you have any other feedback on the entire rest of the series? I already wrote that I support the concept, and the few nit I saw have been fixed, I think. Except this unneeded breaking of backward compatibility. >

Re: [PATCH v6 2/2] board: kontron: pitx-imx8m: Add Kontron pitx-imx8m board support

2021-10-21 Thread Heiko Thiery
Hi Stefano, Hi Simon, Am Do., 21. Okt. 2021 um 15:29 Uhr schrieb Stefano Babic : > > On 21.10.21 15:17, Heiko Thiery wrote: > > Hi Stefano, > > > > > > Am Do., 21. Okt. 2021 um 13:31 Uhr schrieb Stefano Babic : > >> > >> Hi Heiko, > >> > >> On 14.10.21 20:08, Heiko Thiery wrote: > >>> The

[PATCH v2] board: ea: mx7ulp_com: allocate specific region of memory to OP-TEE

2021-10-21 Thread sbabic
> From: Ricardo Salveti > On the iMX7ULP uCOM board, OP-TEE uses the memory region defined by the > maximum DRAM address minus CONFIG_OPTEE_TZDRAM_SIZE, so subtract > CONFIG_OPTEE_TZDRAM_SIZE from the available DRAM size to avoid > conflicts. > Note the OPTEE boot process itself subtracts the

[PATCH 2/7] arm: mach-imx: Allow to build mac.c for EQoS driver

2021-10-21 Thread sbabic
> i.MX8MP has one DWC EQoS controller, so allow to build mac.c when > only this driver is enabled. > Signed-off-by: Ye Li Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH,

[PATCH 1/7] arm: mach-imx: Update MAC fuse for i.MX8MP

2021-10-21 Thread sbabic
> i.MX8MP has two ENET controllers, have to update the function to > enable loading two MAC addresses. > Signed-off-by: Ye Li > Tested-by: Marcel Ziswiler Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic --

[PATCH 6/7] imx8mp_evk: Delete noncached memory config

2021-10-21 Thread sbabic
> DWC EQOS driver has removed to use noncached memory, so delete > the configuration from iMX8MP EVK head file. > Signed-off-by: Ye Li Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- = DENX Software

[PATCH] tools: imx8m_image: Support ddr3 firmware

2021-10-21 Thread sbabic
> Some boards use ddr3, not ddr4, so we need to check ddr3 firmware. > Signed-off-by: Ariel D'Alessandro Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, Managing

[PATCH v2] mx7ulp: add getting a board serial number

2021-10-21 Thread sbabic
> From: Ricardo Salveti > Get Unique ID of SoC iMX7ULP, using the logic described in Fusemap > (IMX7ULPRMB2_Rev0_Fusemap) attached in the i.MX 7ULP APRM [1]. > [1] > https://www.nxp.com/docs/en/reference-manual/IMX7ULPRMB2.pdf > Signed-off-by: Ricardo Salveti > Co-developed-by: Oleksandr Suvorov

Commit 76c2ff3e broke backlight on Chromebook snow

2021-10-21 Thread Guillaume GARDET
Hi, Commit 76c2ff3e [0] broke backlight on Chromebook snow. A revert on top of 2021.10 restores the backlight. Not sure why it breaks on Chromebook snow yet. Dario, any idea how to fix this? Cheers, Guillaume

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Tom Rini
On Thu, Oct 21, 2021 at 09:59:38AM -0600, Simon Glass wrote: > Hi Marek, > > On Thu, 21 Oct 2021 at 07:28, Marek Behún wrote: > > > > On Thu, 21 Oct 2021 15:25:37 +0200 > > Marek Behún wrote: > > > > > Hello, > > > > > > On Thu, 21 Oct 2021 15:06:51 +0200 > > > Wolfgang Denk wrote: > > > > > >

Re: [PATCH 2/3] buildman: Detect Kconfig loops

2021-10-21 Thread Tom Rini
On Thu, Oct 21, 2021 at 10:09:56AM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 21 Oct 2021 at 06:13, Tom Rini wrote: > > > > On Tue, Oct 19, 2021 at 09:43:24PM -0600, Simon Glass wrote: > > > > > Hex and int Kconfig options are supposed to have defaults. This is so we > > > can configure

[PATCH 0/4] arm: mvebu: Fix usage of BIN header arguments

2021-10-21 Thread Pali Rohár
BIN header arguments are used only for aligning ARM executable code to 128-bit boundary. This patch series document this behavior and fix kwbimage and kwboot code to properly generate BIN headers. Pali Rohár (4): tools: kwboot: Align UART baudrate change code in BIN header to 128-bit

[PATCH] arm: mvebu: turris_omnia: Fix MTD partitions order for Linux

2021-10-21 Thread Pali Rohár
Linux enumerates MTD partitions in DTB order, while the fdt_add_subnode() function puts a new subnode at the beginning. To fix this, put MTD partitions into DTB in reverse order. Fixes: 92f36c8e74c1 ("arm: mvebu: turris_omnia: fixup MTD partitions in Linux' DTB") Signed-off-by: Pali Rohár

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Wolfgang Denk
Dear Marek, In message <20211021152831.15524883@thinkpad> you wrote: > > > > I think =+ will confuse far more people than + as last character of var I still fail to see why '=+' could be confusing if properly documented to be the append operator. I mean, it is not a new invention of mine.

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Tom Rini
On Thu, Oct 21, 2021 at 05:12:26PM +0200, Wolfgang Denk wrote: > Dear Marek, > > In message <20211021152831.15524883@thinkpad> you wrote: > > > > > > > I think =+ will confuse far more people than + as last character of var > > I still fail to see why '=+' could be confusing if properly >

Re: [PATCH] cmd: nand biterr - Add support for nand biterr command

2021-10-21 Thread Balamanikandan.Gunasundar
Hello, Can you please provide your comments on this patch. Thanks, Balamanikandan On 29/06/21 12:46 pm, Balamanikandan Gunasundar wrote: > The command shall be used to induce bit errors in the nand page > manually. The code flips a bit in the specified offset without > changing the ECC. This

[PATCH 3/4] arm: mvebu: Add documentation for save_boot_params() function

2021-10-21 Thread Pali Rohár
Important detail is availability of kwbimage BIN header arguments passed via r0 and r1 registers by BootROM. Signed-off-by: Pali Rohár --- arch/arm/mach-mvebu/lowlevel_spl.S | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/mach-mvebu/lowlevel_spl.S

[PATCH 4/4] arm: mvebu: Remove dummy BIN header arguments for SPL binary

2021-10-21 Thread Pali Rohár
U-Boot SPL binary does not read BIN header arguments, so passing some dummy values 005b and 0068 has no effect for U-Boot SPL code. Probably these two values comes from old Marvell DDR training code which was separated from U-Boot and used it for some configuration. Seems that two 32-bit

[PATCH 1/4] tools: kwboot: Align UART baudrate change code in BIN header to 128-bit boundary

2021-10-21 Thread Pali Rohár
ARM executable code inside the BIN header on some mvebu platforms (e.g. A370, AXP) must always be aligned with the 128-bit boundary. This requirement can be met by inserting dummy arguments into BIN header. Signed-off-by: Pali Rohár --- tools/kwboot.c | 22 +- 1 file

[PATCH 2/4] tools: kwbimage: Align BIN header executable code to 128-bit boundary

2021-10-21 Thread Pali Rohár
ARM executable code inside the BIN header on some mvebu platforms (e.g. A370, AXP) must always be aligned with the 128-bit boundary. This requirement can be met by inserting dummy arguments into BIN header. Signed-off-by: Pali Rohár --- tools/kwbimage.c | 51

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Simon Glass
Hi Marek, On Thu, 21 Oct 2021 at 07:28, Marek Behún wrote: > > On Thu, 21 Oct 2021 15:25:37 +0200 > Marek Behún wrote: > > > Hello, > > > > On Thu, 21 Oct 2021 15:06:51 +0200 > > Wolfgang Denk wrote: > > > > > I confirm that '+=' looks better. But '+=" is technically broken. > > > > a bit of

Re: [PATCH 2/3] buildman: Detect Kconfig loops

2021-10-21 Thread Simon Glass
Hi Tom, On Thu, 21 Oct 2021 at 06:13, Tom Rini wrote: > > On Tue, Oct 19, 2021 at 09:43:24PM -0600, Simon Glass wrote: > > > Hex and int Kconfig options are supposed to have defaults. This is so we > > can configure U-Boot without having to enter particular values for the > > items that don't

Re: [PATCH 2/3] buildman: Detect Kconfig loops

2021-10-21 Thread Stefano Babic
Hi Simon, On 21.10.21 18:15, Tom Rini wrote: On Thu, Oct 21, 2021 at 10:09:56AM -0600, Simon Glass wrote: Hi Tom, On Thu, 21 Oct 2021 at 06:13, Tom Rini wrote: On Tue, Oct 19, 2021 at 09:43:24PM -0600, Simon Glass wrote: Hex and int Kconfig options are supposed to have defaults. This is

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Simon Glass
Hi Tom, On Thu, 21 Oct 2021 at 10:03, Tom Rini wrote: > > On Thu, Oct 21, 2021 at 09:59:38AM -0600, Simon Glass wrote: > > Hi Marek, > > > > On Thu, 21 Oct 2021 at 07:28, Marek Behún wrote: > > > > > > On Thu, 21 Oct 2021 15:25:37 +0200 > > > Marek Behún wrote: > > > > > > > Hello, > > > > > >

Re: [PATCH v3 12/13] env: Simplify env_match() and inline into env_get_f()

2021-10-21 Thread Simon Glass
Hi Marek, On Mon, 18 Oct 2021 at 18:50, Marek Behún wrote: > > > Reviewed-by: Simon Glass > > Simon, thanks. Will you be taking this through your tree or should I > change delegate to Tom? I see it in my queue so I'll pick it up. Regards, Simon Applied to u-boot-dm, thanks!

Re: [PATCH v3 13/13] env: Move non-cli env functions to env/common.c

2021-10-21 Thread Simon Glass
From: Marek Behún Move the following functions from cmd/nvedit.c to env/common.c: env_set_ulong() env_set_hex() env_get_hex() eth_env_get_enetaddr() eth_env_set_enetaddr() env_get() from_env() env_get_f() env_get_ulong() since these functions are not specific for U-Boot's CLI.

Re: [PATCH] arm: dts: sun50i-h6-orangepi-3: disable aldo2 regulator

2021-10-21 Thread Maxim Karasev
>What are you packaging, exactly? (And for what distro?) I guess it's some >kind of U-Boot/firmware package [1]? Yes, it's U-Boot + ATF at Alpine and Linux + WiFi/BT firmware at postmarketOS. >So you build this per device then? Well, not exactly. Alpine builds one shared ATF package that

Re: [PATCH] buildman: Add gcc-11.1.0 to the directory list

2021-10-21 Thread Simon Glass
On Thu, Oct 14, 2021 at 07:25:24PM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 14 Oct 2021 at 19:12, Tom Rini wrote: > > > > On Thu, Oct 14, 2021 at 07:05:33PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 5 Oct 2021 at 10:20, Tom Rini wrote: > > > > > > > > While CI has been

Re: [PATCH v3 10/13] env: Make return value of env_get_f() behave like sprintf() on success

2021-10-21 Thread Simon Glass
From: Marek Behún Currently the env_get_f() function's return value behaves weirdly: it returns the number of bytes written into `buf`, but whether this is excluding the terminating NULL-byte or including it depends on whether there was enough space in `buf`. Change the function to always

Re: [PATCH v3 11/13] env: Use memcpy() instead of ad-hoc code to copy variable value

2021-10-21 Thread Simon Glass
From: Marek Behún Copy the value of the found variable into given buffer with memcpy() instead of ad-hoc code. Signed-off-by: Marek Behún Reviewed-by: Simon Glass --- cmd/nvedit.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v3 07/13] env: Use better name for variable in env_get_f()

2021-10-21 Thread Simon Glass
From: Marek Behún The `nxt` variable actually points to the terminating null-byte of the current env var, and the next env var is at `nxt + 1`, not `nxt`. So a better name for this variable is `end`. Signed-off-by: Marek Behún Reviewed-by: Simon Glass --- cmd/nvedit.c | 8 1 file

  1   2   >