Re: Testing PCIe on Armada 370 (or older) in U-Boot

2021-11-05 Thread Stefan Roese
Hi Pali, On 04.11.21 16:49, Pali Rohár wrote: Hello! Recently I have sent more PCIe related patches for mvebu/armada SoCs into U-Boot. Now all were merged into U-Boot git master branch. I have tested everything on Armada 38x. I would like to ask if you have some Armada 370 board (or older,

Re: [PATCH 1/1] sysreset: watchdog: watchdog cannot power off

2021-11-05 Thread Stefan Roese
On 04.11.21 10:31, Heinrich Schuchardt wrote: The watchdog system reset driver can reboot the device but it cannot power it off. If power off is requested, the driver should not reset the system but leave powering off to one of the other system reset drivers. As power cycling is typically not a

kwboot: Testing latest kwboot with Kirkwood SoC boards

2021-11-05 Thread Tony Dinh
Hi Marek and Pali, First off all, thanks for your hughe work on this. I have a few Armada 38x boards that I had quite a hard time running kwboot in the past. Hopefully, I will have more luck with the new kwboot. Here is a problem I've found running kwboot on the Zyxel NSA310S NAS (Kirkwood

Re: [PATCH] driver: gadget: fastboot: Link endpoint and descriptors

2021-11-05 Thread qianfan
在 2021/11/4 0:53, Sean Anderson 写道: On 9/16/21 3:02 AM, qianfangui...@163.com wrote: From: qianfan Zhao If the downloading file size is equal to the partition size, "fastboot flash" can't work, at least in sunxi platform, because used an uninitalized point: ep->desc. Hm, I think that

Re: [PATCH 11/14] watchdog: add support for MediaTek MT7621 SoC

2021-11-05 Thread Stefan Roese
On 04.11.21 10:50, Weijie Gao wrote: This patch makes mt7621_wdt driver available for MediaTek MT7621 SoC Signed-off-by: Weijie Gao Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 10/14] gpio: add support for MediaTek MT7621 SoC

2021-11-05 Thread Stefan Roese
On 04.11.21 10:50, Weijie Gao wrote: This patch makes mt7621_gpio driver available for MediaTek MT7621 SoC Signed-off-by: Weijie Gao Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/gpio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [RFC 2/2] binman: catch RunException for mkimage runtime failure

2021-11-05 Thread Heiko Thiery
Hi Simon, Am Fr., 5. Nov. 2021 um 03:02 Uhr schrieb Simon Glass : > > Hi Heiko, > > On Thu, 4 Nov 2021 at 12:53, Heiko Thiery wrote: > > > > In case mkimage exits with a return code other than zero do not stop. > > Print an error message and go on. > > > > Signed-off-by: Heiko Thiery > > --- >

Re: [PATCH 1/6 v4] tpm2: Introduce TIS tpm core

2021-11-05 Thread Ilias Apalodimas
Hi Simon, [...] > > > > +int tpm_tis_open(struct udevice *udev); > > Please add comments There are comments for all of those in drivers/tpm/tpm2_tis_core.c, isn't that enough? Thanks /Ilias > > > +int tpm_tis_close(struct udevice *udev); > > +int tpm_tis_cleanup(struct udevice *udev); > > +int

[PATCH] mmc: mtk-sd: implement waiting for DAT0 line state

2021-11-05 Thread Julien Masson
With the recent changes on mmc driver, we saw that the boot is ~5 secs longer compared to v2021.07 on mediatek platforms. This regression is seen during mmc_init and caused by the following patch [1]. Indeed since we did not support poll dat0, we fulfilled the condition of [1] and a delay of 500

Re: A38x: Broken Linux kernel booting over UART

2021-11-05 Thread Pali Rohár
On Friday 05 November 2021 10:35:10 Tom Rini wrote: > On Fri, Nov 05, 2021 at 12:38:21PM +0100, Pali Rohár wrote: > > On Monday 11 October 2021 17:49:05 Pali Rohár wrote: > > > On Monday 11 October 2021 10:45:44 Tom Rini wrote: > > > > On Mon, Oct 11, 2021 at 04:33:44PM +0200, Pali Rohár wrote: >

Re: [PATCH v5 02/11] tools: mkeficapsule: add firmwware image signing

2021-11-05 Thread Mark Kettenis
> From: Simon Glass > Date: Thu, 4 Nov 2021 20:02:38 -0600 > > Hi Mark, > > On Thu, 4 Nov 2021 at 10:51, Mark Kettenis wrote: > > > > > From: Simon Glass > > > Date: Thu, 4 Nov 2021 09:11:59 -0600 > > > > > > Hi Mark, > > > > > > On Thu, 4 Nov 2021 at 08:31, Mark Kettenis > > > wrote: > > >

Re: [PATCH v2 11/12] arm: mvebu: Espressobin: Use new API for setting default env at runtime

2021-11-05 Thread Pali Rohár
On Thursday 04 November 2021 20:02:33 Simon Glass wrote: > On Wed, 3 Nov 2021 at 17:23, Marek Behún wrote: > > > > From: Marek Behún > > > > ESPRESSObin's board code uses an ad-hoc solution for ensuring that > > ethaddrs are not overwritten by `env default -a` command and that the > > `fdtfile`

[PATCH 2/2] arm: imx8m: imx8mm-cl-iot-gate: detect extension board

2021-11-05 Thread Ying-Chun Liu
From: "Ying-Chun Liu (PaulLiu)" Extension boards can be added to Compulab's iot-gate-imx8mm. We implement extension board manager for detecting the extension boards. Signed-off-by: Uri Mashiach Signed-off-by: Ying-Chun Liu (PaulLiu) Cc: uboot-imx --- arch/arm/mach-imx/imx8m/Kconfig

[PATCH 1/2] arm: dts: imx8mm-cl-iot-gate: add Compulab's ied overlays

2021-11-05 Thread Ying-Chun Liu
From: "Ying-Chun Liu (PaulLiu)" add the following overlays: - IED extension board - CAN/TPM/ADC extension board on IED board. Signed-off-by: Uri Mashiach Signed-off-by: Ying-Chun Liu (PaulLiu) Cc: uboot-imx --- arch/arm/dts/Makefile| 20 -

[PATCH 0/2] arm: imx8m: imx8mm-cl-iot-gate: detect extension board

2021-11-05 Thread Ying-Chun Liu
From: "Ying-Chun Liu (PaulLiu)" Extension boards can be added to Compulab's iot-gate-imx8mm. We implement extension board manager for detecting the extension boards. The following overlays are added: - IED extension board - CAN/TPM/ADC extension board on IED board. Ying-Chun Liu (PaulLiu)

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-05 Thread Andre Przywara
On Thu, 4 Nov 2021 20:02:41 -0600 Simon Glass wrote: Hi, > On Thu, 4 Nov 2021 at 19:22, Stefan Roese wrote: > > > > Hi Andre, > > > > On 05.11.21 00:11, Andre Przywara wrote: > > > On Thu, 4 Nov 2021 11:37:57 +0100 > > > Stefan Roese wrote: > > > > > > Hi Stefan, > > > > > >> On 04.11.21

Re: [PATCH v2 04/12] sysinfo: Make sysinfo_get_str() behave like snprintf()

2021-11-05 Thread Marek Behún
On Thu, 4 Nov 2021 20:02:25 -0600 Simon Glass wrote: > Hi Marek, > > On Wed, 3 Nov 2021 at 17:23, Marek Behún wrote: > > > > From: Marek Behún > > > > Currently sysinfo_get_str() returns 0 if a string is filled in the > > given buffer, and otherwise gives no simple mechanism to determine > >

Re: [PATCH v1 2/2] bsh: imx8mn-smm-s2/pro: Add iMX8MN BSH SMM S2 boards

2021-11-05 Thread Ariel D'Alessandro
Hi all, On 11/3/21 4:56 PM, Ariel D'Alessandro wrote: > Introduce BSH SystemMaster (SMM) S2 board family, which consists of: > iMX8MN SMM S2 and iMX8MN SMM S2 PRO boards. > > Add support for iMX8MN BSH SMM S2 board: > > - 256 MiB DDR3 RAM > - 512MiB Nand > - USBOTG1 peripheral - fastboot. > >

Re: [RFC PATCH 00/23] sunxi: Add and use a pinctrl driver

2021-11-05 Thread Heinrich Schuchardt
On 10/21/21 06:55, Samuel Holland wrote: This series resolves some longstanding TODOs by implementing a pinctrl driver for sunxi platforms and converting DM drivers to use it. I am sending this as RFC because I have only tested this on a limited amount of hardware, and there are quite a few

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-05 Thread Tom Rini
On Fri, Nov 05, 2021 at 12:14:47PM +0100, Stefan Roese wrote: > Hi Andre, > > Added Tom to Cc. > > On 05.11.21 11:04, Andre Przywara wrote: > > On Thu, 4 Nov 2021 20:02:41 -0600 > > Simon Glass wrote: > > > > Hi, > > > > > On Thu, 4 Nov 2021 at 19:22, Stefan Roese wrote: > > > > > > > > Hi

Re: A38x: Broken Linux kernel booting over UART

2021-11-05 Thread Tom Rini
On Fri, Nov 05, 2021 at 04:16:46PM +0100, Pali Rohár wrote: > On Friday 05 November 2021 10:35:10 Tom Rini wrote: > > On Fri, Nov 05, 2021 at 12:38:21PM +0100, Pali Rohár wrote: > > > On Monday 11 October 2021 17:49:05 Pali Rohár wrote: > > > > On Monday 11 October 2021 10:45:44 Tom Rini wrote: >

Re: [PATCH] driver: gadget: fastboot: Link endpoint and descriptors

2021-11-05 Thread Sean Anderson
On 11/5/21 2:28 AM, qianfan wrote: 在 2021/11/4 0:53, Sean Anderson 写道: On 9/16/21 3:02 AM, qianfangui...@163.com wrote: From: qianfan Zhao If the downloading file size is equal to the partition size, "fastboot flash" can't work, at least in sunxi platform, because used an uninitalized

Re: [PATCH 2/4] sunxi: gpio: Add per-bank drive and pull setters

2021-11-05 Thread Heinrich Schuchardt
On 10/21/21 06:52, Samuel Holland wrote: The GPIO and pinctrl drivers need these setters for pin configuration. Since they are DM drivers, they should not be using hardcoded base addresses. Factor out variants of the setter functions which take a pointer to the GPIO bank's MMIO registers.

Re: A38x: Broken Linux kernel booting over UART

2021-11-05 Thread Tom Rini
On Fri, Nov 05, 2021 at 12:38:21PM +0100, Pali Rohár wrote: > On Monday 11 October 2021 17:49:05 Pali Rohár wrote: > > On Monday 11 October 2021 10:45:44 Tom Rini wrote: > > > On Mon, Oct 11, 2021 at 04:33:44PM +0200, Pali Rohár wrote: > > > > On Monday 11 October 2021 10:32:22 Tom Rini wrote: > >

Re: [PATCH] lib: sparse: Make CHUNK_TYPE_RAW buffer aligned

2021-11-05 Thread Sean Anderson
Hi quanfan, Thanks for the patch. I had something similar in mind. On 11/5/21 1:46 AM, qianfangui...@qq.com wrote: From: qianfan Zhao CHUNK_TYPE_RAW buffer is not aligned, and flash sparse images by fastboot will report "Misaligned operation" if DCACHE is enabled. Flashing Sparse Image

[PATCH] rtc: ds1337: fix compatible string typo

2021-11-05 Thread Clemens Gruber
The driver supports the ds1339 as well, which was probably intended by the author but prevented by a typo. Fix the typo. Signed-off-by: Clemens Gruber --- drivers/rtc/ds1337.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/ds1337.c b/drivers/rtc/ds1337.c index

Re: [PATCH 1/4] sunxi: gpio: Return void from setter functions

2021-11-05 Thread Heinrich Schuchardt
On 10/21/21 06:52, Samuel Holland wrote: The return values of these functions are always zero, and they are never checked. Since they are not needed, remove them. Signed-off-by: Samuel Holland Reviewed-by: Heinrich Schuchardt

Re: [PATCH 3/4] gpio: sunxi: Implement .set_flags

2021-11-05 Thread Heinrich Schuchardt
On 10/21/21 06:52, Samuel Holland wrote: This, along with gpio_flags_xlate(), allows the GPIO driver to handle pull-up/down flags provided by consumer drivers or in the device tree. Signed-off-by: Samuel Holland Reviewed-by: Simon Glass --- drivers/gpio/sunxi_gpio.c | 62

[PATCH] makefile: add missing semicolons

2021-11-05 Thread Angelo Dureghello
On some distributions, as Debian GNU 11, this targets fails with errors. Signed-off-by: Angelo Dureghello --- Makefile | 2 +- scripts/Makefile.autoconf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index c45da3ad88..1a1d1b0426

Re: [PATCH 4/4] mmc: sunxi: Use DM_GPIO flags to set pull-up

2021-11-05 Thread Heinrich Schuchardt
On 10/21/21 06:52, Samuel Holland wrote: Now that the sunxi_gpio driver handles pull-up/down via the driver model, pin configuration does not need a platform-specific function. Signed-off-by: Samuel Holland I tested on an OrangePi PC (orangepi_pc_defconfig). The 'mmc rescan' command detects

[PATCH 1/1] doc: mmc rescan speed mode

2021-11-05 Thread Heinrich Schuchardt
Provide human readable descriptions of the speed nodes instead of the name of constants from the code. Signed-off-by: Heinrich Schuchardt --- doc/usage/mmc.rst | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/doc/usage/mmc.rst

Booting zImage with appended DTB without ATAGs support

2021-11-05 Thread Pali Rohár
On Friday 05 November 2021 11:20:01 Tom Rini wrote: > On Fri, Nov 05, 2021 at 04:16:46PM +0100, Pali Rohár wrote: > > So now I have a question: Do we want to support booting zImage with > > appended DTB in U-Boot when ATAGs support is now disabled by default? > > Based on your experience, yes,

Re: [PATCH 2/6 v4] tpm2: Add a TPMv2 MMIO TIS driver

2021-11-05 Thread Ilias Apalodimas
On Fri, Nov 05, 2021 at 10:17:21AM +0200, Ilias Apalodimas wrote: > Hi Simon, > > [...] > > > > + u8 *result) > > > +{ > > > + struct tpm_tis_chip_data *drv_data = (void > > > *)dev_get_driver_data(udev); > > > + > > > + while (len--) > > > +

Re: Testing PCIe on Armada 370 (or older) in U-Boot

2021-11-05 Thread Pali Rohár
On Friday 05 November 2021 07:08:34 Stefan Roese wrote: > Hi Pali, > > On 04.11.21 16:49, Pali Rohár wrote: > > Hello! Recently I have sent more PCIe related patches for mvebu/armada > > SoCs into U-Boot. Now all were merged into U-Boot git master branch. > > I have tested everything on Armada

Re: kwboot: Testing latest kwboot with Kirkwood SoC boards

2021-11-05 Thread Pali Rohár
Hello! On Thursday 04 November 2021 23:27:32 Tony Dinh wrote: > Hi Marek and Pali, > > First off all, thanks for your hughe work on this. I have a few Armada > 38x boards that I had quite a hard time running kwboot in the past. > Hopefully, I will have more luck with the new kwboot. > > Here is

Re: [PATCH v2 06/12] sysinfo: Add get_str_list() method

2021-11-05 Thread Marek Behún
On Thu, 4 Nov 2021 20:02:27 -0600 Simon Glass wrote: > On Wed, 3 Nov 2021 at 17:23, Marek Behún wrote: > > > > From: Marek Behún > > > > Add get_str_list() method to sysinfo operations. > > > > The get_str_list() method is similar to get_str(), but receives one > > additional argument, @idx,

Re: Injecting public keys into FTDs for FIT verification

2021-11-05 Thread Jan Kiszka
On 05.11.21 13:42, Jan Kiszka wrote: > On 05.11.21 11:28, Rasmus Villemoes wrote: >> On 05/11/2021 11.16, Jan Kiszka wrote: >>> Hi all, >>> >>> in order to use CONFIG_FIT_SIGNATURE and also >>> CONFIG_SPL_FIT_SIGNATURE, a public key needs to be placed into the >>> control FDT. So far, I only found

Re: [PATCH 2/6 v4] tpm2: Add a TPMv2 MMIO TIS driver

2021-11-05 Thread Ilias Apalodimas
Hi Simon, [...] > > + u8 *result) > > +{ > > + struct tpm_tis_chip_data *drv_data = (void > > *)dev_get_driver_data(udev); > > + > > + while (len--) > > + *result++ = ioread8(drv_data->iobase + addr); > > + return 0; > > +} > > + > >

Re: [PATCH 00/31] passage: Define a standard for firmware data flow

2021-11-05 Thread François Ozog
On Fri, 5 Nov 2021 at 03:02, Simon Glass wrote: > Hi François, > > On Tue, 2 Nov 2021 at 10:03, François Ozog > wrote: > > > > Hi Simon, > > > > On Tue, 2 Nov 2021 at 15:59, Simon Glass wrote: > >> > >> Hi François, > >> > >> On Mon, 1 Nov 2021 at 02:53, François Ozog > wrote: > >> > > >> >

Re: [PATCH v5 02/11] tools: mkeficapsule: add firmwware image signing

2021-11-05 Thread AKASHI Takahiro
On Fri, Nov 05, 2021 at 11:35:00AM +0900, AKASHI Takahiro wrote: > On Thu, Nov 04, 2021 at 08:02:40PM -0600, Simon Glass wrote: > > Hi Takahiro, > > > > On Thu, 4 Nov 2021 at 19:04, AKASHI Takahiro > > wrote: > > > > > > Hi, Simon, > > > > > > On Thu, Nov 04, 2021 at 09:11:59AM -0600, Simon

Re: Injecting public keys into FTDs for FIT verification

2021-11-05 Thread Jan Kiszka
On 05.11.21 11:28, Rasmus Villemoes wrote: > On 05/11/2021 11.16, Jan Kiszka wrote: >> Hi all, >> >> in order to use CONFIG_FIT_SIGNATURE and also >> CONFIG_SPL_FIT_SIGNATURE, a public key needs to be placed into the >> control FDT. So far, I only found mkimage being able to do that during >> FIT

Re: kwboot: Testing latest kwboot with Kirkwood SoC boards

2021-11-05 Thread Pali Rohár
On Friday 05 November 2021 09:38:28 Pali Rohár wrote: > Hello! > > On Thursday 04 November 2021 23:27:32 Tony Dinh wrote: > > Hi Marek and Pali, > > > > First off all, thanks for your hughe work on this. I have a few Armada > > 38x boards that I had quite a hard time running kwboot in the past.

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-05 Thread Stefan Roese
Hi Andre, Added Tom to Cc. On 05.11.21 11:04, Andre Przywara wrote: On Thu, 4 Nov 2021 20:02:41 -0600 Simon Glass wrote: Hi, On Thu, 4 Nov 2021 at 19:22, Stefan Roese wrote: Hi Andre, On 05.11.21 00:11, Andre Przywara wrote: On Thu, 4 Nov 2021 11:37:57 +0100 Stefan Roese wrote: Hi

Re: [PATCH v2 08/12] sysinfo: Add support for iterating string list

2021-11-05 Thread Marek Behún
On Thu, 4 Nov 2021 20:02:29 -0600 Simon Glass wrote: > Better to make iter a struct sysinfo_str_list_iter, I think and > require the caller to declare it: > > sysinfo_str_list_iter iter; > char str[80]' > > p = sysinfo_str_list_first(dev, i, , sizeof(str), ); > ... > > Do you need the iter? >

Injecting public keys into FTDs for FIT verification

2021-11-05 Thread Jan Kiszka
Hi all, in order to use CONFIG_FIT_SIGNATURE and also CONFIG_SPL_FIT_SIGNATURE, a public key needs to be placed into the control FDT. So far, I only found mkimage being able to do that during FIT image signing. That is fairly unhandy and often incompatible with how firmware is built & signed vs.

[PATCH] crypto/fsl: Fallback to SW sha1/256 is misaligned buffers

2021-11-05 Thread Christian Sørensen
Problem: With U-Boot 2021.10, we currently cannot load a fitImage on our imx7d board, due to misaligned buffers. Reason: Commit 92055e138f28 ("image: Drop if/elseif hash selection in calculate_hash()") changed the way the FIT were verified. Previously, SW sha1/256 were always used. Due to that

Re: Injecting public keys into FTDs for FIT verification

2021-11-05 Thread Rasmus Villemoes
On 05/11/2021 11.16, Jan Kiszka wrote: > Hi all, > > in order to use CONFIG_FIT_SIGNATURE and also > CONFIG_SPL_FIT_SIGNATURE, a public key needs to be placed into the > control FDT. So far, I only found mkimage being able to do that during > FIT image signing. That is fairly unhandy and often

Re: A38x: Broken Linux kernel booting over UART

2021-11-05 Thread Pali Rohár
On Monday 11 October 2021 17:49:05 Pali Rohár wrote: > On Monday 11 October 2021 10:45:44 Tom Rini wrote: > > On Mon, Oct 11, 2021 at 04:33:44PM +0200, Pali Rohár wrote: > > > On Monday 11 October 2021 10:32:22 Tom Rini wrote: > > > > On Mon, Oct 11, 2021 at 04:25:48PM +0200, Pali Rohár wrote: > >

Re: [PATCH 09/10] Convert CONFIG_SPL_DRIVERS_MISC et al to Kconfig

2021-11-05 Thread Tom Rini
On Sat, Oct 30, 2021 at 11:03:56PM -0400, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_SPL_DRIVERS_MISC >CONFIG_SPL_ENV_SUPPORT >CONFIG_SPL_GPIO >CONFIG_SPL_I2C >CONFIG_SPL_LDSCRIPT >CONFIG_SPL_LIBCOMMON_SUPPORT >CONFIG_SPL_LIBGENERIC_SUPPORT >

Re: [PATCH 10/10] Convert CONFIG_BOARD_EARLY_INIT_F et al to Kconfig

2021-11-05 Thread Tom Rini
On Sat, Oct 30, 2021 at 11:03:57PM -0400, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_BOARD_EARLY_INIT_F >CONFIG_BOARD_LATE_INIT >CONFIG_DISPLAY_BOARDINFO >CONFIG_DISPLAY_BOARDINFO_LATE > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom

RE: [PATCH v6 1/2] net: brcm: netXtreme driver

2021-11-05 Thread Roman Bacik
Hi Pali, > -Original Message- > From: Pali Rohár > Sent: Wednesday, November 3, 2021 4:14 PM > To: Roman Bacik > Cc: U-Boot Mailing List ; Bharat Gooty > ; Joe Hershberger > ; Ramon Fried > Subject: Re: [PATCH v6 1/2] net: brcm: netXtreme driver > > Hello! See inline comments below. >

Re: [PATCH] fs: yaffs2: Finish Kconfig migration

2021-11-05 Thread Tom Rini
On Tue, Oct 19, 2021 at 09:10:14PM -0400, Tom Rini wrote: > For the symbols which are both hard-coded as enabled and used, move to > Kconfig. The rest of the CONFIG_YAFFS namespace is unselected anywhere, > so we leave it as is. > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks!

Re: [PATCH 01/10] spl: Make use of CONFIG_IS_ENABLED(OS_BOOT) in SPL/TPL common code paths

2021-11-05 Thread Tom Rini
On Sat, Oct 30, 2021 at 11:03:48PM -0400, Tom Rini wrote: > When building a system that has both TPL and SPL_OS_BOOT, code which > tests for CONFIG_SPL_OS_BOOT will be built and enabled in TPL, which is > not correct. While there is no CONFIG_TPL_OS_BOOT symbol at this time > (and likely will

Re: [PATCH 02/10] Convert CONFIG_SYS_HZ to Kconfig

2021-11-05 Thread Tom Rini
On Sat, Oct 30, 2021 at 11:03:49PM -0400, Tom Rini wrote: > This converts the following to Kconfig: > CONFIG_SYS_HZ > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 03/10] Convert CONFIG_SYS_TEXT_BASE to Kconfig

2021-11-05 Thread Tom Rini
On Sat, Oct 30, 2021 at 11:03:50PM -0400, Tom Rini wrote: > This converts the following to Kconfig: > CONFIG_SYS_TEXT_BASE > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

[PATCH v1 1/2] image: Fix typo in boot_get_kbd()

2021-11-05 Thread Andy Shevchenko
After the commit 4ed37abc49c2 ("image: Remove ifdefs around image_setup_linux() el at"): common/image-board.c: In function ‘boot_get_kbd’: common/image-board.c:902:17: error: expected ‘)’ before ‘do_bdinfo’ 902 | do_bdinfo(NULL, 0, 0, NULL); | ^

[PATCH v1 2/2] image: Explicitly declare do_bdinfo()

2021-11-05 Thread Andy Shevchenko
Compiler is not happy: common/image-board.c: In function ‘boot_get_kbd’: common/image-board.c:902:17: warning: implicit declaration of function ‘do_bdinfo’ [-Wimplicit-function-declaration] 902 | do_bdinfo(NULL, 0, 0, NULL); | ^ Move the forward

Re: [PATCH 05/10] Convert CONFIG_FEC_MXC to Kconfig

2021-11-05 Thread Tom Rini
On Sat, Oct 30, 2021 at 11:03:52PM -0400, Tom Rini wrote: > This converts the following to Kconfig: > CONFIG_FEC_MXC > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 04/10] Convert CONFIG_SUPPORT_EMMC_BOOT to Kconfig

2021-11-05 Thread Tom Rini
On Sat, Oct 30, 2021 at 11:03:51PM -0400, Tom Rini wrote: > This converts the following to Kconfig: > CONFIG_SUPPORT_EMMC_BOOT > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 07/10] Convert CONFIG_OF_EMBED to Kconfig

2021-11-05 Thread Tom Rini
On Sat, Oct 30, 2021 at 11:03:54PM -0400, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_OF_EMBED > > Signed-off-by: Tom Rini > Reviewed-by: Rick Chen Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 08/10] Convert CONFIG_BMP_16BPP to Kconfig

2021-11-05 Thread Tom Rini
On Sat, Oct 30, 2021 at 11:03:55PM -0400, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_BMP_16BPP > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 06/10] Convert CONFIG_MCFUART to Kconfig

2021-11-05 Thread Tom Rini
On Sat, Oct 30, 2021 at 11:03:53PM -0400, Tom Rini wrote: > This converts the following to Kconfig: > CONFIG_MCFUART > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: Booting zImage with appended DTB without ATAGs support

2021-11-05 Thread Tom Rini
On Fri, Nov 05, 2021 at 04:47:31PM +0100, Pali Rohár wrote: > On Friday 05 November 2021 11:20:01 Tom Rini wrote: > > On Fri, Nov 05, 2021 at 04:16:46PM +0100, Pali Rohár wrote: > > > So now I have a question: Do we want to support booting zImage with > > > appended DTB in U-Boot when ATAGs

Re: [PATCH v2 04/12] sysinfo: Make sysinfo_get_str() behave like snprintf()

2021-11-05 Thread Simon Glass
Hi Marek, On Fri, 5 Nov 2021 at 05:19, Marek Behún wrote: > > On Thu, 4 Nov 2021 20:02:25 -0600 > Simon Glass wrote: > > > Hi Marek, > > > > On Wed, 3 Nov 2021 at 17:23, Marek Behún wrote: > > > > > > From: Marek Behún > > > > > > Currently sysinfo_get_str() returns 0 if a string is filled in

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-05 Thread Simon Glass
Hi, On Fri, 5 Nov 2021 at 08:21, Tom Rini wrote: > > On Fri, Nov 05, 2021 at 12:14:47PM +0100, Stefan Roese wrote: > > Hi Andre, > > > > Added Tom to Cc. > > > > On 05.11.21 11:04, Andre Przywara wrote: > > > On Thu, 4 Nov 2021 20:02:41 -0600 > > > Simon Glass wrote: > > > > > > Hi, > > > > > >

Re: [PATCH 1/6 v4] tpm2: Introduce TIS tpm core

2021-11-05 Thread Simon Glass
Hi Ilias, On Fri, 5 Nov 2021 at 01:02, Ilias Apalodimas wrote: > > Hi Simon, > > [...] > > > > > > +int tpm_tis_open(struct udevice *udev); > > > > Please add comments > > There are comments for all of those in drivers/tpm/tpm2_tis_core.c, > isn't that enough? So just move them to the header

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-05 Thread Andre Przywara
On Fri, 5 Nov 2021 10:12:11 -0600 Simon Glass wrote: Hi, > On Fri, 5 Nov 2021 at 08:21, Tom Rini wrote: > > > > On Fri, Nov 05, 2021 at 12:14:47PM +0100, Stefan Roese wrote: > > > Hi Andre, > > > > > > Added Tom to Cc. > > > > > > On 05.11.21 11:04, Andre Przywara wrote: > > > > On Thu, 4

Re: [PATCH 00/31] passage: Define a standard for firmware data flow

2021-11-05 Thread Simon Glass
) to signal Hi François, On Fri, 5 Nov 2021 at 10:31, François Ozog wrote: > > Hi Simon, > > Le ven. 5 nov. 2021 à 17:12, Simon Glass a écrit : >> >> Hi François, >> >> On Fri, 5 Nov 2021 at 02:27, François Ozog wrote: >> > >> > >> > >> > On Fri, 5 Nov 2021 at 03:02, Simon Glass wrote: >> >>

[PATCH 09/11] mmc: fsl_esdhc_imx: simplify esdhc_setup_data()

2021-11-05 Thread Sean Anderson
From: Michael Walle [ fsl_esdhc commit 7e48a028a42c111ba38a90b86e5f57dace980fa0 ] First, we need the waterlevel setting for PIO mode only. Secondy, both DMA setup code is identical for both directions, except for the data pointer. Thus, unify them. Signed-off-by: Michael Walle Signed-off-by:

[PATCH 11/11] mmc: fsl_esdhc_imx: set sysctl register for clock initialization

2021-11-05 Thread Sean Anderson
From: Yangbo Lu [ fsl_esdhc commit 263ddfc3454ead3a988adef39b962479adce2b28 ] The initial clock setting should be through sysctl register only, while the mmc_set_clock() will call mmc_set_ios() introduce other configurations like bus width, mode, and so on. Signed-off-by: Yangbo Lu

[PATCH 10/11] mmc: fsl_esdhc_imx: replace most #ifdefs by IS_ENABLED()

2021-11-05 Thread Sean Anderson
From: Michael Walle [ fsl_esdhc commit 52faec31827ec1a1837977e29c067424426634c5 ] Make the code cleaner and drop the old-style #ifdef constructs where it is possible. Signed-off-by: Michael Walle Signed-off-by: Sean Anderson --- drivers/mmc/fsl_esdhc_imx.c | 209

[PATCH 07/11] mmc: fsl_esdhc_imx: simplify 64bit check for SDMA transfers

2021-11-05 Thread Sean Anderson
From: Michael Walle [ fsl_esdhc commit da86e8cfcb03ed5c1d8e0718bc8bc8583e60ced8 ] SDMA can only do DMA with 32 bit addresses. This is true for all architectures (just doesn't apply to 32 bit ones). Simplify the code and remove unnecessary CONFIG_FSL_LAYERSCAPE. Also make the error message more

[PATCH 06/11] mmc: fsl_esdhc_imx: fix mmc->clock with actual clock

2021-11-05 Thread Sean Anderson
[ fsl_esdhc commit 30f6444d024a74ee48aa6969c1531aecd3c59deb ] Fix mmc->clock with actual clock which is divided by the controller, and record it with priv->clock. Signed-off-by: Yangbo Lu Signed-off-by: Sean Anderson --- drivers/mmc/fsl_esdhc_imx.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 04/11] mmc: fsl_esdhc_imx: clean up bus width configuration code

2021-11-05 Thread Sean Anderson
[ fsl_esdhc commit 07bae1de382723b94244096953b05225572728cd ] This patch is to clean up bus width setting code. - For DM_MMC, remove getting "bus-width" from device tree. This has been done in mmc_of_parse(). - For non-DM_MMC, move bus width configuration from fsl_esdhc_init() to

[PATCH 08/11] mmc: fsl_esdhc_imx: use dma-mapping API

2021-11-05 Thread Sean Anderson
From: Michael Walle [ fsl_esdhc commit b1ba1460a445bcc67972a617625d0349e4f22b31 ] Use the dma_{map,unmap}_single() calls. These will take care of the flushing and invalidation of caches. Signed-off-by: Michael Walle Signed-off-by: Sean Anderson --- drivers/mmc/fsl_esdhc_imx.c | 50

[PATCH 05/11] mmc: fsl_esdhc_imx: drop redundant code for non-removable feature

2021-11-05 Thread Sean Anderson
From: Yangbo Lu [ fsl_esdhc commit commit 08197cb8dff7cd097ab07a325093043c39d19bbd ] Drop redundant code for non-removable feature. "non-removable" property has been read in mmc_of_parse(). Signed-off-by: Yangbo Lu Signed-off-by: Sean Anderson --- drivers/mmc/fsl_esdhc_imx.c | 28

Re: [PATCH] sf: Querying write-protect status before operating the flash

2021-11-05 Thread Jagan Teki
On Fri, Nov 5, 2021 at 10:47 PM wrote: > > Hi, > > On 6/22/21 8:21 AM, chao zeng wrote: > > From: Chao Zeng > > > > When operating the write-protection flash,spi_flash_std_write() and > > spi_flash_std_erase() would return wrong result.The flash is protected, > > but write or erase the flash

[PATCH 3/6 v5] tpm: Use the new API on tpm2 spi driver

2021-11-05 Thread Ilias Apalodimas
Convert our SPI TPM driver and use the newly added API Reviewed-by: Simon Glass Signed-off-by: Ilias Apalodimas --- drivers/tpm/Makefile | 2 +- drivers/tpm/tpm2_tis_spi.c | 447 +++-- 2 files changed, 32 insertions(+), 417 deletions(-) diff --git

[PATCH 6/6 v5] MAINTAINERS: Add entry for TPM drivers

2021-11-05 Thread Ilias Apalodimas
TPM drivers have currently no maintainers. Add myself since I contributed the TIS implementation. Reviewed-by: Heinrich Schuchardt Reviewed-by: Simon Glass Signed-off-by: Ilias Apalodimas --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: "mmc: rockchip_sdhci: add phy and clock config for rk3399" broke spl emmc boot

2021-11-05 Thread Jack Mitchell
On 05/11/2021 19:03, Alistair Delva wrote: > Hi Yifeng, > > Since "mmc: rockchip_sdhci: add phy and clock config for rk3399", my > RockPi 4b device can't boot off of eMMC. It will start tpl/spl and > then fail: > > U-Boot TPL 2021.10-rc1-gac804143cf-dirty (Aug 11 2021 - 10:02:07) > Channel 0:

Re: [PATCH 00/31] passage: Define a standard for firmware data flow

2021-11-05 Thread François Ozog
Hi Simon, Le ven. 5 nov. 2021 à 17:12, Simon Glass a écrit : > Hi François, > > On Fri, 5 Nov 2021 at 02:27, François Ozog > wrote: > > > > > > > > On Fri, 5 Nov 2021 at 03:02, Simon Glass wrote: > >> > >> Hi François, > >> > >> On Tue, 2 Nov 2021 at 10:03, François Ozog > wrote: > >> > > >>

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-05 Thread Tom Rini
On Fri, Nov 05, 2021 at 07:37:02PM +0100, Heinrich Schuchardt wrote: > On 11/5/21 17:12, Simon Glass wrote: > > Hi, > > > > On Fri, 5 Nov 2021 at 08:21, Tom Rini wrote: > > > > > > On Fri, Nov 05, 2021 at 12:14:47PM +0100, Stefan Roese wrote: > > > > Hi Andre, > > > > > > > > Added Tom to Cc.

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-05 Thread Simon Glass
Hi Andre, On Fri, 5 Nov 2021 at 11:07, Andre Przywara wrote: > > On Fri, 5 Nov 2021 10:12:11 -0600 > Simon Glass wrote: > > Hi, > > > On Fri, 5 Nov 2021 at 08:21, Tom Rini wrote: > > > > > > On Fri, Nov 05, 2021 at 12:14:47PM +0100, Stefan Roese wrote: > > > > Hi Andre, > > > > > > > > Added

[PATCH] usb: Use the first available device for ehci_gadget

2021-11-05 Thread Sean Anderson
For whatever reason, usb_setup_ehci_gadget removes and probes USB device 0. However, not all systems have a device 0. Use the first device instead. The device probed should probably have something to do with the controller (as specified by e.g. ums or fastboot ). In fact, I find it odd that we

[PATCH 01/11] mmc: fsl_esdhc_imx: make BLK as hard requirement of DM_MMC

2021-11-05 Thread Sean Anderson
[ fsl_esdhc commit 41dec2fe99512e941261594f522b2e7d485c314b ] U-boot prefers DM_MMC + BLK for MMC. Now eSDHC driver has already support it, so let's force to use it. - Drop non-BLK support for DM_MMC introduced by below patch. 66fa035 mmc: fsl_esdhc: fix probe issue without CONFIG_BLK enabled

[PATCH 03/11] mmc: fsl_esdhc_imx: fix voltage validation

2021-11-05 Thread Sean Anderson
[ fsl_esdhc commit 5b05fc0310cd933acf76ee661577c6b07a95e684 ] Voltage validation should be done by CMD8. Current comparison between mmc_cfg voltages and host voltage capabilities is meaningless. So drop current comparison and let voltage validation is through CMD8. Signed-off-by: Yangbo Lu

[PATCH 02/11] mmc: fsl_esdhc_imx: remove redundant DM_MMC checking

2021-11-05 Thread Sean Anderson
[ fsl_esdhc commit 2913926f3b3dec282f8773e3c02377c9600d8267 ] Remove redundant DM_MMC checking which is already in DM_MMC conditional compile block. Signed-off-by: Yangbo Lu Signed-off-by: Sean Anderson --- drivers/mmc/fsl_esdhc_imx.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 00/11] fsl_esdhc_imx: port several patches from fsl_esdhc

2021-11-05 Thread Sean Anderson
This series ports some of the patches from fsl_esdhc to fsl_esdhc_imx. Because these drivers share a common lineage, many of these patches apply with minor changes. For each one, I have noted the originating commit in the style of linux stable backports. In fa33d20749 ("mmc: split fsl_esdhc

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-05 Thread Heinrich Schuchardt
On 11/5/21 17:12, Simon Glass wrote: Hi, On Fri, 5 Nov 2021 at 08:21, Tom Rini wrote: On Fri, Nov 05, 2021 at 12:14:47PM +0100, Stefan Roese wrote: Hi Andre, Added Tom to Cc. On 05.11.21 11:04, Andre Przywara wrote: On Thu, 4 Nov 2021 20:02:41 -0600 Simon Glass wrote: Hi, On Thu, 4

Re: [PATCH v2 06/12] sysinfo: Add get_str_list() method

2021-11-05 Thread Simon Glass
Hi Marek, On Fri, 5 Nov 2021 at 05:20, Marek Behún wrote: > > On Thu, 4 Nov 2021 20:02:27 -0600 > Simon Glass wrote: > > > On Wed, 3 Nov 2021 at 17:23, Marek Behún wrote: > > > > > > From: Marek Behún > > > > > > Add get_str_list() method to sysinfo operations. > > > > > > The get_str_list()

Re: [PATCH v5 04/11] doc: update UEFI document for usage of mkeficapsule

2021-11-05 Thread Simon Glass
Hi Takahiro, On Thu, 4 Nov 2021 at 21:15, AKASHI Takahiro wrote: > > On Thu, Nov 04, 2021 at 09:11:51AM -0600, Simon Glass wrote: > > Hi Takahiro, > > > > On Wed, 3 Nov 2021 at 19:49, AKASHI Takahiro > > wrote: > > > > > > On Tue, Nov 02, 2021 at 08:57:48AM -0600, Simon Glass wrote: > > > > Hi

Re: [PATCH 00/31] passage: Define a standard for firmware data flow

2021-11-05 Thread Simon Glass
Hi François, On Fri, 5 Nov 2021 at 02:27, François Ozog wrote: > > > > On Fri, 5 Nov 2021 at 03:02, Simon Glass wrote: >> >> Hi François, >> >> On Tue, 2 Nov 2021 at 10:03, François Ozog wrote: >> > >> > Hi Simon, >> > >> > On Tue, 2 Nov 2021 at 15:59, Simon Glass wrote: >> >> >> >> Hi

Re: [PATCH v2 08/12] sysinfo: Add support for iterating string list

2021-11-05 Thread Simon Glass
Hi Marek, On Fri, 5 Nov 2021 at 05:24, Marek Behún wrote: > > On Thu, 4 Nov 2021 20:02:29 -0600 > Simon Glass wrote: > > > Better to make iter a struct sysinfo_str_list_iter, I think and > > require the caller to declare it: > > > > sysinfo_str_list_iter iter; > > char str[80]' > > > > p =

Re: [PATCH 2/6 v4] tpm2: Add a TPMv2 MMIO TIS driver

2021-11-05 Thread Simon Glass
Hi Ilias, On Fri, 5 Nov 2021 at 02:23, Ilias Apalodimas wrote: > > On Fri, Nov 05, 2021 at 10:17:21AM +0200, Ilias Apalodimas wrote: > > Hi Simon, > > > > [...] > > > > > > + u8 *result) > > > > +{ > > > > + struct tpm_tis_chip_data *drv_data = (void > > > >

[PATCH 1/1] watchdog: don't autostart watchdog on Sunxi boards

2021-11-05 Thread Heinrich Schuchardt
The Sunxi boards only support a 16 second watchdog timeout. This is too short to boot Linux. The UEFI specification requires 300 seconds as default timeout. Change the default for CONFIG_WATCHDOG_AUTOSTART for ARCH_SUNXI. Fixes: b147bd3607f8 ("sunxi: Enable watchdog timer support by default")

[PATCH 1/6 v5] tpm2: Introduce TIS tpm core

2021-11-05 Thread Ilias Apalodimas
There's a lot of code duplication in U-Boot right now. All the TPM TIS compatible drivers we have at the moment have their own copy of a TIS implementation. So let's create a common layer which implements the core TIS functions. Any driver added from now own, which is compatible with the TIS

[PATCH 2/6 v5] tpm2: Add a TPMv2 MMIO TIS driver

2021-11-05 Thread Ilias Apalodimas
Add support for devices that expose a TPMv2 though MMIO. Apart from those devices, we can use the driver in our QEMU setups and test TPM related code which is difficult to achieve using the sandbox driver (e.g test the EFI TCG2 protocol). It's worth noting that a previous patch added TPMv2 TIS

[PATCH 0/6 v5] TPM cleanups and MMIO driver

2021-11-05 Thread Ilias Apalodimas
Hi! This is the update for [1]. Changes since v4: - renamed struct udevice *udev -> struct udevice *dev - added comments on struct tpm_tis_phy_ops - removed duplicate defines from tpm2_tis_spi driver (now in tpm_tis.h) - moved API function description for the .c to the .h file - added

[PATCH 5/6 v5] doc: qemu: Add instructions for swtpm usage

2021-11-05 Thread Ilias Apalodimas
A previous patch added support for an mmio based TPM. Add an example in QEMU on it's usage Reviewed-by: Simon Glass Signed-off-by: Ilias Apalodimas --- doc/board/emulation/qemu-arm.rst | 25 + 1 file changed, 25 insertions(+) diff --git

[PATCH 4/6 v5] configs: Enable tpmv2 mmio on qemu for arm/arm64

2021-11-05 Thread Ilias Apalodimas
A previous commit is adding an MMIO TPMv2 driver. Include in the default qemu arm configs, since we plan on using them on EFI testing Reviewed-by: Simon Glass Signed-off-by: Ilias Apalodimas --- configs/qemu_arm64_defconfig | 2 ++ configs/qemu_arm_defconfig | 2 ++ 2 files changed, 4

  1   2   >