[PATCH v2] introduce CONFIG_DEVICE_TREE_INCLUDES

2021-11-21 Thread Rasmus Villemoes
The build system already automatically looks for and includes an in-tree *-u-boot.dtsi when building the control .dtb. However, there are some things that are awkward to maintain in such an in-tree file, most notably the metadata associated to public keys used for verified boot. The only

link error while u-boot-spl build : undefined ref to `printf` or `strcmp` etc.

2021-11-21 Thread Chan Kim
Hello, When I build u-boot, I get this error at the end. (during u-boot-spl build). I've been fixing some link errors by adding config values but I can't figure out what is wrong with this. Below is the final command for u-boot-spl build and the error messages. Can any expert tell me what can

Re: link error while u-boot-spl build : undefined ref to `printf` or `strcmp` etc.

2021-11-21 Thread Ovidiu Panait
Hi Chan, On 11/21/21 1:45 PM, Chan Kim wrote: [Please note: This e-mail is from an EXTERNAL e-mail address] Hello, When I build u-boot, I get this error at the end. (during u-boot-spl build). I've been fixing some link errors by adding config values but I can't figure out what is wrong with

two questions on verified boot

2021-11-21 Thread Rasmus Villemoes
(1) When one wants to get rid of CONFIG_LEGACY_IMAGE_FORMAT, one also has to wrap any boot script in a FIT rather than a uImage. While it's not directly documented anywhere how to do that, it seems that a minimal .its for achieving it is /dts-v1/; / { description = "U-Boot script(s)";

[PATCH v4 1/2] GPIO: fxl6408: Add support for FXL6408 GPIO expander

2021-11-21 Thread Oleksandr Suvorov
From: Oleksandr Suvorov Initial support for Fairchild's 8 bit I2C gpio expander FXL6408. The CONFIG_FXL6408_GPIO define enables support for such devices. Based on: https://patchwork.kernel.org/patch/9148419/ Signed-off-by: Oleksandr Suvorov Reviewed-by: Simon Glass Tested-by: Marcel Ziswiler

[PATCH v4 0/2] Add support of the FXL6408 GPIO expander

2021-11-21 Thread Oleksandr Suvorov
Add support of the Fairchild's FXL6408 i2c gpio expander and enable this driver for Toradex Colibri iMX8QXP SoM. Changes in v4: - fix misuse of MF_ID_x instead of FW_REV_x in fxl6408_probe(). - fix kernel doc formatting. - sort headers. - fix hex numbers style. - explicitly claim values of enum

Re: two questions on verified boot

2021-11-21 Thread Dhananjay Phadke
On 11/21/2021 6:55 AM, Rasmus Villemoes wrote: > (2) Assuming for the moment that I would be happy with just using > required=image, am I right in that not only does that mean that the > combination of kernel/fdt/initramfs is not verified, merely the > individual parts, but more importantly (a

Re: [PATCH] net: zynq: Add support for PHY configuration in SGMII mode

2021-11-21 Thread Ramon Fried
On Fri, Nov 19, 2021 at 7:01 PM Sean Anderson wrote: > > > > On 11/18/21 7:09 AM, Michal Simek wrote:> SGMII configuration depends on > proper GT setting that's why when node has > > phys property call PSGTR driver to configure it properly. > > > > Signed-off-by: Michal Simek > > --- > > > >

Re: [PATCH 2/2] clk: define LOG_CATEGORY for generic and ccf clocks

2021-11-21 Thread Sean Anderson
On 11/19/21 9:12 AM, Patrick Delaunay wrote: Define LOG_CATEGORY to allow filtering with log command for generic clock and CCF clocks. This patch also change existing printf, debug and pr_ macro to log_ or dev_ macro. Signed-off-by: Patrick Delaunay --- drivers/clk/clk-composite.c| 3

Re: [PATCH v2 13/14] net: mediatek: add support for MediaTek MT7621 SoC

2021-11-21 Thread Ramon Fried
On Fri, Nov 19, 2021 at 3:37 AM Weijie Gao wrote: > > This patch adds GMAC support for MediaTek MT7621 SoC. > MT7621 has the same GMAC/Switch configuration as MT7623. > > Signed-off-by: Weijie Gao > --- > v2 changes: none > --- > drivers/net/mtk_eth.c | 27 +-- >

Re: [PATCH 1/2] clk: cosmetic: reorder include files

2021-11-21 Thread Sean Anderson
On 11/19/21 9:12 AM, Patrick Delaunay wrote: Reorder include files in the U-Boot expected order: the common.h header should always be first, followed by other headers in order, then headers with directories, then local files. It is a preliminary step for next patch. Signed-off-by: Patrick

[PATCH 1/2] rpi: Update the Raspberry Pi doucmentation URL

2021-11-21 Thread Peter Robinson
The Raspberry Pi Foundation has updated their documentation so update the URL to the latest place to find the HW device revision codes. Signed-off-by: Peter Robinson --- board/raspberrypi/rpi/rpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/raspberrypi/rpi/rpi.c

[PATCH 2/2] rpi: Add identifier for the new RPi Zero 2 W

2021-11-21 Thread Peter Robinson
The Raspberry Pi Foundation released the new Zero 2 W which we want to detect, so we can detect the correct device tree file name. Signed-off-by: Peter Robinson --- board/raspberrypi/rpi/rpi.c | 5 + 1 file changed, 5 insertions(+) diff --git a/board/raspberrypi/rpi/rpi.c

Re: [PATCH] net: zynq: Add support for PHY configuration in SGMII mode

2021-11-21 Thread Sean Anderson
On 11/21/21 2:16 PM, Ramon Fried wrote: On Fri, Nov 19, 2021 at 7:01 PM Sean Anderson wrote: On 11/18/21 7:09 AM, Michal Simek wrote:> SGMII configuration depends on proper GT setting that's why when node has phys property call PSGTR driver to configure it properly. Signed-off-by: Michal

[PATCH v4 2/2] colibri-imx8x: add on-module gpio expander fxl6408

2021-11-21 Thread Oleksandr Suvorov
From: Oleksandr Suvorov The FXL6408 GPIO expander manages critical devices, including on-module USB hub. Configure the expander to switch the USB hub into bypass mode, allowing to use on-carrier-board USB hub. Signed-off-by: Oleksandr Suvorov Signed-off-by: Oleksandr Suvorov --- Changes in

Re: [PATCH] net: zynq: Add support for GEM reset

2021-11-21 Thread Ramon Fried
On Thu, Nov 18, 2021 at 2:08 PM Michal Simek wrote: > > Perform reset before core initialization. Does it fix any apparent issue ? How did it work before that ? > > Signed-off-by: Michal Simek > --- > > drivers/net/zynq_gem.c | 26 ++ > 1 file changed, 26 insertions(+) >

Re: [PATCH] net: zynq: Add support for mdio bus address decoding

2021-11-21 Thread Ramon Fried
On Thu, Nov 18, 2021 at 2:06 PM Michal Simek wrote: > > There are flying two configurations around. Can you rephrase ? I don't understand. > The first (already supported) has phy as subnode of gem node. > The second has mdio subnode (with mdio name) which has phy subnode. > > This patch adds

Re: [PATCH] net: gem: Reduce timeout of mdio phy idle status check

2021-11-21 Thread Ramon Fried
On Thu, Nov 18, 2021 at 2:05 PM Michal Simek wrote: > > From: Ashok Reddy Soma > > Timeout for checking mdio phy idle status is 20seconds. In case of errors > this timeout will be too much. Reduce it to 100ms. > > Signed-off-by: Ashok Reddy Soma > Signed-off-by: Michal Simek > --- > >

[PATCH 0/6] Add a pylint check

2021-11-21 Thread Simon Glass
U-Boot has about 60k lines of Python code. This is quite small relative to the total code size, but it is still important to keep the code style consistent. This series allows pylint to be run on Python files within U-Boot to detect any changes that reduce the current pylint ‘score’ of any

Re: [Uboot-stm32] [PATCH 4/7] video: Add video_is_active function

2021-11-21 Thread Patrice CHOTARD
Hi Patrick On 11/15/21 4:32 PM, Patrick Delaunay wrote: > Add the helper function video_is_active() to test if one video device > is active. > > This function can be used in board code to execute operation > only when the display is probed / really used. > > Signed-off-by: Patrick Delaunay >

Re: [Uboot-stm32] [PATCH 2/7] common: rename lcd_simplefb.c file to fdt_simplefb.c

2021-11-21 Thread Patrice CHOTARD
Hi Patrick On 11/15/21 4:32 PM, Patrick Delaunay wrote: > Rename the file lcd_simplefb.c to fdt_simplefb.c to be aligned > with the configuration name and with the associated include file > ./include/fdt_simplefb.h > > Signed-off-by: Patrick Delaunay > --- > > common/Makefile

Re: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults

2021-11-21 Thread Peng Fan (OSS)
+ Rob On 2021/11/20 20:57, Tom Rini wrote: On Sat, Nov 20, 2021 at 12:10:54PM +, Peng Fan (OSS) wrote: Subject: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults From: Peng Fan Current code has a force clk_set_defaults in multiple stages, U-Boot reuse the same device tree and Linux

Re: [PATCH] configs: stm32mp15: deactivate the CONFIG_STM32_IPCC

2021-11-21 Thread Patrice CHOTARD
HI Patrick On 11/19/21 10:07 AM, Patrick Delaunay wrote: > The IPCC mailbox is only used for communication with M4 firmware but > it is not used in the stm32 remoteproc driver; it was planed but the > support of this mailbox in remoteproc for STM32MP15x is dropped. > > So the associated drivers

Re: [PATCH 7/7] board: stm32mp1: enable simple framebuffer node for splashscreen

2021-11-21 Thread Patrice CHOTARD
Hi Patrick On 11/15/21 4:32 PM, Patrick Delaunay wrote: > Enable an existing simple framebuffer node in the Linux kernel device > tree and the add the associated reserved memory node to preserved the > resources (clock, memory) used by the stm32 video driver to display > the splashscreen =

Re: [PATCH 2/3] stm32mp1: ram: remove the support of calibration result

2021-11-21 Thread Patrice CHOTARD
Hi Patrick On 11/15/21 3:32 PM, Patrick Delaunay wrote: > The support of a predefined DDR PHY tuning result is removed for > STM32MP1 driver because it is not needed at the supported frequency > when built-in calibration is executed. > > The calibration parameters were provided in the device

Re: [PATCH v3 1/2] nvme: Enable FUA

2021-11-21 Thread Jon Lin
On 2021/11/19 9:14, Tom Rini wrote: On Fri, Nov 19, 2021 at 08:56:08AM +0800, Bin Meng wrote: Hi Tom, On Fri, Nov 19, 2021 at 3:14 AM Tom Rini wrote: On Tue, Oct 19, 2021 at 10:40:53AM +0800, Jon Lin wrote: Most NVME devcies maintain data in internal cache for an uncertain times, and

Re: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults

2021-11-21 Thread Peng Fan (OSS)
On 2021/11/20 23:06, Sean Anderson wrote: On 11/20/21 7:57 AM, Tom Rini wrote: On Sat, Nov 20, 2021 at 12:10:54PM +, Peng Fan (OSS) wrote: Subject: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults From: Peng Fan Current code has a force clk_set_defaults in multiple stages, U-Boot

Re: [Uboot-stm32] [PATCH 5/7] common: add fdt_simplefb_enable_and_mem_rsv function

2021-11-21 Thread Patrice CHOTARD
Hi Patrick On 11/15/21 4:32 PM, Patrick Delaunay wrote: > Add a new function to activate an existing simple frame buffer node > and add the associated reserved memory, with no-map properties. > > This device tree update is only done when the video device is active > and the video buffer is used.

Re: [PATCH] net: zynq: Add support for GEM reset

2021-11-21 Thread Michal Simek
On 11/21/21 20:12, Ramon Fried wrote: On Thu, Nov 18, 2021 at 2:08 PM Michal Simek wrote: Perform reset before core initialization. Does it fix any apparent issue ? How did it work before that ? Standard flow which I would say close to 99% users are using getting all IPs out of reset

Re: [PATCH 6/7] video: stm32: stm32_ltdc: align framebuffer on 2MB

2021-11-21 Thread Patrice CHOTARD
Hi Patrick On 11/15/21 4:32 PM, Patrick Delaunay wrote: > Align the framebuffer size on MMU_SECTION_SIZE in kernel, = max 2MB for > LPAE for armV7, to avoid issue with the simple frame buffer activation, > when U-Boot add a reserved memory in the kernel device tree to preserve > the splash screen

Re: [PATCH 1/3] stm32mp1: ram: add read valid training support

2021-11-21 Thread Patrice CHOTARD
Hi Patrick On 11/15/21 3:32 PM, Patrick Delaunay wrote: > Add the read data eye training = training for optimal read valid placement > (RVTRN) when the built-in calibration is executed for LPDDR2 and LPDDR3. > > This training is supported on the PUBL integrated in the STM32MP15x > DDR subsystem

Re: [PATCH 2/2] ARM: dts: stm32: Auto-detect DHSOM with uSD level translator

2021-11-21 Thread Patrice CHOTARD
Hi Marek On 11/13/21 3:29 AM, Marek Vasut wrote: > The uSD level translator on DHSOM and Avenger96 are optional, however it > is possible to auto-detect it. This is done by setting SD CMD line high, > and then testing whether signal level on CK line matches the signal level > on CKIN line. If so,

Re: [PATCH 1/4] arm: stm32mp: bsec: Update OTP shadow registers in SPL

2021-11-21 Thread Patrice CHOTARD
Hi Patrick On 10/11/21 9:52 AM, Patrick Delaunay wrote: > Currently the upper OTP (after 57) are shadowed in U-Boot proper, > when TFABOOT is not used. > > This choice cause an issue when U-Boot is not executed after SPL, > so this BSEC initialization is moved in SPL and no more executed in

RE: link error while u-boot-spl build : undefined ref to `printf` or `strcmp` etc.

2021-11-21 Thread Chan Kim
Hi Ovidiu, Thank you so much, with those two configs added, u-boot-spl was finally built ok (The remaining 3 or 4 link errors are all gone together) Thank you, Best regards, Chan Kim > -Original Message- > From: Ovidiu Panait > Sent: Monday, November 22, 2021 12:30 AM > To: Chan Kim ;

[PATCH 5/6] Makefile: Add a pylint checker to the build

2021-11-21 Thread Simon Glass
At present the Python code in U-Boot is somewhat inconsistent, with some files passing pylint quite cleanly and others not. Add a way to track progress on this clean-up, by checking that no module has got any worse as a result of changes. This can be used with 'make pylint'. Signed-off-by:

Re: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults

2021-11-21 Thread Simon Glass
Hi Peng, On Sun, 21 Nov 2021 at 20:33, Peng Fan (OSS) wrote: > > + Rob > > On 2021/11/20 20:57, Tom Rini wrote: > > On Sat, Nov 20, 2021 at 12:10:54PM +, Peng Fan (OSS) wrote: > >>> Subject: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults > >>> > >>> From: Peng Fan > >>> > >>> Current

[PATCH 2/6] dtoc: Fix up a code comment that confuses pylint

2021-11-21 Thread Simon Glass
This produces a pylint error at present. Fix it. Signed-off-by: Simon Glass --- tools/dtoc/dtb_platdata.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/dtoc/dtb_platdata.py b/tools/dtoc/dtb_platdata.py index 3bb5c680f2e..a69a7889ce1 100644 ---

[PATCH 6/6] Azure/GitLab CI: Add the pylint checker

2021-11-21 Thread Simon Glass
Add a check that new Python code does not regress the pylint score for any module. Signed-off-by: Simon Glass --- .azure-pipelines.yml | 17 + .gitlab-ci.yml | 12 2 files changed, 29 insertions(+) diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml

[PATCH 3/6] patman: Update the list of modules

2021-11-21 Thread Simon Glass
Update the __init__ file to include recently added files. Add a license header while we are here. Signed-off-by: Simon Glass --- tools/patman/__init__.py | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tools/patman/__init__.py b/tools/patman/__init__.py index

[PATCH 4/6] tools: Add init files for Python tools

2021-11-21 Thread Simon Glass
Add some empty __init__ files for binman, buildman and dtoc so that pylint is able to recognise these as Python modules and produce more useful pylint output. Signed-off-by: Simon Glass --- tools/binman/__init__.py | 0 tools/buildman/__init__.py | 0 tools/dtoc/__init__.py | 0 3 files

[PATCH 1/6] .gitignore: Ignore any html coverage directory

2021-11-21 Thread Simon Glass
This is created when checking code coverage of Python tools. Ignore it. Signed-off-by: Simon Glass --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index e66aa864da6..35034de6556 100644 --- a/.gitignore +++ b/.gitignore @@ -95,3 +95,6 @@ GTAGS #

RE: [EXT] RE: [PATCH v5 01/16] crypto/fsl: Add support for CAAM Job ring driver model

2021-11-21 Thread Gaurav Jain
Hello Andrey > -Original Message- > From: ZHIZHIKIN Andrey > Sent: Wednesday, November 17, 2021 6:33 PM > To: Gaurav Jain ; u-boot@lists.denx.de > Cc: Stefano Babic ; Fabio Estevam ; > Peng Fan ; Simon Glass ; Priyanka > Jain ; Ye Li ; Horia Geanta > ; Ji Luo ; Franck Lenormand > ;

Re: [PATCH 6/6] Azure/GitLab CI: Add the pylint checker

2021-11-21 Thread Heinrich Schuchardt
On 11/22/21 04:48, Simon Glass wrote: Add a check that new Python code does not regress the pylint score for any module. How will ./scripts/pylint.base be updated? Some or the worst scores are for binman. Any plans to address these? Best regards Heinrich

Re: [PATCH] net: zynq: Add support for mdio bus address decoding

2021-11-21 Thread Michal Simek
On 11/21/21 20:11, Ramon Fried wrote: On Thu, Nov 18, 2021 at 2:06 PM Michal Simek wrote: There are flying two configurations around. Can you rephrase ? I don't understand. The first configuration is eth { phy-handle = <>; phy0: ethernet-phy@21 { ...

Re: [PATCH 3/3] stm32mp1: ram: remove tuning support

2021-11-21 Thread Patrice CHOTARD
Hi Patrick On 11/15/21 3:32 PM, Patrick Delaunay wrote: > Remove the DDR interactive command tuning, as the support of a predefined > DDR PHY tuning is removed for STM32MP1 driver in SPL and in TF-A > and the result of this tuning will be never used. > > Moreover this SW tuning procedure can

Re: [PATCH 2/6] dtoc: Fix up a code comment that confuses pylint

2021-11-21 Thread Heinrich Schuchardt
On 11/22/21 04:48, Simon Glass wrote: This produces a pylint error at present. Fix it. Signed-off-by: Simon Glass --- tools/dtoc/dtb_platdata.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/dtoc/dtb_platdata.py b/tools/dtoc/dtb_platdata.py index