[PATCH 1/1] efi_loader: correct function comment style

2022-01-20 Thread Heinrich Schuchardt
Replace @return and @param. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_file.c | 2 +- lib/efi_loader/efi_freestanding.c | 8 lib/efi_loader/efi_gop.c | 2 +- lib/efi_loader/helloworld.c

Re: [PATCH v3 31/31] RFC: Switch rpi over to use bootstd

2022-01-20 Thread Simon Glass
Hi Mark, On Thu, 20 Jan 2022 at 11:56, Mark Kettenis wrote: > > > Date: Thu, 20 Jan 2022 13:30:47 -0500 > > From: Tom Rini > > > > On Thu, Jan 20, 2022 at 11:16:35AM -0700, Simon Glass wrote: > > > Hi Mark, > > > > > > On Thu, 20 Jan 2022 at 03:29, Mark Kettenis > > > wrote: > > > > > > > > >

Re: [PATCH v3 31/31] RFC: Switch rpi over to use bootstd

2022-01-20 Thread Simon Glass
Hi Tom, On Thu, 20 Jan 2022 at 11:30, Tom Rini wrote: > > On Thu, Jan 20, 2022 at 11:16:35AM -0700, Simon Glass wrote: > > Hi Mark, > > > > On Thu, 20 Jan 2022 at 03:29, Mark Kettenis wrote: > > > > > > > From: Michael Walle > > > > Date: Thu, 20 Jan 2022 09:35:44 +0100 > > > > > > > > > The

Re: [PATCH v3 31/31] RFC: Switch rpi over to use bootstd

2022-01-20 Thread Tom Rini
On Thu, Jan 20, 2022 at 11:16:35AM -0700, Simon Glass wrote: > Hi Mark, > > On Thu, 20 Jan 2022 at 03:29, Mark Kettenis wrote: > > > > > From: Michael Walle > > > Date: Thu, 20 Jan 2022 09:35:44 +0100 > > > > > > > The bootdevs have a natural priority, based on the assumed speed of > > > > the

Re: [PATCH 00/11] Add support for SUNIV and F1C100s.

2022-01-20 Thread Jesse Taube
On 1/20/22 13:12, Chris Morgan wrote: On Sat, Jan 15, 2022 at 04:02:05PM -0500, Jesse Taube wrote: On 1/10/22 00:13, Tnze Jdao wrote: I tested this patch and tried to run it on my LicheePi Nano. It works, but I found there is WARNINGs when compile the code: ---

Re: [PATCH v3 31/31] RFC: Switch rpi over to use bootstd

2022-01-20 Thread Simon Glass
Hi Mark, On Thu, 20 Jan 2022 at 03:29, Mark Kettenis wrote: > > > From: Michael Walle > > Date: Thu, 20 Jan 2022 09:35:44 +0100 > > > > > The bootdevs have a natural priority, based on the assumed speed of > > > the device, so the board would only need to intervene (with an env var > > > or a

Re: [PATCH v3 00/31] Initial implementation of standard boot

2022-01-20 Thread Simon Glass
Hi Michael, On Thu, 20 Jan 2022 at 01:38, Michael Walle wrote: > > Hi, > > Am 2022-01-19 15:56, schrieb Simon Glass: > > On Wed, 19 Jan 2022 at 01:09, Michael Walle wrote: > >> > >> > >> > The bootflow feature provide a built-in way for U-Boot to automatically > >> > boot an Operating System

Re: [PATCH 00/11] Add support for SUNIV and F1C100s.

2022-01-20 Thread Chris Morgan
On Sat, Jan 15, 2022 at 04:02:05PM -0500, Jesse Taube wrote: > > > On 1/10/22 00:13, Tnze Jdao wrote: > > I tested this patch and tried to run it on my LicheePi Nano. It works, but > > I found there is WARNINGs when compile the code: > > --- > > include/configs/sunxi-common.h:128:0:

Re: [PATCH v3 31/31] RFC: Switch rpi over to use bootstd

2022-01-20 Thread Tom Rini
On Thu, Jan 20, 2022 at 12:56:55PM -0700, Simon Glass wrote: > Hi Tom, > > On Thu, 20 Jan 2022 at 11:30, Tom Rini wrote: > > > > On Thu, Jan 20, 2022 at 11:16:35AM -0700, Simon Glass wrote: > > > Hi Mark, > > > > > > On Thu, 20 Jan 2022 at 03:29, Mark Kettenis > > > wrote: > > > > > > > > >

Re: [PATCH v3 31/31] RFC: Switch rpi over to use bootstd

2022-01-20 Thread Simon Glass
Hi Tom, On Thu, 20 Jan 2022 at 13:08, Tom Rini wrote: > > On Thu, Jan 20, 2022 at 12:56:55PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Thu, 20 Jan 2022 at 11:30, Tom Rini wrote: > > > > > > On Thu, Jan 20, 2022 at 11:16:35AM -0700, Simon Glass wrote: > > > > Hi Mark, > > > > > > > > On

Re: Please pull u-boot-marvell/master

2022-01-20 Thread Tom Rini
On Thu, Jan 20, 2022 at 05:31:09PM +0100, Stefan Roese wrote: > Hi Tom, > > please pull the next batch of mostly Marvell MVEBU related patches: > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

[PATCH v2] xilinx: common: change bootm_size to not go beyond ram_top

2022-01-20 Thread Ricardo Salveti
The available ram can be limited by ram_top as that depends on the reserved memory nodes provided by the device-tree (via board_get_usable_ram_top), so make sure to respect ram_top when setting up bootm_size to avoid overlapping reserved memory regions (e.g. memory used by OP-TEE). The same logic

Re: [PATCH v3] drivers: spi-nor: Add JEDEC id for W25Q16JV

2022-01-20 Thread Dhananjay Phadke
On 1/20/2022 7:46 AM, tudor.amba...@microchip.com wrote: FWIW, "w25q15jvm" would be the "correct" name in linux. Although for this particular flash the name in linux is "w25q16jv-im/jm".. would you fix it? :D Anyhow, see [1] for a lengthy discussion on that name. That being said, I still

Re: [PATCH v3 31/31] RFC: Switch rpi over to use bootstd

2022-01-20 Thread Mark Kettenis
> Date: Thu, 20 Jan 2022 13:30:47 -0500 > From: Tom Rini > > On Thu, Jan 20, 2022 at 11:16:35AM -0700, Simon Glass wrote: > > Hi Mark, > > > > On Thu, 20 Jan 2022 at 03:29, Mark Kettenis wrote: > > > > > > > From: Michael Walle > > > > Date: Thu, 20 Jan 2022 09:35:44 +0100 > > > > > > > > >

Re: [PATCH v9 04/11] tools: mkeficapsule: add firmware image signing

2022-01-20 Thread Heinrich Schuchardt
On 1/18/22 05:39, AKASHI Takahiro wrote: With this enhancement, mkeficapsule will be able to sign a capsule file when it is created. A signature added will be used later in the verification at FMP's SetImage() call. To do that, we need specify additional command parameters: -monotonic-cout

Re: [RESEND PATCH v3 4/4] arm: kirkwood: Pogoplug V4 : Add board include header and defconfig files

2022-01-20 Thread Tony Dinh
Hi Stefan, On Thu, Jan 20, 2022 at 3:55 AM Stefan Roese wrote: > > Hi Tony, > > On 1/20/22 01:28, Tony Dinh wrote: > > Add board include header and defconfig files for Pogoplug V4 > > > > Signed-off-by: Tony Dinh > > --- > > > > Changes in v3: > > - Migrate config symbols from board include

Re: [PATCH v3 31/31] RFC: Switch rpi over to use bootstd

2022-01-20 Thread Tom Rini
On Thu, Jan 20, 2022 at 01:47:41PM -0700, Simon Glass wrote: > Hi Tom, > > On Thu, 20 Jan 2022 at 13:08, Tom Rini wrote: > > > > On Thu, Jan 20, 2022 at 12:56:55PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Thu, 20 Jan 2022 at 11:30, Tom Rini wrote: > > > > > > > > On Thu, Jan 20,

Re: [PATCH v2 00/38] binman: Add support for bintools and missing tools

2022-01-20 Thread Simon Glass
Hi custodians, On Sun, 9 Jan 2022 at 20:14, Simon Glass wrote: > > > At present binman uses binary tools (like cbfstool, futiltiy, lz4) in an > ad-hoc manner. Various parts of binman use tools.Run() to run tools as > needed. If a tool is missing, an error is produced and binman stops. > >

Re: [PATCH 2/8] net: ti: am65-cpsw: Add support for multi port independent MAC mode

2022-01-20 Thread Tom Rini
On Fri, Jan 21, 2022 at 01:13:54AM +0200, Ramon Fried wrote: > On Mon, Jan 17, 2022 at 8:37 PM Tom Rini wrote: > > > > On Fri, Dec 24, 2021 at 12:55:30PM +0530, Vignesh Raghavendra wrote: > > > > > On certain TI SoC, like AM64x there is a CPSW3G which supports 2 > > > external independent MAC

Re: [PATCH v3 31/31] RFC: Switch rpi over to use bootstd

2022-01-20 Thread Simon Glass
Hi Tom, On Thu, 20 Jan 2022 at 18:08, Tom Rini wrote: > > On Thu, Jan 20, 2022 at 05:59:53PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Thu, 20 Jan 2022 at 16:23, Tom Rini wrote: > > > > > > On Thu, Jan 20, 2022 at 01:47:41PM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On

Re: [PATCH 2/8] net: ti: am65-cpsw: Add support for multi port independent MAC mode

2022-01-20 Thread Vignesh Raghavendra
On 30/12/21 1:01 am, Ramon Fried wrote: > On Fri, Dec 24, 2021 at 9:25 AM Vignesh Raghavendra wrote: >> >> On certain TI SoC, like AM64x there is a CPSW3G which supports 2 >> external independent MAC ports for single CPSW instance. >> It is not possible for Ethernet driver to register more

Re: [RFC PATCH 10/14] FWU: Reboot soon after successfully install the new firmware

2022-01-20 Thread Masami Hiramatsu
Hi Takahiro, 2022年1月21日(金) 10:46 AKASHI Takahiro : > > On Fri, Jan 21, 2022 at 12:31:00AM +0900, Masami Hiramatsu wrote: > > Reboot to the trial state soon after successfully installing > > the new firmware to the next bank and updating the active_index. > > This is enabled by

Re: [PATCH v3 31/31] RFC: Switch rpi over to use bootstd

2022-01-20 Thread Tom Rini
On Thu, Jan 20, 2022 at 05:59:53PM -0700, Simon Glass wrote: > Hi Tom, > > On Thu, 20 Jan 2022 at 16:23, Tom Rini wrote: > > > > On Thu, Jan 20, 2022 at 01:47:41PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Thu, 20 Jan 2022 at 13:08, Tom Rini wrote: > > > > > > > > On Thu, Jan 20,

[PATCH v4 0/4] arm: kirkwood: Add support for Pogoplug V4

2022-01-20 Thread Tony Dinh
Pogoplug V4 specifications: Kirkwood 88F6192 SoC 800 MHz CPU 1Gbs Ethernet 128 MB RAM 128 MB NAND 1x USB 2.0 2x USB 3.0 (on PCIe bus) 1 SDHC slot 1x External SATA port (USM enclosure form factor slot) Changes in v4: - Remove CONFIG_FEATURE_COMMAND_EDITING and ifdefs for CMD_NET in include

Re: [RFC PATCH 12/14] FWU: synquacer: Add FWU Multi bank update support for DeveloperBox

2022-01-20 Thread AKASHI Takahiro
On Fri, Jan 21, 2022 at 12:31:20AM +0900, Masami Hiramatsu wrote: > The DeveloperBox platform can support the FWU Multi bank > update. SCP firmware will switch the boot mode by DSW3-4 > and load the Multi bank update supported TF-A BL2 from > 0x60 offset on the SPI flash. Thus it can co-exist

Re: [RFC PATCH 11/14] FWU: Add FWU Multi Bank Update on SPI Flash

2022-01-20 Thread Masami Hiramatsu
2022年1月21日(金) 11:20 AKASHI Takahiro : > > On Fri, Jan 21, 2022 at 12:31:10AM +0900, Masami Hiramatsu wrote: > > Signed-off-by: Masami Hiramatsu > > --- > > include/fwu.h | 13 ++ > > lib/fwu_updates/Kconfig| 34 ++ > > lib/fwu_updates/Makefile |5 - > >

Re: [RFC PATCH 12/14] FWU: synquacer: Add FWU Multi bank update support for DeveloperBox

2022-01-20 Thread Masami Hiramatsu
2022年1月21日(金) 11:22 AKASHI Takahiro : > > On Fri, Jan 21, 2022 at 12:31:20AM +0900, Masami Hiramatsu wrote: > > The DeveloperBox platform can support the FWU Multi bank > > update. SCP firmware will switch the boot mode by DSW3-4 > > and load the Multi bank update supported TF-A BL2 from > >

Re: [PATCH 2/8] net: ti: am65-cpsw: Add support for multi port independent MAC mode

2022-01-20 Thread Ramon Fried
On Mon, Jan 17, 2022 at 8:37 PM Tom Rini wrote: > > On Fri, Dec 24, 2021 at 12:55:30PM +0530, Vignesh Raghavendra wrote: > > > On certain TI SoC, like AM64x there is a CPSW3G which supports 2 > > external independent MAC ports for single CPSW instance. > > It is not possible for Ethernet driver

Re: [PATCH 03/11] dt-bindings: clock: Add initial suniv headers

2022-01-20 Thread Andre Przywara
On Tue, 4 Jan 2022 19:35:00 -0500 Jesse Taube wrote: > From: Icenowy Zheng > > This commit introduces suniv dt-bindings headers needed for > device tree files. > > Signed-off-by: Icenowy Zheng > Signed-off-by: Jesse Taube This seems to be some old copy, it doesn't match with what's in the

Re: [PATCH 01/11] arm: arm926ej-s: start.S: port save_boot_params support from armv7 code

2022-01-20 Thread Andre Przywara
On Tue, 4 Jan 2022 19:34:58 -0500 Jesse Taube wrote: Hi, > From: Icenowy Zheng > > The ARMv7 start code has support for saving some boot params at the > entry point, which is used by some SoCs to return to BROM. > > Port this to ARM926EJ-S start code. > > Signed-off-by: Icenowy Zheng >

Re: [PATCH 02/11] arm: arm926ej-s: add sunxi code

2022-01-20 Thread Andre Przywara
On Tue, 4 Jan 2022 19:34:59 -0500 Jesse Taube wrote: Hi, > From: Icenowy Zheng > > Some Allwinner SoCs use ARM926EJ-S core. > > Add Allwinner/sunXi specific code to ARM926EJ-S CPU dircetory. > > Signed-off-by: Icenowy Zheng > Signed-off-by: Jesse Taube > --- >

Re: [PATCH 02/11] arm: arm926ej-s: add sunxi code

2022-01-20 Thread Jesse Taube
On 1/20/22 21:25, Andre Przywara wrote: On Tue, 4 Jan 2022 19:34:59 -0500 Jesse Taube wrote: Hi, From: Icenowy Zheng Some Allwinner SoCs use ARM926EJ-S core. Add Allwinner/sunXi specific code to ARM926EJ-S CPU dircetory. Signed-off-by: Icenowy Zheng Signed-off-by: Jesse Taube ---

Re: [PATCH v3 0/4] rockchip: sdhci: Fix reinit and add HS400 Enhanced Strobe support

2022-01-20 Thread Simon Glass
Hi Alper, On Sun, 16 Jan 2022 at 13:18, Alper Nebi Yasak wrote: > > My rk3399-gru-kevin has some problems with the eMMC. The board can boot > to U-Boot proper with the eMMC working at a low speed, but trying to > reinitialize it with "mmc dev 0" or "mmc rescan" makes it unusable. If > the HS400

[PATCH v3] gitlab: x86: Add a coreboot test

2022-01-20 Thread Simon Glass
Coreboot supports U-Boot as a payload and this recently got a bit of a facelist. Add a test for this. For now this uses a binary build of coreboot (v4.15). Future work could potentially build it from source, but we need to figure out the toolchain problems first, since coreboot uses its own

Re: [PATCH v3 31/31] RFC: Switch rpi over to use bootstd

2022-01-20 Thread Simon Glass
Hi Tom, On Thu, 20 Jan 2022 at 16:23, Tom Rini wrote: > > On Thu, Jan 20, 2022 at 01:47:41PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Thu, 20 Jan 2022 at 13:08, Tom Rini wrote: > > > > > > On Thu, Jan 20, 2022 at 12:56:55PM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On

Re: [PATCH 10/11] ARM: dts: suniv: Add device tree files for F1C100s

2022-01-20 Thread Andre Przywara
On Tue, 4 Jan 2022 19:35:07 -0500 Jesse Taube wrote: Hi, > From: Icenowy Zheng > > Add device tree files for suniv and > Lichee Pi Nano it is a board based on F1C100s. > > Signed-off-by: Icenowy Zheng > Signed-off-by: Jesse Taube Those files differ significantly from the kernel. It looks

Re: [PATCH 04/11] dt-bindings: reset: Add initial suniv headers

2022-01-20 Thread Andre Przywara
On Tue, 4 Jan 2022 19:35:01 -0500 Jesse Taube wrote: > From: Icenowy Zheng > > This commit introduces suniv dt-bindings headers > needed for device tree files. > > Signed-off-by: Icenowy Zheng > Signed-off-by: Jesse Taube This seems to be some old copy, it doesn't match with what's in the

Re: [PATCH 07/11] sunxi: board: Add support for SUNIV

2022-01-20 Thread Andre Przywara
On Tue, 4 Jan 2022 19:35:04 -0500 Jesse Taube wrote: Hi, > From: Icenowy Zheng > > Generic Timer Extension is not available on SUNIV. Well, that, plus there are no ID registers with which we could query this. But that has the same effect, so: > Signed-off-by: Icenowy Zheng >

Re: [PATCH 10/11] ARM: dts: suniv: Add device tree files for F1C100s

2022-01-20 Thread Jesse Taube
On 1/20/22 20:59, Andre Przywara wrote: On Tue, 4 Jan 2022 19:35:07 -0500 Jesse Taube wrote: Hi, From: Icenowy Zheng Add device tree files for suniv and Lichee Pi Nano it is a board based on F1C100s. Signed-off-by: Icenowy Zheng Signed-off-by: Jesse Taube Those files differ

[PATCH 3/3] net: xilinx: Force a probe failure if it cannot setup phy

2022-01-20 Thread Andy Chiu
Or we may get load access faults afterward. The `phydev` field on axi-ethernet’s private struct is not set on a failed phy_connect(): axi_emac_probe() => axiemac_phy_init() => priv->phydev = phy_connect() <--- may fail However, all of the following calls on `axi_emac_ops` assume a valid

[PATCH] net: xilinx: fix the wrong dma base address issue

2022-01-20 Thread Andy Chiu
From: Greentime Hu If we just use fdtdec_get_addr_size_fixed to get "reg" it will use 64bit address cell to get the base address. soc { #address-cells = <1>; #size-cells = <1>; compatible ="SiFive,FU500-soc", "fu500-soc", "sifive-soc", "simple-bus"; ranges; L28: axidma@3001 {

[PATCH 1/3] net: xilinx: fix load access fault

2022-01-20 Thread Andy Chiu
From: Greentime Hu phy_connect() may fail by returning a NULL pointer. Thus, axiemac_phy_init() should handle the case or we may get an access fault when it tries to dereference it. Signed-off-by: Greentime Hu Reviewed-by: Andy Chiu Signed-off-by: Andy Chiu ---

Re: [RFC PATCH 10/14] FWU: Reboot soon after successfully install the new firmware

2022-01-20 Thread AKASHI Takahiro
On Fri, Jan 21, 2022 at 12:31:00AM +0900, Masami Hiramatsu wrote: > Reboot to the trial state soon after successfully installing > the new firmware to the next bank and updating the active_index. > This is enabled by CONFIG_FWU_REBOOT_AFTER_UPDATE and is a > recommended option.

Re: [PATCH 8/8] configs: am64x_evm_r5/a53_defconfig: Enable configs required for Ethboot

2022-01-20 Thread Vignesh Raghavendra
On 17/01/22 8:47 am, Tom Rini wrote: > On Fri, Dec 24, 2021 at 12:55:36PM +0530, Vignesh Raghavendra wrote: > >> Enable config options needed to support Ethernet boot on AM64x SK. >> >> Signed-off-by: Vignesh Raghavendra > > This leads to size overflow on r5. > Hmm, I don't see size

[PATCH 2/3] net: xilinx: Move setup of 1G MAC to a function

2022-01-20 Thread Andy Chiu
Separate the flow out so that it would be easiler to implement error handling logic. Signed-off-by: Andy Chiu --- drivers/net/xilinx_axi_emac.c | 50 +-- 1 file changed, 30 insertions(+), 20 deletions(-) diff --git a/drivers/net/xilinx_axi_emac.c

[PATCH v4 3/4] arm: kirkwood: Pogoplug-V4 : Add board implementation files

2022-01-20 Thread Tony Dinh
Note: currently the fdt_get_phy_addr function in this file is duplicate in this board and many other Kirkwood boards (eg. Sheevaplug, GoFlex Home, etc.). This function is being factored out into common area by another patch. And because it was written for flattree only, the patch is being

[PATCH v4 1/4] arm: kirkwood: Pogoplug-V4 : Add DTS files

2022-01-20 Thread Tony Dinh
Add DTS files for Pogoplug V4 board Reviewed-by: Stefan Roese Signed-off-by: Tony Dinh --- (no changes since v2) Changes in v2: - Use mainline Linux DTS version arch/arm/dts/Makefile | 1 + arch/arm/dts/kirkwood-pogoplug-series-4.dts | 180 2

[PATCH v4 4/4] arm: kirkwood: Pogoplug V4 : Add board include header and defconfig files

2022-01-20 Thread Tony Dinh
Add board include header and defconfig files for Pogoplug V4 Signed-off-by: Tony Dinh --- Changes in v4: - Remove CONFIG_FEATURE_COMMAND_EDITING and ifdefs for CMD_NET in include header Changes in v3: - Migrate config symbols from board include header to defconfig - Remove obsolete config

[PATCH v4 2/4] arm: kirkwood: Pogoplug-V4 : Add Kconfig files

2022-01-20 Thread Tony Dinh
Add Kconfig files for Pogoplug V4 board Signed-off-by: Tony Dinh --- (no changes since v3) Changes in v3: - Migrate symbols from board include header to Kconfig arch/arm/mach-kirkwood/Kconfig | 6 ++ board/cloudengines/pogo_v4/Kconfig | 16 2 files changed, 22

Re: [RFC PATCH 11/14] FWU: Add FWU Multi Bank Update on SPI Flash

2022-01-20 Thread AKASHI Takahiro
On Fri, Jan 21, 2022 at 12:31:10AM +0900, Masami Hiramatsu wrote: > Signed-off-by: Masami Hiramatsu > --- > include/fwu.h | 13 ++ > lib/fwu_updates/Kconfig| 34 ++ > lib/fwu_updates/Makefile |5 - > lib/fwu_updates/fwu_mdata_sf.c | 241 >

Re: [PATCH 2/8] net: ti: am65-cpsw: Add support for multi port independent MAC mode

2022-01-20 Thread Vignesh Raghavendra
On 21/01/22 4:49 am, Tom Rini wrote: > On Fri, Jan 21, 2022 at 01:13:54AM +0200, Ramon Fried wrote: >> On Mon, Jan 17, 2022 at 8:37 PM Tom Rini wrote: >>> >>> On Fri, Dec 24, 2021 at 12:55:30PM +0530, Vignesh Raghavendra wrote: >>> On certain TI SoC, like AM64x there is a CPSW3G which

Re: [RFC PATCH 10/14] FWU: Reboot soon after successfully install the new firmware

2022-01-20 Thread AKASHI Takahiro
On Fri, Jan 21, 2022 at 03:54:12PM +0900, Masami Hiramatsu wrote: > Hi, > > 2022年1月21日(金) 13:35 Masami Hiramatsu : > > > > Hi Takahiro, > > > > 2022年1月21日(金) 10:46 AKASHI Takahiro : > > > > > > On Fri, Jan 21, 2022 at 12:31:00AM +0900, Masami Hiramatsu wrote: > > > > Reboot to the trial state

Re: [RFC PATCH v3 5/9] EFI: FMP: Add provision to update image's ImageTypeId in image descriptor

2022-01-20 Thread Sughosh Ganu
hi Takahiro, On Thu, 20 Jan 2022 at 10:54, AKASHI Takahiro wrote: > > On Thu, Jan 20, 2022 at 12:25:44AM +0530, Sughosh Ganu wrote: > > The FWU Multi Banks Update feature allows updating different types of > > updatable firmware images on the platform. These image types are > > identified using

Re: [RFC PATCH v3 0/9] FWU: Add support for FWU Multi Bank Update feature

2022-01-20 Thread Sughosh Ganu
hi Takahiro, On Thu, 20 Jan 2022 at 11:01, AKASHI Takahiro wrote: > > Sughosh, > > On Thu, Jan 20, 2022 at 12:25:39AM +0530, Sughosh Ganu wrote: > > > > The patchset adds support for the FWU Multi Bank Update[1] > > feature. Certain aspects of the Dependable Boot[2] specification have > > also

Re: [RFC PATCH v3 9/9] mkeficapsule: Add support for generating empty capsules

2022-01-20 Thread Sughosh Ganu
hi Takahiro, On Thu, 20 Jan 2022 at 07:43, AKASHI Takahiro wrote: > > Hi Sughosh, > > From user's point of view, > > On Thu, Jan 20, 2022 at 12:25:48AM +0530, Sughosh Ganu wrote: > > The Dependable Boot specification describes the structure of the > > May we have a pointer or reference to it?

Re: [RFC PATCH v3 7/9] FWU: Add support for FWU Multi Bank Update feature

2022-01-20 Thread Sughosh Ganu
hi Masami, On Thu, 20 Jan 2022 at 11:37, Masami Hiramatsu wrote: > > Hello Sughosh, > > 2022年1月20日(木) 3:57 Sughosh Ganu : > > > diff --git a/lib/fwu_updates/Kconfig b/lib/fwu_updates/Kconfig > > new file mode 100644 > > index 00..6de28e0c9c > > --- /dev/null > > +++

Re: [PATCH 6/8] configs: am64x_evm: set eth1 as boot interface

2022-01-20 Thread Vignesh Raghavendra
On 17/01/22 8:16 pm, Tom Rini wrote: > On Fri, Dec 24, 2021 at 12:55:34PM +0530, Vignesh Raghavendra wrote: > >> ROM supports boot from CPSW second port, therefore set eth1 boot >> interface >> >> Signed-off-by: Vignesh Raghavendra >> --- >> include/configs/am64x_evm.h | 5 - >> 1 file

Re: [PATCH] stm32prog: add partition name in treat_partition_list error messages

2022-01-20 Thread Patrice CHOTARD
HI Patrick On 1/18/22 10:33 AM, Patrick Delaunay wrote: > Add the partition name and remove the line number in error messages > of treat_partition_list() to provide correct information to user of > STM32CubeProgrammer. > > The "line number" value was confusing because it is incorrect here; > the

[PATCH 1/4] net: ti: am65-cpsw-nuss: Fix err msg for port bind failures

2022-01-20 Thread Vignesh Raghavendra
Replace error case print with meaning full message. Signed-off-by: Vignesh Raghavendra --- drivers/net/ti/am65-cpsw-nuss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ti/am65-cpsw-nuss.c b/drivers/net/ti/am65-cpsw-nuss.c index 6ae69b51c7..454986ff15 100644

[PATCH 4/4] configs: am64x_evm_r5/a53_defconfig: Enable configs required for Ethboot

2022-01-20 Thread Vignesh Raghavendra
Enable config options needed to support Ethernet boot on AM64x SK. Signed-off-by: Vignesh Raghavendra --- configs/am64x_evm_a53_defconfig | 4 configs/am64x_evm_r5_defconfig | 12 2 files changed, 16 insertions(+) diff --git a/configs/am64x_evm_a53_defconfig

[PATCH 0/4] ARM: ti: AM64x: Clean up Ethernet boot support on AM64x SK

2022-01-20 Thread Vignesh Raghavendra
This series is follow up to [1] First patch cleans up err msg in CPSW-NUSS driver Second patch disable cpsw_port1 at SPL stage Third patch increases SPL BSS size in anticipation of enabling network stack Last patch enables all configs needed to support ethboot [1]

[PATCH 3/4] configs: am64xx_evm: Increase BSS max size to 16K

2022-01-20 Thread Vignesh Raghavendra
With Ethboot support in SPL, network stack requires more BSS area, so increase BSS max size to 16K Signed-off-by: Vignesh Raghavendra --- include/configs/am64x_evm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/am64x_evm.h b/include/configs/am64x_evm.h

[PATCH 2/4] ARM: dts: k3-am642-sk: Disable cpsw_port1 in SPL

2022-01-20 Thread Vignesh Raghavendra
ROM supports cpsw_port2 for Ethernet boot and SPL stages continue to download images on the same port, therefore there is no need to enable cpsw_port1. Disable the same. Signed-off-by: Vignesh Raghavendra --- arch/arm/dts/k3-am642-r5-sk.dts | 11 ---

Re: [RFC PATCH 10/14] FWU: Reboot soon after successfully install the new firmware

2022-01-20 Thread Masami Hiramatsu
Hi, 2022年1月21日(金) 13:35 Masami Hiramatsu : > > Hi Takahiro, > > 2022年1月21日(金) 10:46 AKASHI Takahiro : > > > > On Fri, Jan 21, 2022 at 12:31:00AM +0900, Masami Hiramatsu wrote: > > > Reboot to the trial state soon after successfully installing > > > the new firmware to the next bank and updating

Re: [RFC PATCH v3 0/9] FWU: Add support for FWU Multi Bank Update feature

2022-01-20 Thread Sughosh Ganu
hi Heinrich, On Thu, 20 Jan 2022 at 15:39, Heinrich Schuchardt wrote: > > On 1/19/22 19:55, Sughosh Ganu wrote: > > The patchset adds support for the FWU Multi Bank Update[1] > > feature. Certain aspects of the Dependable Boot[2] specification have > > also been implemented. > > The document

Re: [RFC PATCH v3 2/9] FWU: Add FWU metadata access functions for GPT partitioned block devices

2022-01-20 Thread Masami Hiramatsu
Hi Sughosh, 2022年1月20日(木) 3:56 Sughosh Ganu : > +static int fwu_gpt_update_mdata(struct fwu_mdata *mdata) > +{ > + int ret; > + struct blk_desc *desc; > + u16 primary_mpart = 0, secondary_mpart = 0; > + I think this update_mdata() method (or fwu_update_mdata() wrapper) should

[PULL u-boot] Please pull u-boot-amlogic-20220120

2022-01-20 Thread Neil Armstrong
repository at: https://source.denx.de/u-boot/custodians/u-boot-amlogic.git tags/u-boot-amlogic-20220120 for you to fetch changes up to 09c2debab70271fdb3b1ff89e0e7d186502c548d: board: amlogic: vim3: configure serial# from ethaddr (2022-01-20 09:50:54 +0100

Re: [PATCH v3 31/31] RFC: Switch rpi over to use bootstd

2022-01-20 Thread Michael Walle
> The bootdevs have a natural priority, based on the assumed speed of > the device, so the board would only need to intervene (with an env var > or a devicetree property) when that is wrong. Does this make sense in general? The default boot order for a board should depend on what is available on

Re: [PATCH v3 00/31] Initial implementation of standard boot

2022-01-20 Thread Michael Walle
Hi, Am 2022-01-19 15:56, schrieb Simon Glass: On Wed, 19 Jan 2022 at 01:09, Michael Walle wrote: > The bootflow feature provide a built-in way for U-Boot to automatically > boot an Operating System without custom scripting and other customisation. > This is called 'standard boot' since it

Re: [RFC PATCH v3 0/9] FWU: Add support for FWU Multi Bank Update feature

2022-01-20 Thread Heinrich Schuchardt
On 1/19/22 19:55, Sughosh Ganu wrote: The patchset adds support for the FWU Multi Bank Update[1] feature. Certain aspects of the Dependable Boot[2] specification have also been implemented. The document "Platform Security Firmware Update for the A-profile Arm Architecture Beta" [1] that you

Re: [PATCH v3 31/31] RFC: Switch rpi over to use bootstd

2022-01-20 Thread Mark Kettenis
> From: Michael Walle > Date: Thu, 20 Jan 2022 09:35:44 +0100 > > > The bootdevs have a natural priority, based on the assumed speed of > > the device, so the board would only need to intervene (with an env var > > or a devicetree property) when that is wrong. > > Does this make sense in

UDC driver implementation

2022-01-20 Thread Oleh Kravchenko
Hello all, I'm working on a new USB device controller driver for U-Boot. And I need some advice how to properly implement it. Could you please describe what is gadget.ep0? - Why ep0 defined separetly (not included in end points list)? - Why other end-points has "in" and "out" `struct usb_ep`

Re: [RESEND PATCH v3 4/4] arm: kirkwood: Pogoplug V4 : Add board include header and defconfig files

2022-01-20 Thread Stefan Roese
Hi Tony, On 1/20/22 01:28, Tony Dinh wrote: Add board include header and defconfig files for Pogoplug V4 Signed-off-by: Tony Dinh --- Changes in v3: - Migrate config symbols from board include header to defconfig - Remove obsolete config symbols from header file - Don't use ifdefs for

Re: [RFC PATCH v3 8/9] FWU: cmd: Add a command to read FWU metadata

2022-01-20 Thread Heinrich Schuchardt
On 1/19/22 19:55, Sughosh Ganu wrote: Add a command to read the metadata as specified in the FWU specification and print the fields of the metadata. Signed-off-by: Sughosh Ganu --- Changes since V2: * Include the log.h and stdio.h header files cmd/Kconfig | 7 ++ cmd/Makefile

Re: [PATCH v11] driver: spi: add bcm iproc qspi support

2022-01-20 Thread Jagan Teki
On Sat, Dec 18, 2021 at 1:52 AM Roman Bacik wrote: > > From: Rayagonda Kokatanur > > IPROC qspi driver supports both BSPI and MSPI modes. > > Signed-off-by: Rayagonda Kokatanur > Signed-off-by: Bharat Gooty > Acked-by: Rayagonda Kokatanur > > Signed-off-by: Roman Bacik > --- > > Changes in

Re: [PATCH] cmd: mmc: Consider GP partitions in mmc hwpartition user enh start -

2022-01-20 Thread Fabio Estevam
Hi Marek, On Mon, Jan 17, 2022 at 6:54 PM Marek Vasut wrote: > > In case the eMMC contains any GP partitions or user sets up new GP > partitions, the size of these GP partitions reduce the size of the > USER partition. Subtract the size of those GP partitions from the > calculated size of USER

Re: [RFC PATCH v3 1/9] FWU: Add FWU metadata structure and functions for accessing metadata

2022-01-20 Thread Heinrich Schuchardt
On 1/19/22 19:55, Sughosh Ganu wrote: In the FWU Multi Bank Update feature, the information about the updatable images is stored as part of the metadata, which is stored on a dedicated partition. Add the metadata structure, and functions to access the metadata. These are generic API's, and

Re: [RFC PATCH v3 3/9] FWU: stm32mp1: Add helper functions for accessing FWU metadata

2022-01-20 Thread Heinrich Schuchardt
On 1/19/22 19:55, Sughosh Ganu wrote: Add helper functions needed for accessing the FWU metadata which contains information on the updatable images. These functions have been added for the STM32MP157C-DK2 board which has the updatable images on the uSD card, formatted as GPT partitions.

Re: [RFC PATCH v3 2/9] FWU: Add FWU metadata access functions for GPT partitioned block devices

2022-01-20 Thread Heinrich Schuchardt
On 1/19/22 19:55, Sughosh Ganu wrote: In the FWU Multi Bank Update feature, the information about the updatable images is stored as part of the metadata, on a separate partition. Add functions for reading from and writing to the metadata when the updatable images and the metadata are stored on a

Re: [PATCH v3] drivers: spi-nor: Add JEDEC id for W25Q16JV

2022-01-20 Thread Jagan Teki
On Mon, Jan 17, 2022 at 7:27 PM Angus Ainslie wrote: > > Add a JEDEC id for the Winbond W25Q16JV 16M-BIT serial flash memory with > DUAL/QUAD SPI > > Changes since v2: > > Chagned the name to follow "DTR" parts > > Changes since v1: > > Updated the name for more suffixes > > Signed-off-by: Angus

Re: [PATCH v3] drivers: spi-nor: Add JEDEC id for W25Q16JV

2022-01-20 Thread Michael Walle
>> + { >> + INFO("w25q16jvm", 0xef7015, 0, 64 * 1024, 32, > > Can this name as "w25q16jv-im/jm" ? FWIW, "w25q15jvm" would be the "correct" name in linux. Although for this particular flash the name in linux is "w25q16jv-im/jm".. Anyhow, see [1] for a lengthy discussion on

Re: [RFC PATCH v3 4/9] FWU: STM32MP1: Add support to read boot index from backup register

2022-01-20 Thread Heinrich Schuchardt
On 1/19/22 19:55, Sughosh Ganu wrote: The FWU Multi Bank Update feature allows the platform to boot the firmware images from one of the partitions(banks). The first stage bootloader(fsbl) passes the value of the boot index, i.e. the bank from which the firmware images were booted from to U-Boot.

Re: [PATCH v4 0/3] mtd: Support slc-mode for NTC CHIP

2022-01-20 Thread Jagan Teki
On Fri, Dec 17, 2021 at 12:14 AM Chris Morgan wrote: > > From: Chris Morgan > > Add support for slc-mode implemented in Linux for the Toshiba > TC58TEG5DCLTA00 NAND and Hynix H27UCG8T2ETR NAND flash found on the NTC > CHIP. This requires the addition of a paired-pages scheme, a new > parameter

Re: [PATCH 7/7] sunxi: H6: Enable SPI0 in DT when no eMMC is used

2022-01-20 Thread Jagan Teki
On Tue, Jan 11, 2022 at 6:16 PM Andre Przywara wrote: > > On the Allwinner H6 SoC both the SPI0 and the eMMC device share one pin, > so cannot be used simultaneously. On Linux this is a showstopper, since > only one of them would be able to claim the pin, and the probe order is > somewhat random.

Re: [PATCH 7/7] sunxi: H6: Enable SPI0 in DT when no eMMC is used

2022-01-20 Thread Jagan Teki
On Thu, Jan 20, 2022 at 7:36 PM Andre Przywara wrote: > > On Thu, 20 Jan 2022 19:08:57 +0530 > Jagan Teki wrote: > > Hi, > > > On Tue, Jan 11, 2022 at 6:16 PM Andre Przywara > > wrote: > > > > > > On the Allwinner H6 SoC both the SPI0 and the eMMC device share one pin, > > > so cannot be used

Re: Commit 4f2e2280862a ("RFC: arm: pci: Add PCI cam support to PCI-E ecam driver")

2022-01-20 Thread Pali Rohár
Hello Alistair! On Wednesday 19 January 2022 14:48:21 Alistair Delva wrote: > Hi Pali, > > Sorry for the late reply.. > > On Thu, Jan 13, 2022 at 4:34 AM Pali Rohár wrote: > > > > Hello! > > > > Now I see that you have merged commit 4f2e2280862a ("RFC: arm: pci: Add > > PCI cam support to

Re: Commit 4f2e2280862a ("RFC: arm: pci: Add PCI cam support to PCI-E ecam driver")

2022-01-20 Thread Pali Rohár
Hello Mark! On Thursday 20 January 2022 00:23:02 Mark Kettenis wrote: > CAM is just a version of ECAM that only gives you access to the > classic PCI config space (register offsets < 256). This has very > little to do with the classic "mode 1" and "mode 2" config space > access methods of the

Re: [PATCH 7/7] sunxi: H6: Enable SPI0 in DT when no eMMC is used

2022-01-20 Thread Andre Przywara
On Thu, 20 Jan 2022 19:08:57 +0530 Jagan Teki wrote: Hi, > On Tue, Jan 11, 2022 at 6:16 PM Andre Przywara wrote: > > > > On the Allwinner H6 SoC both the SPI0 and the eMMC device share one pin, > > so cannot be used simultaneously. On Linux this is a showstopper, since > > only one of them

Re: [PATCH v3] drivers: spi-nor: Add JEDEC id for W25Q16JV

2022-01-20 Thread Jagan Teki
On Thu, Jan 20, 2022 at 7:53 PM wrote: > > On 1/20/22 3:20 PM, Michael Walle wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > >>> + { > >>> + INFO("w25q16jvm", 0xef7015, 0, 64 * 1024, 32, > >> > >> Can this name

Re: [PATCH 1/1] drivers: octeon: get rid of Unicode in code

2022-01-20 Thread Stefan Roese
On 1/16/22 23:11, Heinrich Schuchardt wrote: Placing Unicode control codes in the middle of a comment does not make much sense. Let's get rid of all Unicode in drivers/ram/octeon/octeon3_lmc.c. Signed-off-by: Heinrich Schuchardt Reviewed-by: Stefan Roese Thanks, Stefan ---

Re: [PATCH] mxc_gpio: on imx8m read the DR instead of the PSR

2022-01-20 Thread Angus Ainslie
Hi Fabio, On 2022-01-18 08:59, Fabio Estevam wrote: Hi Angus, On Sun, Nov 28, 2021 at 12:42 PM Angus Ainslie wrote: [1] diff --git a/arch/arm/dts/imx8mq-librem5.dts b/arch/arm/dts/imx8mq-librem5.dts index b28420654f..b60a8538af 100644 --- a/arch/arm/dts/imx8mq-librem5.dts +++

Re: [PATCH] mxc_gpio: on imx8m read the DR instead of the PSR

2022-01-20 Thread Fabio Estevam
Hi Angus, On Thu, Jan 20, 2022 at 10:56 AM Angus Ainslie wrote: > I decided to bypass the devicetree to test it on the imx8mq > > static const iomux_v3_cfg_t configure_pads[] = { >IMX8MQ_PAD_GPIO1_IO03__GPIO1_IO3 | MUX_PAD_CTRL(PAD_CTL_DSE6) > | MUX_MODE_SION, >

Re: [PATCH v3] drivers: spi-nor: Add JEDEC id for W25Q16JV

2022-01-20 Thread Angus Ainslie
Hi Jagan, On 2022-01-20 04:55, Jagan Teki wrote: On Mon, Jan 17, 2022 at 7:27 PM Angus Ainslie wrote: Add a JEDEC id for the Winbond W25Q16JV 16M-BIT serial flash memory with DUAL/QUAD SPI Changes since v2: Chagned the name to follow "DTR" parts Changes since v1: Updated the name for

Re: [PATCH v9 03/11] tools: build mkeficapsule with tools-only_defconfig

2022-01-20 Thread Tom Rini
On Thu, Jan 20, 2022 at 10:39:03AM +0900, AKASHI Takahiro wrote: > Heinrich, > > On Wed, Jan 19, 2022 at 05:08:14PM +0100, Heinrich Schuchardt wrote: > > On 1/18/22 05:39, AKASHI Takahiro wrote: > > > Add CONFIG_TOOLS_MKEFICAPSULE. Then we want to always build mkeficapsule > > > if

[RFC PATCH 04/14] doc: usage: DFU: Fix dfu_alt_info document

2022-01-20 Thread Masami Hiramatsu
Fix some typo and wrong information about dfu_alt_info. Signed-off-by: Masami Hiramatsu --- doc/usage/dfu.rst | 45 + 1 file changed, 33 insertions(+), 12 deletions(-) diff --git a/doc/usage/dfu.rst b/doc/usage/dfu.rst index 11c88072b8..25517637ae

[RFC PATCH 03/14] DFU: Check the number of arguments and argument string strictly

2022-01-20 Thread Masami Hiramatsu
When parsing the dfu_alt_info, check the number of arguments and argument string strictly. If there is any garbage data (which is not able to be parsed correctly) in dfu_alt_info, that means something wrong and user may make a typo or mis- understanding about the syntax. Since the dfu_alt_info is

[RFC PATCH 02/14] DFU: Accept redundant spaces and tabs in dfu_alt_info

2022-01-20 Thread Masami Hiramatsu
If dfu_alt_info has repeated spaces or tab (for indentation or readability), the dfu fails to parse it. For example, if dfu_alt_info="mtd nor1=image raw 10 20" (double spaces after "raw"), the image entity start address is '0' and the size '0x10'. This is because the repeated space is

[RFC PATCH 05/14] cmd/dfu: Enable 'dfu list' command without DFU_OVER_USB

2022-01-20 Thread Masami Hiramatsu
Since dfu is not only used for USB, and some platform only supports DFU_OVER_TFTP or EFI capsule update, dfu_alt_info is defined on such platforms too. For such platform, 'dfu list' command is useful to check how the current dfu_alt_info setting is parsed. Signed-off-by: Masami Hiramatsu ---

[RFC PATCH 06/14] FWU: Calculate CRC32 in gpt_update_mdata()

2022-01-20 Thread Masami Hiramatsu
To avoid calculating crc32 in several places, do it in gpt_update_mdata(). This also ensures the mdata crc32 is always sane. Signed-off-by: Masami Hiramatsu --- lib/fwu_updates/fwu_mdata.c | 18 -- lib/fwu_updates/fwu_mdata_gpt_blk.c | 13 - 2 files

[RFC PATCH 01/14] DFU: Do not copy the entity name over the buffer size

2022-01-20 Thread Masami Hiramatsu
Use strlcpy() instead of strcpy() to prevent copying the entity name over the name buffer size. Signed-off-by: Masami Hiramatsu --- drivers/dfu/dfu.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c index af3975925a..66c41b5e76 100644

  1   2   >