RE: [PATCH] configs: ast2600: Move SPL bss section to DRAM space

2022-06-28 Thread ChiaWei Wang
Hi Sean, > From: Sean Anderson > Sent: Tuesday, June 28, 2022 12:57 PM > > Hi Chai, > > On 6/28/22 12:23 AM, Joel Stanley wrote: > > Hi Chai Wei, > > > > On Wed, 1 Jun 2022 at 08:21, Chia-Wei Wang > wrote: > >> > >> The commit b583348ca8c8 ("image: fit: Align hash output buffers") > >> places

Re: [PATCH] EFI: Fix ReadBlocks API reading incorrect sector for, UCLASS_PARTITION devices

2022-06-28 Thread AKASHI Takahiro
Hi Paul, On Tue, Jun 28, 2022 at 09:02:47PM -0400, Paul Barbieri wrote: > From 7a7dd7f16352fc916279cca05a3fa617f8bbef64 Mon Sep 17 00:00:00 2001 > From: Paul Barbieri > Date: Tue, 28 Jun 2022 20:24:33 -0400 > Subject: [PATCH] EFI: Fix ReadBlocks API reading incorrect sector for >

Re: [PATCH 0/8] u-boot: fs: add generic unaligned read handling

2022-06-28 Thread Qu Wenruo
On 2022/6/28 22:17, Tom Rini wrote: On Tue, Jun 28, 2022 at 03:28:00PM +0800, Qu Wenruo wrote: [BACKGROUND] Unlike FUSE/Kernel which always pass aligned read range, U-boot fs code just pass the request range to underlying fses. Under most case, this works fine, as U-boot only really needs

[PATCH v4 2/3] usb: add isp1760 family driver

2022-06-28 Thread Rui Miguel Silva
ISP1760/61/63 are a family of usb controllers, here the main goal is to support the ISP1763 hcd part found in the MPS3 FPGA board form Arm. This is based on the kernel driver and ported to u-boot. Signed-off-by: Rui Miguel Silva --- Makefile|1 +

Serial console input dead after successfully booting buildroot system on rpi4

2022-06-28 Thread Matthias
Hi, after using the u-boot (v2022.01) bootloader built with rpi_4_32b_defconfig on a buildroot 2022.05 custom system, I can no longer input on the serial console connected to an FTDI adapter wired to Pins 8/10 of the RPi4 GPIO pin header. Here's what I did: * Replaced kernel=zImage by

Re: [PATCH] EFI: Fix ReadBlocks API reading incorrect sector for, UCLASS_PARTITION devices

2022-06-28 Thread Heinrich Schuchardt
On 6/29/22 03:02, Paul Barbieri wrote: From 7a7dd7f16352fc916279cca05a3fa617f8bbef64 Mon Sep 17 00:00:00 2001 From: Paul Barbieri Date: Tue, 28 Jun 2022 20:24:33 -0400 Subject: [PATCH] EFI: Fix ReadBlocks API reading incorrect sector for UCLASS_PARTITION devices The requested partition disk

Re: [PATCH 2/2] pmic: pca9450: clear PRESET_EN bit for BUCK1/2/3 voltage settings

2022-06-28 Thread Fabio Estevam
On 28/06/2022 11:06, Heiko Thiery wrote: The regulator driver uses the DVS registers PCA9450_REG_BUCKxOUT_DVS0 to set the voltage for the buck regulators 1, 2 and 3. This has no effect as the PRESET_EN bit is set by default and therefore the preset values are used instead, which are set to

Re: [RESEND PATCH 3/4] configs: imx8mn_bsh_smm_s2: remove console from bootargs

2022-06-28 Thread Tom Rini
On Sun, Jun 26, 2022 at 12:05:17PM +0200, Dario Binacchi wrote: > The Linux kernel device tree already specifies the device to be used for > boot console output with a stdout-path property under /chosen. > > Co-developed-by: Michael Trimarchi > Signed-off-by: Michael Trimarchi > Signed-off-by:

Re: [RESEND PATCH 2/4] configs: imx8mn_bsh_smm_s2: add UBI commands

2022-06-28 Thread Tom Rini
On Sun, Jun 26, 2022 at 12:05:16PM +0200, Dario Binacchi wrote: > imx8mn_bsh_smm_s2 uses ubifs rootfs, UBI commands are required to flash > it. > > Co-developed-by: Michael Trimarchi > Signed-off-by: Michael Trimarchi > Signed-off-by: Dario Binacchi Applied to u-boot/master, thanks! -- Tom

Re: [PATCH v2] fs/squashfs: Use kcalloc when relevant

2022-06-28 Thread Tom Rini
On Mon, Jun 27, 2022 at 12:20:03PM +0200, Miquel Raynal wrote: > A crafted squashfs image could embed a huge number of empty metadata > blocks in order to make the amount of malloc()'d memory overflow and be > much smaller than expected. Because of this flaw, any random code > positioned at the

Re: [RESEND PATCH 4/4] configs: imx8mn_bsh_smm_s2: add mtdparts to bootargs

2022-06-28 Thread Tom Rini
On Sun, Jun 26, 2022 at 12:05:18PM +0200, Dario Binacchi wrote: > Passing the mtdparts environment variable to the Linux kernel is > required to properly mount the UBI rootfs. > > Co-developed-by: Michael Trimarchi > Signed-off-by: Michael Trimarchi > Signed-off-by: Dario Binacchi Applied to

Re: Pull request: u-boot-imx u-boot-imx-20220628

2022-06-28 Thread Tom Rini
ns/u-boot-sunxi (2022-06-26 21:06:08 > -0400) > > are available in the Git repository at: > > https://gitlab.denx.de/u-boot/custodians/u-boot-imx.git > tags/u-boot-imx-20220628 > > for you to fetch changes up to b5023254b88a67fcbca913e212e3401dea521fc9: > > kont

Re: [PATCH 2/2] pmic: pca9450: clear PRESET_EN bit for BUCK1/2/3 voltage settings

2022-06-28 Thread Marek Vasut
On 6/28/22 22:02, Fabio Estevam wrote: On 28/06/2022 11:06, Heiko Thiery wrote: The regulator driver uses the DVS registers PCA9450_REG_BUCKxOUT_DVS0 to set the voltage for the buck regulators 1, 2 and 3. This has no effect as the PRESET_EN bit is set by default and therefore the preset

Re: [PATCH] rockchip: rockpro64: enable leds

2022-06-28 Thread Kever Yang
On 2022/6/12 21:52, Peter Robinson wrote: The Rockpro64 has some GPIO leds so let's enable them so the user gets some output in early boot. Signed-off-by: Peter Robinson Reviewed-by: Kever Yang Thanks, - Kever --- configs/rockpro64-rk3399_defconfig | 2 ++ 1 file changed, 2

Re: [PATCH 2/2] rockchip: rk3399: enable spl-fifo-mode for sdmmc only when needed

2022-06-28 Thread Kever Yang
On 2022/6/9 23:23, Jerome Forissier wrote: Commit 5c606ca35c42 ("rockchip: rk3399: enable spl-fifo-mode for sdmmc") mentions that the RK3399 SoC can't do DMA between SDMMC and SRAM. According to the TRM "7.3.2 Embedded SRAM access path" [1], only the 8KB SRAM at 0xff3b (INTMEM1) is in this

Re: [PATCH] rockchip: pinebook-pro: sync PBP dtb to 5.18

2022-06-28 Thread Kever Yang
On 2022/6/12 22:25, Peter Robinson wrote: Sync the pinebook pro to upstream 5.18, in particular this brings brings in a fix so the DP is disabled so Linux will actually boot. Signed-off-by: Peter Robinson Reviewed-by: Kever Yang Thanks, - Kever ---

Re: [PATCH] rockchip: pinebook-pro: minor SPI flash fixes

2022-06-28 Thread Kever Yang
On 2022/6/12 21:47, Peter Robinson wrote: Set a default offset for environment so it doesn't write it to unexpected locations, drop unneeded mtd config option. Signed-off-by: Peter Robinson Reviewed-by: Kever Yang Thanks, - Kever --- configs/pinebook-pro-rk3399_defconfig | 2 +- 1

Re: [RESEND PATCH 1/4] configs: imx8mn_bsh_smm_s2: add NAND driver

2022-06-28 Thread Tom Rini
On Sun, Jun 26, 2022 at 12:05:15PM +0200, Dario Binacchi wrote: > It allows to boot from NAND. > > Co-developed-by: Michael Trimarchi > Signed-off-by: Michael Trimarchi > Signed-off-by: Dario Binacchi Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] i2c: fix stack buffer overflow vulnerability in i2c md command

2022-06-28 Thread Tom Rini
On Fri, Jun 10, 2022 at 02:50:25PM +, nicolas.iooss.led...@proton.me wrote: > From: Nicolas Iooss > > When running "i2c md 0 0 8100", the function do_i2c_md parses the > length into an unsigned int variable named length. The value is then > moved to a signed variable: > > int

RE: [PATCH] configs: ast2600: Move SPL bss section to DRAM space

2022-06-28 Thread ChiaWei Wang
Hi Joel, > From: Joel Stanley > Sent: Tuesday, June 28, 2022 12:24 PM > > Hi Chai Wei, > > On Wed, 1 Jun 2022 at 08:21, Chia-Wei Wang > wrote: > > > > The commit b583348ca8c8 ("image: fit: Align hash output buffers") > > places the hash output buffer at the .bss section. However, AST2600 by >

Re: [PATCH v1] usb: host: nuvoton: Add nuvoton NPCM7xx ehci/ohci driver

2022-06-28 Thread Jim Liu
Hi Marek no, not yet. I will add i2c otp aes sha pinctrl usb spi mmc feature to poleg_evb_defconfig in the last commit. about the usb patch if you have any suggestion or need modify please let me know. On Tue, Jun 28, 2022 at 5:39 PM Marek Vasut wrote: > > On 6/28/22 05:49, Jim Liu wrote: >

Re: [PATCH 1/2] pmic: pca9450: enable system reset on WDOG_B assertion

2022-06-28 Thread Fabio Estevam
On 28/06/2022 11:06, Heiko Thiery wrote: By default the PCA9450 doesn't handle the assertion of the WDOG_B signal, but this is required to guarantee that things like software resets triggered by the watchdog work reliably. This is a port of the same changes in the Linux kernel: f7684f5a048f

Re: [PATCH v4 3/3] corstone1000: enable isp1763 usb controller and mmc

2022-06-28 Thread Rui Miguel Silva
Hi Marek, On Tue, Jun 28, 2022 at 09:05:43PM +0200, Marek Vasut wrote: > On 6/28/22 19:42, Rui Miguel Silva wrote: > > MPS3 board have a ISP1763 usb controller, enable it to be used > > for mass storage access for example. Enable the usb command > > also and for the FVP support for mass storage

Re: [PATCH] RockPi4: Add UEFI capsule update support

2022-06-28 Thread Kever Yang
Hi Sughosh, Thanks for your patch. On 2022/5/16 14:12, Sughosh Ganu wrote: hi Peter, On Sat, 14 May 2022 at 13:44, Peter Robinson wrote: On Fri, May 13, 2022 at 7:50 AM Sughosh Ganu wrote: Add support for updating the idbloader and u-boot images through the UEFI capsule update

Re: [PATCH v3] powerpc: mpc85xx: Set TEXT_BASE addresses to real base values

2022-06-28 Thread Pali Rohár
On Thursday 23 June 2022 08:34:58 Tom Rini wrote: > On Thu, Jun 23, 2022 at 01:29:10PM +0200, Pali Rohár wrote: > > On Thursday 16 June 2022 14:19:44 Pali Rohár wrote: > > > Currently CONFIG_SPL_TEXT_BASE and CONFIG_SYS_TEXT_BASE addresses are > > > manually increased by 0x1000 due to .bootpg

[PATCH RFC 8/8] fs: erofs: add unaligned read range handling

2022-06-28 Thread Qu Wenruo
I'm not an expert on erofs, but my quick glance didn't expose any special handling on unaligned range, thus I think the U-boot erofs driver doesn't really support unaligned read range. This patch will add erofs_get_blocksize() so erofs can benefit from the generic unaligned read support. Cc:

[PATCH RFC 7/8] fs: ubifs: rely on higher layer to do unaligned read

2022-06-28 Thread Qu Wenruo
Currently ubifs doesn't support unaligned read offset, thanks to the recent _fs_read() work to handle unaligned read, we only need to implement ubifs_get_blocksize() to take advantage of it. Now ubifs can do unaligned read without any problem. Signed-off-by: Qu Wenruo --- fs/fs.c

[PATCH RFC 4/8] fs: ext4: rely on _fs_read() to pass block aligned range into ext4fs_read_file()

2022-06-28 Thread Qu Wenruo
Since _fs_read() is handling the unaligned read internally, ext4 driver only need to handle block aligned read. Unfortunately I'm not familiar with ext4 and its driver, thus not confident enough to cleanup all the unaligned read related code. So here we will have some dead code, and any help to

[PATCH RFC 5/8] fs: fat: rely on higher layer to get block aligned read range

2022-06-28 Thread Qu Wenruo
Just implement fat_get_blocksize() for fat, so that fat_read_file() always get a block aligned read range. Unfortunately I'm not experienced enough to cleanup the fat code, thus further cleanup is appreciated. Cc: Tom Rini Signed-off-by: Qu Wenruo --- fs/fat/fat.c | 13 + fs/fs.c

[PATCH RFC 6/8] fs: sandboxfs: add sandbox_fs_get_blocksize()

2022-06-28 Thread Qu Wenruo
This is to make sandboxfs to report blocksize it supports for _fs_read() to handle unaligned read. Unlike all other fses, sandboxfs can handle unaligned read/write without any problem since it's calling read()/write(), which doesn't bother the blocksize at all. This change is mostly to make

[PATCH RFC 3/8] fs: btrfs: move the unaligned read code to _fs_read() for btrfs

2022-06-28 Thread Qu Wenruo
Unlike FUSE or kernel, U-boot filesystem code makes the underly fs code to handle the unaligned read (aka, read range is not aligned to fs block size). This makes underlying fs code harder to implement, as unlike FUSE/kernel code, now they have to handle unaligned read all by themselves. This

[PATCH RFC 1/8] fs: fat: unexport file_fat_read_at()

2022-06-28 Thread Qu Wenruo
That function is only utilized inside fat driver, unexport it. Signed-off-by: Qu Wenruo --- fs/fat/fat.c | 4 ++-- include/fat.h | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/fat/fat.c b/fs/fat/fat.c index df9ea2c028fc..dcceccbcee0a 100644 --- a/fs/fat/fat.c +++

[PATCH RFC 2/8] fs: always get the file size in _fs_read()

2022-06-28 Thread Qu Wenruo
For _fs_read(), @len == 0 means we read the whole file. And we just pass @len == 0 to make each filesystem to handle it. In fact we have info->size() call to properly get the filesize. So we can not only call info->size() to grab the file_size for len == 0 case, but also detect invalid @len

[PATCH 0/8] u-boot: fs: add generic unaligned read handling

2022-06-28 Thread Qu Wenruo
[BACKGROUND] Unlike FUSE/Kernel which always pass aligned read range, U-boot fs code just pass the request range to underlying fses. Under most case, this works fine, as U-boot only really needs to read the whole file (aka, 0 for both offset and len, len will be later determined using file size).

Re: [PATCH 18/20] kmcoge5ne: Move BFTIC3 CONFIG references to their usage

2022-06-28 Thread Heiko Schocher
Hello Tom, On 25.06.22 17:02, Tom Rini wrote: > We only reference CONFIG_SYS_BFTIC3_BASE in one location. Move the > comment to where we reference it, and use the value directly. > > Cc: Holger Brunck > Cc: Heiko Schocher > Signed-off-by: Tom Rini > --- > board/keymile/km83xx/km83xx.c | 6

Re: [PATCH v1] usb: host: nuvoton: Add nuvoton NPCM7xx ehci/ohci driver

2022-06-28 Thread Marek Vasut
On 6/28/22 05:49, Jim Liu wrote: Hi Marek Hi, Thank you for your reminder. Dell is use novuton uboot git repo now. and request us upstream it. npcm7xx normal defconfig is poleg_evb_defconfig, so all people use this config to build uboot. and poleg_evb_defconfig is in uboot master now. I

Re: [PATCH] mtd: spi-nor-core: Implement spi_nor_read_sfdp_dma_unsafe() for sfdp parse

2022-06-28 Thread Pratyush Yadav
On 03/06/22 12:31PM, Vaishnav Achath wrote: > During SFDP header parse and BFPT parse, structures in stack are used > to perform spi_nor_read_sfdp() which expects a dma-safe buffer. > > This commit introduces spi_nor_read_sfdp_dma_unsafe() to wrap > spi_nor_read_sfdp() using a kmalloc'ed bounce

Re: [PATCH v2 2/2] imx: kontron-sl-mx8mm: Enable PCA9450 regulator driver and fix SD card access

2022-06-28 Thread Fabio Estevam
On Mon, Jun 27, 2022 at 8:01 AM Frieder Schrempf wrote: > > From: Frieder Schrempf > > Currently accessing the SD card on USDHC2 fails with: > > => mmc dev 1 > Card did not respond to voltage select! : -110 > > This is due to the fact that UHS modes are enabled in the defconfig > and the

Re: [PATCH RFC 2/8] fs: always get the file size in _fs_read()

2022-06-28 Thread Huang Jianan
Hi, wenruo, 在 2022/6/28 15:28, Qu Wenruo 写道: For _fs_read(), @len == 0 means we read the whole file. And we just pass @len == 0 to make each filesystem to handle it. In fact we have info->size() call to properly get the filesize. So we can not only call info->size() to grab the file_size for

Re: [PATCH RFC 2/8] fs: always get the file size in _fs_read()

2022-06-28 Thread Qu Wenruo
On 2022/6/28 20:36, Huang Jianan wrote: Hi, wenruo, 在 2022/6/28 15:28, Qu Wenruo 写道: For _fs_read(), @len == 0 means we read the whole file. And we just pass @len == 0 to make each filesystem to handle it. In fact we have info->size() call to properly get the filesize. So we can not only

Re: [PATCH v5 03/23] FWU: Add FWU metadata access driver for GPT partitioned block devices

2022-06-28 Thread Sughosh Ganu
hi Etienne, On Tue, 21 Jun 2022 at 16:26, Etienne Carriere wrote: > > Hello Sughosh, > > On Thu, 9 Jun 2022 at 14:30, Sughosh Ganu wrote: > > > > In the FWU Multi Bank Update feature, the information about the > > updatable images is stored as part of the metadata, on a separate > > partition.

Re: [PATCH v5 03/23] FWU: Add FWU metadata access driver for GPT partitioned block devices

2022-06-28 Thread Sughosh Ganu
hi Patrick, Apologies for the late reply. I had missed out replying to the review comments on this patch. There are some review comments on the Synquacer patches which need to be taken care of by another engineer. Once those review comments are taken care of, I will be sending the next version.

Re: [PATCH v5 08/23] FWU: Add boot time checks as highlighted by the FWU specification

2022-06-28 Thread Sughosh Ganu
hi Etienne, On Thu, 23 Jun 2022 at 18:02, Etienne Carriere wrote: > > Hi Sughosh, > > On Thu, 23 Jun 2022 at 11:46, Sughosh Ganu wrote: > > > > hi Etienne, > > > > On Tue, 21 Jun 2022 at 16:26, Etienne Carriere > > wrote: > > > > > > Hi Sughosh, > > > > > > On Thu, 9 Jun 2022 at 14:31, Sughosh

Re: [PATCH v2 1/2] pmic: pca9450: Add optional SD_VSEL GPIO for LDO5

2022-06-28 Thread Fabio Estevam
On Mon, Jun 27, 2022 at 8:01 AM Frieder Schrempf wrote: > > From: Frieder Schrempf > > LDO5 has two separate control registers. LDO5CTRL_L is used if the > input signal SD_VSEL is low and LDO5CTRL_H if it is high. > The current driver implementation only uses LDO5CTRL_H. To make this > work on

Re: [PATCH v3 0/3] usb: add isp1760 hcd support

2022-06-28 Thread Marek Vasut
On 6/28/22 16:59, Rui Miguel Silva wrote: Hi, On Mon, Jun 20, 2022 at 01:44:02PM -0400, Tom Rini wrote: On Mon, Jun 20, 2022 at 05:00:56PM +0100, Rui Miguel Silva wrote: Hi Tom, On Tue Jun 14, 2022 at 6:45 PM WEST, Rui Miguel Silva wrote: Hi *, On Wed, May 25, 2022 at 02:22:48PM +0100, Rui

[PATCH v2] powerpc: mpc85xx: Simplify jump to _start_cont in flash code

2022-06-28 Thread Pali Rohár
After more patches code for jumping to _start_cont symbol in flash memory involved to code with useless mathematical operations. Currently it does: r3 := CONFIG_SYS_MONITOR_BASE + ABS(_start_cont) - CONFIG_SYS_MONITOR_BASE jump to r3 Which is equivalent of just: r3 := ABS(_start_cont)

Re: [PATCH 8/9] dm: core: Add a command to show driver model statistics

2022-06-28 Thread Simon Glass
This command shows the memory used by driver model along with various hints as to what it might be if some 'core' tags were moved to use the tag list instead of a core (i.e. always-there) pointer. This may help with future work to reduce memory usage. Signed-off-by: Simon Glass --- cmd/dm.c

Re: [PATCH v3] powerpc: mpc85xx: Set TEXT_BASE addresses to real base values

2022-06-28 Thread Tom Rini
On Tue, Jun 28, 2022 at 11:18:34AM +0200, Pali Rohár wrote: > On Thursday 23 June 2022 08:34:58 Tom Rini wrote: > > On Thu, Jun 23, 2022 at 01:29:10PM +0200, Pali Rohár wrote: > > > On Thursday 16 June 2022 14:19:44 Pali Rohár wrote: > > > > Currently CONFIG_SPL_TEXT_BASE and CONFIG_SYS_TEXT_BASE

Re: [PATCH] sandbox: usb: Fix out-of-bounds read when fd=-1

2022-06-28 Thread Simon Glass
Hi Sean, On Wed, 23 Mar 2022 at 16:24, Sean Anderson wrote: > > sandbox_flash_bulk uses priv->read_len to determine if priv->buff contains > the response data (such as from SCSI_INQUIRY). However, if priv->fd=-1 in > handle_read, then priv->read_len is not set even though we are going to >

Re: [PATCH 6/9] dm: core: Support accessing core tags

2022-06-28 Thread Simon Glass
Hi Simon, On Sun, May 08, 2022 at 04:39:24AM -0600, Simon Glass wrote: > At present tag numbers are only allocated for non-core data, meaning that > the 'core' data, like priv and plat, are accessed through dedicated > functions. > > For debugging and consistency it is convenient to use tags for

Re: [PATCH] bloblist: Describe the design goals

2022-06-28 Thread Simon Glass
Add a comment explaining the design goals of bloblist, to make it easier for people to understand and comment on the structure. Signed-off-by: Simon Glass --- doc/develop/bloblist.rst | 2 ++ include/bloblist.h | 62 ++-- 2 files changed, 62

Re: [PATCH] dm: core: Provide fallbacks for ofnode_conf_read_...

2022-06-28 Thread Simon Glass
On 3/28/22 6:14 PM, Sean Anderson wrote: > Because fdt_get_config_str et al. were moved/renamed to > ofnode_conf_read_str, they now depend on CONFIG_DM as well as > CONFIG_OF_CONTROL. Add some fallback implementations, preventing a > linker error when CONFIG_SPL_OF_CONTROL and

Re: [PATCH] dm: core: Use device_foreach_child where possible

2022-06-28 Thread Simon Glass
We have some nice macros for iterating over devices in device.h, but they are not used by the driver core. Convert all the users I could find. Signed-off-by: Sean Anderson --- drivers/core/device-remove.c | 4 ++-- drivers/core/device.c| 21 ++--- drivers/core/devres.c

Re: [PATCH] dtoc: Update fdt tests to use test_util

2022-06-28 Thread Simon Glass
On 19/03/2022 03:01, Simon Glass wrote: > Use the common functions to run tests and report results. Ensure that the > result code indicates success or failure. > > Signed-off-by: Simon Glass > --- > > tools/dtoc/test_fdt.py | 27 ++- > 1 file changed, 10 insertions(+), 17

Re: [PATCH 1/1] efi_loader: initialize console size late

2022-06-28 Thread Fabio Estevam
Hi Heinrich, On Fri, Jun 17, 2022 at 1:59 AM Heinrich Schuchardt wrote: > > This causes: https://source.denx.de/u-boot/u-boot/-/jobs/450891#L229 > > for all instances of sandbox running that test. > > > > This is a only a bug to the test environment: > > test/py/u_boot_console_base.py:110: >

Re: [PATCH 1/1] efi_loader: initialize console size late

2022-06-28 Thread Fabio Estevam
On Tue, Jun 28, 2022 at 10:55 AM Tom Rini wrote: > I thought this was worked around for now? The non-testing case should > be fine again, and tests do need to do additional code to work, which is > not ideal, but good enough for the moment. I haven't realized that the patch has been applied.

Re: [PATCH 1/1] efi_loader: initialize console size late

2022-06-28 Thread Heinrich Schuchardt
On 6/28/22 15:52, Fabio Estevam wrote: Hi Heinrich, On Fri, Jun 17, 2022 at 1:59 AM Heinrich Schuchardt wrote: This causes: https://source.denx.de/u-boot/u-boot/-/jobs/450891#L229 for all instances of sandbox running that test. This is a only a bug to the test environment:

Re: [PATCH 1/1] efi_loader: initialize console size late

2022-06-28 Thread Fabio Estevam
On Tue, Jun 28, 2022 at 11:01 AM Heinrich Schuchardt wrote: > The patch is merged June 19th: > > e05bd68ed5fc ("test: work around for EFI terminal size probing") > > Why do you ask? Because I haven't seen an "applied" message in this thread. I see it in mainline now, thanks.

Re: [PATCH V7 2/4] ddr: imx8m: helper: load ddr firmware according to binman symbols

2022-06-28 Thread Alper Nebi Yasak
Hi Tom, Simon, Peng, On 27/06/2022 06:41, Peng Fan (OSS) wrote: > From: Peng Fan > > By reading binman symbols, we no need hard coded IMEM_LEN/DMEM_LEN after > we update the binman dtsi to drop 0x8000/0x4000 length for the firmware. > > And that could save binary size for many KBs. > >

Re: [PATCH 0/8] u-boot: fs: add generic unaligned read handling

2022-06-28 Thread Tom Rini
On Tue, Jun 28, 2022 at 03:28:00PM +0800, Qu Wenruo wrote: > [BACKGROUND] > Unlike FUSE/Kernel which always pass aligned read range, U-boot fs code > just pass the request range to underlying fses. > > Under most case, this works fine, as U-boot only really needs to read > the whole file (aka, 0

Re: [PATCH RESEND 4/5] ast2600: Configure u-boot-with-spl.bin target

2022-06-28 Thread Tom Rini
On Mon, Jun 27, 2022 at 05:28:10PM +0930, Joel Stanley wrote: > For the u-boot-with-spl.bin target to be useful for the AST2600, set the > maximum SPL size which also sets the padding length. > > The normal way of loading u-boot is as a FIT, so configure u-boot.img as > the SPL playload. > >

Re: [PATCH 3/5] config/ast2600: Disable hash hardware accel

2022-06-28 Thread Steven Lee
The 06/27/2022 18:06, Joel Stanley wrote: > On Mon, 27 Jun 2022 at 08:48, Steven Lee wrote: > > > > Hi Joel, > > > > I was wondering if you could share the commit hash of u-boot you tested. > > I would like to test it on qemu. > > I recommend using master with the patch that fixes FIT hash

[PATCH sunxi/next] spi: sunxi: use XCH status to detect in-progress transfer

2022-06-28 Thread Icenowy Zheng
The current detection of RX FIFO depth seems to be not reliable, and XCH will self-clear when a transfer is done. Check XCH bit when polling for transfer finish. Signed-off-by: Icenowy Zheng --- drivers/spi/spi-sunxi.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff

Re: [PATCH v2 8/8] armv8: u-boot-spl.lds: mark __image_copy_start as symbol

2022-06-28 Thread Simon Glass
From: Peng Fan In arch/arm/lib/sections.c there is below code: char __image_copy_start[0] __section(".__image_copy_start"); But actually 'objdump -t spl/u-boot-spl' not able to find out symbol '__image_copy_start' for binman update image-pos/size. So update link file Signed-off-by: Peng Fan

Re: [PATCH v2 5/8] spl: binman: Add config options for binman symbols in VPL

2022-06-28 Thread Simon Glass
The SPL code declares binman symbols for U-Boot phases depending on CONFIG_IS_ENABLED(BINMAN_UBOOT_SYMBOLS). This config exists for SPL and TPL, also add a version for VPL. Signed-off-by: Alper Nebi Yasak --- Changes in v2: - Update VPL configs for the new BINMAN_UBOOT_SYMBOLS

Re: [PATCH v2 6/8] spl: binman: Check at runtime if binman symbols were filled in

2022-06-28 Thread Simon Glass
Binman lets us declare symbols in SPL/TPL that refer to other entries in the same binman image as them. These symbols are filled in with the correct values while binman assembles the images, but this is done in-memory only. Symbols marked as optional can be filled with BINMAN_SYM_MISSING as an

Re: [PATCH v2 7/8] spl: binman: Disable u_boot_any symbols for i.MX8M boards

2022-06-28 Thread Simon Glass
The i.MX8M boards use partially specified binman images which have an SPL entry without a U-Boot entry. This would normally cause an error due to the 'u_boot_any' binman symbols declared by BINMAN_UBOOT_SYMBOLS requiring a U-Boot-like entry in the same image as the SPL. However, a problem in the

Re: [PATCH 1/1] sandbox: cast to pointer from integer of different size

2022-06-28 Thread Simon Glass
On Sun, Jun 12, 2022 at 7:25 PM Heinrich Schuchardt wrote: > > Building sandbox_defconfig on ARMv7 with HOST_32BIT=y results in: > > drivers/misc/qfw_sandbox.c:51:25: warning: > cast to pointer from integer of different size [-Wint-to-pointer-cast] >51 | void *address = (void

Re: [PATCH] test: fix some pylint errors in test_bind.py

2022-06-28 Thread Simon Glass
* Use spaces not tabs * Limit lines to 100 spaces * Remove an unused import * Sort imports correctly * Add a module description Signed-off-by: Heinrich Schuchardt --- test/py/tests/test_bind.py | 345 +++-- 1 file changed, 175 insertions(+), 170 deletions(-)

Re: [PATCH 4/9] dm: core: Add documentation for the dm command

2022-06-28 Thread Simon Glass
Add a description and examples for the dm subcommands. Signed-off-by: Simon Glass --- doc/usage/cmd/dm.rst | 487 +++ doc/usage/index.rst | 1 + 2 files changed, 488 insertions(+) create mode 100644 doc/usage/cmd/dm.rst Applied to u-boot-dm, thanks!

Re: [PATCH 5/9] dm: core: Switch the testbus driver to use a new struct

2022-06-28 Thread Simon Glass
At present this driver uses 'priv' struct to hold 'plat' data, which is confusing. The contents of the strct don't matter, since only dtoc is using it. Create a new struct with the correct name. Signed-off-by: Simon Glass --- drivers/misc/test_drv.c | 2 +- include/dm/test.h | 7 +++

Re: [PATCH v2 3/8] spl: binman: Declare extern symbols for VPL as well

2022-06-28 Thread Simon Glass
The binman extern symbol declarations in spl.h are missing the VPL symbols recently added to spl.c, add them like the others. Signed-off-by: Alper Nebi Yasak --- (no changes since v1) include/spl.h | 2 ++ 1 file changed, 2 insertions(+) Applied to u-boot-dm, thanks!

Re: [PATCH 1/2] sandbox: add function os_printf()

2022-06-28 Thread Simon Glass
Before setting up the devices U-Boot's printf() function cannot be used for console output. Provide function os_printf() to print to stderr. Signed-off-by: Heinrich Schuchardt --- arch/sandbox/cpu/os.c | 13 + include/os.h | 7 +++ 2 files changed, 20 insertions(+)

Re: [PATCH 1/1] efi_loader: initialize console size late

2022-06-28 Thread Tom Rini
On Tue, Jun 28, 2022 at 10:52:32AM -0300, Fabio Estevam wrote: > Hi Heinrich, > > On Fri, Jun 17, 2022 at 1:59 AM Heinrich Schuchardt > wrote: > > > > This causes: https://source.denx.de/u-boot/u-boot/-/jobs/450891#L229 > > > for all instances of sandbox running that test. > > > > > > > This is

[PATCH 0/2] pmic: pca9450: Initialization of pmic like done in linux

2022-06-28 Thread Heiko Thiery
To be able to initialize the PMIC voltages by using the PCA9450 regulator driver we need to properly disable the BUCK1/2/3 preset behavior. Also the RESET_CTRL/WDOG_B_CFG behavior can be done by the PC9450 PMIC driver. With that enabled the PMIC custom configurations done in SPL code for boards

[PATCH 2/2] pmic: pca9450: clear PRESET_EN bit for BUCK1/2/3 voltage settings

2022-06-28 Thread Heiko Thiery
The regulator driver uses the DVS registers PCA9450_REG_BUCKxOUT_DVS0 to set the voltage for the buck regulators 1, 2 and 3. This has no effect as the PRESET_EN bit is set by default and therefore the preset values are used instead, which are set to 850 mV. This is a port of the same change in

[PATCH 1/2] pmic: pca9450: enable system reset on WDOG_B assertion

2022-06-28 Thread Heiko Thiery
By default the PCA9450 doesn't handle the assertion of the WDOG_B signal, but this is required to guarantee that things like software resets triggered by the watchdog work reliably. This is a port of the same changes in the Linux kernel: f7684f5a048f ("regulator: pca9450: Enable system reset on

Re: [u-boot-test-hooks PATCH 0/2] Aspeed updates

2022-06-28 Thread Tom Rini
On Fri, 24 Jun 2022 12:04:18 +0930, Joel Stanley wrote: > This updates the configuration for the aspeed machines, adding support > for the ast2600. > > Joel Stanley (2): > ast2500: Simplify Qemu command line > travis-ci: Add Aspeed AST2600 Qemu configuration > > [...] Applied, thanks!

Re: [PATCH 0/8] u-boot: fs: add generic unaligned read handling

2022-06-28 Thread Sean Anderson
On 6/28/22 3:28 AM, Qu Wenruo wrote: [BACKGROUND] Unlike FUSE/Kernel which always pass aligned read range, U-boot fs code just pass the request range to underlying fses. Under most case, this works fine, as U-boot only really needs to read the whole file (aka, 0 for both offset and len, len

Re: [PATCH 3/5] patman: test_util: Use unittest text runner to print test results

2022-06-28 Thread Simon Glass
On Sat, 2 Apr 2022 at 11:06, Alper Nebi Yasak wrote: > > The python tools' test utilities handle printing test results, but the > output is quite bare compared to an ordinary unittest run. Delegate > printing the results to a unittest text runner, which gives us niceties > like clear separation

Re: [PATCH v2 2/8] spl: binman: Make TPL_BINMAN_SYMBOLS depend on TPL_FRAMEWORK

2022-06-28 Thread Simon Glass
TPL_BINMAN_SYMBOLS depends on SPL_FRAMEWORK. The code this enables is compiled by checking CONFIG_$(SPL_TPL_)FRAMEWORK, so it should depend on TPL_FRAMEWORK instead (which in turn depends on SPL_FRAMEWORK). This was most likely a typo due to copy-pasting the config's SPL version, fix it.

Re: [PATCH v2 4/8] spl: binman: Split binman symbols support from enabling binman

2022-06-28 Thread Simon Glass
Enabling CONFIG_BINMAN makes binman run after a build to package any images specified in the device-tree. It also enables a mechanism for SPL/TPL to declare and use special linker symbols that refer to other entries in the same binman image. A similar feature that gets this info from the

Re: [PATCH 9/9] dm: spl: Allow SPL to show memory usage

2022-06-28 Thread Simon Glass
Add an option to tell SPL to show memory usage for driver model just before it boots into the next phase. Signed-off-by: Simon Glass --- common/spl/spl.c | 9 + drivers/core/Kconfig | 10 ++ 2 files changed, 19 insertions(+) Applied to u-boot-dm, thanks!

Re: [PATCH 7/9] dm: core: Add a way to collect memory usage

2022-06-28 Thread Simon Glass
Add a function for collecting the amount of memory used by driver model, including devices, uclasses and attached data and tags. This information can provide insights into how to reduce the memory required by driver model. Future work may look at execution speed also. Signed-off-by: Simon Glass

Re: [PATCH v2 1/8] spl: binman: Fix use of undeclared u_boot_any symbols

2022-06-28 Thread Simon Glass
Some SPL functions directly use the binman 'u_boot_any' symbols to get U-Boot's binman image position. These symbols are declared by the SPL/TPL_BINMAN_SYMBOLS configs, but they are accessed by macros defined by just CONFIG_BINMAN. So when BINMAN is enabled and BINMAN_SYMBOLS is disabled, the code

Re: [PATCH 5/5] patman: test_util: Print test stdout/stderr within test summaries

2022-06-28 Thread Simon Glass
On Sat, 2 Apr 2022 at 11:06, Alper Nebi Yasak wrote: > > While running tests for a python tool, the tests' outputs get printed in > whatever order they happen to run, without any indication as to which > output belongs to which test. Unittest supports capturing these outputs > and printing them

Re: [PATCH 2/2] sandbox: show error if the device-tree cannot be loaded

2022-06-28 Thread Simon Glass
U-Boot's printf() used before setting up U-Boot's serial driver does not create any output. Use os_printf() for error messages related to loading the device-tree. Signed-off-by: Heinrich Schuchardt --- arch/sandbox/cpu/cpu.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Applied

Re: [PATCH 1/1] dm: fix formatting of uclass dump

2022-06-28 Thread Simon Glass
Insert an empty line after each uclass independent of whether it has devices or not. Signed-off-by: Heinrich Schuchardt --- drivers/core/dump.c | 2 -- 1 file changed, 2 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 1/5] patman: test_util: Fix printing results for failed tests

2022-06-28 Thread Simon Glass
On Sat, 2 Apr 2022 at 11:06, Alper Nebi Yasak wrote: > > When printing a python tool's test results, the entire list of failed > tests and their tracebacks are reprinted for every failed test. This > makes the test output quite unreadable. Fix the loop to print failures > and tracebacks one at a

Re: [PATCH 2/5] patman: test_util: Handle nonexistent tests while loading tests

2022-06-28 Thread Simon Glass
On Sat, 2 Apr 2022 at 11:06, Alper Nebi Yasak wrote: > > It's possible to request a specific test to run when trying to run a > python tool's tests. If we request a nonexistent test, the unittest > loaders generate a fake test that reports this as an error. However, we > get these fake tests even

Re: [PATCH 1/1] sandbox: raise SANDBOX_RAM_SIZE_MB default to 256

2022-06-28 Thread Simon Glass
The UEFI Self Certification Test (SCT) cannot run on 128 MiB. Signed-off-by: Heinrich Schuchardt --- arch/sandbox/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 1/9] dm: core: Rename dm_dump_all()

2022-06-28 Thread Simon Glass
This is not a good name anymore as it does not dump everything. Rename it to dm_dump_tree() to avoid confusion. Signed-off-by: Simon Glass --- cmd/dm.c| 8 drivers/core/dump.c | 2 +- include/dm/util.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) Applied to

Please pull u-boot-dm/next

2022-06-28 Thread Simon Glass
Hi Tom, This is for the -next branch. https://source.denx.de/u-boot/custodians/u-boot-dm/-/commit/e87da5704ffa6fc782d93d137fa30a37a5df3566 The following changes since commit ea82ed8c2eaee0a0f7dee31016aaee4ce88e9ea7: Merge branch '2022-06-27-add-armv8-sha1-sha256-support' into next

Re: [PATCH v2] patman: Fix defaults not propagating to subparsers

2022-06-28 Thread Simon Glass
On python 3.8.10 (and 3.10), subparsers are not updated with defaults. I suspect this is related to [1]. Fix this by explicitly updating subparsers with settings. [1] https://github.com/python/cpython/issues/89398 Fixes: 3145b63513 ("patman: Update defaults in subparsers") Signed-off-by: Sean

Re: [PATCH 3/9] dm: core: Fix addresses in the dm static command

2022-06-28 Thread Simon Glass
This command converts pointers to addresses, but the pointers being converted are in the image's rodata region. For sandbox this means it is not in DRAM so it does not make sense to do this conversion. Fix this by showing a simple pointer instead. Drop the unnecessary @ and hex prefixes.

Re: [PATCH 2/9] dm: core: Sort dm subcommands

2022-06-28 Thread Simon Glass
Put these in alphabetic order, both in the help and in the implementation, as there are quite a few subcommands now. Tweak the help for 'dm tree' to better explain what it does. Signed-off-by: Simon Glass --- cmd/dm.c | 48 1 file changed, 24

Re: [PATCH 4/5] patman: test_util: Customize unittest test results for more info

2022-06-28 Thread Simon Glass
By default, unittest test summaries only print extended info about tests that failed or couldn't run due to an error. Use a custom text result class to print info about more cases: skipped tests, expected failures and unexpected successes. Signed-off-by: Alper Nebi Yasak --- This could be

Re: [PATCH 6/9] dm: core: Support accessing core tags

2022-06-28 Thread AKASHI Takahiro
On Tue, Jun 28, 2022 at 09:37:56AM -0400, Simon Glass wrote: > Hi Simon, > > On Sun, May 08, 2022 at 04:39:24AM -0600, Simon Glass wrote: > > At present tag numbers are only allocated for non-core data, meaning that > > the 'core' data, like priv and plat, are accessed through dedicated > >

Re: 回复: minor regression in U-Boot 2022.04

2022-06-28 Thread Daniel Golle
Hi Weijie, On Tue, Apr 12, 2022 at 01:40:00AM +, Weijie Gao (高惟杰) wrote: > Hi Daniel, > > I've also noticed this error message. > It seems that some struct variables containing all zero data of the pinctrl > driver are not set to const, which causes these variables to be put into .bss >

Re: [PATCH v2] board: freescale: p1_p2_rdb_pc: Simplify SPL offset macros

2022-06-28 Thread Tom Rini
On Tue, Jun 28, 2022 at 08:34:47PM +0200, Pali Rohár wrote: > On Tuesday 28 June 2022 14:28:52 Tom Rini wrote: > > On Tue, Jun 28, 2022 at 08:22:38PM +0200, Pali Rohár wrote: > > > On Tuesday 28 June 2022 14:17:42 Tom Rini wrote: > > > > On Tue, Jun 28, 2022 at 07:53:55PM +0200, Pali Rohár wrote:

  1   2   >