Re: [PATCH 3/4] rockchip: board: Use a common USB Product ID for UMS

2024-03-08 Thread Kever Yang
On 2024/2/27 07:08, Jonas Karlman wrote: Change to use the common Product ID 0x0010 when the ums command is used. This matches downstream vendor U-Boot and is a Product ID that tools such as rkdeveloptool and RKDevTool will identify as MSC mode. Signed-off-by: Jonas Karlman Reviewed-by:

Re: [PATCH v3 16/20] board: rockchip: add Theobroma-Systems RK3588 Jaguar SBC

2024-03-08 Thread Kever Yang
On 2024/2/21 18:37, Quentin Schulz wrote: From: Quentin Schulz JAGUAR is a Single-Board Computer (SBC) based around the rk3588 SoC and is targeting Autonomous Mobile Robots (AMR). It features: * LPDDR4X (up to 16GB) * 1Gbps Ethernet on RJ45 connector (KSZ9031 or KSZ9131) * PCIe 3.0

Re: [PATCH v3 17/20] rockchip: puma-rk3399: MAINTAINERS: use glob for dtses

2024-03-08 Thread Kever Yang
On 2024/2/21 18:37, Quentin Schulz wrote: From: Quentin Schulz There are multiple Device Trees in U-Boot git repo for Puma, so let's make the MAINTAINERS entry match them all. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever ---

Re: [PATCH] arm: stm32: Enable OHCI HCD support on STM32MP15xx DHSOM

2024-03-08 Thread Patrice CHOTARD
On 3/4/24 19:25, Marek Vasut wrote: > The OHCI HCD is mandatory for USB 1.1 FS/LS device support, enable it. > This used to be enabled implicitly before, now that implicit dependency > disappeared and this got disabled. Enable it manually. > > Signed-off-by: Marek Vasut > --- > Cc: Patrice

Re: [PATCH 0/4] Simplefb and fb reservation related updates

2024-03-08 Thread Devarsh Thakkar
Hi Tom, Anatolij, Simon, On 22/02/24 18:38, Devarsh Thakkar wrote: > This adds support for simple-framebuffer reservation using video handoff > when splash is enabled at SPL stage. > > Also adds helper function to only enable framebuffer reservation without > enabling simple-framebuffer in case

Re: [PATCH 0/5] net: mdio-uclass: probe generic Ethernet PHY driver & Fix Beagleplay Ethernet

2024-03-08 Thread Roger Quadros
On 05/03/2024 15:24, Roger Quadros wrote: > Currently, the GPIO Reset Device Tree properties of the > PHY node are ignored when the PHY is probed via mdio-uclass driver [1]. > > To resolve this, for each child of the MDIO bus node, bind and probe > the generic Ethernet PHY driver if

Re: [PATCH 0/5] net: mdio-uclass: probe generic Ethernet PHY driver & Fix Beagleplay Ethernet

2024-03-08 Thread Roger Quadros
On 08/03/2024 10:22, Roger Quadros wrote: > > > On 05/03/2024 15:24, Roger Quadros wrote: >> Currently, the GPIO Reset Device Tree properties of the >> PHY node are ignored when the PHY is probed via mdio-uclass driver [1]. >> >> To resolve this, for each child of the MDIO bus node, bind and

Re: [PATCH 4/4] rockchip: Migrate to use DM_USB_GADGET on RK3328

2024-03-08 Thread Kever Yang
On 2024/2/27 07:08, Jonas Karlman wrote: USB gadget is not working fully as expected on RK3328, it uses a board_usb_init() function to initialize the DWC2 OTG port. The board_usb_init() function does not intgrate with the generic phy framework and as a result the USB phy is not properly

Re: [PATCH v2 1/5] power: tps65941: Add macros of TPS65224 PMIC

2024-03-08 Thread Dhruva Gole
On Mar 06, 2024 at 19:09:43 +0530, Bhargav Raviprakash wrote: > Re-use the TPS65941 PMIC driver for TPS65224 PMIC. > Add additional macros of TPS65224 to aid in the driver > re-use. > > Signed-off-by: Bhargav Raviprakash > --- Reviewed-by: Dhruva Gole > include/power/tps65941.h | 30

Re: [PATCH v3 19/20] rockchip: ringneck_px30: migrate README to doc/board in rST format

2024-03-08 Thread Kever Yang
On 2024/2/21 18:37, Quentin Schulz wrote: From: Quentin Schulz This migrates the plaintext README in board/theobroma-systems/ringneck_px30 to doc/board/theobroma-systems and while doing so, update the instructions and rewrite it in rST. Cc: Quentin Schulz Signed-off-by: Quentin Schulz

Re: [PATCH v3 20/20] rockchip: ringneck_px30: update website link

2024-03-08 Thread Kever Yang
On 2024/2/21 18:37, Quentin Schulz wrote: From: Quentin Schulz The original link returns a custom 404, so let's point to a link that works today instead. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever ---

[PATCH] stm32mp: Reserve OPTEE area in EFI memory map

2024-03-08 Thread Patrice Chotard
Since commit 7b78d6438a2b3 ("efi_loader: Reserve unaccessible memory") memory region above ram_top is tagged in EFI memory map as EFI_BOOT_SERVICES_DATA. In case of STM32MP1 platform, above ram_top, there is one reserved-memory region tagged "no-map" dedicated to OP-TEE (addr=de00

Re: [PATCH 1/4] rockchip: Update the default USB Product ID value

2024-03-08 Thread Jonas Karlman
Hi Kever, On 2024-03-08 10:22, Kever Yang wrote: > Hi Jonas, > >     Thanks for your patch. > > On 2024/2/27 07:08, Jonas Karlman wrote: >> RK3036 is using the USB product id normally used by RK3066B, and RK3328 >> is using the product id normally used by RK3368. >> >> Fix this and update the

Re: [PATCH 4/4] rockchip: Migrate to use DM_USB_GADGET on RK3328

2024-03-08 Thread Jonas Karlman
Hi Kever, On 2024-03-08 10:29, Kever Yang wrote: > > On 2024/2/27 07:08, Jonas Karlman wrote: >> USB gadget is not working fully as expected on RK3328, it uses a >> board_usb_init() function to initialize the DWC2 OTG port. >> >> The board_usb_init() function does not intgrate with the generic

Re: [PATCH v1 1/2] memory: stm32-fmc2-ebi: add MP25 support

2024-03-08 Thread Patrice CHOTARD
On 3/6/24 10:50, Christophe Kerello wrote: > Add the support of the revision 2 of FMC2 IP. > - PCSCNTR register has been removed, > - CFGR register has been added, > - the bit used to enable the IP has moved from BCR1 to CFGR, > - the timeout for CEx deassertion has moved

Re: [PATCH v1 2/2] memory: stm32-fmc2-ebi: add MP25 RIF support

2024-03-08 Thread Patrice CHOTARD
On 3/6/24 10:50, Christophe Kerello wrote: > The FMC2 revision 2 supports security and isolation compliant with > the Resource Isolation Framework (RIF). From RIF point of view, > the FMC2 is composed of several independent resources, listed below, > which can be assigned to different security

[PATCH] arm64: zynqmp: Describe USB wakeup interrupt

2024-03-08 Thread Michal Simek
Describe usb wakeup interrupt. Signed-off-by: Michal Simek --- arch/arm/dts/zynqmp.dtsi | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/arm/dts/zynqmp.dtsi b/arch/arm/dts/zynqmp.dtsi index daae23c12b79..c19d86e5a0c4 100644 --- a/arch/arm/dts/zynqmp.dtsi +++

Re: [RFC 3/5] board: starfive: support Milk-V Mars board

2024-03-08 Thread Heinrich Schuchardt
On 08.03.24 00:03, E Shattow wrote: On Sun, Mar 3, 2024 at 5:02 AM Heinrich Schuchardt > wrote: ... * The EEPROM is atmel,24c02 according to the vendor U-Boot. ... The same vendor (Milk-V) U-Boot change is present on their branch for Mars CM

Re: [PATCH v3 18/20] rockchip: rk3399-puma: migrate README to doc/board in rST format

2024-03-08 Thread Kever Yang
On 2024/2/21 18:37, Quentin Schulz wrote: From: Quentin Schulz This migrates the plaintext README in board/theobroma-systems/puma_rk3399 to doc/board/theobroma-systems and while doing so, update the instructions and rewrite it in rST. Cc: Quentin Schulz Signed-off-by: Quentin Schulz

Re: [PATCH 1/2] phy: rockchip-inno-usb2: Write to correct GRF

2024-03-08 Thread Kever Yang
On 2024/2/26 06:10, Jonas Karlman wrote: On RK3399 the USB2PHY regs are located in the common GRF, remaining SoCs that is supported by this driver have the USB2PHY regs in a different GRF. When support for RK356x, RK3588 and RK3328 was added this driver was never updated to use correct GRF

Re: [PATCH v2 5/5] power: regulator: tps65941: Add TPS65224 PMIC regulator support

2024-03-08 Thread Dhruva Gole
Hi, On Mar 06, 2024 at 19:09:47 +0530, Bhargav Raviprakash wrote: > Reuse TPS65941 regulator driver to adds support for > TPS65224 PMIC's regulators. 4 BUCKs and 3 LDOs, where > BUCK1 and BUCK2 can be configured in dual phase mode. > > Signed-off-by: Bhargav Raviprakash > --- >

Re: [PATCH] mtd: rawnand: stm32_fmc2: add MP25 support

2024-03-08 Thread Patrice CHOTARD
On 3/6/24 10:54, Christophe Kerello wrote: > FMC2 IP supports up to 4 chip select. On MP1 SoC, only 2 of them are > available when on MP25 SoC, the 4 chip select are available. > > Let's use a platform data structure for parameters that will differ. > > Signed-off-by: Christophe Kerello >

[PATCH] arm64: zynqmp: Remove additional compatible string for sc-revB

2024-03-08 Thread Michal Simek
Based on dt schema there is no need to specify flash via additional compatible string and generic are enough. Signed-off-by: Michal Simek --- arch/arm/dts/zynqmp-sc-revB.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/zynqmp-sc-revB.dts

[PATCH] arm64: zynqmp: Fix gpio-key DT description

2024-03-08 Thread Michal Simek
All gpio-key descriptionos with dt-schema. Signed-off-by: Michal Simek --- arch/arm/dts/zynqmp-sc-revB.dts| 2 +- arch/arm/dts/zynqmp-vp-x-a2785-00-revA.dts | 2 +- arch/arm/dts/zynqmp-vpk120-revA.dts| 2 +- arch/arm/dts/zynqmp-zcu208-revA.dts| 2 +-

Re: [PATCH 2/4] rockchip: board: Prepare for use of DM_USB_GADGET with DWC2_OTG

2024-03-08 Thread Kever Yang
On 2024/2/27 07:08, Jonas Karlman wrote: The board_usb_init() and board_usb_cleanup() functions is always included when USB_GADGET and USB_GADGET_DWC2_OTG is enabled. Prepare for a change to use DM_USB_GADGET with DWC2_OTG by adding an extra ifdef condition. The extra separate ifdef for

Re: [PATCH] stm32mp: cmd_stm32prog: add dependencies with USB_GADGET_DOWNLOAD

2024-03-08 Thread Patrice CHOTARD
On 2/7/24 14:12, Patrick Delaunay wrote: > This patch avoids compilation issue when CONFIG_USB_GADGET is deactivated > in defconfig, with undefined reference to run_usb_dnl_gadget and to > g_dnl_set_product. > > Signed-off-by: Patrick Delaunay > --- > >

Re: [PATCH v2 2/5] power: pmic: tps65941: Add TI TPS65224 PMIC

2024-03-08 Thread Dhruva Gole
On Mar 06, 2024 at 19:09:44 +0530, Bhargav Raviprakash wrote: > Adds compatible and data field values of TPS65224 driver in > TPS65941 PMIC driver. > > Signed-off-by: Bhargav Raviprakash > --- > drivers/power/pmic/tps65941.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH v2 3/5] power: regulator: tps65941: Added macros for BUCK ID

2024-03-08 Thread Dhruva Gole
Hi, On Mar 06, 2024 at 19:09:45 +0530, Bhargav Raviprakash wrote: > Adds macros for buck and ldo ids and switched to using switch > case instead of if else in probe functions. Helps in adding > support for TPS65224 PMIC. > > Signed-off-by: Bhargav Raviprakash > --- >

Re: [PATCH 2/2] phy: rockchip-inno-usb2: Limit changes made to regs

2024-03-08 Thread Kever Yang
Hi Jonas, On 2024/2/26 06:10, Jonas Karlman wrote: The USB2PHY regs already contain working default reset values for RK3328 and RK35xx as evidenced by the fact that this driver never has changed a single value for these SoCs. I would prefer to keep it as is for now, I think these configs are

Re: [PATCH 1/4] rockchip: Update the default USB Product ID value

2024-03-08 Thread Kever Yang
Hi Jonas,     Thanks for your patch. On 2024/2/27 07:08, Jonas Karlman wrote: RK3036 is using the USB product id normally used by RK3066B, and RK3328 is using the product id normally used by RK3368. Fix this and update the default USB_GADGET_PRODUCT_NUM Kconfig option for remaining supported

Re: [PATCH v3 11/20] rockchip: rk3588: fix non-working SD controller if booting from other media

2024-03-08 Thread Kever Yang
Hi Quentin, On 2024/2/21 18:37, Quentin Schulz wrote: From: Quentin Schulz Rockchip SoCs have some jtag/sdmmc autoswitching that simply doesn't work really well.[00] The Linux kernel disables it for all SoCs[01], so U-Boot needs to do the same in order to fix issues related to SD card on

Re: [PATCH v3 15/20] rockchip: rk3588: bind MMC controllers in U-Boot proper pre-reloc

2024-03-08 Thread Kever Yang
On 2024/2/21 18:37, Quentin Schulz wrote: From: Quentin Schulz Since commit 9e644284ab81 ("dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation"), bootph-pre-ram doesn't make U-Boot proper bind the device before relocation. While this is usually not much of an issue, it

Re: [PATCH 5/6] arm: fix __efi_runtime_start/end definitions

2024-03-08 Thread Ilias Apalodimas
On Fri, 8 Mar 2024 at 15:22, Ilias Apalodimas wrote: > > Hi Sam, > > On Thu, 7 Mar 2024 at 08:50, Ilias Apalodimas > wrote: > > > > > > > > On Thu, 7 Mar 2024 at 00:19, Sam Edwards wrote: > >> > >> > >> > >> On 3/6/24 02:13, Ilias Apalodimas wrote: > >> > Hi Sam, > >> > > >> > Again thank you

Re: [PATCH 2/3] ARM: dts: stm32: Fix partition node name for stm32mp15xx-dhcor-u-boot

2024-03-08 Thread Marek Vasut
On 3/8/24 2:50 PM, Patrice Chotard wrote: Fix flash@0 partition node name with correct offset. Fixes: 90f992e6a58c ("arm: dts: stm32: Add partitions in flash0 and nand node for stm32mp15xx-dhcom/dhcor") Signed-off-by: Patrice Chotard Reviewed-by: Marek Vasut

Re: [PATCH 3/3] ARM: dts: stm32: Fix partition node name for stm32mp15xx-dhcom-u-boot

2024-03-08 Thread Marek Vasut
On 3/8/24 2:50 PM, Patrice Chotard wrote: Fix flash@0 partition node name with correct offset. Fixes: 90f992e6a58c ("arm: dts: stm32: Add partitions in flash0 and nand node for stm32mp15xx-dhcom/dhcor") Signed-off-by: Patrice Chotard Reviewed-by: Marek Vasut

Re: [PATCH] fdt_support: fix fdt_copy_fixed_partitions function()

2024-03-08 Thread Dragan Simic
Hello Patrice, Please, see my comment below. On 2024-03-08 14:34, Patrice Chotard wrote: Move variable declaration at the beginning of the function. Fixes: 163c5f60ebb4 ("fdt_support: add fdt_copy_fixed_partitions function") Signed-off-by: Patrice Chotard --- boot/fdt_support.c | 6

Re: [PATCH] Makefile: Improve generated_defconfig file handling

2024-03-08 Thread Andrew Davis
On 3/7/24 9:38 PM, Sam Protsenko wrote: Commit 2027e99e61aa ("Makefile: Run defconfig files through the C preprocessor") adds `generated_defconfig' file, but fails to clean that up. It might be useful to have that file around after `make' is done, but it's better to clean that up on `make

Re: [PATCH v2] rockchip: load env from boot MMC device

2024-03-08 Thread Quentin Schulz
Hi Ben, On 3/8/24 04:00, Ben Wolsieffer wrote: [Some people who received this message don't often get email from benwolsief...@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Currently, if the environment is stored on an MMC device, the device number

[PATCH 2/2] mmc: stm32_sdmmc2: Fix AARCH64 compilation warnings

2024-03-08 Thread Patrice Chotard
When building with AARCH64 defconfig, we got warnings, fix them. Signed-off-by: Patrice Chotard --- drivers/mmc/stm32_sdmmc2.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/stm32_sdmmc2.c b/drivers/mmc/stm32_sdmmc2.c index d4982a14281..39ae79ba129

[PATCH 1/2] mmc: stm32_sdmmc2: Add "st,stm32mp25-sdmmc2" compatible

2024-03-08 Thread Patrice Chotard
From: Patrick Delaunay Add compatible used for STM32MP25 family. Signed-off-by: Patrick Delaunay Signed-off-by: Patrice Chotard --- drivers/mmc/stm32_sdmmc2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mmc/stm32_sdmmc2.c b/drivers/mmc/stm32_sdmmc2.c index

Re: [PATCH v3 6/6] tee: remove common.h inclusion

2024-03-08 Thread Ilias Apalodimas
On Mon, 4 Mar 2024 at 19:45, Igor Opaniuk wrote: > > The usage of the common.h include file is deprecated [1], and has already > been removed from several files. > Get rid of all inclusions in the "drivers/tee" directory, and replace it > with required include files directly where needed. > > [1]

[PATCH] fdt_support: fix fdt_copy_fixed_partitions function()

2024-03-08 Thread Patrice Chotard
Move variable declaration at the beginning of the function. Fixes: 163c5f60ebb4 ("fdt_support: add fdt_copy_fixed_partitions function") Signed-off-by: Patrice Chotard --- boot/fdt_support.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/boot/fdt_support.c

Re: [PATCH 5/6] arm: fix __efi_runtime_start/end definitions

2024-03-08 Thread Ilias Apalodimas
On Fri, 8 Mar 2024 at 16:14, Ilias Apalodimas wrote: > > On Fri, 8 Mar 2024 at 15:22, Ilias Apalodimas > wrote: > > > > Hi Sam, > > > > On Thu, 7 Mar 2024 at 08:50, Ilias Apalodimas > > wrote: > > > > > > > > > > > > On Thu, 7 Mar 2024 at 00:19, Sam Edwards wrote: > > >> > > >> > > >> > > >>

Re: [PATCH 5/6] arm: fix __efi_runtime_start/end definitions

2024-03-08 Thread Ilias Apalodimas
Hi Sam, On Thu, 7 Mar 2024 at 08:50, Ilias Apalodimas wrote: > > > > On Thu, 7 Mar 2024 at 00:19, Sam Edwards wrote: >> >> >> >> On 3/6/24 02:13, Ilias Apalodimas wrote: >> > Hi Sam, >> > >> > Again thank you for the elaborate review. This really helps a lot. >> > >> > On Wed, 6 Mar 2024 at

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-03-08 Thread Conor Dooley
On Fri, Mar 01, 2024 at 01:54:13PM -0500, Tom Rini wrote: > On Fri, Mar 01, 2024 at 01:32:53PM +, Conor Dooley wrote: > > > > > > > > > On Wed, 28 Feb 2024 at 18:40, Tom Rini > > > > > > > > > wrote: > > > > > > > > > > I think the commit in question can be > > > > > > > > > > summarized as

[PATCH] toradex: tdx-cfg-block: add 0087 i.mx8m mini product variant

2024-03-08 Thread Joao Paulo Goncalves
From: Joao Paulo Goncalves Add new product id 0087 Verdin iMX8M Mini Quad 2GB IT. Signed-off-by: Joao Paulo Goncalves --- board/toradex/common/tdx-cfg-block.c | 1 + board/toradex/common/tdx-cfg-block.h | 1 + 2 files changed, 2 insertions(+) diff --git a/board/toradex/common/tdx-cfg-block.c

[PATCH 2/3] ARM: dts: stm32: Fix partition node name for stm32mp15xx-dhcor-u-boot

2024-03-08 Thread Patrice Chotard
Fix flash@0 partition node name with correct offset. Fixes: 90f992e6a58c ("arm: dts: stm32: Add partitions in flash0 and nand node for stm32mp15xx-dhcom/dhcor") Signed-off-by: Patrice Chotard --- arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 3/3] ARM: dts: stm32: Fix partition node name for stm32mp15xx-dhcom-u-boot

2024-03-08 Thread Patrice Chotard
Fix flash@0 partition node name with correct offset. Fixes: 90f992e6a58c ("arm: dts: stm32: Add partitions in flash0 and nand node for stm32mp15xx-dhcom/dhcor") Signed-off-by: Patrice Chotard --- arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 1/3] ARM: dts: stm32: Fix partition node name for stm32mp157c-ev1-u-boot

2024-03-08 Thread Patrice Chotard
Fix flash@0 and nand@0 partition node name with correct offset. Fixes: e91d3c61767b ("arm: dts: stm32: Add partitions in flash0 and nand node for stm32mp15xx-ev1") Signed-off-by: Patrice Chotard --- arch/arm/dts/stm32mp157c-ev1-u-boot.dtsi | 8 1 file changed, 4 insertions(+), 4

Re: [PATCH 2/2] phy: rockchip-inno-usb2: Limit changes made to regs

2024-03-08 Thread Jonas Karlman
Hi Kever, On 2024-03-08 10:06, Kever Yang wrote: > Hi Jonas, > > On 2024/2/26 06:10, Jonas Karlman wrote: >> The USB2PHY regs already contain working default reset values for RK3328 >> and RK35xx as evidenced by the fact that this driver never has changed a >> single value for these SoCs. > > I

Re: [PATCH v3 0/2] Fix Android A/B backup

2024-03-08 Thread Sam Protsenko
On Fri, Mar 8, 2024 at 11:00 AM Colin McAllister wrote: > > - Addresses compiler error due to missing semicolon > - Removes use of preprocessor macros with ANDROID_AB_BACKUP_OFFSET > > Bug was found by noticing a semicolon was missing and not causing a > compiler error when

Re: [PATCH v3 11/20] rockchip: rk3588: fix non-working SD controller if booting from other media

2024-03-08 Thread Quentin Schulz
Hi Kever, On 3/8/24 11:05, Kever Yang wrote: Hi Quentin, On 2024/2/21 18:37, Quentin Schulz wrote: From: Quentin Schulz Rockchip SoCs have some jtag/sdmmc autoswitching that simply doesn't work really well.[00] The Linux kernel disables it for all SoCs[01], so U-Boot needs to do the same in

Re: [PATCH v2 1/2] arm: socfpga: arria10: add option to reprogram the FPGA every reboot

2024-03-08 Thread Marek Vasut
On 3/8/24 6:12 PM, Michał Barnaś wrote: Add Kconfig that enables FPGA reprogramming with warm boot on Arria 10. This option allows to change the bitstream on the filesystem and apply changes with warm reboot without the need for a power cycle. Signed-off-by: Michał Barnaś --- Changes in v2: -

Re: [PATCH v3 0/2] Fix Android A/B backup

2024-03-08 Thread McAllister, Colin
> Ah, ok, I see you replied to my comment here. Yes, sorry. Outlook is terrible to send inline responses too. I figured just adding responses in the patch contents would be better. Next time I'll submit my patch with a different email :) > So when that config option is not defined at all, the

[PATCH] stv0991: Remove stv0991 board and architecture code

2024-03-08 Thread Tom Rini
This architecture and related board are unmaintained currently and have been for a long time. Remove them. Signed-off-by: Tom Rini --- MAINTAINERS | 7 - arch/arm/Kconfig | 15 -- arch/arm/cpu/armv7/Makefile |

Re: [PATCH v3 1/2] android_ab: Add missing semicolon

2024-03-08 Thread Sam Protsenko
On Fri, Mar 8, 2024 at 11:00 AM Colin McAllister wrote: > > Found a missing semicolon in code protected by a #if that will never > evaluate to true due to a separate issue. Fixing this issue before > addressing the #if. > > Fixes: 3430f24bc6 ("android_ab: Try backup booloader_message") >

Re: [PATCH v3 6/6] tee: remove common.h inclusion

2024-03-08 Thread Sam Protsenko
On Mon, Mar 4, 2024 at 11:46 AM Igor Opaniuk wrote: > > The usage of the common.h include file is deprecated [1], and has already > been removed from several files. > Get rid of all inclusions in the "drivers/tee" directory, and replace it > with required include files directly where needed. > >

[PATCH v3 0/2] Fix Android A/B backup

2024-03-08 Thread Colin McAllister
- Addresses compiler error due to missing semicolon - Removes use of preprocessor macros with ANDROID_AB_BACKUP_OFFSET Bug was found by noticing a semicolon was missing and not causing a compiler error when CONFIG_ANDROID_AB_BACKUP_OFFSET was set. I submitted a patch to fix the semicolon before

[PATCH v3 1/2] android_ab: Add missing semicolon

2024-03-08 Thread Colin McAllister
Found a missing semicolon in code protected by a #if that will never evaluate to true due to a separate issue. Fixing this issue before addressing the #if. Fixes: 3430f24bc6 ("android_ab: Try backup booloader_message") Signed-off-by: Colin McAllister Cc: Joshua Watt Cc: Simon Glass --- v2: No

[PATCH v3 2/2] android_ab: Fix ANDROID_AB_BACKUP_OFFSET

2024-03-08 Thread Colin McAllister
Currently, setting CONFIG_AB_BACKUP_OFFSET in a target's defconfig will not actually enable the #if protected code in android_ab.c. This is because "CONFIG_" should have been prepended to the config macro, or the macros defined in kconfig.h could have been used. The code included by

[PATCH v2 0/2] arm: socfpga: arria10: allow to reprogram FPGA with warm reboot

2024-03-08 Thread Michał Barnaś
By default, the board requires power cycle (cold boot) to program the FPGA with bitstream. This change adds Kconfig that allows to enable reprogramming the FPGA with every boot. This makes the update process of the bitstream on the filesystem to be applied with simple system reboot. Changes in

[PATCH v2 1/2] arm: socfpga: arria10: add option to reprogram the FPGA every reboot

2024-03-08 Thread Michał Barnaś
Add Kconfig that enables FPGA reprogramming with warm boot on Arria 10. This option allows to change the bitstream on the filesystem and apply changes with warm reboot without the need for a power cycle. Signed-off-by: Michał Barnaś --- Changes in v2: - Rebase on current master branch

[PATCH v2 2/2] chameleonv3: set in defconfig for FPGA to reprogram every reboot

2024-03-08 Thread Michał Barnaś
Set CONFIG_TARGET_SOCFPGA_ARRIA10_ALWAYS_REPROGRAM as enabled in chameleon v3 board's defconfig. Signed-off-by: Michał Barnaś --- (no changes since v1) configs/socfpga_chameleonv3_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/socfpga_chameleonv3_defconfig

Re: [PATCH 0/3] Fix driver for misc/atsha204a

2024-03-08 Thread Michał Barnaś
Thank you very much! On Tue, Mar 5, 2024 at 2:17 PM Tom Rini wrote: > > On Mon, 19 Feb 2024 16:32:01 +, Michał Barnaś wrote: > > > Fix the driver to behave like the chip datasheet requires. > > Improve wake up function to send low signal on SDA line for at least > > 60us as chip requires to

Re: [PATCH v3 2/2] android_ab: Fix ANDROID_AB_BACKUP_OFFSET

2024-03-08 Thread Sam Protsenko
On Fri, Mar 8, 2024 at 11:50 AM Sam Protsenko wrote: > > On Fri, Mar 8, 2024 at 11:00 AM Colin McAllister > wrote: > > > > Currently, setting CONFIG_AB_BACKUP_OFFSET in a target's defconfig will > > not actually enable the #if protected code in android_ab.c. This is > > because "CONFIG_" should

[PATCH 2/2] clk: clk-imx8qm: Add LPUART IPG entries

2024-03-08 Thread Fabio Estevam
Since commit cc7df0b9e8bc ("serial: lpuart: Enable IPG clock") the apalis-imx8qm board no longer boots. The reason is that the imx8qm clock driver does not handle the LPUART IPG clocks inside get_rate(), set_rate() and enable() functions. Fix the boot regression by adding the LPUART IPG

[PATCH 1/2] clk: clk-imx8qxp: Add LPUART IPG entries

2024-03-08 Thread Fabio Estevam
Since commit cc7df0b9e8bc ("serial: lpuart: Enable IPG clock") the colibri-imx8qxp board no longer boots. The reason is that the imx8qxp clock driver does not handle the LPUART IPG clocks inside get_rate(), set_rate() and enable() functions. Fix the boot regression by adding the LPUART IPG

Re: [PATCH v3 2/2] android_ab: Fix ANDROID_AB_BACKUP_OFFSET

2024-03-08 Thread Sam Protsenko
On Fri, Mar 8, 2024 at 11:00 AM Colin McAllister wrote: > > Currently, setting CONFIG_AB_BACKUP_OFFSET in a target's defconfig will > not actually enable the #if protected code in android_ab.c. This is > because "CONFIG_" should have been prepended to the config macro, or the > macros defined in

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-03-08 Thread Tom Rini
On Fri, Mar 08, 2024 at 01:21:15PM +, Conor Dooley wrote: > On Fri, Mar 01, 2024 at 01:54:13PM -0500, Tom Rini wrote: > > On Fri, Mar 01, 2024 at 01:32:53PM +, Conor Dooley wrote: > > > > > > > > > > On Wed, 28 Feb 2024 at 18:40, Tom Rini > > > > > > > > > > wrote: > > > > > > > > > > >

Re: [RFC 5/5] doc: describe Milk-V Mars board

2024-03-08 Thread E Shattow
Yes this reference to GPIO high/low states is clearer to understand. Have you tested the DIP switch functionality to confirm?; It is not shown in the MilkV documentation or outdated schematics and I don't have a Mars to test. I did find function descriptions from what is likely cut-and-paste of

Re: [PATCH v3 0/2] Fix Android A/B backup

2024-03-08 Thread Sam Protsenko
On Fri, Mar 8, 2024 at 1:24 PM McAllister, Colin wrote: > > > Ah, ok, I see you replied to my comment here. > > Yes, sorry. Outlook is terrible to send inline responses too. I figured > just adding responses in the patch contents would be better. Next time I'll > submit > my patch with a

Re: [PATCH 1/2] arm64: Reduce add_map() complexity

2024-03-08 Thread Fabio Estevam
Hi Paul and Tom, On Tue, Feb 14, 2023 at 10:38 AM Ying-Chun Liu (PaulLiu) wrote: > > From: Marc Zyngier > > In the add_map() function, for each level it populates, it iterates from > the root of the PT tree, making it ineficient if a mapping needs to occur > past level 1. > > Instead, replace

Re: [RFC 5/5] doc: describe Milk-V Mars board

2024-03-08 Thread Heinrich Schuchardt
On 3/8/24 22:48, E Shattow wrote: Yes this reference to GPIO high/low states is clearer to understand. Have you tested the DIP switch functionality to confirm?; It is not shown in the MilkV documentation or outdated schematics and I don't have a Mars to test. I did find function descriptions

Re: [RFC 2/5] riscv: set fdtfile on Milk-V Mars

2024-03-08 Thread Heinrich Schuchardt
On 3/8/24 23:37, E Shattow wrote: Sharing the info from Mars CM Lite 4GB: EEPROM INFO Vendor : MILK-V Product full SN: MARC-V10-2340-D004E016-06DF data version: 0x2 PCB revision: 0xc1 BOM revision: A Ethernet MAC0 address: 6c:cf:39:00:83:11 Ethernet MAC1 address:

Re: [RFC 2/5] riscv: set fdtfile on Milk-V Mars

2024-03-08 Thread E Shattow
Sharing the info from Mars CM Lite 4GB: EEPROM INFO Vendor : MILK-V Product full SN: MARC-V10-2340-D004E016-06DF data version: 0x2 PCB revision: 0xc1 BOM revision: A Ethernet MAC0 address: 6c:cf:39:00:83:11 Ethernet MAC1 address: 6c:cf:39:00:83:12 EEPROM INFO I

[PATCH 11/11] net: dwc_eth_qos: Add support of STM32MP13xx platform

2024-03-08 Thread Marek Vasut
From: Christophe Roullier Add compatible "st,stm32mp13-dwmac" to manage STM32MP13 boards. Signed-off-by: Christophe Roullier Signed-off-by: Marek Vasut # Rebase, reshuffle, squash code --- Cc: Christophe Roullier Cc: Joe Hershberger Cc: Patrice Chotard Cc: Patrick Delaunay Cc: Ramon Fried

[PATCH 10/11] net: dwc_eth_qos: Add DT parsing for STM32MP13xx platform

2024-03-08 Thread Marek Vasut
From: Christophe Roullier Manage 2 ethernet instances, select which instance to configure with mask If mask is not present in DT, it is stm32mp15 platform. Signed-off-by: Christophe Roullier Signed-off-by: Marek Vasut # Rework the code --- Cc: Christophe Roullier Cc: Joe Hershberger Cc:

RE: [PATCH 2/2] clk: clk-imx8qm: Add LPUART IPG entries

2024-03-08 Thread Peng Fan
> Subject: [PATCH 2/2] clk: clk-imx8qm: Add LPUART IPG entries > > Since commit cc7df0b9e8bc ("serial: lpuart: Enable IPG clock") the apalis- > imx8qm board no longer boots. > > The reason is that the imx8qm clock driver does not handle the LPUART IPG > clocks inside get_rate(), set_rate() and

[PATCH 01/11] net: dwc_eth_qos: Split STM32 glue into separate file

2024-03-08 Thread Marek Vasut
Move STM32 glue code into separate file to contain the STM32 specific code outside of the DWMAC core code. No functional change. Signed-off-by: Marek Vasut --- Cc: Christophe Roullier Cc: Joe Hershberger Cc: Patrice Chotard Cc: Patrick Delaunay Cc: Ramon Fried Cc: u-b...@dh-electronics.com

[PATCH 00/11] net: dwc_eth_qos: Clean up STM32 glue code and add STM32MP13xx support

2024-03-08 Thread Marek Vasut
Split off STM32 glue code from the DWMAC driver into separate file, similar to what other SoCs already do, to avoid mixing the ST specifics with generic DWMAC core code. Clean the STM32 DWMAC board code which is currently duplicated in multiple board files, move it into the newly separated glue

RE: [PATCH 1/2] clk: clk-imx8qxp: Add LPUART IPG entries

2024-03-08 Thread Peng Fan
> Subject: [PATCH 1/2] clk: clk-imx8qxp: Add LPUART IPG entries > > Since commit cc7df0b9e8bc ("serial: lpuart: Enable IPG clock") the colibri- > imx8qxp board no longer boots. > > The reason is that the imx8qxp clock driver does not handle the LPUART IPG > clocks inside get_rate(), set_rate()

[PATCH 07/11] net: dwc_eth_qos: Use consistent logging prints

2024-03-08 Thread Marek Vasut
Use dev_*() only to print all the logs from this glue code, instead of mixing dev_*(), log_*(), pr_*() all in one code. Signed-off-by: Marek Vasut --- Cc: Christophe Roullier Cc: Joe Hershberger Cc: Patrice Chotard Cc: Patrick Delaunay Cc: Ramon Fried Cc: u-b...@dh-electronics.com Cc:

[PATCH 03/11] net: dwc_eth_qos: Fold board_interface_eth_init into STM32 glue code

2024-03-08 Thread Marek Vasut
Move board_interface_eth_init() into eqos_probe_syscfg_stm32() in STM32 driver glue code. The eqos_probe_syscfg_stm32() parses STM32 specific DT properties of this MAC and configures SYSCFG registers accordingly, there is nothing board specific happening in this function, move it into generic

[PATCH 08/11] net: dwc_eth_qos: Constify st, eth-* values parsed out of DT

2024-03-08 Thread Marek Vasut
Use const bool for the values parsed out of DT. Drop the duplicate assignment of false into those bool variables, assign them directly with the content parsed out of DT. Abbreviate the variable name too. Signed-off-by: Marek Vasut --- Cc: Christophe Roullier Cc: Joe Hershberger Cc: Patrice

[PATCH 05/11] net: dwc_eth_qos: Use FIELD_PREP for ETH_SEL bitfield

2024-03-08 Thread Marek Vasut
Use FIELD_PREP to configure content of ETH_SEL bitfield in SYSCFG_PMCSETR register. No functional change. Signed-off-by: Marek Vasut --- Cc: Christophe Roullier Cc: Joe Hershberger Cc: Patrice Chotard Cc: Patrick Delaunay Cc: Ramon Fried Cc: u-b...@dh-electronics.com Cc:

[PATCH 02/11] net: dwc_eth_qos: Rename eqos_stm32_config to eqos_stm32mp15_config

2024-03-08 Thread Marek Vasut
The current glue code is specific to STM32MP15xx, the upcoming STM32MP13xx will introduce another entry specific to the STM32MP13xx. Rename the current entry to eqos_stm32mp15_config in preparation for STM32MP13xx addition. No functional change. Signed-off-by: Marek Vasut --- Cc: Christophe

[PATCH 04/11] net: dwc_eth_qos: Scrub ifdeffery

2024-03-08 Thread Marek Vasut
Replace ifdef CONFIG_CLK with if (CONFIG_IS_ENABLED(CLK)) to improve code build coverage. Some of the functions printed debug("%s: OK\n", __func__); on exit with and without CLK enabled, some did not, make it consistent and print nothing if CLK is disabled. Signed-off-by: Marek Vasut --- Cc:

[PATCH 06/11] net: dwc_eth_qos: Move log_debug statements on top of case block

2024-03-08 Thread Marek Vasut
Move the log_debug() calls on top of the bit manipulation code. No functional change. Signed-off-by: Marek Vasut --- Cc: Christophe Roullier Cc: Joe Hershberger Cc: Patrice Chotard Cc: Patrick Delaunay Cc: Ramon Fried Cc: u-b...@dh-electronics.com Cc:

[PATCH 09/11] net: dwc_eth_qos: Request clk-ck earlier in probe on STM32

2024-03-08 Thread Marek Vasut
From: Patrick Delaunay Request the clk-ck earlier in probe in preparation for obtaining the clock rate from these clk-ck in eqos_probe_syscfg_stm32() in the follow up patch. Signed-off-by: Patrick Delaunay --- Cc: Christophe Roullier Cc: Joe Hershberger Cc: Patrice Chotard Cc: Patrick