RE: [EXT] [PATCH v5 1/2] board: kontron: add sl28 support

2020-08-26 Thread Kuldeep Singh
> +/* environment */ > +/* allow to overwrite serial and ethaddr */ #define > +CONFIG_ENV_OVERWRITE [...] Hi Michael, CONFIG_ENV_OVERWRITE is now converted to Kconfig option and has been moved to defconfigs. Adam Ford has a patch doing that and is available in latest master. -Kuldeep

RE: [EXT] [PATCH] armv8: lx2162aqds: Add support for LX2162AQDS platform

2020-08-26 Thread Kuldeep Singh
Hi Meenakshi, [..] > This patch add base support for LX2162 QDS board. > LX2162 is LX2160 based SoC, it has same die as of LX2160 > with different packaging. > Board support's 4GB ddr memory, i2c, micro-click module, microSD card, > serial console, qspi nor flash, qsgmii, sgmii, 25g, 40g, 50g netw

[PATCH 1/2] net: pfe_eth: Fix resoure leak in pfe_spi_flash_init

2020-09-11 Thread Kuldeep Singh
Fix Coverity issue: RESOURCE_LEAK. leaked_storage: Variable addr going out of scope leaks the storage it points to. Fixes: e0152dbed683 ("net: pfe_eth: Use spi_flash_read API to access flash memory") Signed-off-by: Kuldeep Singh --- drivers/net/pfe_eth/pfe_firmware.c | 4 1 file

[PATCH 2/2] net: pfe_eth: Remove non-DM code check from pfe_spi_flash_init

2020-09-11 Thread Kuldeep Singh
ff-by: Kuldeep Singh --- drivers/net/pfe_eth/pfe_firmware.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/net/pfe_eth/pfe_firmware.c b/drivers/net/pfe_eth/pfe_firmware.c index 4ad09dd..d414c75 100644 --- a/drivers/net/pfe_eth/pfe_firmware.c +++ b/driver

[PATCH 1/2] spi: nxp-fspi: Add support for IP read only

2021-03-21 Thread Kuldeep Singh
Add support for disabling AHB bus and read entire flash contents via IP bus only. Please note, this enables IP bus read using a quirk which can be enabled directly in device-type data or in existence of an errata where AHB bus may need to be disabled. Signed-off-by: Kuldeep Singh --- drivers

[PATCH 2/2] spi: nxp_fspi: Implement errata workaround for LS1028A

2021-03-21 Thread Kuldeep Singh
use IP bus to read entire flash contents and disable AHB path when platform frequency is 300Mhz. Signed-off-by: Kuldeep Singh --- drivers/spi/nxp_fspi.c | 49 +- 1 file changed, 44 insertions(+), 5 deletions(-) diff --git a/drivers/spi/nxp_fspi.c b/d

RE: [PATCH 2/2] spi: nxp_fspi: Implement errata workaround for LS1028A

2021-03-21 Thread Kuldeep Singh
+ Ye Li > -Original Message- > From: Kuldeep Singh > Sent: Monday, March 22, 2021 12:00 PM > To: Jagan Teki ; u-boot@lists.denx.de > Cc: Kuldeep Singh > Subject: [PATCH 2/2] spi: nxp_fspi: Implement errata workaround for LS1028A > > Errata ERR050568 description

[PATCH 2/2] configs: ls1012a: Update CONFIG_ENV_SIZE

2020-04-29 Thread Kuldeep Singh
From: Ashish Kumar ENV_SIZE value 0x4 is incorrect. Update to 0x2000 and make it align with other boards environemt size for all variants of LS1012A. Signed-off-by: Kuldeep Singh Signed-off-by: Ashish Kumar --- configs/ls1012a2g5rdb_qspi_defconfig | 2 +- configs

[PATCH 1/2] configs: ls1012a: Increase SYS_MALLOC_LEN size

2020-04-29 Thread Kuldeep Singh
CONFIG_SYS_MALLOC_LEN is currently set to low value and leaves very less space for QSPI environmet. Increase the value and also make it align with other boards(ls1046a, ls1043a etc.) value. Signed-off-by: Kuldeep Singh --- include/configs/ls1012a_common.h | 2 +- 1 file changed, 1 insertion

[PATCH 1/4] configs: ls1012a: Increase CONFIG_SYS_MALLOC_LEN size

2020-05-05 Thread Kuldeep Singh
CONFIG_SYS_MALLOC_LEN is currently set to low value and leaves very less space to do malloc in flash environmet. Increase the value to get more memory and also make it align with other boards(ls1046a, ls1043a etc.) config values. Signed-off-by: Kuldeep Singh --- include/configs/ls1012a_common.h

[PATCH 3/4] configs: nxp: Enable CONFIG_SYS_RELOC_GD_ENV_ADDR

2020-05-05 Thread Kuldeep Singh
ting crash observed in flash environment. Signed-off-by: Kuldeep Singh --- configs/ls1012afrwy_qspi_defconfig | 1 + configs/ls1012afrwy_tfa_defconfig | 1 + configs/ls1046afrwy_tfa_defconfig | 1 + configs/ls1046ardb_tfa_defconfig | 1 + configs/ls2088aqds_tfa_defconfig | 1

[PATCH 0/4] QSPI bugfixes of NXP layerscape platforms

2020-05-05 Thread Kuldeep Singh
0x2000 Kuldeep Singh (3): configs: ls1012a: Increase CONFIG_SYS_MALLOC_LEN size configs: nxp: Enable CONFIG_SYS_RELOC_GD_ENV_ADDR configs: ls1012a: Unset ENV_ADDR value configs/ls1012a2g5rdb_qspi_defconfig | 2 +- configs/ls1012a2g5rdb_tfa_defconfig| 2 +- configs

[PATCH 2/4] configs: ls1012a: Reduce CONFIG_ENV_SIZE to 0x2000

2020-05-05 Thread Kuldeep Singh
CONFIG_ENV_SIZE value to 0x2000. This also helps in making config value aligned with other boards environemt size. Signed-off-by: Kuldeep Singh Signed-off-by: Ashish Kumar --- configs/ls1012a2g5rdb_qspi_defconfig | 2 +- configs/ls1012a2g5rdb_tfa_defconfig| 2 +- configs

[PATCH 4/4] configs: ls1012a: Unset ENV_ADDR value

2020-05-05 Thread Kuldeep Singh
06 elr: 820452c0 lr : 82013f54 (reloc) elr: b7b932c0 lr : b7b61f54 x0 : x1 : 7604e004 x2 : 0001 x3 : ... Code: 5480 9100c000 17f7 f9402241 (3860c820) Resetting CPU ... Signed-off-b

RE: [PATCH] configs: ls1046a: Define ENV_ADDR value

2020-05-11 Thread Kuldeep Singh
> -Original Message- > From: Priyanka Jain (OSS) > Sent: Tuesday, May 12, 2020 11:12 AM > To: Kuldeep Singh ; u-boot@lists.denx.de > Subject: RE: [PATCH] configs: ls1046a: Define ENV_ADDR value > > >-Original Message- > >From: U-Boot On B

[Patch v2] configs: ls1046a: Define ENV_ADDR value

2020-05-12 Thread Kuldeep Singh
V_ADDR and ENV_SECT_SIZE value for QSPI and TFA defconfigs of the board. Signed-off-by: Kuldeep Singh --- v2: - Reword commit message as per Priyanka's comments. - Rebase to top configs/ls1046aqds_qspi_defconfig | 1 + configs/ls1046aqds_tfa_defconfig | 4 ++-- configs/ls1046ardb_qspi_def

RE: [EXT] Re: [Patch v4] net: pfe_eth: Use spi_flash_read API to access flash memory

2020-03-17 Thread Kuldeep Singh
Ping. > -Original Message- > From: Kuldeep Singh > Sent: Thursday, January 23, 2020 12:43 PM > To: Joe Hershberger ; u-boot@lists.denx.de > Cc: Thomas Hebb ; Patrick Delaunay > ; Priyanka Jain ; > Schrempf Frieder > Subject: RE: [EXT] Re: [Patch v4] net: pfe_eth

[Patch v3 1/2] configs: ls2080ardb: Make MC_INIT access flash memory as per spi-mem

2020-03-17 Thread Kuldeep Singh
MC_INIT command currently access spi-nor flash memory directly. As per spi-mem framework, flash memory access via absolute addresses is no more possible. Use flash APIs to access memory instead of directly using it. Signed-off-by: Kuldeep Singh --- v3: -Use complete MC size, 1M works but MC has

[Patch v3 2/2] configs: ls2080ardb: Make BOOT command access flash memory as per spi-mem

2020-03-17 Thread Kuldeep Singh
BOOT command currently access spi-nor flash memory directly. As per spi-mem framework, flash memory access via absolute addresses is no more possible. Use flash APIs to access memory instead of directly using it. Signed-off-by: Kuldeep Singh --- v3: -Rebase v2: -Rebase to top -Reword commit

RE: [Patch v3 2/2] configs: ls2080ardb: Make BOOT command access flash memory as per spi-mem

2020-03-18 Thread Kuldeep Singh
> -Original Message- > From: Priyanka Jain (OSS) > Sent: Wednesday, March 18, 2020 4:03 PM > To: Kuldeep Singh ; u-boot@lists.denx.de > Cc: Kuldeep Singh > Subject: RE: [Patch v3 2/2] configs: ls2080ardb: Make BOOT command > access flash memory as per spi-me

RE: [RESEND Patch v2] configs: lx2160a: Enable FSPI support

2020-03-18 Thread Kuldeep Singh
> -Original Message- > From: Priyanka Jain (OSS) > Sent: Wednesday, March 18, 2020 4:22 PM > To: Kuldeep Singh ; u-boot@lists.denx.de > Cc: Kuldeep Singh > Subject: RE: [RESEND Patch v2] configs: lx2160a: Enable FSPI support > > >-Original Message-

RE: [RESEND Patch v2] configs: lx2160a: Enable FSPI support

2020-03-18 Thread Kuldeep Singh
> -Original Message- > From: Kuldeep Singh > Sent: Wednesday, March 18, 2020 5:15 PM > To: Priyanka Jain (OSS) ; u-boot@lists.denx.de > Subject: RE: [RESEND Patch v2] configs: lx2160a: Enable FSPI support > > > > > -Original Message- > >

[PATCH] configs: ls2088ardb: Correct DEFAULT_DEVICE_TREE value

2020-03-19 Thread Kuldeep Singh
LS2088A-RDB has CONFIG_DEFAULT_DEVICE_TREE value correctly set as "fsl-ls2088a-rdb-qspi" for QSPI secure/non-secure boot and TFA non-secure boot mode. Fix the value for TFA secure boot mode. Signed-off-by: Kuldeep Singh --- configs/ls2088ardb_tfa_SECURE_BOOT_defconfig | 2 +- 1 file

RE: [EXT] [PATCH] mtd: spi-nor-core: call WATCHDOG_RESET() in spi_nor_ready()

2020-03-19 Thread Kuldeep Singh
Hi Vignesh, > -Original Message- > From: U-Boot On Behalf Of Rasmus > Villemoes > Sent: Tuesday, March 17, 2020 1:49 AM > To: u-boot@lists.denx.de > Cc: Jagan Teki ; Vignesh R > ; Rasmus Villemoes > Subject: [EXT] [PATCH] mtd: spi-nor-core: call WATCHDOG_RESET() in > spi_nor_ready() > >

RE: [Patch v5 1/7] spi: Transform the FSL QuadSPI driver to use the SPI MEM API

2020-03-22 Thread Kuldeep Singh
> -Original Message- > From: Kuldeep Singh > Sent: Thursday, February 20, 2020 10:58 PM > To: u-boot@lists.denx.de > Cc: Frieder Schrempf ; Stefan Roese > ; Priyanka Jain ; Jagan Teki > ; Stefano Babic ; Fabio > Estevam ; Vignesh Raghavendra ; > K

[PATCH] mtd: spi-nor-ids: Add Spansion s25fs512s flash entry

2020-04-02 Thread Kuldeep Singh
2s", INFO6(0x010220, 0x4d0081, 256 * 1024, 256...}, Signed-off-by: Kuldeep Singh --- drivers/mtd/spi/spi-nor-ids.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c index 973b6f8..42baa84 100644 --- a/drivers

[PATCH] configs: ls1088a: Enable CONFIG_SYS_RELOC_ENV_ADDR

2021-05-19 Thread Kuldeep Singh
Signed-off-by: Kuldeep Singh --- configs/ls1088aqds_tfa_defconfig | 1 + configs/ls1088ardb_tfa_defconfig | 1 + 2 files changed, 2 insertions(+) diff --git a/configs/ls1088aqds_tfa_defconfig b/configs/ls1088aqds_tfa_defconfig index 5229a351e1..ea308cafef 100644 --- a/configs

RE: [EXT] Re: [PATCH 2/2] spi: nxp_fspi: Implement errata workaround for LS1028A

2021-06-16 Thread Kuldeep Singh
Hi Stefano, > -Original Message- > From: Jagan Teki > Sent: Monday, April 19, 2021 12:17 PM > To: Kuldeep Singh > Cc: U-Boot-Denx > Subject: [EXT] Re: [PATCH 2/2] spi: nxp_fspi: Implement errata workaround for > LS1028A > > Caution: EXT Email > >

[PATCH] configs: ls1043aqds: Configure environment related configs

2021-07-06 Thread Kuldeep Singh
LS1043A-QDS board requires updation in few environment configs in TFA and QSPI defconfigs. Following are the changes: - Define CONFIG_ENV_ADDR - Unset CONFIG_SPI_FLASH_BAR - Enable CONFIG_SYS_RELOC_GD_ENV_ADDR Signed-off-by: Kuldeep Singh --- configs/ls1043aqds_qspi_defconfig| 1

[PATCH] lx2160a: Enable CONFIG_SPI_FLASH_MT35XU for lx2160a-rdb/qds

2021-07-28 Thread Kuldeep Singh
LX2160A-RDB/QDS has micron mt35xu512aba flash which requires flag CONFIG_SPI_FLASH_MT35XU on to probe flash successfully. Signed-off-by: Kuldeep Singh --- configs/lx2160aqds_tfa_SECURE_BOOT_defconfig | 1 + configs/lx2160aqds_tfa_defconfig | 1 + configs

[PATCH 0/5] Flexspi cleanups for ls1028a and lx2160a

2021-03-03 Thread Kuldeep Singh
This patch series aim is to make fspi cleanups for ls1028a and lx2160a. This includes defconfig and header cleanups. Kuldeep Singh (5): configs: lx2160a: Unset CONFIG_SPI_FLASH_SPANSION configs: lx2160a: Remove unused Flexspi config options configs: ls1028a: Unset CONFIG_SPI_FLASH_SPANSION

[PATCH 1/5] configs: lx2160a: Unset CONFIG_SPI_FLASH_SPANSION

2021-03-03 Thread Kuldeep Singh
There is no Spansion flash on LX2160A-RDB/QDS boards. Unset CONFIG_SPI_FLASH_SPANSION option for both the boards. Signed-off-by: Kuldeep Singh --- configs/lx2160aqds_tfa_SECURE_BOOT_defconfig | 1 - configs/lx2160aqds_tfa_defconfig | 1 - configs/lx2160ardb_tfa_SECURE_BOOT_defconfig

[PATCH 2/5] configs: lx2160a: Remove unused Flexspi config options

2021-03-03 Thread Kuldeep Singh
It is now safe to remove Flexspi configs NXP_FSPI_FLASH_SIZE and NXP_FSPI_FLASH_NUM options from headers as they are no longer used by driver anymore. Signed-off-by: Kuldeep Singh --- include/configs/lx2160a_common.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/include/configs

[PATCH 5/5] configs: ls1028a: Correct CONFIG_ENV_SECT_SIZE

2021-03-03 Thread Kuldeep Singh
LS1028A-RDB/QDS has Micron "mt35xu02g" nor flash of size 256M with 128K sector size. Correct CONFIG_ENV_SECT_SIZE value to 128K. Signed-off-by: Kuldeep Singh --- configs/ls1028aqds_tfa_defconfig| 2 +- configs/ls1028aqds_tfa_lpuart_defconfig | 2 +- configs/ls1028ardb_tfa

[PATCH 4/5] configs: ls1028aqds: Move CONFIG_SPI_FLASH_* definitions to defconfig

2021-03-03 Thread Kuldeep Singh
LS1028A-QDS has CONFIG_SPI_FLASH_SST and CONFIG_SPI_FLASH_EON defines present in header. Move these entries from header to defconfigs. Signed-off-by: Kuldeep Singh --- configs/ls1028aqds_tfa_SECURE_BOOT_defconfig | 2 ++ configs/ls1028aqds_tfa_defconfig | 2 ++ configs

[PATCH 3/5] configs: ls1028a: Unset CONFIG_SPI_FLASH_SPANSION

2021-03-03 Thread Kuldeep Singh
There is no Spansion flash on LS1028A-RDB/QDS boards. Unset CONFIG_SPI_FLASH_SPANSION option for both the boards. Signed-off-by: Kuldeep Singh --- configs/ls1028aqds_tfa_SECURE_BOOT_defconfig | 1 - configs/ls1028aqds_tfa_defconfig | 1 - configs/ls1028aqds_tfa_lpuart_defconfig

[PATCH] configs: ls1012a/ls1046a: Define CONFIG_ENV_OVERWRITE

2020-06-30 Thread Kuldeep Singh
; variable. Before the change: => setenv ethaddr 00:E0:0C:00:06:0 => setenv ethaddr 00:E0:0C:00:06:1 Error: Can't overwrite "ethaddr" Error inserting "ethaddr" variable, errno=1 After the change: => setenv ethaddr 00:E0:0C:00:06:0 => setenv ethaddr 0

RE: [PATCH] configs: ls1012a/ls1046a: Define CONFIG_ENV_OVERWRITE

2020-07-21 Thread Kuldeep Singh
> -Original Message- > From: Priyanka Jain (OSS) > Sent: Tuesday, July 21, 2020 2:49 PM > To: Kuldeep Singh ; u-boot@lists.denx.de > Cc: Kuldeep Singh > Subject: RE: [PATCH] configs: ls1012a/ls1046a: Define > CONFIG_ENV_OVERWRITE > > >-Original Me

RE: [PATCH] configs: ls1012a/ls1046a: Define CONFIG_ENV_OVERWRITE

2020-07-21 Thread Kuldeep Singh
> > Can you please check if this change can go into defconfig file, > > instead of adding here? > > This will require conversion of CONFIG_ENV_OVERWRITE to Kconfig option > to add and entry in defconfig. With little search, I found Adam Ford's patch[1] which convert CONFIG_ENV_OVERWRITE to Kconf

RE: [EXT] Re: [Patch v4 4/7] imx: imx6sx: Remove unused 'num-cs' property

2020-02-20 Thread Kuldeep Singh
Hi Fabio, > -Original Message- > From: Fabio Estevam > Sent: Wednesday, February 19, 2020 6:31 PM > To: Priyanka Jain (OSS) > Cc: Kuldeep Singh ; u-boot@lists.denx.de; > Stefano Babic ; s...@denx.de > Subject: [EXT] Re: [Patch v4 4/7] imx: imx6sx: Remove unuse

RE: [EXT] Re: [Patch v4 0/7] Transition of fsl qspi driver to spi-mem framework

2020-02-20 Thread Kuldeep Singh
Hi, > -Original Message- > From: U-Boot On Behalf Of Kuldeep Singh > Sent: Tuesday, February 4, 2020 1:09 PM > To: Jagan Teki ; U-Boot-Denx b...@lists.denx.de>; Priyanka Jain ; Joe > Hershberger > Cc: Stefan Roese > Subject: RE: [EXT] Re: [Patch v4 0/7] Trans

[Patch v5 0/7] Transition of fsl qspi driver to spi-mem framework

2020-02-20 Thread Kuldeep Singh
ommit messages. Patch[1] is required to resolve booting crash observed in LS1012ARDB. Crash was related to pfe driver as it was accessing flash memory directly. [1] https://patchwork.ozlabs.org/patch/1219462/ Kuldeep Singh (7): spi: Transform the FSL QuadSPI driver to use the SPI MEM API treewide: R

[Patch v5 3/7] treewide: Remove unused FSL QSPI config options for IMX platforms

2020-02-20 Thread Kuldeep Singh
Some of these options are not used by the driver anymore and some of them are obsolete as the information is gathered from the dt. So, remove the unused config options now. Signed-off-by: Frieder Schrempf Signed-off-by: Ashish Kumar Signed-off-by: Kuldeep Singh --- v5: New patch. Only imx

[Patch v5 4/7] configs: ls1043a: Move CONFIG_FSL_QSPI and SPI_FLASH_SPANSION to defconfig

2020-02-20 Thread Kuldeep Singh
Move CONFIG_FSL_QSPI to the board defconfigs and while at it also move CONFIG_SPI_FLASH_SPANSION for LS1043AQDS. Signed-off-by: Frieder Schrempf Signed-off-by: Kuldeep Singh --- v5: No change v4: Move SPI_FLASH_SPANSION to defconfig v3: no change v2: No change configs

[Patch v5 1/7] spi: Transform the FSL QuadSPI driver to use the SPI MEM API

2020-02-20 Thread Kuldeep Singh
. Currently tested on LS1088ARDB, LS1012ARDB, LS1046ARDB, LS1046AFRWY, LS1043AQDS, LS1021ATWR, LS2088ARDB, I.MX6ULL EVK. Signed-off-by: Frieder Schrempf Signed-off-by: Ashish Kumar Signed-off-by: Kuldeep Singh Reviewed-by: Stefan Roese Tested-by: Stefan Roese Acked-by: Vignesh Raghavendra --- v5

[Patch v5 6/7] configs: ls1046a: Move SPI_FLASH_SPANSION to defconfig

2020-02-20 Thread Kuldeep Singh
Enable CONFIG_SPI_FLASH_SPANSION in defconfigs of LS1046ARDB and LS1046AQDS which have two spansion flases i.e s25fs512s each of size 64M. Signed-off-by: Kuldeep Singh --- v5: No change v4: No change v3: No change v2: No change configs/ls1046aqds_qspi_defconfig | 1 + configs

[Patch v5 2/7] treewide: Remove unused FSL QSPI config options for Layerscape platforms

2020-02-20 Thread Kuldeep Singh
Some of these options are not used by the driver anymore and some of them are obsolete as the information is gathered from the dt. Also consolidating defines in common headers. Signed-off-by: Frieder Schrempf Signed-off-by: Ashish Kumar Signed-off-by: Kuldeep Singh --- v5: Keep only layerscape

[Patch v5 5/7] configs: ls1012a: Enable CONFIG_SPI_FLASH_SPANSION in defconfigs

2020-02-20 Thread Kuldeep Singh
Since CONFIG_FSL_QSPI is already enabled for LS1012A in defconfigs. Also enable CONFIG_SPI_FLASH_SPANSION for LS1012A boards having spansion flashes. Signed-off-by: Ashish Kumar Signed-off-by: Kuldeep Singh --- v5: No change v4: Reword commit message. Add "in defconfigs" v3: Rew

[Patch v5 7/7] treewide: Update fsl qspi node dt properties as per spi-mem driver

2020-02-20 Thread Kuldeep Singh
ies. Also consolidate spi-max-frequency to 50Mhz treewide. Signed-off-by: Kuldeep Singh --- v5: No change v4: No change v3: No change v2: No change arch/arm/dts/fsl-ls1012a-2g5rdb.dts | 5 ++--- arch/arm/dts/fsl-ls1012a-frdm.dtsi| 5 ++--- arch/arm/dts/fsl-ls1012a-qds.dtsi | 5 ++--- ar

[PATCH] spi: nxp-fspi: Add 1us delay to make controller ready for next transaction

2020-02-24 Thread Kuldeep Singh
-boot poll_timeout API lacks delay functionality, add 1us delay so as to make controller ready for other transactions. Signed-off-by: Kuldeep Singh --- drivers/spi/nxp_fspi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/nxp_fspi.c b/drivers/spi/nxp_fspi.c index 0e6c7be..9703642

[Patch v2] arm: dts: lx2160aqds: Add FSPI node properties

2020-03-02 Thread Kuldeep Singh
lx2160a-qds has 2 micron "mt35xu512aba" flashes of size 64M each connected on A0 and B1 i.e on CS0 and CS3. Since flashes are connected on different buses, only one flash can be probed at a time. Add fspi node properties aligned with LX2160A-RDB fspi properties. Signed-off-by: Kul

RE: [Patch v5 1/7] spi: Transform the FSL QuadSPI driver to use the SPI MEM API

2020-03-03 Thread Kuldeep Singh
Hi Jagan, > -Original Message- > From: Kuldeep Singh > Sent: Thursday, February 20, 2020 10:58 PM > To: u-boot@lists.denx.de > Cc: Frieder Schrempf ; Stefan Roese > ; Priyanka Jain ; Jagan Teki > ; Stefano Babic ; Fabio > Estevam ; Vignesh Raghavendra ; > K

[PATCH] configs: lx2160a: Access flash memory as per spi-mem

2020-03-12 Thread Kuldeep Singh
MC_INIT and BOOT command currently access spi-nor flash memory directly. As per spi-mem framework, flash memory access via absolute addresses is no more possible. Use flash APIs to access memory instead of directly using it. Signed-off-by: Kuldeep Singh --- include/configs/lx2160a_common.h | 23

[Patch v3 1/3] mtd: spi-nor-ids: Enable SPI_NOR_OCTAL_READ flag for mt35xu*

2020-03-14 Thread Kuldeep Singh
Commit 658df8bd9464 ("mtd: spi-nor-core: Add octal mode support") enables octal mode(1-1-8) support in spi-nor framework. mt35xu512aba and mt35xu02g supports SINGLE and OCTAL I/O. Hence, enable SPI_NOR_OCTAL_READ flag for these flashes. Signed-off-by: Kuldeep Singh Reviewed-b

[Patch v3 2/3] arm: dts: ls1028a: Use flexspi in octal I/O mode

2020-03-14 Thread Kuldeep Singh
Configure RX and TX bus-width values to use flexspi in octal I/O mode. If bus-widths are not specified, then single I/O mode is set by default. Signed-off-by: Kuldeep Singh --- v3: Reword commit message. v2: No change. arch/arm/dts/fsl-ls1028a-qds.dts | 2 ++ arch/arm/dts/fsl-ls1028a-rdb.dts

[Patch v3 0/3] Enable octal read support for mt35xu* flashes

2020-03-14 Thread Kuldeep Singh
of the patches -Add lx2160aqds node buswidth in patch3. -Patch3 has dependency on https://patchwork.ozlabs.org/patch/1236164/. Kuldeep Singh (3): mtd: spi-nor-ids: Enable SPI_NOR_OCTAL_READ flag for mt35xu* arm: dts: ls1028a: Use flexspi in octal I/O mode arm: dts: lx2160a: Use flexspi in

[Patch v3 3/3] arm: dts: lx2160a: Use flexspi in octal I/O mode

2020-03-14 Thread Kuldeep Singh
Configure RX and TX bus-width values to use flexspi in octal I/O mode. If bus-widths are not specified, then single I/O mode is set by default. Signed-off-by: Kuldeep Singh --- v3: Reword commit message. v2: No change. arch/arm/dts/fsl-lx2160a-qds.dts | 2 ++ arch/arm/dts/fsl-lx2160a-rdb.dts

[RESEND Patch v2] configs: lx2160a: Enable FSPI support

2020-03-14 Thread Kuldeep Singh
Enable FSPI controller support. So, flash environment can now be used. Signed-off-by: Kuldeep Singh --- v2: -Rebased to top. -Drop other patches from series as already accepted. -Add ENV_SECT_SIZE value as 0x2 configs/lx2160aqds_tfa_SECURE_BOOT_defconfig | 1 + configs

Re: [U-Boot] [EXT] [PATCH v2 2/2] arm: ls1028a: use the new flexspi driver

2019-11-04 Thread Kuldeep Singh
; > - num-cs = <1>; > + reg = <0x0 0x20c 0x0 0x1>, > + <0x0 0x2000 0x0 0x1000>; > + reg-names = "fspi_base", "fspi_mmap"; > + clocks = <&

Re: [U-Boot] [EXT] [PATCH v2 2/2] arm: ls1028a: use the new flexspi driver

2019-11-05 Thread Kuldeep Singh
Hi Michael, > -Original Message- > From: Michael Walle > Sent: Tuesday, November 5, 2019 3:07 PM > To: Kuldeep Singh > Cc: u-boot@lists.denx.de > Subject: Re: [EXT] [U-Boot] [PATCH v2 2/2] arm: ls1028a: use the new flexspi > driver > > Caution: EXT Email >

Re: [U-Boot] [EXT] [PATCH v3 1/3] spi: nxp_fspi: new driver for the FlexSPI controller

2019-11-06 Thread Kuldeep Singh
Hi, > -Original Message- > From: Michael Walle > Sent: Wednesday, November 6, 2019 4:33 AM > To: u-boot@lists.denx.de > Cc: Vignesh R ; Prabhakar X > ; Kuldeep Singh ; > Michael Walle ; Jagan Teki > > Subject: [EXT] [PATCH v3 1/3] spi: nxp_fspi: new driver f

[U-Boot] [PATCH 2/4] arm: dts: lx2160a: Add FSPI node properties

2019-11-06 Thread Kuldeep Singh
Align flexspi node properties with linux device-tree properties Tested on LX2160A-RDB Signed-off-by: Kuldeep Singh --- Depends on https://patchwork.ozlabs.org/patch/1190054/ https://patchwork.ozlabs.org/patch/1190052/ https://patchwork.ozlabs.org/patch/1190051/ arch/arm/dts/fsl-lx2160a-rdb.dts

[U-Boot] [PATCH 4/4] configs: lx2160a: Enable FSPI support

2019-11-06 Thread Kuldeep Singh
Enable FSPI controller support. So, flash environment can now be used Signed-off-by: Kuldeep Singh --- Depends on https://patchwork.ozlabs.org/patch/1190054/ https://patchwork.ozlabs.org/patch/1190052/ https://patchwork.ozlabs.org/patch/1190051/ configs/lx2160aqds_tfa_SECURE_BOOT_defconfig | 1

[U-Boot] [PATCH 1/4] arm: dts: ls1028a: Add FSPI node properties

2019-11-06 Thread Kuldeep Singh
Align flexspi node properties with linux device-tree properties Tested on LS1028A-RDB Signed-off-by: Kuldeep Singh --- Depends on https://patchwork.ozlabs.org/patch/1190054/ https://patchwork.ozlabs.org/patch/1190052/ https://patchwork.ozlabs.org/patch/1190051/ arch/arm/dts/fsl-ls1028a-qds.dts

[U-Boot] [PATCH 3/4] configs: ls1028a: Enable FSPI support

2019-11-06 Thread Kuldeep Singh
Enable FSPI controller support. So, flash environment can now be used Signed-off-by: Kuldeep Singh --- Depends on https://patchwork.ozlabs.org/patch/1190054/ https://patchwork.ozlabs.org/patch/1190052/ https://patchwork.ozlabs.org/patch/1190051/ configs/ls1028aqds_tfa_SECURE_BOOT_defconfig | 1

[U-Boot] [Patch v5 3/4] configs: ls1028a: Enable FSPI_AHB_EN_4B config

2019-11-21 Thread Kuldeep Singh
Enable 4-byte Fast Read command for Flexspi AHB mode Signed-off-by: Kuldeep Singh --- v5: New patch configs/ls1028aqds_tfa_SECURE_BOOT_defconfig | 1 + configs/ls1028aqds_tfa_defconfig | 1 + configs/ls1028ardb_tfa_SECURE_BOOT_defconfig | 1 + configs/ls1028ardb_tfa_defconfig

[U-Boot] [Patch v5 1/4] fsl-lsch3: Add FlexSPI address space in immap_lsch3

2019-11-21 Thread Kuldeep Singh
Signed-off-by: Priyanka Jain Signed-off-by: Sriram Dash Signed-off-by: Ashish Kumar Signed-off-by: Rajat Srivastava Signed-off-by: Kuldeep Singh --- v5: Rebased to top v4: Remove unnecessary dependencies of FSPI_AHB_EN_4BYTE config arch/arm/include/asm/arch-fsl-layerscape/immap_lsch3.h | 6

[U-Boot] [Patch v5 2/4] fsl-lsch3: soc: Enable AHB read support for Flexspi controller

2019-11-21 Thread Kuldeep Singh
Enable AHB support for Flexspi controller interface meaning memory can be accessed via md command using absolute addresses Signed-off-by: Yogesh Gaur Signed-off-by: Ashish Kumar Signed-off-by: Rajat Srivastava Signed-off-by: Kuldeep Singh --- v5: Rebased to top v4: Does not exist arch/arm

[U-Boot] [Patch v5 4/4] configs: lx2160a: Enable FSPI_AHB_EN_4B config

2019-11-21 Thread Kuldeep Singh
Enable 4-byte Fast Read command for Flexspi AHB mode Signed-off-by: Kuldeep Singh --- v5: New patch configs/lx2160aqds_tfa_SECURE_BOOT_defconfig | 1 + configs/lx2160aqds_tfa_defconfig | 1 + configs/lx2160ardb_tfa_SECURE_BOOT_defconfig | 1 + configs/lx2160ardb_tfa_defconfig

RE: [PATCH] configs: ls2088ardb: Correct DEFAULT_DEVICE_TREE value

2020-04-20 Thread Kuldeep Singh
[...] > It does not impact the NOR boot case and fsl-ls2088a-rdb-qspi.dts provides > additional nodes for qspi flash and i2c. > Reviewed . Priyanka, Since Wasim has reviewed the patch maybe we can proceed with his "reviewed-by" tag. -Kuldeep

[Patch v2] spi: nxp-fspi: Add 1us delay to make controller ready for next transaction

2020-04-20 Thread Kuldeep Singh
-boot poll_timeout API lacks delay functionality, add 1us delay so as to make controller ready for other transactions. Signed-off-by: Kuldeep Singh --- v1: Add comments above udelay(1) change. drivers/spi/nxp_fspi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/spi

RE: [EXT] Re: [Patch v2] spi: nxp-fspi: Add 1us delay to make controller ready for next transaction

2020-04-21 Thread Kuldeep Singh
> -Original Message- > From: Jagan Teki > Sent: Tuesday, April 21, 2020 1:45 PM > To: Kuldeep Singh > Cc: U-Boot-Denx > Subject: [EXT] Re: [Patch v2] spi: nxp-fspi: Add 1us delay to make controller > ready for next transaction > > Caution: EXT Email > &

RE: [EXT] Re: [Patch v2] spi: nxp-fspi: Add 1us delay to make controller ready for next transaction

2020-04-26 Thread Kuldeep Singh
> > If you see implementation of " fspi_readl_poll_tout ", it further calls > "readl_poll_timeout" which includes delay of 1us. > > And also please see the difference of "readl_poll_timeout" api > implementation in uboot and Linux. > > This api adds delay in Linux but skips it in uboot. > > Yes, i

[Patch v3] spi: nxp-fspi: Use new readl_poll_sleep_timeout API

2020-04-27 Thread Kuldeep Singh
adds delay alongwith timeout functionality. Signed-off-by: Kuldeep Singh --- v3: -Reword commit message and use new API instead of adding delay. -Depends on: a) https://patchwork.ozlabs.org/project/uboot/patch/20200425110354.12381-2-ja...@amarulasolutions.com/ b) https://patchwork.ozlabs.org/pro

[PATCH] configs: ls1043aqds: Configure QSPI related configs

2020-06-10 Thread Kuldeep Singh
E - Enable CONFIG_SYS_RELOC_GD_ENV_ADDR Signed-off-by: Kuldeep Singh --- configs/ls1043aqds_qspi_defconfig| 1 + configs/ls1043aqds_tfa_SECURE_BOOT_defconfig | 1 + configs/ls1043aqds_tfa_defconfig | 3 ++- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git

RE: [EXT] Re: [RESEND][Patch v4] net: pfe_eth: Use spi_flash_read API to access flash memory

2020-06-19 Thread Kuldeep Singh
> -Original Message- > From: Schrempf Frieder > Sent: Thursday, May 28, 2020 1:46 PM > To: Kuldeep Singh ; Joe Hershberger > ; u-boot@lists.denx.de > Cc: Priyanka Jain ; Tom Rini > Subject: [EXT] Re: [RESEND][Patch v4] net: pfe_eth: Use spi_flash_read API to

RE: [EXT] Re: [RESEND][Patch v4] net: pfe_eth: Use spi_flash_read API to access flash memory

2020-06-21 Thread Kuldeep Singh
> -Original Message- > From: Tom Rini > Sent: Friday, June 19, 2020 8:07 PM > To: Priyanka Jain > Cc: Kuldeep Singh ; Joe Hershberger > ; u-boot@lists.denx.de; Schrempf Frieder > > Subject: Re: [EXT] Re: [RESEND][Patch v4] net: pfe_eth: Use spi_flash_read >

[PATCH] configs: ls1046aqds: Configure QSPI related configs

2020-06-23 Thread Kuldeep Singh
- Restore CONFIG_ENV_ADDR to 0x6050 Signed-off-by: Kuldeep Singh --- configs/ls1046aqds_tfa_SECURE_BOOT_defconfig | 2 ++ configs/ls1046aqds_tfa_defconfig | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/configs/ls1046aqds_tfa_SECURE_BOOT_defconfig

[PATCH] configs: ls1012a: Increase CONFIG_SYS_MALLOC_LEN value

2020-06-25 Thread Kuldeep Singh
rger value i.e 5M. This size should be enough as of now to accommodate further memory requirements. Signed-off-by: Kuldeep Singh --- Depends on https://patchwork.ozlabs.org/project/uboot/patch/1590646373-8795-1-git-send-email-kuldeep.si...@nxp.com/ include/configs/ls1012a_common.h | 3 ++- 1 fi

[PATCH] configs: ls2088a: Restore CONFIG_ENV_ADDR to IFC-NOR

2020-07-22 Thread Kuldeep Singh
Restore CONFIG_ENV_ADDR value to fix boot hang with IFC-NOR as default boot source. Signed-off-by: Ashish Kumar Signed-off-by: Kuldeep Singh --- configs/ls2088ardb_tfa_defconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configs/ls2088ardb_tfa_defconfig b/configs

RE: [PATCH] configs: ls1043aqds: Configure QSPI related configs

2020-07-22 Thread Kuldeep Singh
[...] > Please confirm that all boot-sources will work fine with this change. Please hold both the patches for a moment. I will test other boot sources and will let you know the results.

[Patch v2] configs: ls1012a/ls1046a: Add CONFIG_ENV_OVERWRITE in defconfig

2020-07-30 Thread Kuldeep Singh
; setenv ethaddr 00:E0:0C:00:06:0 => setenv ethaddr 00:E0:0C:00:06:1 Error: Can't overwrite "ethaddr" Error inserting "ethaddr" variable, errno=1 After the change: => setenv ethaddr 00:E0:0C:00:06:0 => setenv ethaddr 00:E0:0C:00:06:1 Signed-off-by: Kuldeep Singh ---

RE: [EXT] Issue with saveenv() and the QSPI NOR memory MICRON MT25QU01GBBB

2020-01-22 Thread Kuldeep Singh
Hi Florian, > -Original Message- > From: U-Boot On Behalf Of > florian.man...@siemens.com > Sent: Wednesday, January 22, 2020 7:13 PM > To: u-boot@lists.denx.de > Cc: daniel.schert...@siemens.com > Subject: [EXT] Issue with saveenv() and the QSPI NOR memory MICRON > MT25QU01GBBB > > Caut

RE: [EXT] Re: [Patch v4] net: pfe_eth: Use spi_flash_read API to access flash memory

2020-01-22 Thread Kuldeep Singh
Hi Joe, > -Original Message- > From: Schrempf Frieder > Sent: Monday, January 13, 2020 3:11 PM > To: Kuldeep Singh ; u-boot@lists.denx.de > Cc: Joe Hershberger ; Thomas Hebb > ; Patrick Delaunay ; > Priyanka Jain > Subject: [EXT] Re: [Patch v4] net: pfe_eth: U

Re: [EXT] Issue with saveenv() and the QSPI NOR memory MICRON MT25QU01GBBB

2020-01-25 Thread Kuldeep Singh
Good to hear this :) From: florian.man...@siemens.com Sent: Friday, January 24, 2020 12:30 AM To: Kuldeep Singh Cc: daniel.schert...@siemens.com ; u-boot@lists.denx.de Subject: AW: [EXT] Issue with saveenv() and the QSPI NOR memory MICRON MT25QU01GBBB

RE: [EXT] Re: [PATCH] configs: ls1012ardb: Enable CONFIG_SYS_RELOC_GD_ENV_ADDR

2020-01-26 Thread Kuldeep Singh
Hi Priyanka, > -Original Message- > From: Schrempf Frieder > Sent: Tuesday, January 7, 2020 4:36 PM > To: Kuldeep Singh ; u-boot@lists.denx.de > Cc: tr...@konsulko.com > Subject: [EXT] Re: [PATCH] configs: ls1012ardb: Enable > CONFIG_SYS_RELOC_GD_ENV_ADDR > >

RE: [EXT] Re: [Patch v4 0/7] Transition of fsl qspi driver to spi-mem framework

2020-01-27 Thread Kuldeep Singh
Hi Jagan, > -Original Message- > From: Jagan Teki > Sent: Monday, January 27, 2020 12:50 PM > To: Kuldeep Singh > Cc: U-Boot-Denx ; Priyanka Jain > ; Ashish Kumar ; Stefan > Roese ; Schrempf Frieder ; > Vignesh R > Subject: [EXT] Re: [Patch v4 0/7] Transitio

[PATCH 1/2] configs: ls2080ardb: Make QSPI_MC_INIT access flash memory as per spi-mem

2020-02-02 Thread Kuldeep Singh
MC_INIT command currently access spi-nor flash memory directly. As per spi-mem framework, flash memory access via absolute addresses is no more possible. Use flash APIs to access memory instead of directly using it. Signed-off-by: Kuldeep Singh --- include/configs/ls2080ardb.h | 22

[PATCH 2/2] configs: ls2080ardb: Make BOOTCOMMAND access flash memory as per spi-mem

2020-02-02 Thread Kuldeep Singh
BOOT command currently access spi-nor flash memory directly. As per spi-mem framework, flash memory access via absolute addresses is no more possible. Use flash APIs to access memory instead of directly using it. Signed-off-by: Kuldeep Singh --- include/configs/ls2080ardb.h | 12 1

[PATCH 0/3] Enable octal read support for mt35xu* flashes

2020-02-03 Thread Kuldeep Singh
and TX buswidth in qspi dts entry to use 1-1-8 mode. DTS entries can be merged once patch[1] is merged. No dependency on framework patch. [1]https://patchwork.ozlabs.org/project/uboot/list/?series=141023 Kuldeep Singh (3): mtd: spi-nor: Enable SPI_NOR_OCTAL_READ flag for mt35xu* arm: dts

[PATCH 2/3] arm: dts: ls1028a: Add RX, TX buswidth in qspi to use octal mode

2020-02-03 Thread Kuldeep Singh
Signed-off-by: Kuldeep Singh --- Depends on https://patchwork.ozlabs.org/project/uboot/list/?series=141023 arch/arm/dts/fsl-ls1028a-qds.dts | 2 ++ arch/arm/dts/fsl-ls1028a-rdb.dts | 2 ++ 2 files changed, 4 insertions(+) diff --git a/arch/arm/dts/fsl-ls1028a-qds.dts b/arch/arm/dts/fsl

[PATCH 3/3] arm: dts: lx2160a: Add RX, TX buswidth in qspi to use octal mode

2020-02-03 Thread Kuldeep Singh
Signed-off-by: Kuldeep Singh --- Depends on https://patchwork.ozlabs.org/project/uboot/list/?series=141023 arch/arm/dts/fsl-lx2160a-rdb.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/fsl-lx2160a-rdb.dts b/arch/arm/dts/fsl-lx2160a-rdb.dts index e542c69..87617ca 100644

[PATCH 1/3] mtd: spi-nor: Enable SPI_NOR_OCTAL_READ flag for mt35xu*

2020-02-03 Thread Kuldeep Singh
Commit "658df8bd9464"(mtd: spi-nor-core: Add octal mode support) enables octal mode(1-1-8) support in spi-nor framework. mt35xu512aba and mt35xu02g flashes support SINGLE and OCTAL I/O. Hence, enable SPI_NOR_OCTAL_READ flag for the same. Signed-off-by: Kuldeep Singh --- drivers/mtd/s

[PATCH] configs: lx2160a: Define ENV_ADDR value

2020-02-03 Thread Kuldeep Singh
CONFIG_ENV_ADDR helps in picking environment from flash before DDR init. Define the value as 0x2050 for lx2160ardb and lx2160aqds. Signed-off-by: Kuldeep Singh --- Hi Priyanka, This patch can be applied after applying below patch. https://patchwork.ozlabs.org/project/uboot/list/?series

[PATCH] configs: lx2160a: Define ENV_SECT_SIZE

2020-02-03 Thread Kuldeep Singh
LX2160ARDB/QDS has mt35xu512aba flash with 128K sector size. Define ENV_SECT_SIZE value as 0x2. Signed-off-by: Kuldeep Singh --- configs/lx2160aqds_tfa_defconfig | 3 ++- configs/lx2160ardb_tfa_defconfig | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/configs

RE: [EXT] Re: [Patch v4 0/7] Transition of fsl qspi driver to spi-mem framework

2020-02-03 Thread Kuldeep Singh
++Joe Hi, > -Original Message- > From: Jagan Teki > Sent: Monday, January 27, 2020 3:44 PM > To: Schrempf Frieder ; Kuldeep Singh > > Cc: U-Boot-Denx ; Priyanka Jain > ; Ashish Kumar ; Stefan > Roese ; Vignesh R > Subject: Re: [EXT] Re: [Patch v4 0/7] Trans

[Patch v2] configs: lx2160a: Enable FSPI support

2020-02-06 Thread Kuldeep Singh
Enable FSPI controller support. So, flash environment can now be used. Signed-off-by: Kuldeep Singh --- Please let me know if rebase required while applying. v2: -Drop other patches from series as already accepted. -Add ENV_SECT_SIZE value as 0x2 configs

[Patch v2 1/2] configs: ls2080ardb: Make MC_INIT access flash memory as per spi-mem

2020-02-09 Thread Kuldeep Singh
MC_INIT command currently access spi-nor flash memory directly. As per spi-mem framework, flash memory access via absolute addresses is no more possible. Use flash APIs to access memory instead of directly using it. Signed-off-by: Kuldeep Singh --- v2: -Rebase to top -reword commit message

[Patch v2 2/2] configs: ls2080ardb: Make BOOT command access flash memory as per spi-mem

2020-02-09 Thread Kuldeep Singh
BOOT command currently access spi-nor flash memory directly. As per spi-mem framework, flash memory access via absolute addresses is no more possible. Use flash APIs to access memory instead of directly using it. Signed-off-by: Kuldeep Singh --- v2: -Rebase to top -Reword commit message

[PATCH] arm: dts: lx2160aqds: Enable FSPI node properties

2020-02-10 Thread Kuldeep Singh
Align flexspi node properties with linux device-tree properties. Signed-off-by: Kuldeep Singh --- arch/arm/dts/fsl-lx2160a-qds.dts | 24 1 file changed, 24 insertions(+) diff --git a/arch/arm/dts/fsl-lx2160a-qds.dts b/arch/arm/dts/fsl-lx2160a-qds.dts index 34df0f5

  1   2   >