Re: [U-Boot] [PATCH 3/3] mx7: add epdc qos settings

2017-08-16 Thread Stefano Babic
On 12/08/2017 16:10, Peng Fan wrote:
> This EPDC/EPXP QoS setting is needed for EPDC stress test to pass.
> 
> Signed-off-by: Peng Fan 
> Cc: Stefano Babic 
> Cc: Fabio Estevam 
> ---
>  arch/arm/include/asm/arch-mx7/imx-regs.h |  5 +
>  arch/arm/mach-imx/mx7/soc.c  | 38 
> 
>  2 files changed, 43 insertions(+)
> 
> diff --git a/arch/arm/include/asm/arch-mx7/imx-regs.h 
> b/arch/arm/include/asm/arch-mx7/imx-regs.h
> index aab3a9a..a6b2091 100644
> --- a/arch/arm/include/asm/arch-mx7/imx-regs.h
> +++ b/arch/arm/include/asm/arch-mx7/imx-regs.h
> @@ -152,6 +152,11 @@
>  #define IP2APB_AXIMON_IPS_BASE_ADDR (AIPS2_OFF_BASE_ADDR+0x1E)
>  #define QOSC_IPS_BASE_ADDR  (AIPS2_OFF_BASE_ADDR+0x1F)
>  
> +#define REGS_QOS_BASEQOSC_IPS_BASE_ADDR
> +#define REGS_QOS_EPDC(QOSC_IPS_BASE_ADDR + 0x3400)
> +#define REGS_QOS_PXP0(QOSC_IPS_BASE_ADDR + 0x2C00)
> +#define REGS_QOS_PXP1(QOSC_IPS_BASE_ADDR + 0x3C00)
> +
>  /* AIPS_TZ#3  - Global enable (0) */
>  #define ECSPI1_BASE_ADDR(AIPS_TZ3_BASE_ADDR+0x2)
>  #define ECSPI2_BASE_ADDR(AIPS_TZ3_BASE_ADDR+0x3)
> diff --git a/arch/arm/mach-imx/mx7/soc.c b/arch/arm/mach-imx/mx7/soc.c
> index 4307ae0..6b37848 100644
> --- a/arch/arm/mach-imx/mx7/soc.c
> +++ b/arch/arm/mach-imx/mx7/soc.c
> @@ -230,6 +230,42 @@ static void imx_enet_mdio_fixup(void)
>   }
>  }
>  
> +static void set_epdc_qos(void)
> +{
> + /* Disable clkgate & soft_reset */
> + writel(0, REGS_QOS_BASE);
> + /* Enable all masters */
> + writel(0, REGS_QOS_BASE + 0x60);
> + /* Disable clkgate & soft_reset */
> + writel(0, REGS_QOS_EPDC);
> + /* Disable clkgate & soft_reset */
> + writel(0, REGS_QOS_PXP0);
> + /* Disable clkgate & soft_reset */
> + writel(0, REGS_QOS_PXP1);
> + /* WR, init = 7 with red flag */
> + writel(0x0f020722, REGS_QOS_EPDC + 0xd0);
> + /* RD,  init = 7 with red flag */
> + writel(0x0f020722, REGS_QOS_EPDC + 0xe0);
> + /* OT_CTRL_EN =1 */
> + writel(1, REGS_QOS_PXP0);
> + /* OT_CTRL_EN =1 */
> + writel(1, REGS_QOS_PXP1);
> + /* WR,  init = 2 with red flag */
> + writel(0x0f020222, REGS_QOS_PXP0 + 0x50);
> + /* WR,  init = 2 with red flag */
> + writel(0x0f020222, REGS_QOS_PXP1 + 0x50);
> + /* rD,  init = 2 with red flag */
> + writel(0x0f020222, REGS_QOS_PXP0 + 0x60);
> + /* rD,  init = 2 with red flag */
> + writel(0x0f020222, REGS_QOS_PXP1 + 0x60);
> + /* tOTAL,  init = 4 with red flag */
> + writel(0x0f020422, REGS_QOS_PXP0 + 0x70);
> + /* TOTAL,  init = 4 with red flag */
> + writel(0x0f020422, REGS_QOS_PXP1 + 0x70);
> + /* EPDC AW/AR CACHE ENABLE */
> + writel(0xe080, IOMUXC_GPR_BASE_ADDR + 0x0034);
> +}

Comments are xhaustive, but can you set appropriate #define for all
constants ?

Best regards,
Stefano Babic


-- 
=
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCH 3/3] mx7: add epdc qos settings

2017-08-12 Thread Peng Fan
This EPDC/EPXP QoS setting is needed for EPDC stress test to pass.

Signed-off-by: Peng Fan 
Cc: Stefano Babic 
Cc: Fabio Estevam 
---
 arch/arm/include/asm/arch-mx7/imx-regs.h |  5 +
 arch/arm/mach-imx/mx7/soc.c  | 38 
 2 files changed, 43 insertions(+)

diff --git a/arch/arm/include/asm/arch-mx7/imx-regs.h 
b/arch/arm/include/asm/arch-mx7/imx-regs.h
index aab3a9a..a6b2091 100644
--- a/arch/arm/include/asm/arch-mx7/imx-regs.h
+++ b/arch/arm/include/asm/arch-mx7/imx-regs.h
@@ -152,6 +152,11 @@
 #define IP2APB_AXIMON_IPS_BASE_ADDR (AIPS2_OFF_BASE_ADDR+0x1E)
 #define QOSC_IPS_BASE_ADDR  (AIPS2_OFF_BASE_ADDR+0x1F)
 
+#define REGS_QOS_BASE  QOSC_IPS_BASE_ADDR
+#define REGS_QOS_EPDC  (QOSC_IPS_BASE_ADDR + 0x3400)
+#define REGS_QOS_PXP0  (QOSC_IPS_BASE_ADDR + 0x2C00)
+#define REGS_QOS_PXP1  (QOSC_IPS_BASE_ADDR + 0x3C00)
+
 /* AIPS_TZ#3  - Global enable (0) */
 #define ECSPI1_BASE_ADDR(AIPS_TZ3_BASE_ADDR+0x2)
 #define ECSPI2_BASE_ADDR(AIPS_TZ3_BASE_ADDR+0x3)
diff --git a/arch/arm/mach-imx/mx7/soc.c b/arch/arm/mach-imx/mx7/soc.c
index 4307ae0..6b37848 100644
--- a/arch/arm/mach-imx/mx7/soc.c
+++ b/arch/arm/mach-imx/mx7/soc.c
@@ -230,6 +230,42 @@ static void imx_enet_mdio_fixup(void)
}
 }
 
+static void set_epdc_qos(void)
+{
+   /* Disable clkgate & soft_reset */
+   writel(0, REGS_QOS_BASE);
+   /* Enable all masters */
+   writel(0, REGS_QOS_BASE + 0x60);
+   /* Disable clkgate & soft_reset */
+   writel(0, REGS_QOS_EPDC);
+   /* Disable clkgate & soft_reset */
+   writel(0, REGS_QOS_PXP0);
+   /* Disable clkgate & soft_reset */
+   writel(0, REGS_QOS_PXP1);
+   /* WR, init = 7 with red flag */
+   writel(0x0f020722, REGS_QOS_EPDC + 0xd0);
+   /* RD,  init = 7 with red flag */
+   writel(0x0f020722, REGS_QOS_EPDC + 0xe0);
+   /* OT_CTRL_EN =1 */
+   writel(1, REGS_QOS_PXP0);
+   /* OT_CTRL_EN =1 */
+   writel(1, REGS_QOS_PXP1);
+   /* WR,  init = 2 with red flag */
+   writel(0x0f020222, REGS_QOS_PXP0 + 0x50);
+   /* WR,  init = 2 with red flag */
+   writel(0x0f020222, REGS_QOS_PXP1 + 0x50);
+   /* rD,  init = 2 with red flag */
+   writel(0x0f020222, REGS_QOS_PXP0 + 0x60);
+   /* rD,  init = 2 with red flag */
+   writel(0x0f020222, REGS_QOS_PXP1 + 0x60);
+   /* tOTAL,  init = 4 with red flag */
+   writel(0x0f020422, REGS_QOS_PXP0 + 0x70);
+   /* TOTAL,  init = 4 with red flag */
+   writel(0x0f020422, REGS_QOS_PXP1 + 0x70);
+   /* EPDC AW/AR CACHE ENABLE */
+   writel(0xe080, IOMUXC_GPR_BASE_ADDR + 0x0034);
+}
+
 int arch_cpu_init(void)
 {
init_aips();
@@ -240,6 +276,8 @@ int arch_cpu_init(void)
 
imx_enet_mdio_fixup();
 
+   set_epdc_qos();
+
 #ifdef CONFIG_APBH_DMA
/* Start APBH DMA */
mxs_dma_init();
-- 
2.6.2

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot