Re: [U-Boot] [PATCH v1] ARM: dts: Makefile: Use board to decide to compile dts

[Wenyou.Yang]

> -Original Message-
> From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass
> Sent: 2016年9月23日 12:17
> To: Wenyou Yang - A41535 
> Cc: U-Boot Mailing List ; Stephen Warren
> ; Andreas Bießmann ; Wenyou
> Yang - A41535 
> Subject: Re: [PATCH v1] ARM: dts: Makefile: Use board to decide to compile dts
> 
> Hi,
> 
> On 18 September 2016 at 01:40, Wenyou Yang  wrote:
> > To avoid to compile all AT91 SoCs' board dts files, use the board to
> > decide to build its corresponding dts, instead of CONFIG_AT91FAMILY.
> >
> > Signed-off-by: Wenyou Yang 
> > ---
> >
> >  arch/arm/dts/Makefile | 8 
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> What is the purpose of this? It seems unnecessary to me. Compiling a few
> more .dts files will be quick.

Why we need to compile all AT91FAMILY dts files, not be used for a specific 
AT91 board?

It is enough to compile the dts file used for the target board. Others is 
unnecessary.

> 
> >
> > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index
> > 223124e..2ac1f20 100644
> > --- a/arch/arm/dts/Makefile
> > +++ b/arch/arm/dts/Makefile
> > @@ -2,10 +2,10 @@
> >  # SPDX-License-Identifier: GPL-2.0+
> >  #
> >
> > -dtb-$(CONFIG_AT91FAMILY) += at91sam9260-smartweb.dtb \
> > -   at91sam9g20-taurus.dtb \
> > -   at91sam9g45-corvus.dtb \
> > -   at91sam9g45-gurnard.dtb
> > +dtb-$(CONFIG_TARGET_SMARTWEB) += at91sam9260-smartweb.dtb
> > +dtb-$(CONFIG_TARGET_TAURUS) += at91sam9g20-taurus.dtb
> > +dtb-$(CONFIG_TARGET_CORVUS) += at91sam9g45-corvus.dtb
> > +dtb-$(CONFIG_TARGET_GURNARD) += at91sam9g45-gurnard.dtb
> >
> >  dtb-$(CONFIG_S5PC100) += s5pc1xx-smdkc100.dtb
> >  dtb-$(CONFIG_S5PC110) += s5pc1xx-goni.dtb
> > --
> > 2.7.4
> >
> 
> Regards,
> Simon


Best Regards,
Wenyou Yang
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v1] ARM: dts: Makefile: Use board to decide to compile dts

[Simon Glass]

Hi,

On 18 September 2016 at 01:40, Wenyou Yang  wrote:
> To avoid to compile all AT91 SoCs' board dts files, use the board
> to decide to build its corresponding dts, instead of
> CONFIG_AT91FAMILY.
>
> Signed-off-by: Wenyou Yang 
> ---
>
>  arch/arm/dts/Makefile | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)

What is the purpose of this? It seems unnecessary to me. Compiling a
few more .dts files will be quick.

>
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index 223124e..2ac1f20 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -2,10 +2,10 @@
>  # SPDX-License-Identifier: GPL-2.0+
>  #
>
> -dtb-$(CONFIG_AT91FAMILY) += at91sam9260-smartweb.dtb \
> -   at91sam9g20-taurus.dtb \
> -   at91sam9g45-corvus.dtb \
> -   at91sam9g45-gurnard.dtb
> +dtb-$(CONFIG_TARGET_SMARTWEB) += at91sam9260-smartweb.dtb
> +dtb-$(CONFIG_TARGET_TAURUS) += at91sam9g20-taurus.dtb
> +dtb-$(CONFIG_TARGET_CORVUS) += at91sam9g45-corvus.dtb
> +dtb-$(CONFIG_TARGET_GURNARD) += at91sam9g45-gurnard.dtb
>
>  dtb-$(CONFIG_S5PC100) += s5pc1xx-smdkc100.dtb
>  dtb-$(CONFIG_S5PC110) += s5pc1xx-goni.dtb
> --
> 2.7.4
>

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v1] ARM: dts: Makefile: Use board to decide to compile dts

[Heiko Schocher]

Hello Wenyou Yang,

Am 18.09.2016 um 09:40 schrieb Wenyou Yang:

To avoid to compile all AT91 SoCs' board dts files, use the board
to decide to build its corresponding dts, instead of
CONFIG_AT91FAMILY.

Signed-off-by: Wenyou Yang 
---

  arch/arm/dts/Makefile | 8 
  1 file changed, 4 insertions(+), 4 deletions(-)


Reviewed-by: Heiko Schocher 

bye,
Heiko


diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 223124e..2ac1f20 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -2,10 +2,10 @@
  # SPDX-License-Identifier:GPL-2.0+
  #

-dtb-$(CONFIG_AT91FAMILY) += at91sam9260-smartweb.dtb \
-   at91sam9g20-taurus.dtb \
-   at91sam9g45-corvus.dtb \
-   at91sam9g45-gurnard.dtb
+dtb-$(CONFIG_TARGET_SMARTWEB) += at91sam9260-smartweb.dtb
+dtb-$(CONFIG_TARGET_TAURUS) += at91sam9g20-taurus.dtb
+dtb-$(CONFIG_TARGET_CORVUS) += at91sam9g45-corvus.dtb
+dtb-$(CONFIG_TARGET_GURNARD) += at91sam9g45-gurnard.dtb

  dtb-$(CONFIG_S5PC100) += s5pc1xx-smdkc100.dtb
  dtb-$(CONFIG_S5PC110) += s5pc1xx-goni.dtb



--
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v1] ARM: dts: Makefile: Use board to decide to compile dts

[Wenyou Yang]

To avoid to compile all AT91 SoCs' board dts files, use the board
to decide to build its corresponding dts, instead of
CONFIG_AT91FAMILY.

Signed-off-by: Wenyou Yang 
---

 arch/arm/dts/Makefile | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 223124e..2ac1f20 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -2,10 +2,10 @@
 # SPDX-License-Identifier: GPL-2.0+
 #
 
-dtb-$(CONFIG_AT91FAMILY) += at91sam9260-smartweb.dtb \
-   at91sam9g20-taurus.dtb \
-   at91sam9g45-corvus.dtb \
-   at91sam9g45-gurnard.dtb
+dtb-$(CONFIG_TARGET_SMARTWEB) += at91sam9260-smartweb.dtb
+dtb-$(CONFIG_TARGET_TAURUS) += at91sam9g20-taurus.dtb
+dtb-$(CONFIG_TARGET_CORVUS) += at91sam9g45-corvus.dtb
+dtb-$(CONFIG_TARGET_GURNARD) += at91sam9g45-gurnard.dtb
 
 dtb-$(CONFIG_S5PC100) += s5pc1xx-smdkc100.dtb
 dtb-$(CONFIG_S5PC110) += s5pc1xx-goni.dtb
-- 
2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot