Re: [U-Boot] [v3] armv8: ls1028ardb: enable DisplayPort Power support

[Prabhakar Kushwaha]

> -Original Message-
> From: U-Boot  On Behalf Of Bin Meng
> Sent: Thursday, July 25, 2019 1:57 PM
> To: Wen He 
> Cc: U-Boot Mailing List 
> Subject: Re: [U-Boot] [v3] armv8: ls1028ardb: enable DisplayPort Power
> support
> 
> On Thu, Jul 25, 2019 at 3:18 PM Wen He  wrote:
> >
> > Enable DP_PWR signal to power the DP to HDMI converter cable.
> >
> > Signed-off-by: Wen He 
> > ---

Hi Wen,

Please work on review comments. 

Also. 
This patch is only valid when display driver is accepted in upstream
Is it accepted?

If display driver not accepted in upstream. Please hold this patch. 

--pk
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [v3] armv8: ls1028ardb: enable DisplayPort Power support

[Bin Meng]

On Thu, Jul 25, 2019 at 3:18 PM Wen He  wrote:
>
> Enable DP_PWR signal to power the DP to HDMI converter cable.
>
> Signed-off-by: Wen He 
> ---
>  board/freescale/ls1028a/ls1028a.c | 13 +
>  include/configs/ls1028a_common.h  |  3 +++
>  2 files changed, 16 insertions(+)
>
> diff --git a/board/freescale/ls1028a/ls1028a.c 
> b/board/freescale/ls1028a/ls1028a.c
> index ece91660bf..ea8c43b6af 100644
> --- a/board/freescale/ls1028a/ls1028a.c
> +++ b/board/freescale/ls1028a/ls1028a.c
> @@ -75,6 +75,19 @@ int board_init(void)
> u8 val = I2C_MUX_CH_DEFAULT;
>
> i2c_write(I2C_MUX_PCA_ADDR_PRI, 0x0b, 1, , 1);
> +#endif
> +
> +#if defined(CONFIG_TARGET_LS1028ARDB)
> +   u8 reg;
> +
> +   reg = QIXIS_READ(brdcfg[4]);
> +   /* Field| Function
> +* 3 | DisplayPort Power Enable (net DP_PWR_EN):
> +* DPPWR | 0= DP_PWR is enabled.
> +*/

Please use correct multi-line comment format.

> +   reg &= ~(DP_PWD_EN_DEFAULT_MASK);
> +   QIXIS_WRITE(brdcfg[4], reg);
> +
>  #endif
> return 0;
>  }

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [v3] armv8: ls1028ardb: enable DisplayPort Power support

[Wen He]

Enable DP_PWR signal to power the DP to HDMI converter cable.

Signed-off-by: Wen He 
---
 board/freescale/ls1028a/ls1028a.c | 13 +
 include/configs/ls1028a_common.h  |  3 +++
 2 files changed, 16 insertions(+)

diff --git a/board/freescale/ls1028a/ls1028a.c 
b/board/freescale/ls1028a/ls1028a.c
index ece91660bf..ea8c43b6af 100644
--- a/board/freescale/ls1028a/ls1028a.c
+++ b/board/freescale/ls1028a/ls1028a.c
@@ -75,6 +75,19 @@ int board_init(void)
u8 val = I2C_MUX_CH_DEFAULT;
 
i2c_write(I2C_MUX_PCA_ADDR_PRI, 0x0b, 1, , 1);
+#endif
+
+#if defined(CONFIG_TARGET_LS1028ARDB)
+   u8 reg;
+
+   reg = QIXIS_READ(brdcfg[4]);
+   /* Field| Function
+* 3 | DisplayPort Power Enable (net DP_PWR_EN):
+* DPPWR | 0= DP_PWR is enabled.
+*/
+   reg &= ~(DP_PWD_EN_DEFAULT_MASK);
+   QIXIS_WRITE(brdcfg[4], reg);
+
 #endif
return 0;
 }
diff --git a/include/configs/ls1028a_common.h b/include/configs/ls1028a_common.h
index 41ce4a054c..1d93b4bf6b 100644
--- a/include/configs/ls1028a_common.h
+++ b/include/configs/ls1028a_common.h
@@ -219,6 +219,9 @@
 #define CONFIG_SYS_EEPROM_PAGE_WRITE_BITS  3
 #define CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS  5
 
+/* DisplayPort */
+#define DP_PWD_EN_DEFAULT_MASK  0x8
+
 #ifdef CONFIG_SECURE_BOOT
 #include 
 #endif
-- 
2.17.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot