Re: [PATCH] arch: arm: uDPU: fix PHY mode definition to sgmii-2500
On 12.05.20 12:02, Jakov Petrina wrote: Commit f49ac7e1c4 switched the default PHY speed to 3.125Gbit to resolve issues with SFP modules. However, U-Boot does not have a "2500base-x" phy-mode. Resolve this by using "sgmii-2500" instead. Signed-off-by: Jakov Petrina Signed-off-by: Vladimir Vid Cc: Luka Perkov Cc: Stefan Roese Applied to u-boot-marvell/master Thanks, Stefan
Re: [PATCH] arch: arm: uDPU: fix PHY mode definition to sgmii-2500
Hi Jakov, On 23.05.20 20:23, Jakov Petrina wrote: On 12/05/2020 12:02, Jakov Petrina wrote: Commit f49ac7e1c4 switched the default PHY speed to 3.125Gbit to resolve issues with SFP modules. However, U-Boot does not have a "2500base-x" phy-mode. Resolve this by using "sgmii-2500" instead. Signed-off-by: Jakov Petrina Signed-off-by: Vladimir Vid Cc: Luka Perkov Cc: Stefan Roese --- arch/arm/dts/armada-3720-uDPU.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Hi Stefan, I'm curious if there are any feedback or blockers on this patch? Sorry for the delay. I'll take care of it shortly. Thanks, Stefan Thanks, Jakov diff --git a/arch/arm/dts/armada-3720-uDPU.dts b/arch/arm/dts/armada-3720-uDPU.dts index 07c7b91175..7f4b8222f4 100644 --- a/arch/arm/dts/armada-3720-uDPU.dts +++ b/arch/arm/dts/armada-3720-uDPU.dts @@ -125,14 +125,14 @@ { pinctrl-0 = <_pins>; status = "okay"; - phy-mode = "2500base-x"; + phy-mode = "sgmii-2500"; managed = "in-band-status"; phy = <>; }; { status = "okay"; - phy-mode = "2500base-x"; + phy-mode = "sgmii-2500"; managed = "in-band-status"; phy = <>; }; Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de
Re: [PATCH] arch: arm: uDPU: fix PHY mode definition to sgmii-2500
On 12/05/2020 12:02, Jakov Petrina wrote: Commit f49ac7e1c4 switched the default PHY speed to 3.125Gbit to resolve issues with SFP modules. However, U-Boot does not have a "2500base-x" phy-mode. Resolve this by using "sgmii-2500" instead. Signed-off-by: Jakov Petrina Signed-off-by: Vladimir Vid Cc: Luka Perkov Cc: Stefan Roese --- arch/arm/dts/armada-3720-uDPU.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Hi Stefan, I'm curious if there are any feedback or blockers on this patch? Thanks, Jakov diff --git a/arch/arm/dts/armada-3720-uDPU.dts b/arch/arm/dts/armada-3720-uDPU.dts index 07c7b91175..7f4b8222f4 100644 --- a/arch/arm/dts/armada-3720-uDPU.dts +++ b/arch/arm/dts/armada-3720-uDPU.dts @@ -125,14 +125,14 @@ { pinctrl-0 = <_pins>; status = "okay"; - phy-mode = "2500base-x"; + phy-mode = "sgmii-2500"; managed = "in-band-status"; phy = <>; }; { status = "okay"; - phy-mode = "2500base-x"; + phy-mode = "sgmii-2500"; managed = "in-band-status"; phy = <>; }; -- Jakov Petrina