Re: [U-Boot] [PATCH] cmd: nvedit: env_get_f must check for env_get_char error codes

2018-02-07 Thread Maxime Ripard
On Mon, Feb 05, 2018 at 04:30:50PM +, York Sun wrote: > On 02/05/2018 05:44 AM, Maxime Ripard wrote: > > Hi York, > > > > On Fri, Feb 02, 2018 at 08:04:12PM +, York Sun wrote: > >> On 02/02/2018 10:51 AM, Maxime Ripard wrote: > > This patch looks correct. But it doesn't fix NOR flash.

Re: [U-Boot] [PATCH] cmd: nvedit: env_get_f must check for env_get_char error codes

2018-02-05 Thread York Sun
On 02/05/2018 05:44 AM, Maxime Ripard wrote: > Hi York, > > On Fri, Feb 02, 2018 at 08:04:12PM +, York Sun wrote: >> On 02/02/2018 10:51 AM, Maxime Ripard wrote: > This patch looks correct. But it doesn't fix NOR flash. Do you have plan > to add .get_char function to other drivers?

Re: [U-Boot] [PATCH] cmd: nvedit: env_get_f must check for env_get_char error codes

2018-02-05 Thread Maxime Ripard
Hi York, On Fri, Feb 02, 2018 at 08:04:12PM +, York Sun wrote: > On 02/02/2018 10:51 AM, Maxime Ripard wrote: > >>> This patch looks correct. But it doesn't fix NOR flash. Do you have plan > >>> to add .get_char function to other drivers? Without that function, we > >>> cannot get env

Re: [U-Boot] [PATCH] cmd: nvedit: env_get_f must check for env_get_char error codes

2018-02-03 Thread Goldschmidt Simon
On 02/02/2018 21:04, York Sun wrote: > On 02/02/2018 10:51 AM, Maxime Ripard wrote: > > > > Simon, This patch looks correct. But it doesn't fix NOR flash. Do you have plan to add .get_char function to other drivers? Without that function, we cannot get env variables

Re: [U-Boot] [PATCH] cmd: nvedit: env_get_f must check for env_get_char error codes

2018-02-02 Thread York Sun
On 02/02/2018 10:51 AM, Maxime Ripard wrote: >>> Simon, >>> >>> This patch looks correct. But it doesn't fix NOR flash. Do you have plan >>> to add .get_char function to other drivers? Without that function, we >>> cannot get env variables before relocation. >> >> Ehrm, sorry  I don't plan

Re: [U-Boot] [PATCH] cmd: nvedit: env_get_f must check for env_get_char error codes

2018-02-02 Thread Maxime Ripard
Hi Simon, On Thu, Feb 01, 2018 at 10:16:46AM +0100, Simon Goldschmidt wrote: > On 01.02.2018 00:00, York Sun wrote: > > On 01/30/2018 10:57 PM, Simon Goldschmidt wrote: > > > env_get_f calls env_get_char to load single characters from the > > > environment. However, the return value of

Re: [U-Boot] [PATCH] cmd: nvedit: env_get_f must check for env_get_char error codes

2018-02-01 Thread Simon Goldschmidt
On 01.02.2018 00:00, York Sun wrote: On 01/30/2018 10:57 PM, Simon Goldschmidt wrote: env_get_f calls env_get_char to load single characters from the environment. However, the return value of env_get_char was not checked for errors. Now if the env driver does not support the .get_char call,

Re: [U-Boot] [PATCH] cmd: nvedit: env_get_f must check for env_get_char error codes

2018-01-31 Thread York Sun
On 01/30/2018 10:57 PM, Simon Goldschmidt wrote: > env_get_f calls env_get_char to load single characters from the > environment. However, the return value of env_get_char was not > checked for errors. Now if the env driver does not support the > .get_char call, env_get_f did not notice this and

Re: [U-Boot] [PATCH] cmd: nvedit: env_get_f must check for env_get_char error codes

2018-01-31 Thread Maxime Ripard
On Wed, Jan 31, 2018 at 07:56:48AM +0100, Simon Goldschmidt wrote: > env_get_f calls env_get_char to load single characters from the > environment. However, the return value of env_get_char was not > checked for errors. Now if the env driver does not support the > .get_char call, env_get_f did not