Re: [U-Boot] [PATCH v2] env: only build env_embedded and envcrc when needed

2009-09-23 Thread Mike Frysinger
On Tuesday 22 September 2009 16:43:14 Wolfgang Denk wrote: Mike Frysinger wrote: i saw it as custom embedding of the environment. the only thing it does is enable the envcrc binary. i thought of using CONFIG_ENVCRC, but it seemed a little too short. CONFIG_ENABLE_ENVCRC ?

Re: [U-Boot] [PATCH v2] env: only build env_embedded and envcrc when needed

2009-09-22 Thread Wolfgang Denk
Dear Mike Frysinger, In message 200909151739.11704.vap...@gentoo.org you wrote: i saw it as custom embedding of the environment. the only thing it does is enable the envcrc binary. i thought of using CONFIG_ENVCRC, but it seemed a little too short. CONFIG_ENABLE_ENVCRC ?

Re: [U-Boot] [PATCH v2] env: only build env_embedded and envcrc when needed

2009-09-15 Thread Wolfgang Denk
Dear Mike Frysinger, In message 200909091032.17175.vap...@gentoo.org you wrote: Hm.. normally we don't add code without users... it's already in use, i just need to basically run sed to change it from current name to the new one. I don't see any users in mainline, though. Or am I missing

Re: [U-Boot] [PATCH v2] env: only build env_embedded and envcrc when needed

2009-09-15 Thread Mike Frysinger
On Tuesday 15 September 2009 16:44:23 Wolfgang Denk wrote: Mike Frysinger wrote: Also, I see no documentation for it? guessing you want it added to the top level README ? Indeed. What's the name supposed to mean? The envrionment is embedded custom sounds strange to me. i

Re: [U-Boot] [PATCH v2] env: only build env_embedded and envcrc when needed

2009-09-09 Thread Wolfgang Denk
Dear Mike Frysinger, In message 1252498455-28276-1-git-send-email-vap...@gentoo.org you wrote: The env code is protected by the ENV_IS_EMBEDDED define, so attempting to compile the code when this isn't defined is pointless. Now that the env headers have unified around CONFIG_ENV_IS_EMBEDDED,

Re: [U-Boot] [PATCH v2] env: only build env_embedded and envcrc when needed

2009-09-09 Thread Mike Frysinger
On Wednesday 09 September 2009 09:33:20 Wolfgang Denk wrote: Mike Frysinger wrote: The env code is protected by the ENV_IS_EMBEDDED define, so attempting to compile the code when this isn't defined is pointless. Now that the env headers have unified around CONFIG_ENV_IS_EMBEDDED, convert

Re: [U-Boot] [PATCH v2] env: only build env_embedded and envcrc when needed

2009-09-09 Thread Wolfgang Denk
Dear Mike Frysinger, In message 200909091002.40958.vap...@gentoo.org you wrote: I guess this is CONFIG_ENV_IS_EMBEDDED_CUSTOM then? Hm... but I see no users of this variable, nobody is setting it? Blackfin has been using ENV_IS_EMBEDDED_CUSTOM. i have a patch to update it to

Re: [U-Boot] [PATCH v2] env: only build env_embedded and envcrc when needed

2009-09-09 Thread Mike Frysinger
On Wednesday 09 September 2009 10:26:20 Wolfgang Denk wrote: Mike Frysinger wrote: I guess this is CONFIG_ENV_IS_EMBEDDED_CUSTOM then? Hm... but I see no users of this variable, nobody is setting it? Blackfin has been using ENV_IS_EMBEDDED_CUSTOM. i have a patch to update it to