Re: [U-Boot] [PATCH v2] env: only build env_embedded and envcrc when needed
On Tuesday 22 September 2009 16:43:14 Wolfgang Denk wrote: Mike Frysinger wrote: i saw it as custom embedding of the environment. the only thing it does is enable the envcrc binary. i thought of using CONFIG_ENVCRC, but it seemed a little too short. CONFIG_ENABLE_ENVCRC ? CONFIG_BUILD_ENVCRC ? the name doesnt really matter to me. if you're fine with CONFIG_BUILD_ENVCRC, i'll use that in common code and keep the CONFIG_ENV_IS_EMBEDDED_CUSTOM in the Blackfin specific code. CONFIG_BUILD_ENVCRC is fine with me (and I'd rather see if you got rid of this unwieldy CONFIG_ENV_IS_EMBEDDED_CUSTOM thingy). so i'll have envcrc controlled by CONFIG_BUILD_ENVCRC and i'll control embedding the env in the LDR by CONFIG_EMBEDDED_ENV_IN_LDR. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] env: only build env_embedded and envcrc when needed
Dear Mike Frysinger, In message 200909151739.11704.vap...@gentoo.org you wrote: i saw it as custom embedding of the environment. the only thing it does is enable the envcrc binary. i thought of using CONFIG_ENVCRC, but it seemed a little too short. CONFIG_ENABLE_ENVCRC ? CONFIG_BUILD_ENVCRC ? the name doesnt really matter to me. if you're fine with CONFIG_BUILD_ENVCRC, i'll use that in common code and keep the CONFIG_ENV_IS_EMBEDDED_CUSTOM in the Blackfin specific code. CONFIG_BUILD_ENVCRC is fine with me (and I'd rather see if you got rid of this unwieldy CONFIG_ENV_IS_EMBEDDED_CUSTOM thingy). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Leave bigotry in your quarters; there's no room for it on the bridge. -- Kirk, Balance of Terror, stardate 1709.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] env: only build env_embedded and envcrc when needed
Dear Mike Frysinger, In message 200909091032.17175.vap...@gentoo.org you wrote: Hm.. normally we don't add code without users... it's already in use, i just need to basically run sed to change it from current name to the new one. I don't see any users in mainline, though. Or am I missing something? Also, I see no documentation for it? guessing you want it added to the top level README ? Indeed. What's the name supposed to mean? The envrionment is embedded custom sounds strange to me. i saw it as custom embedding of the environment. the only thing it does is enable the envcrc binary. i thought of using CONFIG_ENVCRC, but it seemed a little too short. CONFIG_ENABLE_ENVCRC ? CONFIG_BUILD_ENVCRC ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de To live is always desirable. -- Eleen the Capellan, Friday's Child, stardate 3498.9 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] env: only build env_embedded and envcrc when needed
On Tuesday 15 September 2009 16:44:23 Wolfgang Denk wrote: Mike Frysinger wrote: Also, I see no documentation for it? guessing you want it added to the top level README ? Indeed. What's the name supposed to mean? The envrionment is embedded custom sounds strange to me. i saw it as custom embedding of the environment. the only thing it does is enable the envcrc binary. i thought of using CONFIG_ENVCRC, but it seemed a little too short. CONFIG_ENABLE_ENVCRC ? CONFIG_BUILD_ENVCRC ? the name doesnt really matter to me. if you're fine with CONFIG_BUILD_ENVCRC, i'll use that in common code and keep the CONFIG_ENV_IS_EMBEDDED_CUSTOM in the Blackfin specific code. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] env: only build env_embedded and envcrc when needed
Dear Mike Frysinger, In message 1252498455-28276-1-git-send-email-vap...@gentoo.org you wrote: The env code is protected by the ENV_IS_EMBEDDED define, so attempting to compile the code when this isn't defined is pointless. Now that the env headers have unified around CONFIG_ENV_IS_EMBEDDED, convert the build system to only build the env objects when this is enabled. And now that the env code is conditionally compiled, we can drop the source code checks. For people who want to extract the environment manually, add a new option that only enables the envcrc utility. Add a new option...? I guess this is CONFIG_ENV_IS_EMBEDDED_CUSTOM then? Hm... but I see no users of this variable, nobody is setting it? Also, I see no documentation for it? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Of course there's no reason for it, it's just our policy. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] env: only build env_embedded and envcrc when needed
On Wednesday 09 September 2009 09:33:20 Wolfgang Denk wrote: Mike Frysinger wrote: The env code is protected by the ENV_IS_EMBEDDED define, so attempting to compile the code when this isn't defined is pointless. Now that the env headers have unified around CONFIG_ENV_IS_EMBEDDED, convert the build system to only build the env objects when this is enabled. And now that the env code is conditionally compiled, we can drop the source code checks. For people who want to extract the environment manually, add a new option that only enables the envcrc utility. Add a new option...? I guess this is CONFIG_ENV_IS_EMBEDDED_CUSTOM then? Hm... but I see no users of this variable, nobody is setting it? Blackfin has been using ENV_IS_EMBEDDED_CUSTOM. i have a patch to update it to CONFIG_xxx, but was waiting for this to be accepted first. Also, I see no documentation for it? guessing you want it added to the top level README ? -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] env: only build env_embedded and envcrc when needed
Dear Mike Frysinger, In message 200909091002.40958.vap...@gentoo.org you wrote: I guess this is CONFIG_ENV_IS_EMBEDDED_CUSTOM then? Hm... but I see no users of this variable, nobody is setting it? Blackfin has been using ENV_IS_EMBEDDED_CUSTOM. i have a patch to update it to CONFIG_xxx, but was waiting for this to be accepted first. Hm.. normally we don't add code without users... Also, I see no documentation for it? guessing you want it added to the top level README ? Indeed. What's the name supposed to mean? The envrionment is embedded custom sounds strange to me. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de One essential to success is that you desire be an all-obsessing one, your thoughts and aims be co-ordinated, and your energy be concentra- ted and applied without letup. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] env: only build env_embedded and envcrc when needed
On Wednesday 09 September 2009 10:26:20 Wolfgang Denk wrote: Mike Frysinger wrote: I guess this is CONFIG_ENV_IS_EMBEDDED_CUSTOM then? Hm... but I see no users of this variable, nobody is setting it? Blackfin has been using ENV_IS_EMBEDDED_CUSTOM. i have a patch to update it to CONFIG_xxx, but was waiting for this to be accepted first. Hm.. normally we don't add code without users... it's already in use, i just need to basically run sed to change it from current name to the new one. Also, I see no documentation for it? guessing you want it added to the top level README ? Indeed. What's the name supposed to mean? The envrionment is embedded custom sounds strange to me. i saw it as custom embedding of the environment. the only thing it does is enable the envcrc binary. i thought of using CONFIG_ENVCRC, but it seemed a little too short. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
