Re: [U-Boot] [PATCH v2 00/10] splash screen on the stm32f769 disco board
Thanks Patrice, On 03/12/2018 10:09 AM, Patrice CHOTARD wrote: > Hi Vikas > > On 03/06/2018 08:44 PM, Vikas Manocha wrote: >> Hi Patrice/Yannick, >> >> On 03/05/2018 11:50 PM, Patrice CHOTARD wrote: There seems to be a dependency on patch for include/dt-bindings/mfd/stm32f7-rcc.h adding some new macros. Is it also submitted to the list? >>> Right, needed patches are already on the list >>> http://patchwork.ozlabs.org/patch/870938/ >> >> Great addition ! >> >> Few points: >> it seems above mentioned patchset also has dependency on another patchset >> http://patchwork.ozlabs.org/patch/870283/ >> After applying these two dependency patchsets, it creates conflicts with >> pathch "ARM: dts: stm32: Add timer support for STM32F7". >> I understand you want to get it reviewed without waiting for other patchset >> acceptance, it would be good to mention all the dependencies. >> >> Also i observe that without applying f769 display patches, f746 display >> didn't work. >> And F769 board display is not working, i see one error log: >> >> Board 1: >> stm32_ltdc_probe: decode display timing error -4 >> & Board 2: >> stm32_ltdc_probe: decode display timing error -668998023 >> >> Cheers, >> Vikas >> >>> >>> Patrice >>> > > > We got a look at this issue with Yannick. > > On my side, i got this problem because i used the > stm32f746-disco_defconfig by updating CONFIG_DEFAULT_DEVICE_TREE with > the following update, (and i suppose you do the same ;-) ): > > CONFIG_DEFAULT_DEVICE_TREE="stm32f769-disco" > > By using the stm32f769-disco_defconfig, everything is working fine. > That's why Yannick added a dedicated defconfig file for STM32F769. oh, i was also passing DEVICE_TREE during compilation. With the stm32f769 config, it still stops after DRAM size. " U-Boot SPL 2018.03-rc4-00055-g0d3c012-dirty (Mar 12 2018 - 11:31:20 -0700) Trying to boot from XIP U-Boot 2018.03-rc4-00055-g0d3c012-dirty (Mar 12 2018 - 11:31:20 -0700) Model: STMicroelectronics STM32F769-DISCO board DRAM: 16 MiB " But I don't want to hold on for the series. Acked-by: Vikas Manocha Cheers, Vikas > > Patrice > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 00/10] splash screen on the stm32f769 disco board
Hi Vikas On 03/06/2018 08:44 PM, Vikas Manocha wrote: > Hi Patrice/Yannick, > > On 03/05/2018 11:50 PM, Patrice CHOTARD wrote: >>> There seems to be a dependency on patch for >>> include/dt-bindings/mfd/stm32f7-rcc.h >>> adding some new macros. Is it also submitted to the list? >> Right, needed patches are already on the list >> http://patchwork.ozlabs.org/patch/870938/ > > Great addition ! > > Few points: > it seems above mentioned patchset also has dependency on another patchset > http://patchwork.ozlabs.org/patch/870283/ > After applying these two dependency patchsets, it creates conflicts with > pathch "ARM: dts: stm32: Add timer support for STM32F7". > I understand you want to get it reviewed without waiting for other patchset > acceptance, it would be good to mention all the dependencies. > > Also i observe that without applying f769 display patches, f746 display > didn't work. > And F769 board display is not working, i see one error log: > > Board 1: > stm32_ltdc_probe: decode display timing error -4 > & Board 2: > stm32_ltdc_probe: decode display timing error -668998023 > > Cheers, > Vikas > >> >> Patrice >> We got a look at this issue with Yannick. On my side, i got this problem because i used the stm32f746-disco_defconfig by updating CONFIG_DEFAULT_DEVICE_TREE with the following update, (and i suppose you do the same ;-) ): CONFIG_DEFAULT_DEVICE_TREE="stm32f769-disco" By using the stm32f769-disco_defconfig, everything is working fine. That's why Yannick added a dedicated defconfig file for STM32F769. Patrice ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 00/10] splash screen on the stm32f769 disco board
Hi Vikas +Benjamin On 03/06/2018 08:44 PM, Vikas Manocha wrote: > Hi Patrice/Yannick, > > On 03/05/2018 11:50 PM, Patrice CHOTARD wrote: >>> There seems to be a dependency on patch for >>> include/dt-bindings/mfd/stm32f7-rcc.h >>> adding some new macros. Is it also submitted to the list? >> Right, needed patches are already on the list >> http://patchwork.ozlabs.org/patch/870938/ > > Great addition ! > > Few points: > it seems above mentioned patchset also has dependency on another patchset > http://patchwork.ozlabs.org/patch/870283/ > After applying these two dependency patchsets, it creates conflicts with > pathch "ARM: dts: stm32: Add timer support for STM32F7". If the following series are applied first, there is no issue: http://patchwork.ozlabs.org/project/uboot/list/?series=27330 http://patchwork.ozlabs.org/project/uboot/list/?series=27607 > I understand you want to get it reviewed without waiting for other patchset > acceptance, it would be good to mention all the dependencies. Agree, we will pay attention to that point in the future. > > Also i observe that without applying f769 display patches, f746 display > didn't work. Yes, i observed the same issue, the f769 patch http://patchwork.ozlabs.org/patch/880593/ fixes the 746 display > And F769 board display is not working, i see one error log: > > Board 1: > stm32_ltdc_probe: decode display timing error -4 > & Board 2: > stm32_ltdc_probe: decode display timing error -668998023 I confirm too, Yannick is the best person to explain why . Thanks Patrice > > Cheers, > Vikas > >> >> Patrice >> ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 00/10] splash screen on the stm32f769 disco board
Hi Patrice/Yannick, On 03/05/2018 11:50 PM, Patrice CHOTARD wrote: >> There seems to be a dependency on patch for >> include/dt-bindings/mfd/stm32f7-rcc.h >> adding some new macros. Is it also submitted to the list? > Right, needed patches are already on the list > http://patchwork.ozlabs.org/patch/870938/ Great addition ! Few points: it seems above mentioned patchset also has dependency on another patchset http://patchwork.ozlabs.org/patch/870283/ After applying these two dependency patchsets, it creates conflicts with pathch "ARM: dts: stm32: Add timer support for STM32F7". I understand you want to get it reviewed without waiting for other patchset acceptance, it would be good to mention all the dependencies. Also i observe that without applying f769 display patches, f746 display didn't work. And F769 board display is not working, i see one error log: Board 1: stm32_ltdc_probe: decode display timing error -4 & Board 2: stm32_ltdc_probe: decode display timing error -668998023 Cheers, Vikas > > Patrice > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 00/10] splash screen on the stm32f769 disco board
Hi Simon, On Tue, 6 Mar 2018 10:51:29 -0700 Simon Glass s...@chromium.org wrote: ... > Does this use driver model? I cannot see it. Panel drivers in patches 4/10 and 7/10 use driver model. MIPI DSI driver in patch 6/10 uses DM, too. -- Anatolij ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 00/10] splash screen on the stm32f769 disco board
On 2 March 2018 at 08:44, yannick fertre wrote: > > Version 2: > - Replace debug log by pr_error, pr_warn or pr_info. > - Rework bridge between ltdc & dsi panel > - Rework backligh management (with or witout gpio) > - Rework panel otm8009a > - Add new panel raydium rm68200 > > Version 1: > - Initial commit > > This serie contains all patchsets needed for displaying a splash screen > on the stm32f769 disco board. > > yannick fertre (10): > video: stm32: stm32_ltdc: add bridge to display controller > video: stm32: stm32_ltdc: update debug log > video: add support of MIPI DSI interface > video: add support of panel OTM8009A > video: add MIPI DSI host controller bridge > video: add support of STM32 MIPI DSI controller driver > video: add support of panel rm68200 > arm: dts: stm32: add dsi for STM32F746 > arm: dts: stm32: add display for STM32F769 disco board > board: Add STM32F769 SoC, discovery board support > > arch/arm/dts/stm32f746.dtsi| 12 + > arch/arm/dts/stm32f769-disco.dts | 71 > configs/stm32f769-disco_defconfig | 63 +++ > drivers/video/Kconfig | 32 ++ > drivers/video/Makefile | 4 + > drivers/video/dw_mipi_dsi.c| 822 > + > drivers/video/mipi_display.c | 807 > drivers/video/orisetech_otm8009a.c | 329 +++ > drivers/video/raydium-rm68200.c| 329 +++ > drivers/video/stm32/Kconfig| 10 + > drivers/video/stm32/Makefile | 1 + > drivers/video/stm32/stm32_dsi.c| 427 +++ > drivers/video/stm32/stm32_ltdc.c | 144 --- > include/dw_mipi_dsi.h | 32 ++ > include/mipi_display.h | 257 +++- > 15 files changed, 3285 insertions(+), 55 deletions(-) > create mode 100644 configs/stm32f769-disco_defconfig > create mode 100644 drivers/video/dw_mipi_dsi.c > create mode 100644 drivers/video/mipi_display.c > create mode 100644 drivers/video/orisetech_otm8009a.c > create mode 100644 drivers/video/raydium-rm68200.c > create mode 100644 drivers/video/stm32/stm32_dsi.c > create mode 100644 include/dw_mipi_dsi.h Does this use driver model? I cannot see it. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 00/10] splash screen on the stm32f769 disco board
Hi Patrice, On Tue, 6 Mar 2018 07:50:20 + Patrice CHOTARD patrice.chot...@st.com wrote: ... > Right, needed patches are already on the list > http://patchwork.ozlabs.org/patch/870938/ Okay, then I'll wait until Tom merges this stm clk series. Thanks! -- Anatolij ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 00/10] splash screen on the stm32f769 disco board
Hi Anatolij On 03/05/2018 11:51 PM, Anatolij Gustschin wrote: > On Fri, 2 Mar 2018 16:44:01 +0100 > yannick fertre yannick.fer...@st.com wrote: > >> Version 2: >> - Replace debug log by pr_error, pr_warn or pr_info. >> - Rework bridge between ltdc & dsi panel >> - Rework backligh management (with or witout gpio) >> - Rework panel otm8009a >> - Add new panel raydium rm68200 >> >> Version 1: >> - Initial commit >> >> This serie contains all patchsets needed for displaying a splash screen >> on the stm32f769 disco board. >> >> yannick fertre (10): >>video: stm32: stm32_ltdc: add bridge to display controller >>video: stm32: stm32_ltdc: update debug log >>video: add support of MIPI DSI interface >>video: add support of panel OTM8009A >>video: add MIPI DSI host controller bridge >>video: add support of STM32 MIPI DSI controller driver >>video: add support of panel rm68200 >>arm: dts: stm32: add dsi for STM32F746 >>arm: dts: stm32: add display for STM32F769 disco board >>board: Add STM32F769 SoC, discovery board support > > With this series applied some dtbs fail to build: > ... >DTC arch/arm/dts/stm32f746-disco.dtb >DTC arch/arm/dts/stm32f769-disco.dtb > Error: arch/arm/dts/stm32f746.dtsi:339.20-21 syntax error > FATAL ERROR: Unable to parse input tree > scripts/Makefile.lib:329: recipe for target > 'arch/arm/dts/stm32f746-disco.dtb' failed > make[2]: *** [arch/arm/dts/stm32f746-disco.dtb] Error 1 > make[2]: *** Waiting for unfinished jobs > Error: arch/arm/dts/stm32f746.dtsi:339.20-21 syntax error > FATAL ERROR: Unable to parse input tree > scripts/Makefile.lib:329: recipe for target > 'arch/arm/dts/stm32f769-disco.dtb' failed > make[2]: *** [arch/arm/dts/stm32f769-disco.dtb] Error 1 > dts/Makefile:46: recipe for target 'arch-dtbs' failed > make[1]: *** [arch-dtbs] Error 2 > Makefile:880: recipe for target 'dts/dt.dtb' failed > make: *** [dts/dt.dtb] Error 2 > > There seems to be a dependency on patch for > include/dt-bindings/mfd/stm32f7-rcc.h > adding some new macros. Is it also submitted to the list? Right, needed patches are already on the list http://patchwork.ozlabs.org/patch/870938/ Patrice > > -- > Anatolij > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 00/10] splash screen on the stm32f769 disco board
On Fri, 2 Mar 2018 16:44:01 +0100 yannick fertre yannick.fer...@st.com wrote: > Version 2: > - Replace debug log by pr_error, pr_warn or pr_info. > - Rework bridge between ltdc & dsi panel > - Rework backligh management (with or witout gpio) > - Rework panel otm8009a > - Add new panel raydium rm68200 > > Version 1: > - Initial commit > > This serie contains all patchsets needed for displaying a splash screen > on the stm32f769 disco board. > > yannick fertre (10): > video: stm32: stm32_ltdc: add bridge to display controller > video: stm32: stm32_ltdc: update debug log > video: add support of MIPI DSI interface > video: add support of panel OTM8009A > video: add MIPI DSI host controller bridge > video: add support of STM32 MIPI DSI controller driver > video: add support of panel rm68200 > arm: dts: stm32: add dsi for STM32F746 > arm: dts: stm32: add display for STM32F769 disco board > board: Add STM32F769 SoC, discovery board support With this series applied some dtbs fail to build: ... DTC arch/arm/dts/stm32f746-disco.dtb DTC arch/arm/dts/stm32f769-disco.dtb Error: arch/arm/dts/stm32f746.dtsi:339.20-21 syntax error FATAL ERROR: Unable to parse input tree scripts/Makefile.lib:329: recipe for target 'arch/arm/dts/stm32f746-disco.dtb' failed make[2]: *** [arch/arm/dts/stm32f746-disco.dtb] Error 1 make[2]: *** Waiting for unfinished jobs Error: arch/arm/dts/stm32f746.dtsi:339.20-21 syntax error FATAL ERROR: Unable to parse input tree scripts/Makefile.lib:329: recipe for target 'arch/arm/dts/stm32f769-disco.dtb' failed make[2]: *** [arch/arm/dts/stm32f769-disco.dtb] Error 1 dts/Makefile:46: recipe for target 'arch-dtbs' failed make[1]: *** [arch-dtbs] Error 2 Makefile:880: recipe for target 'dts/dt.dtb' failed make: *** [dts/dt.dtb] Error 2 There seems to be a dependency on patch for include/dt-bindings/mfd/stm32f7-rcc.h adding some new macros. Is it also submitted to the list? -- Anatolij ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot