Re: [U-Boot] [PATCH v6 34/34] imx: add i.MX8QXP MEK board support
> -Original Message- > From: Fabio Estevam [mailto:feste...@gmail.com] > Sent: 2018年11月7日 20:36 > To: Jon Nettleton ; Peng Fan > Cc: thar...@gateworks.com; Fabio Estevam ; > U-Boot-Denx > Subject: Re: [U-Boot] [PATCH v6 34/34] imx: add i.MX8QXP MEK board support > > + Peng > > On Wed, Nov 7, 2018 at 4:58 AM Jon Nettleton wrote: > > > > I have been spending some time on this, at least from the lpddr4 side. > > There is a good amount of this that can be abstracted out and made > > into general initialization routines. This is all well and good and > > you can see that Boundary Devices has already codified some of these > > values here. > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit > > > hub.com%2Fboundarydevices%2Fu-boot-imx6%2Fblob%2Fboundary-v2018.07% > 2Fb > > > oard%2Fboundary%2Fnitrogen8m%2Fddr%2Fddrphy_train.cdata=02%7C > 01%7 > > > Cpeng.fan%40nxp.com%7C9ed74670423a422dd7f108d644ad89f0%7C686ea1d > 3bc2b4 > > > c6fa92cd99c5c301635%7C0%7C0%7C636771909469703915sdata=WJtl5 > C4Z5YU > > GLLKZUV6AVfGYjwzFIc7GojsBS8S%2BMWg%3Dreserved=0 > > > > However after you generate the script from the spreadsheet you then > > need to run it through a calibration routine, which is a Windows > > program that takes the values from the spreadsheets and runs them > > against the device and provides some tuned phy values based on the > > device. I don't see a good way to get around just having this chunk > > of code be a board specific function that runs the register settings > > that are spit out by the NXP tool. > > > > As for the initialization I am not sure how much changes depending if > > the board is using DDR3, DDR4 or LPDDR4. It would be great if we > > could come up with some general direction on this and move things > > forward. > > Peng on Cc has been working on this and hopefully will be able to post a new > series soon. Yes, the related patches will be sent out after some test, should be soon. Regards, Peng. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v6 34/34] imx: add i.MX8QXP MEK board support
+ Peng On Wed, Nov 7, 2018 at 4:58 AM Jon Nettleton wrote: > > I have been spending some time on this, at least from the lpddr4 side. > There is a good amount of this that can be abstracted out and made > into general initialization routines. This is all well and good and > you can see that Boundary Devices has already codified some of these > values here. > https://github.com/boundarydevices/u-boot-imx6/blob/boundary-v2018.07/board/boundary/nitrogen8m/ddr/ddrphy_train.c > > However after you generate the script from the spreadsheet you then > need to run it through a calibration routine, which is a Windows > program that takes the values from the spreadsheets and runs them > against the device and provides some tuned phy values based on the > device. I don't see a good way to get around just having this chunk > of code be a board specific function that runs the register settings > that are spit out by the NXP tool. > > As for the initialization I am not sure how much changes depending if > the board is using DDR3, DDR4 or LPDDR4. It would be great if we > could come up with some general direction on this and move things > forward. Peng on Cc has been working on this and hopefully will be able to post a new series soon. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v6 34/34] imx: add i.MX8QXP MEK board support
I have been spending some time on this, at least from the lpddr4 side. There is a good amount of this that can be abstracted out and made into general initialization routines. This is all well and good and you can see that Boundary Devices has already codified some of these values here. https://github.com/boundarydevices/u-boot-imx6/blob/boundary-v2018.07/board/boundary/nitrogen8m/ddr/ddrphy_train.c However after you generate the script from the spreadsheet you then need to run it through a calibration routine, which is a Windows program that takes the values from the spreadsheets and runs them against the device and provides some tuned phy values based on the device. I don't see a good way to get around just having this chunk of code be a board specific function that runs the register settings that are spit out by the NXP tool. As for the initialization I am not sure how much changes depending if the board is using DDR3, DDR4 or LPDDR4. It would be great if we could come up with some general direction on this and move things forward. -Jon On Sat, Oct 27, 2018 at 7:56 PM Fabio Estevam wrote: > > Hi Tim, > > On Fri, Oct 26, 2018 at 2:18 PM Tim Harvey wrote: > > > Can you point me to the NXP DDR tool for IMX8? I'm just getting > > started with the IMX8M and haven't run into it yet. DDR calibration > > was a huge pain for us for IMX6. > > You can find it here: > https://community.nxp.com/docs/DOC-340179 > ___ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v6 34/34] imx: add i.MX8QXP MEK board support
Hi Tim, On Fri, Oct 26, 2018 at 2:18 PM Tim Harvey wrote: > Can you point me to the NXP DDR tool for IMX8? I'm just getting > started with the IMX8M and haven't run into it yet. DDR calibration > was a huge pain for us for IMX6. You can find it here: https://community.nxp.com/docs/DOC-340179 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v6 34/34] imx: add i.MX8QXP MEK board support
On Thu, Oct 25, 2018 at 5:46 PM Peng Fan wrote: > > Hi Tim, > > > -Original Message- > > From: Tim Harvey [mailto:thar...@gateworks.com] > > Sent: 2018年10月26日 5:10 > > To: Anatolij Gustschin ; Peng Fan > > Cc: u-boot ; Stefano Babic ; Fabio > > Estevam > > Subject: Re: [U-Boot] [PATCH v6 34/34] imx: add i.MX8QXP MEK board support > > > > On Thu, Oct 18, 2018 at 5:52 AM Anatolij Gustschin wrote: > > > > > > From: Peng Fan > > > > > > Add i.MX8QXP MEK board support > > > Enabled pinctrl/clk/power-domain/mmc/i2c/fec driver. > > > Added README file. > > > > > > Signed-off-by: Peng Fan > > > Reviewed-by: Anatolij Gustschin > > > Cc: Stefano Babic > > > Cc: Fabio Estevam > > > --- > > > arch/arm/dts/Makefile | 2 + > > > arch/arm/dts/fsl-imx8qxp-mek.dts | 246 > > ++ > > > arch/arm/mach-imx/imx8/Kconfig| 13 ++ > > > board/freescale/imx8qxp_mek/Kconfig | 14 ++ > > > board/freescale/imx8qxp_mek/MAINTAINERS | 6 + > > > board/freescale/imx8qxp_mek/Makefile | 7 + > > > board/freescale/imx8qxp_mek/README| 72 +++ > > > board/freescale/imx8qxp_mek/imx8qxp_mek.c | 170 +++ > > > board/freescale/mx8mq_evk/README | 81 +++ > > > > Peng, > > > > Was the inclusion of the mx8mq_evk/README a mistake as this patch was > > centered around adding support for the i.MX8QXP MEK board? > > That file was added by mistaken. > > > > > I'm interested in building mainline U-Boot for the NXP i.MX 8M Quad > > Evaluation > > Kit (IMX8MQUADEVKQSG) which I assume is what the mx8mq_evk is for. Do you > > have plans to submit the rest of what's required for this board > > (configs/mx8mq_evk_defconfig, board/freescale/mx8mq_evk/*, > > arch/arm/dts/fsl-imx8mq-evk.dts). > > > > It looks like inclusion of imx8mq-evk was was in a patch series early this > > year and > > got stalled for some reason? > > The ddr script is not good enough for upstream. I have asked help internal to > restructure the code, > but seems I have to be the guy working on this again. > > My current plan is the board support including ddr and mkimage could be ready > in next RC1. > Peng, Ok - thanks for the update. If you remember at the time please cc me on the imx8mq-evk patch series and I will be happy to test. I read through the discussion regarding the ddr init from your v5 submission (https://patchwork.ozlabs.org/patch/857974/). You mention in that discussion that there is a ddr tool developed by NXP much like the one used for i.MX6/7. I remember using a DDR config tool from Freescale which was a spreadsheet and we ended up writing the ddr init code for imx6 SPL that followed the equations in that spreadsheet along with the ddr init sequence from the IMX6 reference manual. Could this be done here as well? Can you point me to the NXP DDR tool for IMX8? I'm just getting started with the IMX8M and haven't run into it yet. DDR calibration was a huge pain for us for IMX6. Also, for your next submission for imx8m-evk please think about the following: - rename mx8mq to imx8mq to be consistent with what you did for imx8qxp_mek - consider adding a flash map to the README showing where imx-mkimage is putting everything in the flash.bin image I tried to apply your v5 imx8mq-evk patch on top of the latest master but ran into build issues so I'm anxiously awaiting your next submission! Best Regards, Tim ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v6 34/34] imx: add i.MX8QXP MEK board support
Hi Tim, > -Original Message- > From: Tim Harvey [mailto:thar...@gateworks.com] > Sent: 2018年10月26日 5:10 > To: Anatolij Gustschin ; Peng Fan > Cc: u-boot ; Stefano Babic ; Fabio > Estevam > Subject: Re: [U-Boot] [PATCH v6 34/34] imx: add i.MX8QXP MEK board support > > On Thu, Oct 18, 2018 at 5:52 AM Anatolij Gustschin wrote: > > > > From: Peng Fan > > > > Add i.MX8QXP MEK board support > > Enabled pinctrl/clk/power-domain/mmc/i2c/fec driver. > > Added README file. > > > > Signed-off-by: Peng Fan > > Reviewed-by: Anatolij Gustschin > > Cc: Stefano Babic > > Cc: Fabio Estevam > > --- > > arch/arm/dts/Makefile | 2 + > > arch/arm/dts/fsl-imx8qxp-mek.dts | 246 > ++ > > arch/arm/mach-imx/imx8/Kconfig| 13 ++ > > board/freescale/imx8qxp_mek/Kconfig | 14 ++ > > board/freescale/imx8qxp_mek/MAINTAINERS | 6 + > > board/freescale/imx8qxp_mek/Makefile | 7 + > > board/freescale/imx8qxp_mek/README| 72 +++ > > board/freescale/imx8qxp_mek/imx8qxp_mek.c | 170 +++ > > board/freescale/mx8mq_evk/README | 81 +++ > > Peng, > > Was the inclusion of the mx8mq_evk/README a mistake as this patch was > centered around adding support for the i.MX8QXP MEK board? That file was added by mistaken. > > I'm interested in building mainline U-Boot for the NXP i.MX 8M Quad Evaluation > Kit (IMX8MQUADEVKQSG) which I assume is what the mx8mq_evk is for. Do you > have plans to submit the rest of what's required for this board > (configs/mx8mq_evk_defconfig, board/freescale/mx8mq_evk/*, > arch/arm/dts/fsl-imx8mq-evk.dts). > > It looks like inclusion of imx8mq-evk was was in a patch series early this > year and > got stalled for some reason? The ddr script is not good enough for upstream. I have asked help internal to restructure the code, but seems I have to be the guy working on this again. My current plan is the board support including ddr and mkimage could be ready in next RC1. Thanks, Peng. > > Regards, > > Tim ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v6 34/34] imx: add i.MX8QXP MEK board support
On Thu, Oct 18, 2018 at 5:52 AM Anatolij Gustschin wrote: > > From: Peng Fan > > Add i.MX8QXP MEK board support > Enabled pinctrl/clk/power-domain/mmc/i2c/fec driver. > Added README file. > > Signed-off-by: Peng Fan > Reviewed-by: Anatolij Gustschin > Cc: Stefano Babic > Cc: Fabio Estevam > --- > arch/arm/dts/Makefile | 2 + > arch/arm/dts/fsl-imx8qxp-mek.dts | 246 ++ > arch/arm/mach-imx/imx8/Kconfig| 13 ++ > board/freescale/imx8qxp_mek/Kconfig | 14 ++ > board/freescale/imx8qxp_mek/MAINTAINERS | 6 + > board/freescale/imx8qxp_mek/Makefile | 7 + > board/freescale/imx8qxp_mek/README| 72 +++ > board/freescale/imx8qxp_mek/imx8qxp_mek.c | 170 +++ > board/freescale/mx8mq_evk/README | 81 +++ Peng, Was the inclusion of the mx8mq_evk/README a mistake as this patch was centered around adding support for the i.MX8QXP MEK board? I'm interested in building mainline U-Boot for the NXP i.MX 8M Quad Evaluation Kit (IMX8MQUADEVKQSG) which I assume is what the mx8mq_evk is for. Do you have plans to submit the rest of what's required for this board (configs/mx8mq_evk_defconfig, board/freescale/mx8mq_evk/*, arch/arm/dts/fsl-imx8mq-evk.dts). It looks like inclusion of imx8mq-evk was was in a patch series early this year and got stalled for some reason? Regards, Tim ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
