[Bug 1719322] Re: Remove patch to remove headerbar

This bug was fixed in the package gnome-calculator - 1:3.26.0-3ubuntu1 --- gnome-calculator (1:3.26.0-3ubuntu1) bionic; urgency=medium * Sync with Debian (LP: #1719322). Remaining change: - Add epoch gnome-calculator (3.26.0-3) unstable; urgency=medium [ Jeremy Bicha ] *

[Bug 1719322] Re: Remove patch to remove headerbar

** Changed in: gnome-screenshot (Ubuntu) Status: Triaged => Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1719322 Title: Remove patch to remove headerbar To manage notifications

[Bug 1719322] Re: Remove patch to remove headerbar

This bug was fixed in the package totem - 3.26.0-0ubuntu3 --- totem (3.26.0-0ubuntu3) bionic; urgency=medium * Drop patches that provided old-style decorations and menus for Unity7. This conveniently also fixes LP: #1502476. LP: #1719322 -- Daniel van Vugt

[Bug 1719322] Re: Remove patch to remove headerbar

This bug was fixed in the package gedit - 3.22.1-3ubuntu1 --- gedit (3.22.1-3ubuntu1) bionic; urgency=medium * Sync with Debian. Remaining change: - debian/rules: + Make a compatibility desktop file for upgraders * Drop unity_no_csd.patch: No longer needed. (LP:

[Bug 1719322] Re: Remove patch to remove headerbar

This bug was fixed in the package evince - 3.26.0-3 --- evince (3.26.0-3) unstable; urgency=medium * Update Vcs fields for migration to https://salsa.debian.org/ * Bump debhelper compat to 11 * Drop obsolete patches (Closes: #876993, #886937) - traditional_menu_bar.patch

[Bug 1719322] Re: Remove patch to remove headerbar

This bug was fixed in the package eog - 3.26.2-3 --- eog (3.26.2-3) unstable; urgency=medium * Update Vcs fields for migration to https://salsa.debian.org/ * Bump debhelper compat to 11 * Drop obsolete patches (Closes: #881463) - 0001-Add-a-traditional-menu-bar.patch -

[Bug 1719322] Re: Remove patch to remove headerbar

This bug was fixed in the package file-roller - 3.26.2-3ubuntu1 --- file-roller (3.26.2-3ubuntu1) bionic; urgency=medium * Sync with Debian. Remaining change: - debian/rules: + Make a compatibility desktop file for upgraders * Drop bz_unity_header.patch: No longer

[Bug 1719322] Re: Remove patch to remove headerbar

** Changed in: totem (Ubuntu) Status: In Progress => Fix Committed ** Changed in: gnome-calculator (Ubuntu) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1719322] Re: Remove patch to remove headerbar

** Also affects: gedit (Ubuntu) Importance: Undecided Status: New ** Changed in: gedit (Ubuntu) Status: New => Fix Committed ** Description changed: - As of Artful, it seems that there are still patches against various apps - that remove/replace the Gtk.HeaderBar with a

[Bug 1719322] Re: Remove patch to remove headerbar

** Changed in: file-roller (Ubuntu) Status: Triaged => Fix Committed ** Changed in: eog (Ubuntu) Status: Triaged => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1719322

[Bug 1719322] Re: Remove patch to remove headerbar

** Changed in: evince (Ubuntu) Status: Triaged => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1719322 Title: Remove patch to remove headerbar To manage notifications about

[Bug 1719322] Re: Remove patch to remove headerbar

Totem: Menubar patches depends on if gnome-shell shows app-menu or not which is configurable in dconf. ** Patch added: "ubuntu-use-traditional-titlebars.patch" https://bugs.launchpad.net/ubuntu/+source/file-roller/+bug/1719322/+attachment/5012044/+files/ubuntu-use-traditional-titlebars.patch

[Bug 1719322] Re: Remove patch to remove headerbar

** Also affects: totem (Ubuntu) Importance: Undecided Status: New ** Changed in: totem (Ubuntu) Assignee: (unassigned) => Daniel van Vugt (vanvugt) ** Changed in: totem (Ubuntu) Status: New => In Progress ** Changed in: totem (Ubuntu) Importance: Undecided => Low --

[Bug 1719322] Re: Remove patch to remove headerbar

By "Xfce doesn't include..." I'll presume you mean Xubuntu, which in fact does include file-roller. I'd be very disappointed if the headerbars came back or were restricted to Unity. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1719322] Re: Remove patch to remove headerbar

Evince: converted from 2 to 1 ** Patch added: "unity_normal_titlebar.patch" https://bugs.launchpad.net/ubuntu/+source/file-roller/+bug/1719322/+attachment/5000892/+files/unity_normal_titlebar.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1719322] Re: Remove patch to remove headerbar

Eog: Converted from 2 to 1 ** Patch added: "0001-Add-a-traditional-menu-bar.patch" https://bugs.launchpad.net/ubuntu/+source/file-roller/+bug/1719322/+attachment/5000870/+files/0001-Add-a-traditional-menu-bar.patch -- You received this bug notification because you are a member of Ubuntu

[Bug 1719322] Re: Remove patch to remove headerbar

Evince: Converted from 2 to 1 ** Patch added: "traditional_menu_bar.patch" https://bugs.launchpad.net/ubuntu/+source/file-roller/+bug/1719322/+attachment/5000891/+files/traditional_menu_bar.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1719322] Re: Remove patch to remove headerbar

Eog: converted from 2 to 1 ** Patch added: "0002-Show-traditional-title-bar-in-unity.patch" https://bugs.launchpad.net/ubuntu/+source/file-roller/+bug/1719322/+attachment/5000820/+files/0002-Show-traditional-title-bar-in-unity.patch -- You received this bug notification because you are a

[Bug 1719322] Re: Remove patch to remove headerbar

@Jeremy Some apps do not need those, as they get all functions from header-bar buttons and gear menu like Gnome-Calendar. But for some header-bar apps as you know, preference is not under gear menu. If a user enables LIM in Unity (which is a very popular feature) they won't have access to

[Bug 1719322] Re: Remove patch to remove headerbar

The attachment "bz_unity_headerbar.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by

[Bug 1719322] Re: Remove patch to remove headerbar

Khurshid, are you aware that there are apps in the default Ubuntu install that never got these headerbar patches, like gnome-calendar and gnome-sudoku? And there are a rather large number of GNOME apps that aren't in the default install. Even Firefox is switching to headerbars, maybe by early

[Bug 1719322] Re: Remove patch to remove headerbar

Hi Jeremy, I converted file-roller patch from 2 to 1. See my above comment for details. Now, it will use titlebar only under Unity. All other sessions will use headerbar including pantheon. ** Patch added: "bz_unity_headerbar.patch"

[Bug 1719322] Re: Remove patch to remove headerbar

I am against this. These patches are needed for Unity. These patches are designed in two ways: 1) It will use title-bar only under Unity & headerbar under all non- unity sessions. 2) It will use header-bar only for Gnome session. 2 is the problem. What we need to do is convert 2 into 1. It

[Bug 1719322] Re: Remove patch to remove headerbar

I am reverting the file-roller change for Ubuntu 17.10 because of User Interface Freeze. ** Changed in: file-roller (Ubuntu) Status: Fix Released => Triaged ** Changed in: evince (Ubuntu) Status: Incomplete => Triaged ** Changed in: eog (Ubuntu) Status: Incomplete =>

[Bug 1719322] Re: Remove patch to remove headerbar

Thanks for your work on this Jeremy! We only release on LTS, so we're totally fine with waiting for 18.04 for the change. Just wanted to make sure we filed the issue before then :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1719322] Re: Remove patch to remove headerbar

gnome-contacts and epiphany-browser are not included in any Ubuntu flavors and I'd like to keep this change for artful for those packages (for reasons I mentioned briefly earlier on this bug). I am willing to revert the file-roller change for 17.10 and postpone eog and evince to 18.04 if we think

[Bug 1719322] Re: Remove patch to remove headerbar

Daniel, how important do you think this issue is? Can it wait until 18.04 LTS? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1719322 Title: Remove patch to remove headerbar To manage notifications

[Bug 1719322] Re: Remove patch to remove headerbar

those changes modify the look of the softwares on some desktops right? they require at least a UIFe... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1719322 Title: Remove patch to remove headerbar

[Bug 1719322] Re: Remove patch to remove headerbar

** Changed in: gnome-contacts (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1719322 Title: Remove patch to remove headerbar To manage

[Bug 1719322] Re: Remove patch to remove headerbar

This bug was fixed in the package epiphany-browser - 3.26.1-1ubuntu1 --- epiphany-browser (3.26.1-1ubuntu1) artful; urgency=medium * Sync with Debian. Remaining change: - Modify 07_bookmarks.patch: + Add Ubuntu-specific default bookmarks, borrowed from Firefox * Drop

[Bug 1719322] Re: Remove patch to remove headerbar

This bug was fixed in the package file-roller - 3.26.0-0ubuntu2 --- file-roller (3.26.0-0ubuntu2) artful; urgency=medium * Drop bz_unity_header.patch: No longer needed for Unity (LP: #1719322) -- Jeremy Bicha Sat, 30 Sep 2017 11:43:39 -0400 ** Changed in:

[Bug 1719322] Re: Remove patch to remove headerbar

** Also affects: eog (Ubuntu) Importance: Undecided Status: New ** Changed in: eog (Ubuntu) Status: New => Incomplete ** Changed in: eog (Ubuntu) Importance: Undecided => Wishlist -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1719322] Re: Remove patch to remove headerbar

The GNOME Contacts patches were broken: it wasn't possible to use the app menu on Budgie or Xfce. Also, the patches no longer applied against The headerbar patches look bad in Xfce (waste of vertical space) and they are inconsistent. Most GNOME apps use headerbars so trying to avoid them in a few

[Bug 1719322] Re: Remove patch to remove headerbar

*the gnome-contacts patches no longer applied against 3.26 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1719322 Title: Remove patch to remove headerbar To manage notifications about this bug go

[Bug 1719322] Re: Remove patch to remove headerbar

** Changed in: file-roller (Ubuntu) Status: Incomplete => Fix Committed ** Changed in: gnome-contacts (Ubuntu) Status: Incomplete => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1719322] Re: Remove patch to remove headerbar

** Branch linked: lp:~ubuntu-desktop/file-roller/ubuntu -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1719322 Title: Remove patch to remove headerbar To manage notifications about this bug go to:

[Bug 1719322] Re: Remove patch to remove headerbar

I agree. There isn't much point in not using CSD for Epiphany since the visual difference is really minor and Firefox will be getting CSD soon too. ** Changed in: epiphany-browser (Ubuntu) Status: New => Fix Committed -- You received this bug notification because you are a member of

[Bug 1719322] Re: Remove patch to remove headerbar

Hey Jeremy, "Pantheon" reports as itself ;) I've attached here a screenshot of how it looks. ** Attachment added: "Screenshot" https://bugs.launchpad.net/ubuntu/+source/epiphany-browser/+bug/1719322/+attachment/4957689/+files/Screenshot%20from%202017-09-27%2010.06.34.png -- You received

[Bug 1719322] Re: Remove patch to remove headerbar

Daniel, could you attach some screenshots to show the brokenness? The patches could probably be updated to not change the UI on Elementary. What's the output of echo $XDG_CURRENT_DESKTOP -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 1719322] Re: Remove patch to remove headerbar

Mainly the issue for us is that it appears quite broken. It would be preferable to use the upstream version of the application's UI. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1719322 Title:

[Bug 1719322] Re: Remove patch to remove headerbar

The Debian GNOME team are fine with us removing the headerbar patches for eog and evince. (In fact, the Debian GNOME team is a bit unhappy with the patches since they add several untranslated strings when run outside GNOME or Ubuntu). ** Also affects: gnome-contacts (Ubuntu) Importance:

[Bug 1719322] Re: Remove patch to remove headerbar

I recently helped get the baobab patch pushed upstream (for 3.28): it only uses the "traditional" titlebar on Unity. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1719322 Title: Remove patch to

[Bug 1719322] Re: Remove patch to remove headerbar

It could also we that xfce or some other desktop still want to stay away from CSD -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1719322 Title: Remove patch to remove headerbar To manage

[Bug 1719322] Re: Remove patch to remove headerbar

evince is in sync with Debian so the patch should probably be removed there rather than in an Ubuntu specific delta which is creating more work for us. Do you have any issue with the patch or what's the motivation for the request? ** Changed in: evince (Ubuntu) Importance: Undecided =>

[Bug 1719322] Re: Remove patch to remove headerbar

** Also affects: evince (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1719322 Title: Remove patch to remove headerbar To manage notifications