[Bug 1762572] Re: regression: sftp method no longer uses temporary file name during upload

2019-02-08 Thread Mathew Hodson
** Changed in: dput (Ubuntu) Importance: Undecided => Low -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1762572 Title: regression: sftp method no longer uses temporary file name during upload

[Bug 1762572] Re: regression: sftp method no longer uses temporary file name during upload

2019-02-03 Thread Julian Andres Klode
Thanks for the patch! I think Python has built-in functions for generating files names we could use, tough, that might look nicer. I'll have a look later. I also need to update my git Branch for upstreaming. ** Changed in: dput (Ubuntu) Status: Confirmed => Triaged -- You received this b

[Bug 1762572] Re: regression: sftp method no longer uses temporary file name during upload

2019-02-02 Thread Ubuntu Foundations Team Bug Bot
The attachment "0001-fix-atomic-upload-regression-for-sftp-method.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by

[Bug 1762572] Re: regression: sftp method no longer uses temporary file name during upload

2019-02-02 Thread David Lechner
It is a feature to me. I can't think of an easy way to work around it otherwise. Using a temporary file like this seems common. In fact dput used to do this, which is why I consider it a regression. Similar advice here: https://stackoverflow.com/questions/25119076/how- to-do-an-atomic-sftp-file-t

[Bug 1762572] Re: regression: sftp method no longer uses temporary file name during upload

2019-02-02 Thread Sebastien Bacher
Thank you for your bug report, is the use of the temporary filename really a feature or is that an implementation detail you happened to rely on? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1762572

[Bug 1762572] Re: regression: sftp method no longer uses temporary file name during upload

2019-02-02 Thread David Lechner
Here is a patch that I have been using for a while. ** Patch added: "0001-fix-atomic-upload-regression-for-sftp-method.patch" https://bugs.launchpad.net/ubuntu/+source/dput/+bug/1762572/+attachment/5235354/+files/0001-fix-atomic-upload-regression-for-sftp-method.patch -- You received this bu

[Bug 1762572] Re: regression: sftp method no longer uses temporary file name during upload

2018-07-31 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: dput (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1762572 Title: regre

[Bug 1762572] Re: regression: sftp method no longer uses temporary file name during upload

2018-04-09 Thread David Lechner
It looks like this can be fixed by copying (parts of) the _put() method from bzrlib def _put(self, abspath, f, mode=None): """Helper function so both put() and copy_abspaths can reuse the code""" tmp_abspath = '%s.tmp.%.9f.%d.%d' % (abspath, time.time(),