[Bug 1764668] Re: guest cleanup script fails to iterate

2018-05-03 Thread Launchpad Bug Tracker
This bug was fixed in the package libvirt - 3.6.0-1ubuntu6.6 --- libvirt (3.6.0-1ubuntu6.6) artful; urgency=medium * Fix clean shut down of guests on system shutdown (LP: #1764668) - d/p/ubuntu/lp-1764668-do-not-report-unknown-guests.patch -

[Bug 1764668] Re: guest cleanup script fails to iterate

2018-05-03 Thread Launchpad Bug Tracker
This bug was fixed in the package libvirt - 1.3.1-1ubuntu10.22 --- libvirt (1.3.1-1ubuntu10.22) xenial; urgency=medium * Fix clean shut down of guests on system shutdown (LP: #1764668) - d/p/ubuntu/lp-1764668-do-not-report-unknown-guests.patch -

[Bug 1764668] Re: guest cleanup script fails to iterate

2018-05-02 Thread ChristianEhrhardt
In fact the MP above is approved by Pitti who sort of owns cockpit. Since neither of us can push this change I'd appreciate if on SRU handling this could be done (as it is ~ubuntu-sru scope). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 1764668] Re: guest cleanup script fails to iterate

2018-05-01 Thread ChristianEhrhardt
FYI - we opened [1], and while this needs some processing to be acked an merged I'd ask the SRU team to consider these autopkgtest fails not a blocker to move on with thie SRU here atm. [1]: https://code.launchpad.net/~paelzer/britney/hints-ubuntu-artful- cockpitfails/+merge/344874 -- You

[Bug 1764668] Re: guest cleanup script fails to iterate

2018-04-30 Thread ChristianEhrhardt
@SRU-Team: Dep8 tests show unrelated issues in cockpit for Artful. I'm in discussion with pitti if we should even mask those tests, considering what fails and what we changed they are really unrelated (and this type of error showed before the changes of this SRU). See the artful column in [1]

[Bug 1764668] Re: guest cleanup script fails to iterate

2018-04-30 Thread ChristianEhrhardt
As described in testcases I set up a few guests and made sure some of them won't shutdown properly. We want to see 1. all tried to shut down 2. waiting up until timeout for the one that does not shut down ## Pre-Fix ## Xenial: sudo /usr/lib/libvirt/libvirt-guests.sh stop Running guests on

[Bug 1764668] Re: guest cleanup script fails to iterate

2018-04-26 Thread Robie Basak
Hello ChristianEhrhardt, or anyone else affected, Accepted libvirt into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libvirt/1.3.1-1ubuntu10.22 in a few hours, and then in the -proposed repository. Please help us by testing this new

[Bug 1764668] Re: guest cleanup script fails to iterate

2018-04-26 Thread Robie Basak
12:35 cpaelzer: on bug 1764668 12:35 bug 1764668 in libvirt (Ubuntu Artful) "guest cleanup script fails to iterate" [Undecided,Confirmed] https://launchpad.net/bugs/1764668 12:35 cpaelzer: is it possible that some users have guests that fail to shut down in production? In that case, what will

[Bug 1764668] Re: guest cleanup script fails to iterate

2018-04-25 Thread ChristianEhrhardt
Note: I realized the script might want to re-issue the shutdown command but that is for a different time/bug. After a final test against [1] with the proposed upload being good I pushed this for SRU. Also I added a proper SRU Template to the bug. For SRU Review:

[Bug 1764668] Re: guest cleanup script fails to iterate

2018-04-25 Thread ChristianEhrhardt
** Description changed: + [Impact] + + * Due to a bug in a recent fix guests now are immediately considered shut +down. Due to that the helper to shut down guests cleanly might not wait +long enough. + + * backporting the upstream fix to the affected releases. + + [Test Case] + +

[Bug 1764668] Re: guest cleanup script fails to iterate

2018-04-24 Thread Launchpad Bug Tracker
This bug was fixed in the package libvirt - 4.0.0-1ubuntu8 --- libvirt (4.0.0-1ubuntu8) bionic; urgency=medium * Fix clean shut down of guests on system shutdown (LP: #1764668) - d/p/ubuntu/lp-1764668-do-not-report-unknown-guests.patch -

[Bug 1764668] Re: guest cleanup script fails to iterate

2018-04-24 Thread ChristianEhrhardt
Thank Janake, you are right that transients would vanish in that case. I were able to construct the same issue by concurrently destroy/undefining them simulating some other script running on shutdown. That is rather similar to the corosync case that does things on shutdown. But with the current

[Bug 1764668] Re: guest cleanup script fails to iterate

2018-04-24 Thread Janåke Rönnblom
If you have a cluster (corosync and pacemaker) running a VM as a resource then during a shutdown the VM would be removed from virsh list since its running as a transient domain. https://wiki.libvirt.org/page/VM_lifecycle#Transient_guest_domains_vs_Persistent_guest_domains This would cause the VM

[Bug 1764668] Re: guest cleanup script fails to iterate

2018-04-24 Thread ChristianEhrhardt
Changes just got accepted as: 08bb5eeb tools: fix check_guests_shutdown loop cce57265 tools: do not report unknown guests in print_guests_shutdown Lets prep a fix for Bionic asap to hopefully get it in the release. But libvirt is seeded and ISO respins are - umm - unwanted at this moment. OTOH

[Bug 1764668] Re: guest cleanup script fails to iterate

2018-04-23 Thread Dariusz Gadomski
I have repeated the tests for the second part of patch as well - everything went as expected. Although I haven't been able to hit the undefined guest scenario before. I'll make a couple of attempts more. -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1764668] Re: guest cleanup script fails to iterate

2018-04-19 Thread ChristianEhrhardt
Thanks for the testing I added another fix in case guests are fully undefined (or libvirt gone) in the meantime. Otherwise it might report an empty variable guest name. Submitted as v2: https://www.redhat.com/archives/libvir- list/2018-April/msg01825.html -- You received this bug notification

[Bug 1764668] Re: guest cleanup script fails to iterate

2018-04-17 Thread Dariusz Gadomski
I can confirm. With the patch applied all guests are being shutdown correctly and the "Failed to determine state of guest" message is gone. Tested for PARALLEL=2, 5, 10 for 40 guests. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1764668] Re: guest cleanup script fails to iterate

2018-04-17 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: libvirt (Ubuntu Xenial) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1764668

[Bug 1764668] Re: guest cleanup script fails to iterate

2018-04-17 Thread ChristianEhrhardt
Submitted upstream as https://www.redhat.com/archives/libvir- list/2018-April/msg01408.html ** Changed in: libvirt (Ubuntu) Status: New => In Progress ** Also affects: libvirt (Ubuntu Xenial) Importance: Undecided Status: New ** Also affects: libvirt (Ubuntu Bionic)

[Bug 1764668] Re: guest cleanup script fails to iterate

2018-04-17 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: libvirt (Ubuntu Artful) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1764668

[Bug 1764668] Re: guest cleanup script fails to iterate

2018-04-17 Thread ChristianEhrhardt
Without the fix they were in my case always detected as immediately shut down which likely is wrong and can end in non-clean shutdown even it would have been clean if the guests had some more time. This was due to the fact that it picked up the empty external var to loop over and then the