Re: [Bug 260443] Re: main inclusion request: update-motd

2008-09-18 Thread Martin Pitt
Hi Dustin, thanks for the discussion yesterday. Dustin Kirkland [2008-09-18 2:31 -]: * eliminates the init script entirely (purging it from the system in the postinst if upgrading from a version 1.6) * purges all debconf handling (config, postinst, po, templates) * installs

[Bug 260443] Re: main inclusion request: update-motd

2008-09-18 Thread Martin Pitt
Some review comments: - postinst: use lt-nl instead of lt for --compare-versions - prerm: You should be able to drop this entirely; conffiles are automatically removed on purge - there should be a preinst which makes sure you don't get a dpkg conffile conflict question on intra-intrepid

Re: [Bug 260443] Re: main inclusion request: update-motd

2008-09-18 Thread Dustin Kirkland
On Thu, Sep 18, 2008 at 11:37 AM, Martin Pitt [EMAIL PROTECTED] wrote: Some review comments: - postinst: use lt-nl instead of lt for --compare-versions Cool, thanks. Will change. - prerm: You should be able to drop this entirely; conffiles are automatically removed on purge Well, I

Re: [Bug 260443] Re: main inclusion request: update-motd

2008-09-18 Thread Martin Pitt
Hi Dustin, Dustin Kirkland [2008-09-18 17:03 -]: - prerm: You should be able to drop this entirely; conffiles are automatically removed on purge Well, I thought it would be a good idea to remove the cronjob even on just a normal removal (in addition to a purge). Once the binary

[Bug 260443] Re: main inclusion request: update-motd

2008-09-17 Thread Colin Watson
= Cron job = I really think we need to lose the debconf configuration of cron job frequency. I know that you've put effort into making it at least somewhat policy-compliant, but: * no other package that I know of offers debconf configuration of cron job frequency, so system administrators will

[Bug 260443] Re: main inclusion request: update-motd

2008-09-17 Thread Dustin Kirkland
I just uploaded update-motd_1.6. I hope that this version satisfies the requests of both pitti and cjwatson. Notably this release: * eliminates the init script entirely (purging it from the system in the postinst if upgrading from a version 1.6) * purges all debconf handling (config,

[Bug 260443] Re: main inclusion request: update-motd

2008-09-16 Thread Dustin Kirkland
** Changed in: update-motd (Ubuntu) Status: Incomplete = In Progress -- main inclusion request: update-motd https://bugs.launchpad.net/bugs/260443 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list

[Bug 260443] Re: main inclusion request: update-motd

2008-09-15 Thread Dustin Kirkland
Hi Martin- I just uploaded update-motd_1.3, hopefully addressing all of your concerns, and preserving most of the functionality that I really wanted to keep. You can see the changelog in the last 2 uploads for per-file change documentation, but I'll explain here for continuity... The

Re: [Bug 260443] Re: main inclusion request: update-motd

2008-09-14 Thread Martin Pitt
Hi, Dustin Kirkland [2008-09-13 14:59 -]: I put it in the init script such that it would be easy for an administrator to stop update-motd from running, by removing the script from /etc/cron.d. And the start restores the /etc/cron.d script by regenerating the script from the template in

[Bug 260443] Re: main inclusion request: update-motd

2008-09-13 Thread Dustin Kirkland
Martin- Notice that the init script sources /etc/default/update-motd, where it should obtain $FREQ_IN_MIN. To change /etc/cron.d/update-motd, the administrator could either dpkg- reconfigure update-motd, or edit /etc/default/update-motd directly (which is what the postinst script will affect).

[Bug 260443] Re: main inclusion request: update-motd

2008-09-13 Thread Dustin Kirkland
Martin- I put it in the init script such that it would be easy for an administrator to stop update-motd from running, by removing the script from /etc/cron.d. And the start restores the /etc/cron.d script by regenerating the script from the template in /usr/share, and reading the $FREQ_IN_MIN

[Bug 260443] Re: main inclusion request: update-motd

2008-09-13 Thread Dustin Kirkland
Martin- I'm open to other solutions, however, I really, really want to have working start and stop operations, that would effectively enable and disable the update-motd cronjob. Any suggestions? :-Dustin -- main inclusion request: update-motd https://bugs.launchpad.net/bugs/260443 You

[Bug 260443] Re: main inclusion request: update-motd

2008-09-12 Thread Martin Pitt
The configuration file handling in here needs to be fixed. At the moment, the init script does sed s/FREQ_IN_MIN/$FREQ_IN_MIN/ /usr/share/update-motd/update- motd.cron /etc/cron.d/update-motd unconditionally. This overwrites the admin's changes without checking or confirmation. If you ask

[Bug 260443] Re: main inclusion request: update-motd

2008-09-11 Thread Dustin Kirkland
Required by landscape-client. :-Dustin ** Changed in: update-motd (Ubuntu) Importance: Undecided = Medium Status: New = Confirmed Target: None = intrepid-alpha-6 -- main inclusion request: update-motd https://bugs.launchpad.net/bugs/260443 You received this bug notification

[Bug 260443] Re: main inclusion request: update-motd

2008-08-23 Thread Greg Auger
** Changed in: update-motd (Ubuntu) Sourcepackagename: None = update-motd -- main inclusion request: update-motd https://bugs.launchpad.net/bugs/260443 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list