[Bug 540940] Re: Regression: Unable to add a partition to a disk that has another partition in use

2010-06-16 Thread Bug Watch Updater
** Changed in: parted Status: New = Fix Released -- Regression: Unable to add a partition to a disk that has another partition in use https://bugs.launchpad.net/bugs/540940 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. --

[Bug 540940] Re: Regression: Unable to add a partition to a disk that has another partition in use

2010-03-30 Thread Mario Limonciello
I can confirm this fix resolves the problems from the duplicate bug (532961). Thanks! ** Changed in: oem-priority Status: Confirmed = Fix Released -- Regression: Unable to add a partition to a disk that has another partition in use https://bugs.launchpad.net/bugs/540940 You received

[Bug 540940] Re: Regression: Unable to add a partition to a disk that has another partition in use

2010-03-29 Thread Colin Watson
I fixed up the problems I mentioned, and did some basic testing. In the process, I ran into and fixed what I believe is a bug in extended partition geometry handling that broke automatic partitioning in the installer (I forwarded this fix upstream). Other than that, things seem to be working

[Bug 540940] Re: Regression: Unable to add a partition to a disk that has another partition in use

2010-03-29 Thread Launchpad Bug Tracker
This bug was fixed in the package parted - 2.2-1ubuntu4 --- parted (2.2-1ubuntu4) lucid; urgency=low [ Phillip Susi ] * put-back-BLKPG.patch: Upstream removed the code using the new BLKPG ioctls instead of the old BLKRRPART ioctl to update the in-kernel partition table.

[Bug 540940] Re: Regression: Unable to add a partition to a disk that has another partition in use

2010-03-29 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/parted -- Regression: Unable to add a partition to a disk that has another partition in use https://bugs.launchpad.net/bugs/540940 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list

[Bug 540940] Re: Regression: Unable to add a partition to a disk that has another partition in use

2010-03-29 Thread Phillip Susi
I think I ran into that same bug... when putting parted into sector mode it allowed me to create a logical partition starting on the sector immediately following the EBR of the extended partition, but the second sector is also consumed by the device node that is created for the extended partition

Re: [Bug 540940] Re: Regression: Unable to add a partition to a disk that has another partition in use

2010-03-29 Thread Colin Watson
Even if that is a bug (which I'm not convinced about - I haven't spent the time digging into LILO to verify), to be honest I'd much rather preserve it and deal with its consequences (by means of my extended-geom patch or similar) than try to change it. That goes double a month before Lucid's

[Bug 540940] Re: Regression: Unable to add a partition to a disk that has another partition in use

2010-03-29 Thread Phillip Susi
True, your patch should be used for now, but I'm going to push upstream to fix the kernel. If that one sector is not there, then the partition should not use it. It seems the code was put there to force the size to 2 since LILO wants 2 sectors, but it seems to me that when the space for the

Re: [Bug 540940] Re: Regression: Unable to add a partition to a disk that has another partition in use

2010-03-29 Thread Colin Watson
I'm still missing the _has_partitions call (see comment 6), and there's still a moderate amount of whitespace damage. I'll sync this up myself and see how it looks ... -- Regression: Unable to add a partition to a disk that has another partition in use https://bugs.launchpad.net/bugs/540940

[Bug 540940] Re: Regression: Unable to add a partition to a disk that has another partition in use

2010-03-27 Thread Phillip Susi
This should be the final cut. I've done quite a bit of testing and an pleased with the results. The last try did not warn if it failed to remove a partition and you did not try to replace it. This one collects a list of all partitions that it could not remove, discards any that are supposed to

[Bug 540940] Re: Regression: Unable to add a partition to a disk that has another partition in use

2010-03-26 Thread Colin Watson
Thanks for looking at this! I definitely want to take something like this for Lucid, and this looks fairly close to being usable. A few comments: Could you use 'quilt refresh -pab' so that you don't change the format of all the patches, please? Try to pay attention to the style of the

[Bug 540940] Re: Regression: Unable to add a partition to a disk that has another partition in use

2010-03-26 Thread Colin Watson
In fact, use 'quilt refresh --no-timestamps -pab'. (You can set this up in ~/.quiltrc if you like.) ** Also affects: parted (Ubuntu Lucid) Importance: Undecided Assignee: Phillip Susi (psusi) Status: In Progress ** Changed in: parted (Ubuntu Lucid) Milestone: None =

[Bug 540940] Re: Regression: Unable to add a partition to a disk that has another partition in use

2010-03-26 Thread Neil Perry
@ Phillip Susi - I have reviewed you're patch, which seems to build fine and fix the issue. Could you please post this upstream. Thanks ** Tags added: patch-forwarded-upstream -- Regression: Unable to add a partition to a disk that has another partition in use

Re: [Bug 540940] Re: Regression: Unable to add a partition to a disk that has another partition in use

2010-03-26 Thread Colin Watson
On Fri, Mar 26, 2010 at 01:40:37PM -, Neil Perry wrote: @ Phillip Susi - I have reviewed you're patch, which seems to build fine and fix the issue. Could you please post this upstream. I commented separately on issues with the patch, with a more detailed review (does the Ubuntu Review Team

[Bug 540940] Re: Regression: Unable to add a partition to a disk that has another partition in use

2010-03-26 Thread Phillip Susi
I am emailing this upstream now for them to comment on and will work on the cleanups you suggested tomorrow ( going to see Lewis Black live tonight ). -- Regression: Unable to add a partition to a disk that has another partition in use https://bugs.launchpad.net/bugs/540940 You received this

[Bug 540940] Re: Regression: Unable to add a partition to a disk that has another partition in use

2010-03-25 Thread Phillip Susi
Second attempt. This time it only throws the warning if you are modifying the partition that was in use. If you only changed other partitions, you should be fine. Will do some testing and if it looks good will send the patches upstream for review. ** Patch added: use-BLKPG2.diff

[Bug 540940] Re: Regression: Unable to add a partition to a disk that has another partition in use

2010-03-25 Thread Phillip Susi
Tested and this version seems to be working well for me. Sending upstream for approval. ** Patch added: use-BLKPG3.diff http://launchpadlibrarian.net/42010335/use-BLKPG3.diff -- Regression: Unable to add a partition to a disk that has another partition in use

[Bug 540940] Re: Regression: Unable to add a partition to a disk that has another partition in use

2010-03-23 Thread Phillip Susi
Attaching debdiff of my first attempt to resolve this. ** Patch added: use-BLKPG.diff http://launchpadlibrarian.net/41748772/use-BLKPG.diff -- Regression: Unable to add a partition to a disk that has another partition in use https://bugs.launchpad.net/bugs/540940 You received this bug

[Bug 540940] Re: Regression: Unable to add a partition to a disk that has another partition in use

2010-03-23 Thread Brian Murray
** Tags added: patch -- Regression: Unable to add a partition to a disk that has another partition in use https://bugs.launchpad.net/bugs/540940 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list

[Bug 540940] Re: Regression: Unable to add a partition to a disk that has another partition in use

2010-03-18 Thread Phillip Susi
Confirmed from inspecting the sources that the BLKPG code was removed upstream. There is a ChangeLog entry explaining the change. Will take the issue upstream. ** Changed in: parted (Ubuntu) Status: New = Confirmed -- Regression: Unable to add a partition to a disk that has another

[Bug 540940] Re: Regression: Unable to add a partition to a disk that has another partition in use

2010-03-18 Thread Phillip Susi
** Bug watch added: Parted tracker #253 http://parted.alioth.debian.org/cgi-bin/trac.cgi/ticket/253 ** Also affects: parted via http://parted.alioth.debian.org/cgi-bin/trac.cgi/ticket/253 Importance: Unknown Status: Unknown -- Regression: Unable to add a partition to a disk that

[Bug 540940] Re: Regression: Unable to add a partition to a disk that has another partition in use

2010-03-18 Thread Bug Watch Updater
** Changed in: parted Status: Unknown = New -- Regression: Unable to add a partition to a disk that has another partition in use https://bugs.launchpad.net/bugs/540940 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. --

[Bug 540940] Re: Regression: Unable to add a partition to a disk that has another partition in use

2010-03-18 Thread Phillip Susi
Seems I'll be working on a patch for this. ** Changed in: parted (Ubuntu) Status: Confirmed = In Progress ** Changed in: parted (Ubuntu) Assignee: (unassigned) = Phillip Susi (psusi) -- Regression: Unable to add a partition to a disk that has another partition in use