[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-02-07 Thread Michael Hope
** Changed in: gcc-linaro Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/685352 Title: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-02-07 Thread Ulrich Weigand
** Changed in: gcc-linaro Milestone: None => 4.5-2011.02-0 ** Changed in: gcc-linaro Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/685352 Title: libp

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-02-03 Thread Bug Watch Updater
** Changed in: plymouth Importance: Unknown => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/685352 Title: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering --

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-25 Thread Bug Watch Updater
Launchpad has imported 8 comments from the remote bug at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47299. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-24 Thread Bug Watch Updater
** Changed in: plymouth Status: Unknown => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/685352 Title: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text renderi

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-18 Thread Ulrich Weigand
Backport proposed for merge: https://code.launchpad.net/~uweigand/gcc-linaro/lp-685352/+merge/46663 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/685352 Title: libplymouth2_0.8.2-2ubuntu6 and later

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-18 Thread Launchpad Bug Tracker
** Branch linked: lp:~uweigand/gcc-linaro/lp-685352 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/685352 Title: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering -- ubu

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-18 Thread Ulrich Weigand
Upstream GCC patch committed here: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=168944 I'll backport to Linaro GCC 4.5. ** Changed in: gcc-linaro Status: Confirmed => In Progress ** Changed in: gcc-linaro Assignee: (unassigned) => Ulrich Weigand (uweigand) -- You received this

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-18 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/gcc-4.5 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/685352 Title: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering -- ubuntu-bugs mailing

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-17 Thread Ulrich Weigand
** Changed in: gcc-linaro Status: New => Confirmed ** Changed in: gcc-linaro Importance: Undecided => High -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/685352 Title: libplymouth2_0.8.2-2

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-17 Thread Launchpad Bug Tracker
This bug was fixed in the package gcc-4.5 - 4.5.2-1ubuntu6 --- gcc-4.5 (4.5.2-1ubuntu6) natty; urgency=low * Update to SVN 20110117 (r168896) from the gcc-4_5-branch. - Fix PR target/43309, PR fortran/46874, PR tree-optimization/47286, PR tree-optimization/44592, PR target

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-17 Thread Matthias Klose
the backport of the proposed upstream patches fixes the test case on 4.5 linaro. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/685352 Title: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-17 Thread Matthias Klose
seen on 4.5 linaro, not 4.5 fsf ** Also affects: gcc-linaro Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/685352 Title: libplymouth2_0.8.2-2ubuntu6 and

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-15 Thread Phillip Susi
Changing the argument from an unsigned char to an unsigned short works around the bug. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/685352 Title: libplymouth2_0.8.2-2ubuntu6 and later give ragged s

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-15 Thread Phillip Susi
Oh wow, this is the disassembly I get: Dump of assembler code for function test: => 0x00400530 <+0>: movzbl %dil,%eax 0x00400534 <+4>: neg%eax 0x00400536 <+6>: retq So it looks like it is doing all 8 bit math and since 255 in 8 bits is -1, optimize

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-15 Thread Colin Watson
The integer constant 255 has type int, not signed char or anything like that. See C99 section 6.4.4.1. Treating it as a signed char and then sign-extending it certainly does not seem to be valid. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed

Re: [Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-15 Thread Martin Pitt
Phillip Susi [2011-01-15 19:35 -]: > 255 is 0xFF, which when you sign extend to 16 bits is 0x. Yes, but gcc claiming that would be a valid representation of 255 sounds wrong to me. -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debia

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-15 Thread Phillip Susi
255 is 0xFF, which when you sign extend to 16 bits is 0x. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/685352 Title: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text renderin

Re: [Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-15 Thread Martin Pitt
Phillip Susi [2011-01-15 5:40 -]: > It looks to me like what it is doing is promoting the 255 to a signed > short, which sign extends to 0x That sounds wrong, though. 0x is not 255 in any kind of data type. -- You received this bug notification because you are a member of Ubuntu Bug

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-14 Thread Phillip Susi
It looks to me like what it is doing is promoting the 255 to a signed short, which sign extends to 0x, then multiplying that by 0x0040 to get the 0xffc0 result. I think that this is allowed by the standard since the signedness of the literal 255 is undefined. Try adding adding a 'U' to the 25

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-14 Thread Martin Pitt
** Also affects: gcc via http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47299 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/685352 Title: libplymouth2_0

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-14 Thread Ulrich Weigand
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47299 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/685352 Title: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering -- ubunt

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-14 Thread Ulrich Weigand
Opened upstream gcc bug report PR rtl-optimzation/47299 ** Bug watch added: GCC Bugzilla #47299 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47299 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/68535

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-14 Thread Ulrich Weigand
doko asked me to look into this. This is definitely a compiler bug. The minimal test case I get is: unsigned short test (unsigned char val) __attribute__ ((noinline)); unsigned short test (unsigned char val) { return val * 255; } int main(int argc, char**argv) { printf ("test(val=40) = %x\n

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-14 Thread Martin Pitt
Forwarded the patch to the plymouth folks, as it is actually a bug fix there. ** Bug watch added: freedesktop.org Bugzilla #33129 http://bugs.freedesktop.org/show_bug.cgi?id=33129 ** Also affects: plymouth via http://bugs.freedesktop.org/show_bug.cgi?id=33129 Importance: Unknown S

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-14 Thread Launchpad Bug Tracker
This bug was fixed in the package plymouth - 0.8.2-2ubuntu9 --- plymouth (0.8.2-2ubuntu9) natty; urgency=low [ Steve Langasek ] * debian/control: set Vcs-Bzr to forestall future mis-uploads [ Martin Pitt ] * Add gcc45-arith-workaround.patch: Work around a gcc-4.5 behaviour

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-14 Thread Martin Pitt
Now that we have a separate test case, I'd like to work around this issue in plymouth. ** Changed in: plymouth (Ubuntu Natty) Importance: High => Medium ** Changed in: plymouth (Ubuntu Natty) Milestone: ubuntu-11.04-beta => natty-alpha-2 ** Changed in: plymouth (Ubuntu Natty) Assigne

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-14 Thread Martin Pitt
This is a test case which is as small as I could get it. It would be nice if we could get a review of that from the gcc guys to see whether it's a bug or undefined behaviour? $ gcc -o /tmp/out test-685352-minimal.c && /tmp/out 7f80 $ gcc -o /tmp/out -O2 test-685352-minimal.c && /tmp/out 3f8

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-14 Thread Martin Pitt
I notice one strange thing in that code: the result will only fit in 16 bits if red1 and red2*alpha_1 together aren't bigger than 0x80. In fact, if I bump the data type of red, green, blue to uint32_t, it works fine. I'm just not sure why it would work with least16_t without optimization, as the i

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-14 Thread Martin Pitt
This is a broken-out test case which is a lot easier to debug than having to start plymouth-x11 and diffing log files. It extracts the pixel blending function and prints out some additional intermediate steps and the result. They differ depending on whether or not optimizing: $ gcc -o /tmp/out t

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-13 Thread Martin Pitt
Keeping notes here, mostly for myself, but also in case someone else is looking at this. I bisected it down to ply_pixel_buffer_fill_with_argb32_data_at_opacity_with_clip(), using gcc 4.4's shiny new #pragma GCC optimize ("1") feature. That doesn't work within a function, so I now had to resort to

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-13 Thread Martin Pitt
If I just build ply-pixel-buffer.c with -O1, and everything else with -O2, it works. Cross-checking, building everything with -O1 and just build ply-pixel-buffer.c with -O2, it fails, so the problem happens with this file. -- You received this bug notification because you are a member of Ubuntu B

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-13 Thread Martin Pitt
Specifically, the problem is in libply-splash-core.so. Building that one with gcc-4.4 works, while using the other three shared libs from the current natty libplymouth2 package. In particular, I tested this by building locally (but not installing), and running sudo LD_LIBRARY_PATH=`pwd`/src/libp

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-13 Thread Matthias Klose
does the behaviour change with plymouth built with -O1, -O0? when built with gcc-snapshot? If yes, can the object file be identified which may cause the issue? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-12 Thread Steve Langasek
This problem is reported with builds of plymouth 0.8.2-2ubuntu6 and later, which was built using gcc-4.5 4.5.1-10ubuntu3. ** Also affects: gcc-4.5 (Ubuntu) Importance: Undecided Status: New ** Changed in: gcc-4.5 (Ubuntu Natty) Importance: Undecided => High -- You received this bug

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-07 Thread Martin-Éric Racine
Not directly related to this bug, but the same jagged graphics issue seems to affect GRUB2 since a few days, whenever holding the Shift key to make the GRUB menu appear. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.laun

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-06 Thread Martin Pitt
Confirmed workaround: Build with CC=gcc-4.4 (I didn't upload that, though). I also tested with --no-as-needed, this doesn't help. So as far as I can see this is either a regression in gcc-4.5, or a bug in libplymouth which didn't manifest with gcc < 4.5? -- You received this bug notification be

[Bug 685352] Re: libplymouth2_0.8.2-2ubuntu6 and later give ragged splash and text rendering

2011-01-06 Thread Martin Pitt
Merely rebuilding maverick's ubuntu5.1 on natty causes the bug (even without pkgbinarymangler), so it looks like a toolchain issue. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/685352 Title: libply