[Bug 1948434] Re: Check if secure boot is enabled with development keys
** Tags removed: verification-needed-focal ** Tags added: verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1948434 Title: Check if secure boot is enabled with development keys To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1948434/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1948436] Re: Add RevID field to VPD info in EEPROM
** Tags removed: verification-needed-focal ** Tags added: verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1948436 Title: Add RevID field to VPD info in EEPROM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1948436/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1948436] [NEW] Add RevID field to VPD info in EEPROM
Public bug reported: SRU Justification: [Impact] Currently, the VPD info stored in the EEPROM does not include a Rev ID. This field is incremented when a PN goes through minor HW changes. Sometimes, SW needs to differentiate the two versions of the card. Hence, this field should be supported in the EEPROM MFG partition. [Fix] EC (Engineering Changes) field is used to denote the HW Revision of a PN. Add it to the EEPROM MFG and provide a sysfs entry to access the same via mlx-bootctl. [Test Case] This field is typically programmed at the manufacturing step using the bfcfg tool which uses the write mechanism in the driver and then the MFG partition is locked. Reading the "rev" sysfs will show the current value. [Regression Potential] Can be considered minimum. ** Affects: linux-bluefield (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1948436 Title: Add RevID field to VPD info in EEPROM To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1948436/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1948434] [NEW] Check if secure boot is enabled with development keys
Public bug reported: SRU Justification: [Impact] Currently, there is no indication from mlx-bootctl when the user reads the lifecycle_state sysfs as to whether secure boot is enabled with development keys or production keys. In order to make this clear to the user, add a check in the driver. [Fix] Check the secure boot development mode status bit. If secure boot is enabled with the development key, then print it to the output buffer when lifecycle_state_show() is invoked. [Test Case] On a system in secure state, if it has been programmed with development keys, then reading the lifecycle_state sysfs entry in the mlx-bootctl driver should print a message that indicates the same. Similarly, a secure system which has been programmed with production keys must print the appropriate message when the lifecycle_state sysfs is read. [Regression Potential] Can be considered minimum. ** Affects: linux-bluefield (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1948434 Title: Check if secure boot is enabled with development keys To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1948434/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1931843] Re: Update mlx-bootctl to access new fields in EEPROM MFG
** Tags removed: verification-needed-focal ** Tags added: verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1931843 Title: Update mlx-bootctl to access new fields in EEPROM MFG To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1931843/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1931981] Re: mlx-bootctl: Fix potential buffer overflow
*** This bug is a duplicate of bug 1931843 *** https://bugs.launchpad.net/bugs/1931843 ** This bug has been marked a duplicate of bug 1931843 Update mlx-bootctl to access new fields in EEPROM MFG -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1931981 Title: mlx-bootctl: Fix potential buffer overflow To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1931981/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1933642] Re: mlx-bootctl: Fix exclusion issues around arm_smccc_smc
*** This bug is a duplicate of bug 1931843 *** https://bugs.launchpad.net/bugs/1931843 ** This bug has been marked a duplicate of bug 1931843 Update mlx-bootctl to access new fields in EEPROM MFG -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1933642 Title: mlx-bootctl: Fix exclusion issues around arm_smccc_smc To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1933642/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1931984] Re: mlx-bootctl: Update license and version info
*** This bug is a duplicate of bug 1931843 *** https://bugs.launchpad.net/bugs/1931843 ** This bug has been marked a duplicate of bug 1931843 Update mlx-bootctl to access new fields in EEPROM MFG -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1931984 Title: mlx-bootctl: Update license and version info To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1931984/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1933642] [NEW] mlx-bootctl: Fix exclusion issues around arm_smccc_smc
Public bug reported: SRU Justification: [Impact] Exclusion is being handled around arm_smccc_smc() only in the store functions. It should be implemented in the show functions also as this call might not be thread-safe. [Fix] Add mutex_lock/unlock around arm_smccc_smc calls in the show functions. [Test Case] Multiple simultaneous accesses to a sysfs entry exposed by the driver are successful. [Regression Potential] Can be considered minimum ** Affects: linux-bluefield (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1933642 Title: mlx-bootctl: Fix exclusion issues around arm_smccc_smc To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1933642/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1931984] [NEW] mlx-bootctl: Update license and version info
Public bug reported: SRU Justification: [Impact] License info needs to be updated since the current info is no longer accurate. Driver version needs to be incremented since new features have been added. [Fix] Update license info to "Dual BSD/GPL". Increment version to 1.4 [Test Plan] Verify version change [Regression Potential] None ** Affects: linux-bluefield (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1931984 Title: mlx-bootctl: Update license and version info To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1931984/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1931981] [NEW] mlx-bootctl: Fix potential buffer overflow
Public bug reported: SRU Justification: [Impact] The sysfs store/show functions use sprintf without specifying a size which could lead to potential buffer overflow. [Fix] Replace sprintf with snprintf to avoid buffer overflow. Also, remove the redundant strlen usage since count is already available in the _store functions. [Test Plan] Read/write access to the EEPROM MFG fields can be tested via the sysfs entries that are exposed by the driver. Please note that the MFG partition is locked in order to protect the data and this could block all writes to it. In order to enable writes to the EEPROM, the MFG Info needs to be reset via the UEFI Device Manager. [Regression Potential] Can be considered minimum. ** Affects: linux-bluefield (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1931981 Title: mlx-bootctl: Fix potential buffer overflow To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1931981/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1931843] [NEW] Update mlx-bootctl to access new fields in EEPROM MFG
Public bug reported: SRU Justification: [Impact] The EEPROM MFG partition on BlueField-2 has been updated to include the VPD information for each card. In order to access these newly added fields, the mlx-bootctl driver needs to be updated to provide an access mechanism. [Fix] Add support for VPD fields in the EEPROM MFG and provide access to these via sysfs entries. The newly added sysfs entries are: sku (SKU ID), modl (Model Number), sn (Serial Number) and uuid (UUID). And the previously added opn_str sysfs has been renamed to opn. [Test Case] Though the driver provides read and write access through sysfs, the contents of the MFG partition are written during Manufacturing and then locked in order to protect the info. Writing to this partition will therefore require resetting the MFG info from the UEFI Device Manager, which will unlock the partition and allow for it to be reprogrammed. Reading the sysfs entries will print the contents of each field. It could also be empty if the field was not programmed earlier. [Regression Potential] Can be considered minimum, since the new fields have been added without interfering with the existing fields which might already be present in the EEPROM. ** Affects: linux-bluefield (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1931843 Title: Update mlx-bootctl to access new fields in EEPROM MFG To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1931843/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1926424] Re: Use rate-limited prints for mlx-trio errors
** Tags removed: verification-needed-focal ** Tags added: verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1926424 Title: Use rate-limited prints for mlx-trio errors To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1926424/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1926424] [NEW] Use rate-limited prints for mlx-trio errors
Public bug reported: The mlx-trio module's IRQ handler prints errors and additional debug info in case of errors. However, these prints can be excessive in certain cases, thereby interfering with other functions. This patch limits the message amount. SRU Justification: [Impact] In cases where the mlx-trio module continuously receives interrupts, it prints a lot of messages which can potentially affect the console output and clutter dmesg logs. [Fix] This commit calls dev_err_ratelimited() instead of dev_err() to limit the amount of messages. [Test Case] When TRIO receives a bunch of PIO completion errors or PCIe link disabled errors, a ton of error messages from the IRQ handler can be seen, which has been limited by this patch. [Regression Potential] Regression potential can be considered minimum since the patch does not change any functions of the driver, but merely makes the error log more readable. ** Affects: linux-bluefield (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1926424 Title: Use rate-limited prints for mlx-trio errors To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1926424/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1916318] Re: ACPI table updated for bluefield_edac module
** Tags removed: verification-needed-focal ** Tags added: verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1916318 Title: ACPI table updated for bluefield_edac module To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1916318/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1916318] [NEW] ACPI table updated for bluefield_edac module
Public bug reported: The ACPI table entry now specifies whether access to the EMI (memory interface which is part of the memory sub-system) registers needs to be via secure calls. This requires the driver to be updated in order to add SMC support. SRU Justification: [Impact] Since secure calls have been enabled for bluefield_edac via ACPI, all EMI register reads will return 0, and writes will have no effect. So the edac driver will not provide any valid logs when an ECC error occurs. [Fix] Add support for SMC in bluefield_edac. [Test case] Verified by injecting an ECC error to trigger an EDAC event. The driver logs display information from EMI registers accessed via secure calls. [Regression potential] Regression potential can be considered low since the driver first reads from the ACPI table to decide whether to use the secure calls or not. If disabled, it uses the existing path to access the registers. ** Affects: linux-bluefield (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1916318 Title: ACPI table updated for bluefield_edac module To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1916318/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
