[Bug 1686183] Re: Ship ubuntu-advantage in basefiles for ubuntu

[Andreas Hasenack]

I can't use a debdiff here anymore because the new key is a binary file.
I created a git branch here:

https://code.launchpad.net/~ahasenack/ubuntu/+source/base-files/+git
/base-files/+ref/ubuntu-advantage-sru

Is that enough for your review? Should I make an MP against the precise-
updates packaging branch imported at https://code.launchpad.net/~usd-
import-team/ubuntu/+source/base-files/+git/base-files ?

** Patch removed: "ubuntu-advantage.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/base-files/+bug/1686183/+attachment/4868686/+files/ubuntu-advantage.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1686183

Title:
  Ship ubuntu-advantage in basefiles for ubuntu

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/base-files/+bug/1686183/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1686183] Re: Ship ubuntu-advantage in basefiles for ubuntu

[Andreas Hasenack]

I pushed it to keyserver.ubuntu.com, key id 67C7A026

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1686183

Title:
  Ship ubuntu-advantage in basefiles for ubuntu

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/base-files/+bug/1686183/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1686183] Re: Ship ubuntu-advantage in basefiles for ubuntu

[Dimitri John Ledkov]

The key was updated, is there an updated export of it available?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1686183

Title:
  Ship ubuntu-advantage in basefiles for ubuntu

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/base-files/+bug/1686183/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1686183] Re: Ship ubuntu-advantage in basefiles for ubuntu

[Dimitri John Ledkov]

e...@ubuntu.com actually might be a better email address, following on
ftpmaster@ cdimage@ pattern.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1686183

Title:
  Ship ubuntu-advantage in basefiles for ubuntu

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/base-files/+bug/1686183/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1686183] Re: Ship ubuntu-advantage in basefiles for ubuntu

[Dimitri John Ledkov]

The key UID is interesting. It is "Ubuntu ESM " is this an appropriate user facing uid that is
listed in the output of $ apt-key list?

Our current key names are a bit more descriptive than that, e.g.:
* Ubuntu Archive Automatic Signing Key 
* Ubuntu CD Image Automatic Signing Key 

Have you considered changing UID to e.g.
 * Ubuntu Extended Security Maintenance Automatic Signing Key 


Such that it is descriptive, and has email address that is user/public
facing.

prodstack-cdo seems like an internal email address, which is not
customer facing.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1686183

Title:
  Ship ubuntu-advantage in basefiles for ubuntu

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/base-files/+bug/1686183/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1686183] Re: Ship ubuntu-advantage in basefiles for ubuntu

[Dimitri John Ledkov]

* the key should be shipped as a key fragment in /usr/share/keyrings
/ubuntu-keyring-extended-security-maintainance.gpg

* the shell script should simply copy that key fragment into
/etc/apt/trusted.gpg.d/ upon enablement of the ESM repository

* there should not be encoded binary in the shell script, and no need to
call apt-key; just a cp.

* the script should check for and install apt-transport-https if missing

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1686183

Title:
  Ship ubuntu-advantage in basefiles for ubuntu

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/base-files/+bug/1686183/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1686183] Re: Ship ubuntu-advantage in basefiles for ubuntu

[Andreas Hasenack]

Updated debdiff attached. Changes:
- the ubuntu-advantage script is now shell (/bin/sh)
- install an MOTD script that will print a banner informing the status of ESM

** Patch added: "ubuntu-advantage.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/base-files/+bug/1686183/+attachment/4868686/+files/ubuntu-advantage.debdiff

** Patch removed: "lp1686183.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/base-files/+bug/1686183/+attachment/4867936/+files/lp1686183.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1686183

Title:
  Ship ubuntu-advantage in basefiles for ubuntu

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/base-files/+bug/1686183/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1686183] Re: Ship ubuntu-advantage in basefiles for ubuntu

[David Britton]

The difference here is a supported machine is up to date, even if it
only has the minimum packages installed.

Asking for another package to be installed to be "supported" is a small
bit of friction that can be removed by delivering the script with
basefiles.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1686183

Title:
  Ship ubuntu-advantage in basefiles for ubuntu

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/base-files/+bug/1686183/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1686183] Re: Ship ubuntu-advantage in basefiles for ubuntu

[Andreas Hasenack]

This introduces a python dependency to base-files, which I think is
incorrect. I think the decision to choose base-files should be
reevaluated.

>From the point of view of end-users, regardless if the script is in
base-files or in its own package, the same number of apt commands will
be needed either way.

It's either:
apt-get update
apt-get dist-upgrade
ubuntu-advantage enable-esm 

or:
apt-get update
apt-get install ubuntu-advantage
ubuntu-advantage enable-esm 

In its own package it can have its own copyright, manpage, correct
dependencies, its own source tarball, tests (which were stripped from
the debdiff here), upstream url, nice description, etc.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1686183

Title:
  Ship ubuntu-advantage in basefiles for ubuntu

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/base-files/+bug/1686183/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1686183] Re: Ship ubuntu-advantage in basefiles for ubuntu

[David Britton]

** Changed in: base-files (Ubuntu)
   Status: Confirmed => Incomplete

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1686183

Title:
  Ship ubuntu-advantage in basefiles for ubuntu

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/base-files/+bug/1686183/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1686183] Re: Ship ubuntu-advantage in basefiles for ubuntu

[Launchpad Bug Tracker]

Status changed to 'Confirmed' because the bug affects multiple users.

** Changed in: base-files (Ubuntu)
   Status: New => Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1686183

Title:
  Ship ubuntu-advantage in basefiles for ubuntu

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/base-files/+bug/1686183/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1686183] Re: Ship ubuntu-advantage in basefiles for ubuntu

[Ubuntu Foundations Team Bug Bot]

** Tags added: patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1686183

Title:
  Ship ubuntu-advantage in basefiles for ubuntu

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/base-files/+bug/1686183/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1686183] Re: Ship ubuntu-advantage in basefiles for ubuntu

[Andreas Hasenack]

debdiff for base-files on precise

** Patch added: "lp1686183.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/base-files/+bug/1686183/+attachment/4867936/+files/lp1686183.debdiff

** Description changed:

  [Impact]
  
-  * Allow ubuntu-advantage users to access the extended security
+  * Allow ubuntu-advantage users to access the extended security
  maintenance script with a simple command line tool.  This script needs
  to hit precise machines and be easy for ubuntu-advantage customers to
  enable, thus basefiles was chosen as a home.
  
  [Test Case]
  
-  * Run ubuntu-advantage, it should print out help
-  * Run ubuntu-advantage enable , but you need to be an 
ubuntu-advantage customer to get that token.  In the end, the script simply 
adds and removes an /etc/apt/sources.list.d entry.
-  * you can contact me (d...@canonical.com) if you would like a token for test 
purposes.
+  * Run ubuntu-advantage, it should print out help
+  * Run sudo ubuntu-advantage enable  (without sudo it will warn you), 
but you need to be an ubuntu-advantage customer to get that token.  In the end, 
the script simply adds and removes an /etc/apt/sources.list.d entry.
+  * you can contact me (d...@canonical.com) if you would like a token for test 
purposes.
  
  [Regression Potential]
  
-  * Low, this is a new script, not included in any automated startup
+  * Low, this is a new script, not included in any automated startup
  paths.
  
  [Other Info]
-  
-  * http://blog.dustinkirkland.com/2017/03/ubuntu-1204-esm.html
+ 
+  * http://blog.dustinkirkland.com/2017/03/ubuntu-1204-esm.html

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1686183

Title:
  Ship ubuntu-advantage in basefiles for ubuntu

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/base-files/+bug/1686183/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs