This is an untested patch for 4.12 and maybe earlier versions.
** Patch added: "0001-Wait-for-lockcommand-to-exit-on-suspend-hibernate.patch"
This is an untested patch for xfce 4.14.
** Patch added: "0001-Wait-for-lockcommand-to-exit.-Bug-10089.patch"
https://bugs.launchpad.net/ubuntu/+source/xfce4-session/+bug/1054299/+attachment/5337188/+files/0001-Wait-for-lockcommand-to-exit.-Bug-10089.patch
--
You received this bug
Martin Castillo (2-acc-von), oh I thought the function would reserve
some memory for the variable. I do not have the source checked out
either, but maybe later. Thanks for your contribution.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to
Why didn't the compiler warn about the uninitialized variable? Don't you
use -Wuninitialized (or -Wall for developing)?
My first corrected patch is still not checking the return value of
g_spawn_command_line_sync().
Jarno, just from looking at it, I think your patch is wrong.
You passed an uninitialized pointer to g_spawn_command_line_sync().
This function will write to whatever address was passed. That's a memory
corruption and probably the source of the error message in comment #47.
Please try the
Sean, I think then there is a bug in the locker of your choice (which?),
if it does not hide the screen before its command exits. Anyway, I am
glad to know that you could use the patch in Xubuntu 18.10.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is
Just some additional thoughts brought to you by the work of the fella's
over at the LXQt project on this same issue:
TL;DR: systemd-logind may not be inhibiting long enough for screen-
lockers to complete. Variable adjustments can be made.
1.
I've tried this patch in Xubuntu 18.10, and my desktop is still briefly
visible when coming back from suspend. I do believe the amount of time
it is visible is reduced, but it's still visible nonetheless.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is
The "error" you tell in #47 is actually not an error, but warning. It
should not stop suspend from working. Theo, did bluesabre test the
patch? Did the test fail even if xflock4 returned 0?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to
Maybe it would work in Xenial that has pm-utils.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1054299
Title:
Race condition in suspend scripts reveals desktop
To manage notifications about this
I suspend the system via xfce4-session-logout > suspend.
It works with the default xfce4-session package. It works if I rebuild
the package with no changes. The problem only occurs if I rebuild the
package with your patch added to the Debian patch series.
I have asked bluesabre from the Xubuntu
Oh, it seems to be dropped from Xubuntu.
How did you launch suspend? Try "xfce4-session-logout --suspend" in
terminal.
xfsm-shutdown-helper seems still to rely on pm-utils on Linux.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
The package pm-utils is not installed. It happens with any screen
locker.
This is tested in a live session environment inside a VM with the
xfce4-session package rebuilt to include your patch.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to
Do you have pm-utils installed? What if you use another locker in
xflock4?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1054299
Title:
Race condition in suspend scripts reveals desktop
To manage
Still not working. Oddly, the log entry is from xfsm-shutdown-helper.
After disabling 'lock on suspend' I can suspend just fine.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1054299
Title:
Race
You could try replacing
"g_spawn_command_line_sync ("xflock4", NULL, NULL, exit_status, error);"
by
"g_spawn_command_line_sync ("xflock4", NULL, NULL, exit_status, NULL);"
(In git in calls of g_spawn_command_line_async NULL is used for the
error parameter (in xfce-sreensaver.c). Error variable
This error is logged in .xsession-errors:
(xfsm-shutdown-helper:28111): GLib-WARNING **: 14:20:07.868: GError set over
the top of a previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL before
it's set.
The overwriting error message
Oh, how does it break suspend?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1054299
Title:
Race condition in suspend scripts reveals desktop
To manage notifications about this bug go to:
The approval by upstream was mainly meant for xflock4. Also, I assumed
that /general/LockCommand is already included in 4.12.1, but it is not.
Your patch for xfsm-systemd.c appears to have the expected effect.
However, it breaks suspend in my test environment.
--
You received this bug
Why does it need to be approved upstream?
You asked what if the locker does not exit immediately. It is pointless
question with current xflock4 (in Xubuntu releases), as it does not have
such lockers (or they are run in background). xlock is not available for
Ubuntu. slock is so tiny and fast
Alright. I see that you have covered most use cases while turning
xflock4 into a rather complex shell script.
This needs to be approved upstream, but I am not sure if anything will
happen..
"The thing is that xflock4 is not fixable, it's a hack that's broken by
design and needs to go away."
--
That is handled in xflock4 I attached in
https://bugzilla.xfce.org/show_bug.cgi?id=10217 :
If such a fallback locker is used, they will be called in background in
xflock4. If you have defined such a locker in xfce4-session ->
/general/LockCommand configuration variable, you should not set
What if the locker command does not exit immediately (waits until
unlock)?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1054299
Title:
Race condition in suspend scripts reveals desktop
To manage
The attachment "call xflock4 synchronously and return according to its
exit status" seems to be a patch. If it isn't, please remove the
"patch" flag from the attachment, remove the "patch" tag, and if you are
a member of the ~ubuntu-reviewers, unsubscribe the team.
[This is an automated message
Please test this patch, if you are able to build xfce4-session. (I
created the patch using diff -Nrud)
** Patch added: "call xflock4 synchronously and return according to its exit
status"
Oh, yes, albeit the xfce-screensaver.c is present only in newer
xfce4-session than what is used by Xubuntu.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1054299
Title:
Race condition in suspend
The relevant code should be in the following two files:
xfce4-session/xfsm-systemd.c
xfce4-session/xfce-screensaver.c
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1054299
Title:
Race condition in
Theo, sorry, but I can not even find the part of code where the locking
is executed as part of suspend to RAM function.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1054299
Title:
Race condition
Jarno, would you be able to contribute a patch to improve the
functionality?
This is a long-standing issue and still not fully fixed. The upstream
developers may not be aware of its severity.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to
Theo, Xfce Bugzilla #10089 should be fixed.
Testing this is easiest with xscreensaver:
$ pkill light-locker(or whatever screen saver daemon is running.)
$ xscreensaver
(Install it first, if you have to.)
Setup long "fade to black when blancking" duration in the Advanced tab
of Screensaver
** Changed in: xfce4-power-manager
Importance: Wishlist => Undecided
** Changed in: xfce4-power-manager
Status: Fix Released => New
** Changed in: xfce4-power-manager
Remote watch: Xfce Bugzilla #6413 => None
--
You received this bug notification because you are a member of Ubuntu
Jarno, does the race condition still exist in 18.04? If yes, what
changes are needed to finally fix this issue?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1054299
Title:
Race condition in
Launchpad has imported 10 comments from the remote bug at
https://bugzilla.xfce.org/show_bug.cgi?id=6413.
If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
I just added Unity to this bug. I looked for a way to report this
directly to the Unity project, but it wasn't immediately apparent.
I'm seeing identical behaviour using stock unity on Ubuntu 15.10.
** Also affects: unity
Importance: Undecided
Status: New
--
You received this bug
** Also affects: xfce4-power-manager via
https://bugzilla.xfce.org/show_bug.cgi?id=6413
Importance: Unknown
Status: Unknown
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1054299
Title:
Launchpad has imported 5 comments from the remote bug at
https://bugzilla.xfce.org/show_bug.cgi?id=10089.
If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
Yes, but the race condition still exists, if the system does not wait
until screen has been locked before suspending.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1054299
Title:
Race condition in
Any news on this issue? The bug was originally reported against
xscreensaver, and it has been fixed in utopic (bug 1229486).
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1054299
Title:
Race
** Changed in: acpi-support (Debian)
Status: New = Fix Released
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1054299
Title:
Race condition in suspend scripts reveals desktop
To manage
Status changed to 'Confirmed' because the bug affects multiple users.
** Changed in: xfce4-power-manager (Ubuntu)
Status: New = Confirmed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1054299
** Project changed: xfce4-power-manager = xfce4-power-manager (Ubuntu)
** Changed in: xfce4-power-manager (Ubuntu)
Status: New = Incomplete
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
** Changed in: xfce4-power-manager (Ubuntu)
Importance: Undecided = High
** Changed in: xfce4-power-manager (Ubuntu)
Status: Incomplete = Triaged
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
** Also affects: xfce4-power-manager
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1054299
Title:
Race condition in suspend scripts reveals desktop
To
** Summary changed:
- race condition in suspend scripts reveals desktop
+ Race condition in suspend scripts reveals desktop
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1054299
Title:
Race
** Summary changed:
- screensaver doesn't hide screen during unsuspend
+ race condition in suspend scripts reveals desktop
** Bug watch added: Debian Bug tracker #593303
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=593303
** Changed in: acpi-support (Debian)
Status: New = Unknown
** Changed in: acpi-support (Debian)
Status: Unknown = New
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1054299
Title:
race condition in suspend scripts reveals desktop
To manage
46 matches
Mail list logo
