[Bug 1813003] Re: Invalid free while running docker build
This bug was fixed in the package golang-github-docker-docker- credential-helpers - 0.5.0-2ubuntu0.1 --- golang-github-docker-docker-credential-helpers (0.5.0-2ubuntu0.1) bionic; urgency=medium * d/p/free_unsafe_pointer_fix.patch: fix invalid free call when running docker build (LP: #1813003) -- Athos Ribeiro Tue, 10 Aug 2021 09:43:00 -0300 ** Changed in: golang-github-docker-docker-credential-helpers (Ubuntu Bionic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813003 Title: Invalid free while running docker build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-docker-credential-helpers/+bug/1813003/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813003] Re: Invalid free while running docker build
I tested this in a bionic lxc container with the following steps: # install affected golang-docker-credential-helpers version 0.5.0-2 apt update && apt install -y docker.io golang-docker-credential-helpers # prepare Dockerfile and run build mkdir /tmp/dummy-docker-build cd /tmp/dummy-docker-build cat < Dockerfile FROM ubuntu:focal LABEL hello=label EOF docker build -t testing . # This will get the error to be reproduced. # then we can enable -proposed and upgrade golang-docker-credential-helpers cat
[Bug 1813003] Re: Invalid free while running docker build
Ah, I see now - it actually ships a binary. Thank you for confirming! ** Changed in: golang-github-docker-docker-credential-helpers (Ubuntu Bionic) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813003 Title: Invalid free while running docker build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-docker-credential-helpers/+bug/1813003/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813003] Re: Invalid free while running docker build
Hi Robie, This will not need a subsequent rebuild of other packages here since it is the binary package (and not the -dev one) which is triggering the reported issue. However, may the bogus call to free manifest in any other form for any other binary package building against the golang -dev package in question, then they may need a rebuild. I did test this change against a locally built package (built from the same sources pushed to that PPA). I just re-triggered my tests against the package (x86_64) available in that PPA just to make sure everything is working as expected here. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813003 Title: Invalid free while running docker build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-docker-credential-helpers/+bug/1813003/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813003] Re: Invalid free while running docker build
Hi Robie, I verified that it is not necessary to rebuild other packages in this case. Just updating golang-docker-credential- helpers_0.5.0-2ubuntu0.1_amd64.deb inside a VM is enough to fix the issue and have the "docker build" stop manifesting the error. But maybe Athos would like to complement this info somehow. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813003 Title: Invalid free while running docker build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-docker-credential-helpers/+bug/1813003/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813003] Re: Invalid free while running docker build
Won't this need a subsequent rebuild of other packages for this change to have any effect? Have you tested the outcome against your PPA? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813003 Title: Invalid free while running docker build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-docker-credential-helpers/+bug/1813003/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813003] Re: Invalid free while running docker build
I verified that the patch is applied in Impish. ** Changed in: golang-github-docker-docker-credential-helpers (Ubuntu) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813003 Title: Invalid free while running docker build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-docker-credential-helpers/+bug/1813003/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813003] Re: Invalid free while running docker build
Thanks for the review and upload, Sergio! ** Changed in: golang-github-docker-docker-credential-helpers (Ubuntu Bionic) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813003 Title: Invalid free while running docker build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-docker-credential-helpers/+bug/1813003/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813003] Re: Invalid free while running docker build
Thanks for addressing the comments, Athos. Uploaded: $ dput golang-github-docker-docker-credential-helpers_0.5.0-2ubuntu0.1_source.changes Trying to upload package to ubuntu Checking signature on .changes gpg: /home/sergio/work/golang-github-docker-docker-credential-helpers/golang-github-docker-docker-credential-helpers_0.5.0-2ubuntu0.1_source.changes: Valid signature from 106DA1C8C3CBBF14 Checking signature on .dsc gpg: /home/sergio/work/golang-github-docker-docker-credential-helpers/golang-github-docker-docker-credential-helpers_0.5.0-2ubuntu0.1.dsc: Valid signature from 106DA1C8C3CBBF14 Uploading to ubuntu (via ftp to upload.ubuntu.com): Uploading golang-github-docker-docker-credential-helpers_0.5.0-2ubuntu0.1.dsc: done. Uploading golang-github-docker-docker-credential-helpers_0.5.0-2ubuntu0.1.debian.tar.xz: done. Uploading golang-github-docker-docker-credential-helpers_0.5.0-2ubuntu0.1_source.buildinfo: done. Uploading golang-github-docker-docker-credential-helpers_0.5.0-2ubuntu0.1_source.changes: done. Successfully uploaded packages. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813003 Title: Invalid free while running docker build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-docker-credential-helpers/+bug/1813003/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813003] Re: Invalid free while running docker build
Thanks for the review, Sergio. I addressed your comments and pushed the proposed fix to the following PPA: https://launchpad.net/~athos-ribeiro/+archive/ubuntu/lp-1813003-docker- credential-helpers/+packages ** Patch added: "1-0.5.0-2ubuntu0.1.debdiff" https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-docker-credential-helpers/+bug/1813003/+attachment/5517153/+files/1-0.5.0-2ubuntu0.1.debdiff ** Description changed: [Impact] The bug results in an error being printed on the user screen when running docker builds. While the error will not cause the build to fail, the bug does prevent users to login on servers with no X11 installed. [Test Plan] - Install docker.io and golang-docker-credential-helpers - Run a simple docker build - Verify that the error occurs - Install the proposed fix - Run a simple docker build - Verify the error is no longer present - alternatively, try to run "docker login" and provide a correct username and password. By the end of the login process, an error will occur and the login will not succeed. ``` apt-get update apt-get install -y docker.io golang-docker-credential-helpers mkdir /tmp/dummy-docker-build cd /tmp/dummy-docker-build cat < Dockerfile FROM ubuntu:focal LABEL hello=label EOF - docker build -t golang-docker-credential-helpers:test + docker build -t golang-docker-credential-helpers:test . # Verify the error is triggered. # update the package and try the build again with # docker build -t golang-docker-credential-helpers:test # from this directory ``` [Where problems could occur] While the patch being applied is a simple, straightforward change, performing a rebuild of this package in bionic may pull newer versions of build dependencies which may cause unpredictable behavior in a stable package. [Other Info] - - This fix is already present upstream, in Debian, and in all following Ubuntu series. + + This fix is already present upstream, in Debian, and in all following + Ubuntu series. [Original message] Description of the problem: Running docker build generates a warning that an invalid free was performed. Steps to reproduce: sudo apt-get install docker-compose sudo docker build -f Dockerfile.build https://github.com/docker-library/hello-world.git Expected results: Docker container to be built without errors Actual results: An error is produced while the container is being built: free(): invalid pointer SIGABRT: abort PC=0x7f7027c42e97 m=0 sigcode=18446744073709551610 signal arrived during cgo execution goroutine 1 [syscall, locked to thread]: runtime.cgocall(0x4afd50, 0xc420073cc0, 0xc420073ce8) /usr/lib/go-1.8/src/runtime/cgocall.go:131 +0xe2 fp=0xc420073c90 sp=0xc420073c50 github.com/docker/docker-credential-helpers/secretservice._Cfunc_free(0x12c4da0) github.com/docker/docker-credential-helpers/secretservice/_obj/_cgo_gotypes.go:111 +0x41 fp=0xc420073cc0 sp=0xc420073c90 github.com/docker/docker-credential-helpers/secretservice.Secretservice.List.func5(0x12c4da0) /build/golang-github-docker-docker-credential-helpers-cMhSy1/golang-github-docker-docker-credential-helpers-0.5.0/obj-x86_64-linux-gnu/src/github.com/docker/docker-credential-helpers/secretservice/secretservice_linux.go:96 +0x60 fp=0xc420073cf8 sp=0xc420073cc0 github.com/docker/docker-credential-helpers/secretservice.Secretservice.List(0x0, 0x756060, 0xc420014370) /build/golang-github-docker-docker-credential-helpers-cMhSy1/golang-github-docker-docker-credential-helpers-0.5.0/obj-x86_64-linux-gnu/src/github.com/docker/docker-credential-helpers/secretservice/secretservice_linux.go:97 +0x217 fp=0xc420073da0 sp=0xc420073cf8 github.com/docker/docker-credential-helpers/secretservice.(*Secretservice).List(0x77e548, 0xc420073e88, 0x410022, 0xc4200142d0) :4 +0x46 fp=0xc420073de0 sp=0xc420073da0 github.com/docker/docker-credential-helpers/credentials.List(0x756ba0, 0x77e548, 0x7560e0, 0xc42000e018, 0x0, 0x10) /build/golang-github-docker-docker-credential-helpers-cMhSy1/golang-github-docker-docker-credential-helpers-0.5.0/obj-x86_64-linux-gnu/src/github.com/docker/docker-credential-helpers/credentials/credentials.go:145 +0x3e fp=0xc420073e68 sp=0xc420073de0 github.com/docker/docker-credential-helpers/credentials.HandleCommand(0x756ba0, 0x77e548, 0x7fff8fa9e879, 0x4, 0x7560a0, 0xc42000e010, 0x7560e0, 0xc42000e018, 0x40e398, 0x4d35c0) /build/golang-github-docker-docker-credential-helpers-cMhSy1/golang-github-docker-docker-credential-helpers-0.5.0/obj-x86_64-linux-gnu/src/github.com/docker/docker-credential-helpers/credentials/credentials.go:60 +0x16d fp=0xc420073ed8 sp=0xc420073e68 github.com/docker/docker-credential-helpers/credentials.Serve(0x756ba0, 0x77e548) /build/golang-github-docker-docker-credential-helpers-cMhSy1/golang-github-docker-docker-credential-helpers-0.5.0/obj-x86_64-linux
[Bug 1813003] Re: Invalid free while running docker build
Thanks for the patch and for working on this bug, Athos. A few comments: - Since this is an SRU, the version will be a bit different than in a normal upload to a development version. In this particular case, the version should be: 0.5.0-2ubuntu0.1 - The "Origin:" DEP-3 header should contain the direct link to the commit. It should also specify if this patch is a backport or if it was applied cleanly from upstream. For example: Origin: upstream, https://link.to.commit or Origin: backport, https://link.to.commit Other than that, the patch LGTM. The SRU template also LGTM, but there's a small nit in the Test Case section: the "docker build" command expects the directory where the build will happen as an argument, so I think the command should be: docker build -t golang-docker-credential-helpers:test . Other than that, I followed the reproduction steps and verified that (1) the error is indeed hapening, and (2) it is fixed by this patch. Let me know when you update the patch and I can upload it. Thanks. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813003 Title: Invalid free while running docker build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-docker-credential-helpers/+bug/1813003/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813003] Re: Invalid free while running docker build
This is a debdiff to apply the fix proposed in https://github.com/docker/docker-credential-helpers/pull/29 to bionic. ** Description changed: + [Impact] + + The bug results in an error being printed on the user screen when + running docker builds. + + While the error will not cause the build to fail, the bug does prevent + users to login on servers with no X11 installed. + + [Test Plan] + + - Install docker.io and golang-docker-credential-helpers + - Run a simple docker build + - Verify that the error occurs + - Install the proposed fix + - Run a simple docker build + - Verify the error is no longer present + + - alternatively, try to run "docker login" and provide a correct + username and password. By the end of the login process, an error will + occur and the login will not succeed. + + ``` + apt-get update + apt-get install -y docker.io golang-docker-credential-helpers + mkdir /tmp/dummy-docker-build + cd /tmp/dummy-docker-build + cat < Dockerfile + FROM ubuntu:focal + LABEL hello=label + EOF + docker build -t golang-docker-credential-helpers:test + # Verify the error is triggered. + # update the package and try the build again with + # docker build -t golang-docker-credential-helpers:test + # from this directory + ``` + + [Where problems could occur] + + While the patch being applied is a simple, straightforward change, + performing a rebuild of this package in bionic may pull newer versions + of build dependencies which may cause unpredictable behavior in a stable + package. + + [Other Info] + + This fix is already present upstream, in Debian, and in all following Ubuntu series. + + [Original message] + Description of the problem: - Running docker build generates a warning that an invalid free was performed. + Running docker build generates a warning that an invalid free was performed. Steps to reproduce: sudo apt-get install docker-compose - sudo docker build -f Dockerfile.build https://github.com/docker-library/hello-world.git + sudo docker build -f Dockerfile.build https://github.com/docker-library/hello-world.git Expected results: Docker container to be built without errors Actual results: An error is produced while the container is being built: free(): invalid pointer SIGABRT: abort PC=0x7f7027c42e97 m=0 sigcode=18446744073709551610 signal arrived during cgo execution goroutine 1 [syscall, locked to thread]: runtime.cgocall(0x4afd50, 0xc420073cc0, 0xc420073ce8) - /usr/lib/go-1.8/src/runtime/cgocall.go:131 +0xe2 fp=0xc420073c90 sp=0xc420073c50 + /usr/lib/go-1.8/src/runtime/cgocall.go:131 +0xe2 fp=0xc420073c90 sp=0xc420073c50 github.com/docker/docker-credential-helpers/secretservice._Cfunc_free(0x12c4da0) - github.com/docker/docker-credential-helpers/secretservice/_obj/_cgo_gotypes.go:111 +0x41 fp=0xc420073cc0 sp=0xc420073c90 + github.com/docker/docker-credential-helpers/secretservice/_obj/_cgo_gotypes.go:111 +0x41 fp=0xc420073cc0 sp=0xc420073c90 github.com/docker/docker-credential-helpers/secretservice.Secretservice.List.func5(0x12c4da0) - /build/golang-github-docker-docker-credential-helpers-cMhSy1/golang-github-docker-docker-credential-helpers-0.5.0/obj-x86_64-linux-gnu/src/github.com/docker/docker-credential-helpers/secretservice/secretservice_linux.go:96 +0x60 fp=0xc420073cf8 sp=0xc420073cc0 + /build/golang-github-docker-docker-credential-helpers-cMhSy1/golang-github-docker-docker-credential-helpers-0.5.0/obj-x86_64-linux-gnu/src/github.com/docker/docker-credential-helpers/secretservice/secretservice_linux.go:96 +0x60 fp=0xc420073cf8 sp=0xc420073cc0 github.com/docker/docker-credential-helpers/secretservice.Secretservice.List(0x0, 0x756060, 0xc420014370) - /build/golang-github-docker-docker-credential-helpers-cMhSy1/golang-github-docker-docker-credential-helpers-0.5.0/obj-x86_64-linux-gnu/src/github.com/docker/docker-credential-helpers/secretservice/secretservice_linux.go:97 +0x217 fp=0xc420073da0 sp=0xc420073cf8 + /build/golang-github-docker-docker-credential-helpers-cMhSy1/golang-github-docker-docker-credential-helpers-0.5.0/obj-x86_64-linux-gnu/src/github.com/docker/docker-credential-helpers/secretservice/secretservice_linux.go:97 +0x217 fp=0xc420073da0 sp=0xc420073cf8 github.com/docker/docker-credential-helpers/secretservice.(*Secretservice).List(0x77e548, 0xc420073e88, 0x410022, 0xc4200142d0) - :4 +0x46 fp=0xc420073de0 sp=0xc420073da0 + :4 +0x46 fp=0xc420073de0 sp=0xc420073da0 github.com/docker/docker-credential-helpers/credentials.List(0x756ba0, 0x77e548, 0x7560e0, 0xc42000e018, 0x0, 0x10) - /build/golang-github-docker-docker-credential-helpers-cMhSy1/golang-github-docker-docker-credential-helpers-0.5.0/obj-x86_64-linux-gnu/src/github.com/docker/docker-credential-helpers/credentials/credentials.go:145 +0x3e fp=0xc420073e68 sp=0xc420073de0 + /build/golang-github-docker-docker-credential-helpers-cMhSy1/golang-github-docker-docker-credential-helpers-0.5.0/o
[Bug 1813003] Re: Invalid free while running docker build
** Changed in: golang-github-docker-docker-credential-helpers (Ubuntu Bionic) Assignee: (unassigned) => Athos Ribeiro (athos-ribeiro) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813003 Title: Invalid free while running docker build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-docker-credential-helpers/+bug/1813003/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813003] Re: Invalid free while running docker build
It works for me. I confirm that error is not displayed anymore if package 'pass' is installed. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813003 Title: Invalid free while running docker build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-docker-credential-helpers/+bug/1813003/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813003] Re: Invalid free while running docker build
(For anyone who comes across this one of the upstream issues (https://github.com/docker/docker-credential- helpers/issues/103#issuecomment-576854271 ) mentions the problem goes away if `pass` package is also installed and this seemed to make the issue disappear for me too) ** Bug watch added: github.com/docker/docker-credential-helpers/issues #103 https://github.com/docker/docker-credential-helpers/issues/103 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813003 Title: Invalid free while running docker build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-docker-credential-helpers/+bug/1813003/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813003] Re: Invalid free while running docker build
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: golang-github-docker-docker-credential-helpers (Ubuntu Bionic) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813003 Title: Invalid free while running docker build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-docker-credential-helpers/+bug/1813003/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813003] Re: Invalid free while running docker build
** Also affects: golang-github-docker-docker-credential-helpers (Ubuntu Bionic) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813003 Title: Invalid free while running docker build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-docker-credential-helpers/+bug/1813003/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813003] Re: Invalid free while running docker build
What does the packag "golang-github-docker-docker-credential-helpers" do? ->It stores username and password used for `docker login` to "docker registries" in a "safer way". When does the bug manifest/occur? ->The bug occurs for instance when running `docker build`. How to get rid of this bug (considering in Ubuntu 18.04 this package is still not fixed month after the report is filed)? -> The bug can be circumvented (especially for those pointless, crazy cases like `docker build` where the credentials appear to be not even necessary) by disabling this "security for your credentials feature" eithe by: a) removing the @&(#* package via: `dpkg -r --force-depends golang-docker-credential-helpers` b) by setting a bogus credential helper program `printf '{ "credsStore":"bogus" }\n' > ~/.docker/config.json` Option b) comes with less side affects (collateral damage) than option a) wich would make `apt` complain about the "broken/missing" package. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813003 Title: Invalid free while running docker build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-docker-credential-helpers/+bug/1813003/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813003] Re: Invalid free while running docker build
Hello, we are also affected by this bug. dpkg -l | grep docker ii docker-compose 1.17.1-2 all Punctual, lightweight development environments using Docker ii docker.io 18.09.7-0ubuntu1~18.04.3 amd64Linux container runtime ii golang-docker-credential-helpers0.5.0-2 amd64Use native stores to safeguard Docker credentials ii python-docker 2.5.1-1 all Python wrapper to access docker.io's control socket ii python-dockerpty0.4.1-1 all Pseudo-tty handler for docker Python client (Python 2.x) ii python-dockerpycreds0.2.1-1 all Python bindings for the docker credentials store API -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813003 Title: Invalid free while running docker build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-docker-credential-helpers/+bug/1813003/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813003] Re: Invalid free while running docker build
** Tags added: bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813003 Title: Invalid free while running docker build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-docker-credential-helpers/+bug/1813003/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813003] Re: Invalid free while running docker build
diff --git a/secretservice/secretservice_linux.go b/secretservice/secretservice_linux.go index 95a1310..383b0c2 100644 --- a/secretservice/secretservice_linux.go +++ b/secretservice/secretservice_linux.go @@ -93,7 +93,7 @@ func (h Secretservice) List() (map[string]string, error) { var listLenC C.uint err := C.list(credsLabelC, &pathsC, &acctsC, &listLenC) if err != nil { - defer C.free(unsafe.Pointer(err)) + defer C.g_error_free(err) return nil, errors.New("Error from list function in secretservice_linux.c likely due to error in secretservice library") } defer C.freeListData(&pathsC, listLenC) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813003 Title: Invalid free while running docker build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-docker-credential-helpers/+bug/1813003/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813003] Re: Invalid free while running docker build
I agree with @anatoly.borodin - in fact the commit https://github.com/docker/docker-credential- helpers/commit/73e5f5dbfea31ee3b8ebbf189785fa69731c and pull request https://github.com/docker/docker-credential- helpers/pull/29/commits/79f93e5e69abc2ead458d19f4577b64b7e35c504 are the same fix. It's a crying shame that @aidanh010 filed this with a link to a fix last year but then it was somehow forgotten about... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813003 Title: Invalid free while running docker build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-docker-credential-helpers/+bug/1813003/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813003] Re: Invalid free while running docker build
A fix could be ported, or a package could be upgraded to v0.6.2. See https://github.com/docker/docker-credential- helpers/pull/29/commits/79f93e5e69abc2ead458d19f4577b64b7e35c504 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813003 Title: Invalid free while running docker build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-docker-credential-helpers/+bug/1813003/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813003] Re: Invalid free while running docker build
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: golang-github-docker-docker-credential-helpers (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813003 Title: Invalid free while running docker build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-docker-credential-helpers/+bug/1813003/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs