[Bug 1862312] Re: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel
This bug was fixed in the package linux - 4.15.0-88.88 --- linux (4.15.0-88.88) bionic; urgency=medium * bionic/linux: 4.15.0-88.88 -proposed tracker (LP: #1862824) * Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel (LP: #1862312) - Revert "mm/memory_hotplug: fix online/offline_pages called w.o. mem_hotplug_lock" - mm/memory_hotplug: fix online/offline_pages called w.o. mem_hotplug_lock linux (4.15.0-87.87) bionic; urgency=medium * bionic/linux: 4.15.0-87.87 -proposed tracker (LP: #1861165) * Bionic update: upstream stable patchset 2020-01-22 (LP: #1860602) - scsi: lpfc: Fix discovery failures when target device connectivity bounces - scsi: mpt3sas: Fix clear pending bit in ioctl status - scsi: lpfc: Fix locking on mailbox command completion - Input: atmel_mxt_ts - disable IRQ across suspend - iommu/tegra-smmu: Fix page tables in > 4 GiB memory - scsi: target: compare full CHAP_A Algorithm strings - scsi: lpfc: Fix SLI3 hba in loop mode not discovering devices - scsi: csiostor: Don't enable IRQs too early - powerpc/pseries: Mark accumulate_stolen_time() as notrace - powerpc/pseries: Don't fail hash page table insert for bolted mapping - powerpc/tools: Don't quote $objdump in scripts - dma-debug: add a schedule point in debug_dma_dump_mappings() - clocksource/drivers/asm9260: Add a check for of_clk_get - powerpc/security/book3s64: Report L1TF status in sysfs - powerpc/book3s64/hash: Add cond_resched to avoid soft lockup warning - ext4: update direct I/O read lock pattern for IOCB_NOWAIT - jbd2: Fix statistics for the number of logged blocks - scsi: tracing: Fix handling of TRANSFER LENGTH == 0 for READ(6) and WRITE(6) - scsi: lpfc: Fix duplicate unreg_rpi error in port offline flow - f2fs: fix to update dir's i_pino during cross_rename - clk: qcom: Allow constant ratio freq tables for rcg - irqchip/irq-bcm7038-l1: Enable parent IRQ if necessary - irqchip: ingenic: Error out if IRQ domain creation failed - fs/quota: handle overflows of sysctl fs.quota.* and report as unsigned long - scsi: lpfc: fix: Coverity: lpfc_cmpl_els_rsp(): Null pointer dereferences - scsi: ufs: fix potential bug which ends in system hang - powerpc/pseries/cmm: Implement release() function for sysfs device - powerpc/security: Fix wrong message when RFI Flush is disable - scsi: atari_scsi: sun3_scsi: Set sg_tablesize to 1 instead of SG_NONE - clk: pxa: fix one of the pxa RTC clocks - bcache: at least try to shrink 1 node in bch_mca_scan() - HID: logitech-hidpp: Silence intermittent get_battery_capacity errors - libnvdimm/btt: fix variable 'rc' set but not used - HID: Improve Windows Precision Touchpad detection. - scsi: pm80xx: Fix for SATA device discovery - scsi: ufs: Fix error handing during hibern8 enter - scsi: scsi_debug: num_tgts must be >= 0 - scsi: NCR5380: Add disconnect_mask module parameter - scsi: iscsi: Don't send data to unbound connection - scsi: target: iscsi: Wait for all commands to finish before freeing a session - gpio: mpc8xxx: Don't overwrite default irq_set_type callback - apparmor: fix unsigned len comparison with less than zero - scripts/kallsyms: fix definitely-lost memory leak - cdrom: respect device capabilities during opening action - perf script: Fix brstackinsn for AUXTRACE - perf regs: Make perf_reg_name() return "unknown" instead of NULL - s390/zcrypt: handle new reply code FILTERED_BY_HYPERVISOR - libfdt: define INT32_MAX and UINT32_MAX in libfdt_env.h - s390/cpum_sf: Check for SDBT and SDB consistency - ocfs2: fix passing zero to 'PTR_ERR' warning - kernel: sysctl: make drop_caches write-only - userfaultfd: require CAP_SYS_PTRACE for UFFD_FEATURE_EVENT_FORK - x86/mce: Fix possibly incorrect severity calculation on AMD - net, sysctl: Fix compiler warning when only cBPF is present - netfilter: nf_queue: enqueue skbs with NULL dst - ALSA: hda - Downgrade error message for single-cmd fallback - bonding: fix active-backup transition after link failure - perf strbuf: Remove redundant va_end() in strbuf_addv() - Make filldir[64]() verify the directory entry filename is valid - filldir[64]: remove WARN_ON_ONCE() for bad directory entries - netfilter: ebtables: compat: reject all padding in matches/watchers - 6pack,mkiss: fix possible deadlock - netfilter: bridge: make sure to pull arp header in br_nf_forward_arp() - inetpeer: fix data-race in inet_putpeer / inet_putpeer - net: add a READ_ONCE() in skb_peek_tail() - net: icmp: fix data-race in cmp_global_allow() - hrtimer: Annotate lockless access to timer->state - spi: fsl: don't map irq during probe - tty/serial: atmel: fix out of range clock divider handling - pinctrl: baytrail: Reall
[Bug 1862312] Re: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel
Xenial 4.15, Xenial 4.15 Oracle all green. thank you! ** Tags removed: verification-needed-bionic ** Tags added: verification-done-bionic ** Changed in: ubuntu-kernel-tests Status: Fix Committed => Fix Released ** Changed in: linux (Ubuntu) Status: Incomplete => Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1862312 Title: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1862312/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1862312] Re: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel
Bionic 4.15 amd64, ppc64 are good. Checking Xenial 4.15 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1862312 Title: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1862312/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1862312] Re: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel
4.15.0-1060.62 linux-aws ubuntu_kernel_selftests has passed on all instances 4.15.0-1033.36 linux-oracle ubuntu_kernel_selftests has memory_hotplug test has passed 4.15.0-1052.55 linux-gke ubuntu_kernel_selftests has passed on all instances ** Changed in: ubuntu-kernel-tests Status: New => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1862312 Title: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1862312/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1862312] Re: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel
awaiting main-kernel for amd64 and ppc64 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1862312 Title: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1862312/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1862312] Re: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel
This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed- bionic' to 'verification-done-bionic'. If the problem still exists, change the tag 'verification-needed-bionic' to 'verification-failed- bionic'. If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you! ** Tags added: verification-needed-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1862312 Title: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1862312/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1862312] Re: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel
** Changed in: linux (Ubuntu Bionic) Status: New => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1862312 Title: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1862312/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1862312] Re: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel
Fix for the issue: https://lists.ubuntu.com/archives/kernel- team/2020-February/107398.html Tested on AWS with positive test results. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1862312 Title: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1862312/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1862312] Re: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel
Hi Marcelo, as it's much more easier to reproduce this on clouds (for now), so I just built a bionic AWS kernel with that commit reverted: https://people.canonical.com/~phlin/kernel/lp-1862312-memhp/ The memory hotplug test works fine with multiple retries with this kernel. But if I switched to the 1059 in proposed, the r5.large instance will crash within 2 retries. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1862312 Title: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1862312/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1862312] Re: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel
Issue NOT spotted on 4.15 GKE (4.15.0-1051.54), X-4.15 GCP (4.15.0-1053.57) Spotted on B-4.15 AWS (4.15.0-1059.61) with instance r5.large -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1862312 Title: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1862312/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1862312] Re: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel
Thanks! I will try, but this issue was not spotted in our general kernel testing with the node we use (node rizzo). Thus it might take some time to find out an affected node first. You can run this with the source tree: $ make -C tools/testing/selftests TARGETS=memory-hotplug run_tests Ref: https://www.kernel.org/doc/html/v4.15/dev-tools/kselftest.html -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1862312 Title: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1862312/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1862312] Re: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel
Hi, Sam. Can you help me testing the change above? I uploaded a test kernel with this change to https://kernel.ubuntu.com/~mhcerri/lp1862312/ It's not clear to me what's the requirement to run the memory hotplug self test. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1862312 Title: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1862312/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1862312] Re: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel
A possible cause might be the Bionic commit 483735440add (mm/memory_hotplug: fix online/offline_pages called w.o. mem_hotplug_lock) that was backported from the upstream commit 381eab4a6ee8. It seems the location of the new call to mem_hotplug_being() was shifted: -->8-- diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 6cd0c4a144d5..7dd8b84ea849 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -891,6 +891,8 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages, int online_typ int ret; struct memory_notify arg; + mem_hotplug_begin(); + nid = pfn_to_nid(pfn); /* associate pfn range with the zone */ zone = move_pfn_range(online_type, nid, pfn, nr_pages); @@ -904,8 +906,6 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages, int online_typ if (ret) goto failed_addition; - mem_hotplug_begin(); - /* * If this zone is not populated, then it is not in zonelist. * This means the page allocator ignores this zone. @@ -1178,9 +1178,7 @@ int __ref add_memory_resource(int nid, struct resource *res, bool online) walk_memory_range(PFN_DOWN(start), PFN_UP(start + size - 1), NULL, online_memory_block); - return ret; - error: /* rollback pgdat allocation and others */ if (new_pgdat && pgdat) -->8-- I will build a test kernel with this change to test it. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1862312 Title: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1862312/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1862312] Re: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel
Issue found on 4.15.0-1059.61~16.04.1 AWS as well. It's not failing on all of the instances. ** Tags added: aws oracle ** Also affects: ubuntu-kernel-tests Importance: Undecided Status: New ** Tags added: ubuntu-kernel-selftests ** Tags added: sru-20200127 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1862312 Title: Segmentation fault (kernel oops) with memory-hotplug in ubuntu_kernel_selftests on Bionic kernel To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1862312/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
