[Bug 1943481] Re: libvirtd crashes when creating network interface pools in 6.0.0-0ubuntu8.13

2021-09-15 Thread Launchpad Bug Tracker
This bug was fixed in the package libvirt - 6.0.0-0ubuntu8.14 --- libvirt (6.0.0-0ubuntu8.14) focal; urgency=medium * Fixup backport of "util: Add phys_port_name support on virPCIGetNetName" to include the incorrectly removed "firstEntryName = NULL;" line, which caused a

[Bug 1943481] Re: libvirtd crashes when creating network interface pools in 6.0.0-0ubuntu8.13

2021-09-15 Thread Christian Ehrhardt 
As discussed I've thrown this into some general regression testing. While it didn't catch the former issue it provides some general coverage and confidence avoiding that something totally unexpected slipped in. I tested only x86 as that was the system I had ready, but nothing should be

[Bug 1943481] Re: libvirtd crashes when creating network interface pools in 6.0.0-0ubuntu8.13

2021-09-15 Thread Andy Whitcroft
Early release has been requested, as this is a simple fix this seems ok with some additional testing. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1943481 Title: libvirtd crashes when creating

[Bug 1943481] Re: libvirtd crashes when creating network interface pools in 6.0.0-0ubuntu8.13

2021-09-14 Thread Christian Ehrhardt 
Thank you Paul! ** Tags removed: verification-needed verification-needed-focal ** Tags added: verification-done verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1943481 Title:

Re: [Bug 1943481] Re: libvirtd crashes when creating network interface pools in 6.0.0-0ubuntu8.13

2021-09-14 Thread Paul Saab
Installed, rebooted and VM's started up.. Fix is working apt-cache policy libvirt-daemon-system libvirt-daemon-system: Installed: 6.0.0-0ubuntu8.14 Candidate: 6.0.0-0ubuntu8.14 Version table: *** 6.0.0-0ubuntu8.14 500 500 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64

[Bug 1943481] Re: libvirtd crashes when creating network interface pools in 6.0.0-0ubuntu8.13

2021-09-14 Thread Matthew Ruffell
Hi Paul, Could you please install the libvirt packages in -proposed and verify that it fixes the problem? Instructions to Install (on a Focal system): 1) cat << EOF | sudo tee /etc/apt/sources.list.d/ubuntu-$(lsb_release -cs)-proposed.list # Enable Ubuntu proposed archive deb

[Bug 1943481] Re: libvirtd crashes when creating network interface pools in 6.0.0-0ubuntu8.13

2021-09-14 Thread Chris Halse Rogers
Hello Paul, or anyone else affected, Accepted libvirt into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libvirt/6.0.0-0ubuntu8.14 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

[Bug 1943481] Re: libvirtd crashes when creating network interface pools in 6.0.0-0ubuntu8.13

2021-09-14 Thread Matthew Ruffell
** Description changed: - The latest libvirtd (6.0.0-0ubuntu8.13) crashes when trying to bring up - network pools with the stacktrace below. I tracked down the problem to - the newly added patch (lp-1892132-Add-phys_port_name-support-on- - virPCIGetNetName.patch). Assigning *netname =

[Bug 1943481] Re: libvirtd crashes when creating network interface pools in 6.0.0-0ubuntu8.13

2021-09-14 Thread Christian Ehrhardt 
Sponsored, Matthew will add the updated Description (with the SRU template) any minute. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1943481 Title: libvirtd crashes when creating network interface

[Bug 1943481] Re: libvirtd crashes when creating network interface pools in 6.0.0-0ubuntu8.13

2021-09-14 Thread Christian Ehrhardt 
Only a focal issue, so I marked the general libvirt task as invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1943481 Title: libvirtd crashes when creating network interface pools in

[Bug 1943481] Re: libvirtd crashes when creating network interface pools in 6.0.0-0ubuntu8.13

2021-09-14 Thread Christian Ehrhardt 
I also double checked if Hirsute is ok and I agree to comment 5 - Hirsute already uses g_steal_pointer in that place and thereby is fine. Ok, discussed with Matthew - g_steal_pointer would indeed be ok there as well, but OTOH I've checked the g_steal_pointer in glib2 glib2.0/glib/gmem.h and it

[Bug 1943481] Re: libvirtd crashes when creating network interface pools in 6.0.0-0ubuntu8.13

2021-09-13 Thread Christian Ehrhardt 
Thank you Matthew for the quick response and I see you already added Frode who was driving this change. I have reviewed the PPA and the diff that it has right now. Yes 77401d54 seems present and c0ae4919e would be needed for that as dependency. The code still has the needed VIR_DIR_CLOSE so it

[Bug 1943481] Re: libvirtd crashes when creating network interface pools in 6.0.0-0ubuntu8.13

2021-09-13 Thread Matthew Ruffell
Hi Paul, Thank you very much for testing, we appreciate it. I'll make sure we get this fix fast-tracked, and try get a new libvirt build into -proposed in a couple hours, and try go for a release to -updates in the next day or so. Thanks, Matthew -- You received this bug notification because

Re: [Bug 1943481] Re: libvirtd crashes when creating network interface pools in 6.0.0-0ubuntu8.13

2021-09-13 Thread Paul Saab
Patch applied, installed and rebooted. Guest VM comes up now. Thank you! libvirt-daemon-system: Installed: 6.0.0-0ubuntu8.13+lp1943481v20210914b2 Candidate: 6.0.0-0ubuntu8.13+lp1943481v20210914b2 Version table: *** 6.0.0-0ubuntu8.13+lp1943481v20210914b2 500 500

[Bug 1943481] Re: libvirtd crashes when creating network interface pools in 6.0.0-0ubuntu8.13

2021-09-13 Thread Matthew Ruffell
Test packages are now available in: https://launchpad.net/~mruffell/+archive/ubuntu/lp1943481-test Please note these test packages are NOT SUPPORTED by Canonical, and are for TEST PURPOSES ONLY. ONLY install in a dedicated test environment. Instructions to Install (on a Focal system): 1) sudo

[Bug 1943481] Re: libvirtd crashes when creating network interface pools in 6.0.0-0ubuntu8.13

2021-09-13 Thread Matthew Ruffell
Okay, after reviewing the various patches and backports, Frode's backport was correct, it was just missing the "firstEntryName = NULL;" line. Attached is a debdiff with the "firstEntryName = NULL;" line restored. Only Focal is affected, Hirsute and Impish are working correctly. I have a test

[Bug 1943481] Re: libvirtd crashes when creating network interface pools in 6.0.0-0ubuntu8.13

2021-09-13 Thread Ubuntu Foundations Team Bug Bot
The attachment "lp-1892132-Add-phys_port_name-support-on- virPCIGetNetName.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message

[Bug 1943481] Re: libvirtd crashes when creating network interface pools in 6.0.0-0ubuntu8.13

2021-09-13 Thread Matthew Ruffell
** Changed in: libvirt (Ubuntu Focal) Assignee: (unassigned) => Matthew Ruffell (mruffell) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1943481 Title: libvirtd crashes when creating network

[Bug 1943481] Re: libvirtd crashes when creating network interface pools in 6.0.0-0ubuntu8.13

2021-09-13 Thread Matthew Ruffell
Okay, this is what appears to have happened. During the backport of: commit 5b1c525b1f3608156884aed0dc5e925306c1e260 Author: Dmytro Linkin Date: Thu Jan 21 14:15:22 2021 +0200 Subject: util: Add phys_port_name support on virPCIGetNetName Link:

[Bug 1943481] Re: libvirtd crashes when creating network interface pools in 6.0.0-0ubuntu8.13

2021-09-13 Thread Matthew Ruffell
** Also affects: libvirt (Ubuntu Focal) Importance: Undecided Status: New ** Changed in: libvirt (Ubuntu Focal) Importance: Undecided => Critical ** Changed in: libvirt (Ubuntu Focal) Status: New => In Progress -- You received this bug notification because you are a member

[Bug 1943481] Re: libvirtd crashes when creating network interface pools in 6.0.0-0ubuntu8.13

2021-09-13 Thread Dan Streetman
Yeah, looking at the patch it's clear the NULL setting was accidentally (?) left off: -if (physPortID) {

[Bug 1943481] Re: libvirtd crashes when creating network interface pools in 6.0.0-0ubuntu8.13

2021-09-13 Thread Paul Saab
This is an updated lp-1892132-Add-phys_port_name-support-on- virPCIGetNetName.patch that uses g_steal_pointer(); when assigning *netname. ** Patch added: "lp-1892132-Add-phys_port_name-support-on-virPCIGetNetName.patch"