Re: upstream Source patches and patch systems

2009-10-07 Thread Scott Kitterman
On Wed, 07 Oct 2009 10:40:53 +0200 Reinhard Tartler wrote: > >> - if it's an Ubuntu (-0ubuntuX) package and no previous modifications >> has been done, adding a patch system is preferred > >May I ask why? > >Espc. since uploads are auto-imported these days into a bzr branch, and >earlier revision

Re: upstream Source patches and patch systems

2009-10-07 Thread Reinhard Tartler
fabrice writes: > let me rephrase it this way: > - if modification has already been done, stick to what the Debian > maintainer or Ubuntu is already doing. That mean use the existing patch > system, if any, or modify directly the source if some modifications has > already been done, but do not ad

Re: upstream Source patches and patch systems

2009-10-07 Thread Scott Kitterman
On Wed, 07 Oct 2009 07:02:58 +0200 fabrice wrote: >Hi, > >We were having a discussion yesterday on IRC about the sense of adding a >patch system to a package that don't have one when modifying the >upstream source code. > >My understanding of the general rules is: >- if it's a Debian package and m

Re: upstream Source patches and patch systems

2009-10-07 Thread Stefan Potyra
Hi, Am Wednesday 07 October 2009 08:13:36 schrieb fabrice: > John Dong escribió: > > Can you clarify these two points? To my 2AM mind it reads as if the > > It's because my 7AM mind needs some coffee :-) > > let me rephrase it this way: > - if modification has already been done, stick to what the

Re: upstream Source patches and patch systems

2009-10-07 Thread Andreas Wenning
On Wednesday 07 October 2009 08:13:36 fabrice wrote: > - if it's a Debian package and no previous modifications has been done, > modify directly the source, and do not introduce a patch system If it is a small patch and it is applicaple in Debian+upstream, don't add a patch system. But if the patc

Re: upstream Source patches and patch systems

2009-10-06 Thread John Dong
Thanks; that is much clearer! I agree with the general idea here. Any specific patchsys we would like ubuntu devs to add in particular? On Oct 7, 2009, at 2:13 AM, fabrice wrote: > John Dong escribió: >> Can you clarify these two points? To my 2AM mind it reads as if the > > It's because my 7A

Re: upstream Source patches and patch systems

2009-10-06 Thread fabrice
John Dong escribió: > Can you clarify these two points? To my 2AM mind it reads as if the It's because my 7AM mind needs some coffee :-) let me rephrase it this way: - if modification has already been done, stick to what the Debian maintainer or Ubuntu is already doing. That mean use the existing

Re: upstream Source patches and patch systems

2009-10-06 Thread John Dong
Can you clarify these two points? To my 2AM mind it reads as if the latter says "Same rules except completely different rules" :) On Oct 7, 2009, at 1:02 AM, fabrice wrote: > - if it's a Debian package and no previous modifications has been > done, > modify directly the source, and do not intr

upstream Source patches and patch systems

2009-10-06 Thread fabrice
Hi, We were having a discussion yesterday on IRC about the sense of adding a patch system to a package that don't have one when modifying the upstream source code. My understanding of the general rules is: - if it's a Debian package and modification has already been done, stick to what the Debian