Re: [UrJTAG-dev] about commit messages
Geert Stappers: > On Sun, Aug 04, 2019 at 11:01:45AM +0200, wait for elaboration wrote: ... > > Save entity name as part_name > AKA short commit message, max 52 characters, shows up the Subject > > Why > AKA the long commit message. > It tells what the change suppoes and WHY. > Illustration with before and after examples is fine. This commit and the previous one is to move the setting of part_name outside of bsdl parser so we can test for idcode match without special casing inside the bsdl parser. We don't want special casing within the parser, since the parser should just be given a file name and return a parse tree or an error code. > Don't worry if the commit message has more text > than the actual code change. Honestly, if urjtag was quality code, I'd be fine with thoose smallish patches you want. But looking at the data structures one just wishes to solve this mess as fast as possible, treating this code as you want to do it is in my opinion just a waste of time (well, apart from learning to write good commit messages...). And I don't need to get my patches to be accepted upstream, I'm content to just have them applied locally. Regards, /Karl Hammar ___ UrJTAG-development mailing list UrJTAG-development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/urjtag-development
Re: [UrJTAG-dev] about commit messages
On Sun, Aug 04, 2019 at 11:01:45AM +0200, wait for elaboration wrote: > On Sun, Aug 04, 2019 at 10:38:48AM +0200, k...@aspodata.se wrote: > > Geert Stappers: > > ... > > > fix bug in detect/bsdl > > > > > > Save the entity name as part_name if the idcode matches for this file. > > > > Would it be if the first line was dropped ? > > > > Save entity name as part_name AKA short commit message, max 52 characters, shows up the Subject > Why AKA the long commit message. It tells what the change suppoes and WHY. Illustration with before and after examples is fine. Don't worry if the commit message has more text than the actual code change. Regards Geert Stappers ___ UrJTAG-development mailing list UrJTAG-development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/urjtag-development
Re: [UrJTAG-dev] about commit messages Was: [PATCH] fix bug in detect/bsdl
On Sun, Aug 04, 2019 at 10:38:48AM +0200, k...@aspodata.se wrote: > Geert Stappers: > ... > > fix bug in detect/bsdl > > > > Save the entity name as part_name if the idcode matches for this file. > > Would it be if the first line was dropped ? > Save entity name as part_name Why ___ UrJTAG-development mailing list UrJTAG-development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/urjtag-development
