Re: upgrading from 2.x TWCS to 3.x TWCS

2019-09-30 Thread Carl Mueller
sweet Ugh, for the test I just realized that sstableloader probably wont' produce buckets corresponding with the actual insertion time of the data in twcs. Well, we can still run the test. On Mon, Sep 30, 2019 at 2:47 AM Oleksandr Shulgin < oleksandr.shul...@zalando.de> wrote: > On Fri, Sep

Re: upgrading from 2.x TWCS to 3.x TWCS

2019-09-30 Thread Oleksandr Shulgin
On Fri, Sep 27, 2019 at 7:39 PM Carl Mueller wrote: > So IF that delegate class would work: > > 1) create jar with the delegate class > 2) deploy jar along with upgrade on node > 3) once all nodes are upgraded, issue ALTER to change to the > org.apache.cassandra TWCS class. > Yes, this used to

Re: upgrading from 2.x TWCS to 3.x TWCS

2019-09-27 Thread Jeff Jirsa
I suspect this will work, yes (Sorry I can't make a proper upgrade path, sorta out of my hands) On Fri, Sep 27, 2019 at 11:19 AM Carl Mueller wrote: > Oops, I think the getName() is an important thing: > > package com.jeffjirsa.cassandra.db.compaction; > > import

Re: upgrading from 2.x TWCS to 3.x TWCS

2019-09-27 Thread Carl Mueller
Oops, I think the getName() is an important thing: package com.jeffjirsa.cassandra.db.compaction; import org.apache.cassandra.db.ColumnFamilyStore; import java.util.Map; public class TimeWindowCompactionStrategy extends org.apache.cassandra.db.compaction.TimeWindowCompactionStrategy {

Re: upgrading from 2.x TWCS to 3.x TWCS

2019-09-27 Thread Carl Mueller
Or can we just do this safely in a side jar? package com.jeffjirsa.cassandra.db.compaction; import org.apache.cassandra.db.ColumnFamilyStore; import org.apache.cassandra.db.compaction.TimeWindowCompactionStrategy; import java.util.Map; public class TimeWindowCompactionStrategy extends

Re: upgrading from 2.x TWCS to 3.x TWCS

2019-09-27 Thread Carl Mueller
So IF that delegate class would work: 1) create jar with the delegate class 2) deploy jar along with upgrade on node 3) once all nodes are upgraded, issue ALTER to change to the org.apache.cassandra TWCS class. will that trigger full recompaction? On Fri, Sep 27, 2019 at 12:25 PM Carl Mueller

Re: upgrading from 2.x TWCS to 3.x TWCS

2019-09-27 Thread Carl Mueller
For example (delegating all public methods from AbstractCompactionStrategy and some from TimeWindowCompactionStrategy EXCEPT getName() ) package com.jeffjirsa.cassandra.db.compaction; public class TimeWindowCompactionStrategy extends AbstractCompactionStrategy {

Re: upgrading from 2.x TWCS to 3.x TWCS

2019-09-27 Thread Carl Mueller
Is this still the official answer on TWCS 2.X --> 3.X upgrades? Pull the code and recompile as a different package? Can I just declare the necessary class and package namespace and delegate to the actual main-codebase class? On Mon, Nov 5, 2018 at 1:41 AM Oleksandr Shulgin <

Re: upgrading from 2.x TWCS to 3.x TWCS

2018-11-04 Thread Oleksandr Shulgin
On Sat, Nov 3, 2018 at 1:13 AM Brian Spindler wrote: > That wasn't horrible at all. After testing, provided all goes well I can > submit this back to the main TWCS repo if you think it's worth it. > > Either way do you mind just reviewing briefly for obvious mistakes? > > >

Re: upgrading from 2.x TWCS to 3.x TWCS

2018-11-02 Thread Brian Spindler
That wasn't horrible at all. After testing, provided all goes well I can submit this back to the main TWCS repo if you think it's worth it. Either way do you mind just reviewing briefly for obvious mistakes? https://github.com/bspindler/twcs/commit/7ba388dbf41b1c9dc1b70661ad69273b258139da

Re: upgrading from 2.x TWCS to 3.x TWCS

2018-11-02 Thread Brian Spindler
I hope I can do as you suggest and leapfrog to 3.11 rather than two stepping it from 3.7->3.11 Just having TWCS has saved me lots of hassle so it’s all good, thanks for all you do for our community. -B On Fri, Nov 2, 2018 at 3:54 PM Jeff Jirsa wrote: > I'm sincerely sorry for the hassle, but

Re: upgrading from 2.x TWCS to 3.x TWCS

2018-11-02 Thread Jeff Jirsa
I'm sincerely sorry for the hassle, but for various reasons beyond, it's unlikely I'll update my repo (at least me, personally). One fix is likely to grab the actual java classes from the apache repo, pull them in and fix the package names, and compile (essentially making your own 3.11 branch). I

Re: upgrading from 2.x TWCS to 3.x TWCS

2018-11-02 Thread Brian Spindler
you are right, it won't even compile: [INFO] - [ERROR] COMPILATION ERROR : [INFO] - [ERROR]

Re: upgrading from 2.x TWCS to 3.x TWCS

2018-11-02 Thread Jeff Jirsa
There’s a chance it will fail to work - possible method signatures changed between 3.0 and 3.11. Try it in a test cluster before prod -- Jeff Jirsa > On Nov 2, 2018, at 11:49 AM, Brian Spindler wrote: > > Nevermind, I spoke to quickly. I can change the cass version in the pom.xml > and re

Re: upgrading from 2.x TWCS to 3.x TWCS

2018-11-02 Thread Brian Spindler
Nevermind, I spoke to quickly. I can change the cass version in the pom.xml and re compile, thanks! On Fri, Nov 2, 2018 at 2:38 PM Brian Spindler wrote: > [image: image.png] > > > On Fri, Nov 2, 2018 at 2:34 PM Jeff Jirsa wrote: > >> Easiest approach is to build the 3.11 jar from my repo,

Re: upgrading from 2.x TWCS to 3.x TWCS

2018-11-02 Thread Brian Spindler
[image: image.png] On Fri, Nov 2, 2018 at 2:34 PM Jeff Jirsa wrote: > Easiest approach is to build the 3.11 jar from my repo, upgrade, then > ALTER table to use the official TWCS (org.apache.cassandra) jar > > Sorry for the headache. I hope I have a 3.11 branch for you. > > > -- > Jeff Jirsa >

Re: upgrading from 2.x TWCS to 3.x TWCS

2018-11-02 Thread Jeff Jirsa
Easiest approach is to build the 3.11 jar from my repo, upgrade, then ALTER table to use the official TWCS (org.apache.cassandra) jar Sorry for the headache. I hope I have a 3.11 branch for you. -- Jeff Jirsa > On Nov 2, 2018, at 11:28 AM, Brian Spindler wrote: > > Hi all, we're planning

upgrading from 2.x TWCS to 3.x TWCS

2018-11-02 Thread Brian Spindler
Hi all, we're planning an upgrade from 2.1.5->3.11.3 and currently we have several column families configured with twcs class 'com.jeffjirsa.cassandra.db.compaction.TimeWindowCompactionStrategy' and with 3.11.3 we need to set it to 'TimeWindowCompactionStrategy' Is that a safe operation? Will