Re: Flink packaging makes life hard for SBT fat jar's

2016-03-12 Thread Till Rohrmann
Great to hear Shikhar :-) Cheers, Till On Mar 4, 2016 3:51 AM, "shikhar" wrote: > Thanks Till. I can confirm that things are looking good with RC5. > sbt-assembly works well with the flink-kafka connector dependency not > marked > as "provided". > > > > -- > View this message in context: > http:

Re: Flink packaging makes life hard for SBT fat jar's

2016-03-03 Thread shikhar
Thanks Till. I can confirm that things are looking good with RC5. sbt-assembly works well with the flink-kafka connector dependency not marked as "provided". -- View this message in context: http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Flink-packaging-makes-life-hard-for-

Re: Flink packaging makes life hard for SBT fat jar's

2016-03-02 Thread Till Rohrmann
Hi Shikhar, that is a problem we just found out today. The problem is that the scala.binary.version was not properly replaced in the parent pom so that it resolves to 2.10 [1]. Max already opened a PR to fix this problem. With the next release candidate, this should be fixed. [1] https://issues.a

Re: Flink packaging makes life hard for SBT fat jar's

2016-03-02 Thread shikhar
Hi Till, I just tried creating an assembly with RC4: ``` "org.apache.flink" %% "flink-clients" % flinkVersion % "provided", "org.apache.flink" %% "flink-streaming-scala" % flinkVersion % "provided", "org.apache.flink" %% "flink-connector-kafka-0.8" % flinkVersion, ``` It actually succeeds

Re: Flink packaging makes life hard for SBT fat jar's

2016-02-22 Thread Till Rohrmann
Hi Shikhar, you're right that including a connector dependency would have let us spot the problem earlier. In fact, any project building a fat jar with SBT would have failed without setting the flink dependencies to provided. The problem is that the template is a general purpose template. Thus, i

Re: Flink packaging makes life hard for SBT fat jar's

2016-02-22 Thread shikhar
Hi Till, Thanks so much for sorting this out! One suggestion, can the Flink template depend on a connector (Kafka?) -- this would verify that assembly works smoothly for a very common use-case when you need to include connector JAR's. Cheers, Shikhar -- View this message in context: http://

Re: Flink packaging makes life hard for SBT fat jar's

2016-02-22 Thread Till Rohrmann
Hi Shikhar, I just wanted to let you know that we've found the problem with the failing assembly plugin. It was caused by incompatible classes [1, 2]. Once these PRs are merged, the merge problems should be resolved. By the way, we've also added now a SBT template for Flink projects using giter8

Re: Flink packaging makes life hard for SBT fat jar's

2016-02-17 Thread Stephan Ewen
Hi! I know that Till is currently looking into making the SBT experience better. He should have an update in a bit. We need to check a few corner cases about how SBT and Maven dependencies and types (provided, etc) interact and come up with a plan. We'll also add an SBT quickstart to the homepag

Re: Flink packaging makes life hard for SBT fat jar's

2016-02-17 Thread shikhar
This seems to work to generate the assembly, hopefully not missing any required transitive deps: ``` "org.apache.flink" %% "flink-clients" % flinkVersion % "provided", "org.apache.flink" %% "flink-streaming-scala" % flinkVersion % "provided", "org.apache.kafka" %% "kafka" % "0.8.2.2", ("or

Re: Flink packaging makes life hard for SBT fat jar's

2016-02-15 Thread shikhar
Stephan Ewen wrote > Do you know why you are getting conflicts on the FashHashMap class, even > though the core Flink dependencies are "provided"? Does adding the Kafka > connector pull in all the core Flink dependencies? Yes, the core Flink dependencies are being pulled in transitively from the K

Re: Flink packaging makes life hard for SBT fat jar's

2016-02-15 Thread Stephan Ewen
Hi! Looks like that experience should be improved. Do you know why you are getting conflicts on the FashHashMap class, even though the core Flink dependencies are "provided"? Does adding the Kafka connector pull in all the core Flink dependencies? Concerning the Kafka connector: We did not inclu

Flink packaging makes life hard for SBT fat jar's

2016-02-12 Thread shikhar
Repro at https://github.com/shikhar/flink-sbt-fatjar-troubles, run `sbt assembly` A fat jar seems like the best way to provide jobs for Flink to execute. I am declaring deps like: {noformat} "org.apache.flink" %% "flink-clients" % "1.0-SNAPSHOT" % "provided" "org.apache.flink" %% "flink-streaming