Re: [Neo4j] GraphAlgoFactory.pathsWithLength returns paths with loops

2010-10-22 Thread Mattias Persson
Hi again, I just solved the problem... it was a bug because your example found a path which contained a relationship in two places, which isn't even loops (where a node can be found in more than one place in a path). So now I'd guess it's working as you'd expect. Please let me know otherwise.

Re: [Neo4j] GraphAlgoFactory.pathsWithLength returns paths with loops

2010-10-18 Thread Mattias Persson
2010/10/18, Yaniv Ben Yosef yani...@gmail.com: Thanks Mattias! Do you have an expected time-frame for that? Alternatively, do you have any quick tips on how I would go and implement this myself? I very briefly scanned the code in org.neo4j.graphalgo.impl.path.ShortestPath and I suspect I

Re: [Neo4j] GraphAlgoFactory.pathsWithLength returns paths with loops

2010-10-18 Thread Yaniv Ben Yosef
Thanks, I figured that.. Would you be so kind reviewing the code once I finish it? --- Yaniv On Mon, Oct 18, 2010 at 8:20 AM, Mattias Persson matt...@neotechnology.comwrote: 2010/10/18, Yaniv Ben Yosef yani...@gmail.com: Thanks Mattias! Do you have an expected time-frame for that?

Re: [Neo4j] GraphAlgoFactory.pathsWithLength returns paths with loops

2010-10-18 Thread Mattias Persson
2010/10/18 Yaniv Ben Yosef yani...@gmail.com Thanks, I figured that.. Would you be so kind reviewing the code once I finish it? Sure! --- Yaniv On Mon, Oct 18, 2010 at 8:20 AM, Mattias Persson matt...@neotechnology.comwrote: 2010/10/18, Yaniv Ben Yosef yani...@gmail.com: Thanks

Re: [Neo4j] GraphAlgoFactory.pathsWithLength returns paths with loops

2010-10-18 Thread Yaniv Ben Yosef
Hi Mattias, While taking a closer look at the code, I realized there's an AllSimplePaths class, which can be easily modified to filter paths whose length isn't maxDepth (with an extra argument or subclass). I think that's the simplest solution, but I'm not clear on why pathsWithLength() uses

Re: [Neo4j] GraphAlgoFactory.pathsWithLength returns paths with loops

2010-10-18 Thread Andreas Kollegger
Hi Yaniv, To build the jar file, be sure to run `mvn clean package` which will run through clean, compile, test, then package. Or, `mvn clean install` to have the jar files installed in your local maven repository. Best, Andreas On Oct 18, 2010, at 5:15 PM, Yaniv Ben Yosef wrote: Hi

Re: [Neo4j] GraphAlgoFactory.pathsWithLength returns paths with loops

2010-10-18 Thread Mattias Persson
2010/10/18, Yaniv Ben Yosef yani...@gmail.com: Hi Mattias, While taking a closer look at the code, I realized there's an AllSimplePaths class, which can be easily modified to filter paths whose length isn't maxDepth (with an extra argument or subclass). I think that's the simplest solution,

[Neo4j] GraphAlgoFactory.pathsWithLength returns paths with loops

2010-10-17 Thread Yaniv Ben Yosef
Hi, I am playing with Neo4J version 1.2 M1, specifically with GraphAlgoFactory.pathsWithLength(). According to the javadoc, it should never return paths with loops. However, it seems like it does. I created a simple test case to demonstrate that: http://snipt.org/kpwn/ I expect the code not to

Re: [Neo4j] GraphAlgoFactory.pathsWithLength returns paths with loops

2010-10-17 Thread Peter Neubauer
Hi Yaniv, thanks for the report, I will take a look at it tomorrow if that is ok? Cheers, /peter neubauer VP Product Management, Neo Technology GTalk:      neubauer.peter Skype       peter.neubauer Phone       +46 704 106975 LinkedIn   http://www.linkedin.com/in/neubauer Twitter     

Re: [Neo4j] GraphAlgoFactory.pathsWithLength returns paths with loops

2010-10-17 Thread Yaniv Ben Yosef
Sure :) Will be happy to get your feedback. --- Yaniv On Sun, Oct 17, 2010 at 6:24 PM, Peter Neubauer peter.neuba...@neotechnology.com wrote: Hi Yaniv, thanks for the report, I will take a look at it tomorrow if that is ok? Cheers, /peter neubauer VP Product Management, Neo Technology

Re: [Neo4j] GraphAlgoFactory.pathsWithLength returns paths with loops

2010-10-17 Thread Mattias Persson
I just realized (it was me who put it there) that the documentation is wrong. That one allows cyclic paths, as you obviously noticed :). I'll try to add a simplePathsWithLength method also to take care of that... 2010/10/17 Yaniv Ben Yosef yani...@gmail.com Sure :) Will be happy to get your

Re: [Neo4j] GraphAlgoFactory.pathsWithLength returns paths with loops

2010-10-17 Thread Yaniv Ben Yosef
Thanks Mattias! Do you have an expected time-frame for that? Alternatively, do you have any quick tips on how I would go and implement this myself? I very briefly scanned the code in org.neo4j.graphalgo.impl.path.ShortestPath and I suspect I should test whether a node has already been visited (in