Hi Robert,
MEXEC-121: I agree about using the OS encoding by default. I updated the
patch and made this the default, with a new property
'executableOutputCharset' to override it. I also added an integration
test. Since this patch only has an effect when outputting to a console,
the test doesn'
Hi Trask,
regarding MEXEC-121: after having a second look I think this looks okay. I
only have some concerns for the WriterOutputStream. I think it should use
the OS encoding. Since this piece of code is used by every IT it should
already be covered. However, we could add a unittest to conf
Hi Robert,
Thanks for the response.
The patch for MEXEC-121 already checks whether System.console() exists and
falls back to System.out if it does not (i.e. on JDK5).
I looked at the test harness (invoker). I'm not sure I can use it to test
MEXEC-121, since the test harness captures the output,
Hi,
thanks for the patches.
A few remarks: Even though JDK6 has reached EOL, Mavens requirement is
still JDK5.
So for MEXEC-121 you need to check if java.io.Console is available, since
it was introduced with Java6
In both cases it would be nice to add an integration test, based on the
mav
