Re: Bugs in OrderView.groovy

2009-06-01 Thread Cimballi
provide the expected result. That's helpful and will tend to get a response fairly quickly as they may not require as much time to verify and fix. This post is very different and could be titled Potential bugs in OrderView.groovy. I don't think anybody involved in OFBiz can answer your post

Re: Bugs in OrderView.groovy

2009-06-01 Thread BJ Freeman
quickly as they may not require as much time to verify and fix. This post is very different and could be titled Potential bugs in OrderView.groovy. I don't think anybody involved in OFBiz can answer your post with out doing a full code review of the file. There are numerous possible reasons

Re: Bugs in OrderView.groovy

2009-06-01 Thread Scott Gray
is very different and could be titled Potential bugs in OrderView.groovy. I don't think anybody involved in OFBiz can answer your post with out doing a full code review of the file. There are numerous possible reasons for including the first check and not the second, it depends on lots

Re: Bugs in OrderView.groovy

2009-05-31 Thread Ray
not require as much time to verify and fix. This post is very different and could be titled Potential bugs in OrderView.groovy. I don't think anybody involved in OFBiz can answer your post with out doing a full code review of the file. There are numerous possible reasons for including

Re: Bugs in OrderView.groovy

2009-05-31 Thread Divesh Dutta
a response fairly quickly as they may not require as much time to verify and fix. This post is very different and could be titled Potential bugs in OrderView.groovy. I don't think anybody involved in OFBiz can answer your post with out doing a full code review of the file. There are numerous

Re: Bugs in OrderView.groovy

2009-05-31 Thread Cimballi
specific: do this, do that, it crashes/doesn't provide the expected result. That's helpful and will tend to get a response fairly quickly as they may not require as much time to verify and fix. This post is very different and could be titled Potential bugs in OrderView.groovy. I don't think anybody

Re: Bugs in OrderView.groovy

2009-05-31 Thread BJ Freeman
bugs in OrderView.groovy. I don't think anybody involved in OFBiz can answer your post with out doing a full code review of the file. There are numerous possible reasons for including the first check and not the second, it depends on lots of things and the file is split in to several

Re: Bugs in OrderView.groovy

2009-05-31 Thread Scott Gray
that, it crashes/ doesn't provide the expected result. That's helpful and will tend to get a response fairly quickly as they may not require as much time to verify and fix. This post is very different and could be titled Potential bugs in OrderView.groovy. I don't think anybody involved in OFBiz

Bugs in OrderView.groovy

2009-05-29 Thread Cimballi
Hi, There are several inconsistancies in the file applications/order/webapp/ordermgr/WEB-INF/actions/order/OrderView.groovy. I didn't note all of them, but here is an example : Line 260, productStore can be null : productStore = orderHeader.getRelatedOne(ProductStore); if (productStore)

Re: Bugs in OrderView.groovy

2009-05-29 Thread Adrian Crum
What is the bug? What was the expected behavior and what was the actual result? -Adrian --- On Fri, 5/29/09, Cimballi cimba...@cimballi.net wrote: From: Cimballi cimba...@cimballi.net Subject: Bugs in OrderView.groovy To: user user@ofbiz.apache.org Date: Friday, May 29, 2009, 3:39 PM Hi

Re: Bugs in OrderView.groovy

2009-05-29 Thread Scott Gray
Hi Cimballi Inconsistencies aren't necessarily bugs, but you are most welcome to create a patch and jira issue for the corrections you think should be made. Thanks Scott On 30/05/2009, at 10:39 AM, Cimballi wrote: Hi, There are several inconsistancies in the file

Re: Bugs in OrderView.groovy

2009-05-29 Thread Cimballi
Well, I don't know how to explain you, it seems evident to me... In the first case you check if productStore is null or not. In the second case, you don't check. So, what is the correct behaviour ? Should an order be linked to a productStore or not ? If yes, why the first test ? If no, there is

Re: Bugs in OrderView.groovy

2009-05-29 Thread BJ Freeman
I will give you a general answer to all you statements. this is a community effort. the people that answer on the mailing list do so as a volunteers, not as a paid support person. You may have a valid point. Don't expect a response if you don't want to follow the guidelines that have been setup.