Re: No container in actions after upgrading to 2.5.13

2017-09-19 Thread Yasser Zamani
On 9/19/2017 11:43 AM, LAW Andy wrote: > >> On 14 Sep 2017, at 16:03, Yasser Zamani wrote: >> >> Do last three exceptions occur in same time, in one action call (I think >> because of first word of their lines 73709, 73712 and 73716 and their >> same thread name

Re: No container in actions after upgrading to 2.5.13

2017-09-19 Thread LAW Andy
> On 14 Sep 2017, at 16:03, Yasser Zamani wrote: > > Do last three exceptions occur in same time, in one action call (I think > because of first word of their lines 73709, 73712 and 73716 and their > same thread name "http-nio-8082-exec-9") ? If so, it means you want

Re: No container in actions after upgrading to 2.5.13

2017-09-19 Thread Lukasz Lenart
2017-09-14 11:11 GMT+02:00 LAW Andy : >> On 14 Sep 2017, at 09:48, Lukasz Lenart wrote: >> >> You are not the first person who complains about missing container ... >> I wonder if we should add a fallback though. >> >>if (container ==

Re: No container in actions after upgrading to 2.5.13

2017-09-14 Thread Yasser Zamani
Do last three exceptions occur in same time, in one action call (I think because of first word of their lines 73709, 73712 and 73716 and their same thread name "http-nio-8082-exec-9") ? If so, it means you want to evaluate Using version 2.5.13 on Tomcat 8.0.21. > > I’ve attached it to this

Re: No container in actions after upgrading to 2.5.13

2017-09-14 Thread LAW Andy
> On 14 Sep 2017, at 09:48, Lukasz Lenart wrote: > > You are not the first person who complains about missing container ... > I wonder if we should add a fallback though. > >if (container == null) { >LOG.warn("Container is null, action was created

Re: No container in actions after upgrading to 2.5.13

2017-09-14 Thread Lukasz Lenart
You are not the first person who complains about missing container ... I wonder if we should add a fallback though. if (container == null) { LOG.warn("Container is null, action was created manually? Fallback to ActionContext"); container =

Re: No container in actions after upgrading to 2.5.13

2017-09-13 Thread LAW Andy
That looks more relevant. I’ll look into it some more tomorrow morning. Thanks for your help so far. > On 13 Sep 2017, at 17:04, Yasser Zamani wrote: > > Maybe you have a similar issue of [1]. > > Say you have X that extends ActionSupport. Please make sure if every X

Re: No container in actions after upgrading to 2.5.13

2017-09-13 Thread Yasser Zamani
Maybe you have a similar issue of [1]. Say you have X that extends ActionSupport. Please make sure if every X has been instantiated not manually (e.g. X = new X() inside your java files). They should be instantiated via Strut's object factory ( e.g.

Re: No container in actions after upgrading to 2.5.13

2017-09-13 Thread LAW Andy
> On 13 Sep 2017, at 14:17, Lukasz Lenart wrote: > > 2017-09-13 11:02 GMT+02:00 LAW Andy : >> Using version 2.5.13 on Tomcat 8.0.21. >> >> I’ve attached it to this message as a text file. > > How do you fetch action in >

Re: No container in actions after upgrading to 2.5.13

2017-09-13 Thread Lukasz Lenart
2017-09-13 11:02 GMT+02:00 LAW Andy : > Using version 2.5.13 on Tomcat 8.0.21. > > I’ve attached it to this message as a text file. How do you fetch action in "my.domain.controller.ActionOption.getAction(ActionOption.java:138)" ? Do you construct those actions manually?

Re: No container in actions after upgrading to 2.5.13

2017-09-13 Thread LAW Andy
Using version 2.5.13 on Tomcat 8.0.21. I’ve attached it to this message as a text file. Later, Andy > On 12 Sep 2017, at 15:56, Yasser Zamani wrote: > > Each one you're more comfortable or is more important for you. > > On 9/12/2017 7:08 PM, LAW Andy wrote: >> >>> On

Re: No container in actions after upgrading to 2.5.13

2017-09-12 Thread Yasser Zamani
Each one you're more comfortable or is more important for you. On 9/12/2017 7:08 PM, LAW Andy wrote: > >> On 12 Sep 2017, at 14:46, Yasser Zamani wrote: >> >> Great! they mean devMode works. >> >> Could you post your whole stacktrace of exception (including caused >>

Re: No container in actions after upgrading to 2.5.13

2017-09-12 Thread LAW Andy
> On 12 Sep 2017, at 14:46, Yasser Zamani wrote: > > Great! they mean devMode works. > > Could you post your whole stacktrace of exception (including caused > bys). If you should not send your internal app related info, delete such > lines from stacktrace. I need to

Re: No container in actions after upgrading to 2.5.13

2017-09-12 Thread Yasser Zamani
Great! they mean devMode works. Could you post your whole stacktrace of exception (including caused bys). If you should not send your internal app related info, delete such lines from stacktrace. I need to know the trace of the Struts itself only. If I know how and where Struts fails, then

Re: No container in actions after upgrading to 2.5.13

2017-09-12 Thread Lukasz Lenart
2017-09-12 11:42 GMT+02:00 LAW Andy : > >> On 12 Sep 2017, at 10:19, Lukasz Lenart wrote: >> >> You can ignore this, it only happens in devMode when Struts want to >> reload resources. Did you try with Struts 2.3.12? > > Also broken in 2.3.12 :(

Re: No container in actions after upgrading to 2.5.13

2017-09-12 Thread LAW Andy
Not sure where we’re going with this line of enquiry, but reducing log4j2 level to warn and hitting up the fake property via GET parameter as you suggested shows… 155201 [http-nio-8082-exec-9] WARN com.opensymphony.xwork2.util.AbstractLocalizedTextProvider [] - Missing key

Re: No container in actions after upgrading to 2.5.13

2017-09-12 Thread Yasser Zamani
No, "DEBUG" level is not interesting for me now. Also, as I saw, it seems this specific message is not dependent to devMode value [1]. Could you please reduce your log4j2 root level to only log "WARN" ? so it'll be less puffy and simpler to examine. Then please check if devMode works, open

Re: No container in actions after upgrading to 2.5.13

2017-09-12 Thread LAW Andy
> On 12 Sep 2017, at 10:19, Lukasz Lenart wrote: > > You can ignore this, it only happens in devMode when Struts want to > reload resources. Did you try with Struts 2.3.12? Also broken in 2.3.12 :( Later, Andy -- The University of Edinburgh is a charitable body,

Re: No container in actions after upgrading to 2.5.13

2017-09-12 Thread LAW Andy
> On 12 Sep 2017, at 10:19, Lukasz Lenart wrote: > > You can ignore this, it only happens in devMode when Struts want to > reload resources. Did you try with Struts 2.3.12? Next on the list (after I deal with a different crisis). Later, Andy -- The University of

Re: No container in actions after upgrading to 2.5.13

2017-09-12 Thread Lukasz Lenart
2017-09-12 10:47 GMT+02:00 LAW Andy : > 6727 [http-nio-8082-exec-5] DEBUG > com.opensymphony.xwork2.util.AbstractLocalizedTextProvider [] - Base class > org.apache.catalina.loader.WebappClassLoader doesn't contain > 'resourceEntries' field, trying with parent! >

Re: No container in actions after upgrading to 2.5.13

2017-09-12 Thread LAW Andy
> On 12 Sep 2017, at 09:47, LAW Andy wrote: > > >> On 11 Sep 2017, at 22:50, LAW Andy wrote: >> >> >>> >>> Did you try "devmode=true" and then examining output for any warning? >> >> >> I did. And there’s nothing obvious. >> > > Scrub

Re: No container in actions after upgrading to 2.5.13

2017-09-12 Thread LAW Andy
> On 11 Sep 2017, at 22:50, LAW Andy wrote: > > >> >> Did you try "devmode=true" and then examining output for any warning? > > > I did. And there’s nothing obvious. > Scrub that - there is something coming up (I think I must have been looking at the wrong debug

Re: No container in actions after upgrading to 2.5.13

2017-09-11 Thread LAW Andy
> On 11 Sep 2017, at 18:24, Yasser Zamani wrote: > > I sense you may think Struts uses Spring to inject Container. No, > "Internally, the framework uses its own dependency injection container > that is very similar to Google Guice" [1]. > > So do not worry about Spring

Re: No container in actions after upgrading to 2.5.13

2017-09-11 Thread Lukasz Lenart
2017-09-11 16:28 GMT+02:00 LAW Andy : > Not *quite* sure what you’re asking with regard to the request and JSPs bit, > but I’ll try to describe: Do you access /my-web-app/index.jsp or /my-web-app/index.action ? > applicationContext.xml configures (amongst other things)

Re: No container in actions after upgrading to 2.5.13

2017-09-11 Thread Yasser Zamani
I sense you may think Struts uses Spring to inject Container. No, "Internally, the framework uses its own dependency injection container that is very similar to Google Guice" [1]. So do not worry about Spring and it's auto-wiring. Did you try "devmode=true" and then examining output for any

Re: No container in actions after upgrading to 2.5.13

2017-09-11 Thread LAW Andy
Does anyone know if the default autowiring method changed in Struts between 2.5.10 and 2.5.13? > On 11 Sep 2017, at 15:28, LAW Andy wrote: > > >> On 11 Sep 2017, at 15:13, Lukasz Lenart wrote: >> >> 2017-09-11 16:09 GMT+02:00 LAW Andy

Re: No container in actions after upgrading to 2.5.13

2017-09-11 Thread LAW Andy
> On 11 Sep 2017, at 15:13, Lukasz Lenart wrote: > > 2017-09-11 16:09 GMT+02:00 LAW Andy : >> (Indirectly) from a JSP. This is “furniture” on the web page. >> >> Each action has an “ActionPropertyKey” annotated on it. Each Action inherits >>

Re: No container in actions after upgrading to 2.5.13

2017-09-11 Thread Lukasz Lenart
2017-09-11 16:09 GMT+02:00 LAW Andy : > (Indirectly) from a JSP. This is “furniture” on the web page. > > Each action has an “ActionPropertyKey” annotated on it. Each Action inherits > from a base class that has a getActionTitle() method on it. > > JSP furniture calls

Re: No container in actions after upgrading to 2.5.13

2017-09-11 Thread LAW Andy
> On 11 Sep 2017, at 15:03, Lukasz Lenart wrote: > > 2017-09-11 16:01 GMT+02:00 LAW Andy : >> I probably could, but I think this is less of an Action problem and more of >> a struts/spring dependency injection problem. I don’t think there’s

Re: No container in actions after upgrading to 2.5.13

2017-09-11 Thread Lukasz Lenart
2017-09-11 16:01 GMT+02:00 LAW Andy : > I probably could, but I think this is less of an Action problem and more of a > struts/spring dependency injection problem. I don’t think there’s anything > wrong with the Action class code itself, unless there’s an annotation

Re: No container in actions after upgrading to 2.5.13

2017-09-11 Thread LAW Andy
I probably could, but I think this is less of an Action problem and more of a struts/spring dependency injection problem. I don’t think there’s anything wrong with the Action class code itself, unless there’s an annotation that I need to add now that wasn’t necessary with 2.5.10.1 > On 11 Sep

Re: No container in actions after upgrading to 2.5.13

2017-09-11 Thread Yasser Zamani
I recently have resolved very similar issue at [1]. That was because of wrong PUBLIC ID in his validator xmls. But in general, please add to your struts.xml and configure log4j2 for your application [2] and then run your application and review it's output for any warnings. I guess you should

Re: No container in actions after upgrading to 2.5.13

2017-09-11 Thread Lukasz Lenart
2017-09-11 15:51 GMT+02:00 LAW Andy : > I recently upgraded the struts 2 library in an old web application from > 2.5.10.1 to 2.5.13. Simultaneously I upgraded Spring (which we use for > managing the database connections and some other bits and bobs) from 4.3.7 to >