Re: [uml-devel] [PATCH RESEND] um: vdso: remove unused vdso-syms.lds

2018-06-03 Thread Richard Weinberger
ada >> Acked-by: Ingo Molnar >> --- > > > Could you take a look at this patch, please? Acked-by: Richard Weinberger -- Thanks, //richard -- Check out the vibrant tech co

Re: [uml-devel] [UML] Question about arch/x86/um/vdso/vdso-syms.lds

2018-05-08 Thread Richard Weinberger
Masahiro, Am Mittwoch, 9. Mai 2018, 05:36:18 CEST schrieb Masahiro Yamada: > Hi Richard, > > > Please let me ask a question about vdso-syms.lds > under arch/x86/um/vdso/. > > This file exists since: > > commit f1c2bb8b9964ed31de988910f8b1cfb586d30091 > Auth

Re: [uml-devel] [REVIEW][PATCH 19/22] signal/um: Use force_sig_fault in relay_signal.

2018-04-24 Thread Richard Weinberger
On Fri, Apr 20, 2018 at 6:06 PM, Anton Ivanov wrote: > > On 04/20/18 15:38, Eric W. Biederman wrote: >> >> Today user mode linux only works on x86 and x86_64 and this allows >> simplifications of relay_signal. > > > I believe someone recently fixed the ARM port. I have not had the time to > try th

Re: [uml-devel] [PATCH] um: remove uml initcalls

2018-04-23 Thread Richard Weinberger
Alexander, Am Montag, 23. April 2018, 20:20:17 CEST schrieb Alexander Pateenok: > __uml_initcall() is not used and .uml.initcall.init section is empty: > > $ grep -r '__uml_initcall(' > arch/um/include/shared/init.h:#define __uml_initcall(fn) \ > $ readelf -s ../umobj/linux | grep __uml_init

[uml-devel] [ANNOUNCE] New User Mode Linux Mailing List

2018-04-18 Thread Richard Weinberger
Hi! The new mailing list address is: linux...@lists.infradead.org Please subscribe via web[0] or mail[1]. Thanks, //richard [0] http://lists.infradead.org/mailman/listinfo/linux-um [1] linux-um-j...@lists.infradead.org -- sigma star gmbh - Eduard-Bodem-Gasse 6 - 6020 Innsbruck - Austria ATU66

[uml-devel] [PATCH] um: Update mailing list address

2018-04-18 Thread Richard Weinberger
We have a new mailing list, so update the MAINTAINERS file. Signed-off-by: Richard Weinberger --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index b60179d948bb..4834d1551248 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14768,8

Re: [uml-devel] [PATCH] um: Fix return value of start_idle_thread

2018-04-11 Thread Richard Weinberger
Am Donnerstag, 29. März 2018, 22:45:59 CEST schrieb Richard Weinberger: > While the function will never returns, gcc will warns. > Add a return statement to make gcc happy. > Before f44f1e7da7c8 we never noticed because gcc knows that longjmp does > not return. > > arch/um/os-Li

Re: [uml-devel] [PATCH] um: Add HAVE_DEBUG_BUGVERBOSE.

2018-04-11 Thread Richard Weinberger
Am Donnerstag, 5. April 2018, 23:21:02 CEST schrieb Hernán Gonzalez: > This option restores the DEBUG_BUGVERBOSE functionality as it was > previous to commit 9a93848fe787 ("x86/debug: Implement __WARN() using > UD0"). > > Signed-off-by: Hernán Gonzalez Applied. Thanks, //richard --

[uml-devel] [GIT PULL] UML changes for 4.17-rc1

2018-04-10 Thread Richard Weinberger
Linus, The following changes since commit 91ab883eb21325ad80f3473633f794c78ac87f51: Linux 4.16-rc2 (2018-02-18 17:29:42 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git for you to fetch changes up to e40238dedb484c8a19f8257e4ef5d77d03

[uml-devel] [PATCH] um: Fix return value of start_idle_thread

2018-03-29 Thread Richard Weinberger
: control reaches end of non-void function [-Wreturn-type] Fixes: f44f1e7da7c8 ("um: Avoid longjmp/setjmp symbol clashes with libpthread.a") Signed-off-by: Richard Weinberger --- arch/um/os-Linux/skas/process.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/um/os-Linux/skas

Re: [uml-devel] UML hangs with hrtimer test module

2018-03-29 Thread Richard Weinberger
Am Donnerstag, 29. März 2018, 22:20:47 CEST schrieb Joel Fernandes: > Thanks a lot! I am wondering why the same compiler works when running > the test for a regular image. Maybe different compiler flags. Anyway > good to learn this. > > Also one more slightly OT question, why is UML only doing UP

Re: [uml-devel] [PATCH v2] Fix vector raw inintialization logic

2018-03-29 Thread Richard Weinberger
Am Montag, 5. März 2018, 14:29:05 CEST schrieb anton.iva...@cambridgegreys.com: > From: Anton Ivanov > > Vector RAW in UML needs to BPF filter its own MAC only > if QDISC_BYPASS has failed. If QDISC_BYPASS is successful, the > frames originated locally are not visible to readers on the > raw sock

Re: [uml-devel] [PATCH] Migrate vector timers to new timer API

2018-03-29 Thread Richard Weinberger
Am Montag, 5. März 2018, 11:41:42 CEST schrieb anton.iva...@cambridgegreys.com: > From: Anton Ivanov > > The patches for the UML vector drivers were in-flight when > the timer changes happened and were not covered by them. > > This change migrates vector_kern.c to use the new timer API. > > Sig

Re: [uml-devel] UML hangs with hrtimer test module

2018-03-28 Thread Richard Weinberger
Am Donnerstag, 29. März 2018, 00:19:39 CEST schrieb Joel Fernandes: > Thanks for the quick reply. > > On Wed, Mar 28, 2018 at 6:19 AM, Richard Weinberger wrote: > > Am Mittwoch, 28. März 2018, 15:11:29 CEST schrieb Geert Uytterhoeven: > >> On Wed, Mar 28, 2018 at

Re: [uml-devel] UML hangs with hrtimer test module

2018-03-28 Thread Richard Weinberger
Am Mittwoch, 28. März 2018, 15:11:29 CEST schrieb Geert Uytterhoeven: > On Wed, Mar 28, 2018 at 12:28 PM, Joel Fernandes wrote: > > while(release_now == 0); > > while (release_now == 0) > cpu_relax(); Not sure whether a cpu_relax() fixes the problem. I guess the root of the prob

Re: [uml-devel] UML hangs with hrtimer test module

2018-03-28 Thread Richard Weinberger
Am Mittwoch, 28. März 2018, 12:28:02 CEST schrieb Joel Fernandes: > Hi, > > I wrote a kernel module to play with hrtimer subsystem and it hangs > with UML, Any ideas on why it may be hanging? It doesn't hang on any > of my other machines. Hopefully I'm not doing something stupid, but I > don't thi

Re: [uml-devel] Is the list working correctly

2018-03-20 Thread Richard Weinberger
Am Dienstag, 20. März 2018, 03:45:11 CET schrieb Bernd Petrovitsch: > On Mon, 2018-03-19 at 15:24 +0100, Richard Weinberger wrote: > [...] > > > I checked, migrating is not an option. > > sourceforge has hacked mailman to hide member mail addresses: > > "As a

Re: [uml-devel] Is the list working correctly

2018-03-19 Thread Richard Weinberger
Am Dienstag, 13. März 2018, 14:59:41 CET schrieb Richard Weinberger: > Am Dienstag, 13. März 2018, 14:24:23 CET schrieb Geert Uytterhoeven: > > Hi Richard, > > > > On Mon, Mar 12, 2018 at 4:21 PM, Richard Weinberger wrote: > > > Am Montag, 12. März 2018, 16:10:45

Re: [uml-devel] Is the list working correctly

2018-03-13 Thread Richard Weinberger
Am Dienstag, 13. März 2018, 14:24:23 CET schrieb Geert Uytterhoeven: > Hi Richard, > > On Mon, Mar 12, 2018 at 4:21 PM, Richard Weinberger wrote: > > Am Montag, 12. März 2018, 16:10:45 CET schrieb Brandeburg, Jesse: > >> > Is the list working for everyone? > &g

Re: [uml-devel] Is the list working correctly

2018-03-12 Thread Richard Weinberger
Anton, Jesse, Am Montag, 12. März 2018, 16:10:45 CET schrieb Brandeburg, Jesse: > > Is the list working for everyone? > > I got this mail... BTW Sourceforge had a major datacenter issue over the > last few weeks, not sure if that broke something along the way. Hmm, I got this mail only because

Re: [uml-devel] [RFC PATCH 25/35] hostfs: rename do_rmdir() to hostfs_do_rmdir()

2018-03-11 Thread Richard Weinberger
Am Sonntag, 11. März 2018, 11:55:47 CET schrieb Dominik Brodowski: > do_rmdir() is used in the VFS layer at fs/namei.c, so use a different > name in hostfs. > > CC: Jeff Dike > CC: Richard Weinberger > CC: user-mode-linux-devel@lists.sourceforge.net > Signed-off-by: Dominik

Re: [uml-devel] [PATCH 2/2] um: vector: Fix an error handling path in 'vector_parse()'

2018-02-06 Thread Richard Weinberger
Anton, Am Samstag, 27. Januar 2018, 12:42:17 CET schrieb Anton Ivanov: > Thanks, looks correct, +1 > > Richard, can you add it to the next pull. > > Thanks in advance, Is that a Reviewed-by? :) (Same for the other patch) Thanks, //richard P.s: Something is odd with your mail setup, none of yo

Re: [uml-devel] [PATCH] arch/um: compile with modern headers

2017-12-13 Thread Richard Weinberger
Jason, Am Mittwoch, 13. Dezember 2017, 18:22:30 CET schrieb Jason A. Donenfeld: > Recent libcs have gotten a bit more strict, so we actually need to > include the right headers and use the right types. This enables UML to > compile again. > > Signed-off-by: Jason A. Donenfeld > Cc: sta...@vger.k

Re: [uml-devel] [PATCH 1/2] um: vector_kern: Unlock on error in vector_net_open()

2017-12-11 Thread Richard Weinberger
Anton, Am Samstag, 9. Dezember 2017, 18:09:17 CET schrieb Anton Ivanov: > Thanks, > > I guess I missed that one. > > A. > > On 09/12/17 11:49, Dan Carpenter wrote: > > We need to unlock and restore IRQs on this error path. > > > > Fixes: ad1f62ab2bd4 ("High Performance UML Vector Network Drive

Re: [uml-devel] [PATCH] [RFC] um: Convert ubd driver to blk-mq

2017-12-03 Thread Richard Weinberger
Christoph, Am Mittwoch, 29. November 2017, 22:46:51 CET schrieb Christoph Hellwig: > On Sun, Nov 26, 2017 at 02:10:53PM +0100, Richard Weinberger wrote: > > MAX_SG is 64, used for blk_queue_max_segments(). This comes from > > a0044bdf60c2 ("uml: batch I/O requests").

[uml-devel] [PATCH] um: Convert ubd driver to blk-mq

2017-12-03 Thread Richard Weinberger
Convert the driver to the modern blk-mq framework. As byproduct we get rid of our open coded restart logic and let blk-mq handle it. Signed-off-by: Richard Weinberger --- arch/um/drivers/ubd_kern.c | 178 +++-- 1 file changed, 93 insertions(+), 85

Re: [uml-devel] [PATCH] [RFC] um: Convert ubd driver to blk-mq

2017-11-26 Thread Richard Weinberger
re still > single-core in UML and AFAIK this is likely to stay that way, right? Well, someday blk-mq should completely replace the legacy block interface. Christoph asked me convert the UML driver. Also do find corner cases in blk-mq. > On 26/11/17 13:10, Richard Weinberger wrote: >

[uml-devel] [PATCH] [RFC] um: Convert ubd driver to blk-mq

2017-11-26 Thread Richard Weinberger
ith blk-mq, maybe there is a way in blk-mq to put back a (partial) request? Signed-off-by: Richard Weinberger --- arch/um/drivers/ubd_kern.c | 188 ++--- 1 file changed, 107 insertions(+), 81 deletions(-) diff --git a/arch/um/drivers/ubd_kern.c b/arch/

Re: [uml-devel] [GIT PULL] UBI/UBIFS updates for 4.15-rc1

2017-11-24 Thread Richard Weinberger
Linus, Am Freitag, 24. November 2017, 04:41:37 CET schrieb Linus Torvalds: > On Thu, Nov 23, 2017 at 4:37 AM, Richard Weinberger wrote: > > git://git.infradead.org/linux-ubifs.git tags/upstream-4.15-rc1 > > Similarly to the arch/um case, none of this seems to have been in >

[uml-devel] [GIT PULL] UML updates for 4.15-rc1

2017-11-23 Thread Richard Weinberger
Linus, The following changes since commit bebc6082da0a9f5d47a1ea2edc099bf671058bd4: Linux 4.14 (2017-11-12 10:46:13 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git for-linus-4.15-rc1 for you to fetch changes up to 02eb0b11eab56b47bcc

Re: [uml-devel] PATCH v11-2

2017-11-22 Thread Richard Weinberger
Am Mittwoch, 22. November 2017, 14:09:11 CET schrieb anton.ivanov@kot- begemot.co.uk: > Resending patchset v11 versus Linux Next 20171121 Erm, you sent me again full patches. *confused* Version 10 is in linux-next, now we have to deal with the fallout. Otherwise I have to revert. Thanks, //richa

Re: [uml-devel] PATCH v11

2017-11-22 Thread Richard Weinberger
Am Mittwoch, 22. November 2017, 12:57:21 CET schrieb anton.ivanov@kot- begemot.co.uk: > This revision adds EXPORT for deactivate_irq_by_fd as needed > by the random driver with some kernel configs Please patchs ontop of linux-next. Rebasing linux-next is not nice. Thanks, //richard -- sigma sta

Re: [uml-devel] [PATCH v9 2/2] High Performance UML Vector Network Driver

2017-11-20 Thread Richard Weinberger
Anton, Am Montag, 20. November 2017, 08:39:25 CET schrieb anton.ivanov@kot- begemot.co.uk: > +#define VECTOR_NUM_STATS ARRAY_SIZE(ethtool_stats_keys) > + > +/* Used in the 4.4 OpenWRT backport */ > + > +#if LINUX_VERSION_CODE <= KERNEL_VERSION(4, 7, 0) > +static inline void netif_trans_update(

Re: [uml-devel] [PATCH] um: use POSIX ucontext_t instead of struct ucontext

2017-11-15 Thread Richard Weinberger
Am Mittwoch, 15. November 2017, 12:04:16 CET schrieb Krzysztof Mazur: > On Wed, Nov 15, 2017 at 11:19:41AM +0100, Richard Weinberger wrote: > > Am Mittwoch, 15. November 2017, 11:12:39 CET schrieb Krzysztof Mazur: > > > glibc 2.26 removed the 'struct ucontext' t

Re: [uml-devel] [PATCH] um: use POSIX ucontext_t instead of struct ucontext

2017-11-15 Thread Richard Weinberger
Am Mittwoch, 15. November 2017, 11:12:39 CET schrieb Krzysztof Mazur: > glibc 2.26 removed the 'struct ucontext' to "improve" POSIX compliance > and break programs, including User Mode Linux. Fix User Mode Linux > by using POSIX ucontext_t. > > This fixes: > > arch/um/os-Linux/signal.c: In functi

Re: [uml-devel] [PATCH] um: Fix kcov crash before kernel is started.

2017-10-14 Thread Richard Weinberger
Am Samstag, 14. Oktober 2017, 00:00:25 CEST schrieb Thomas Meyer: > UMLs current_thread_info() unconditionally assumes that the top of the stack > contains the thread_info structure. > Prevent kcov from using invalid curent_thread_info() data by disable > instrumentation of early startup code. > >

Re: [uml-devel] [PATCH] um: Fix kcov crash before kernel is started.

2017-10-08 Thread Richard Weinberger
Am Sonntag, 8. Oktober 2017, 12:31:58 CEST schrieb Thomas Meyer: > UMLs current_thread_info() unconditionally assumes that the top of the stack > contains the thread_info structure. But on UML the __sanitizer_cov_trace_pc > function is called for *all* functions! This results in an early crash: >

Re: [uml-devel] [PATCH 02/14] um: Use %pS printk format for symbols from direct addresses

2017-09-21 Thread Richard Weinberger
tency throughout the kernel fix the wrong usage here too. >> >> Signed-off-by: Helge Deller >> Cc: Jeff Dike >> Cc: Richard Weinberger >> Cc: user-mode-linux-devel@lists.sourceforge.net >> --- >> arch/um/kernel/sysrq.c | 2 +- >> 1 file changed

[uml-devel] [GIT PULL] UML updates for 4.14-rc1

2017-09-16 Thread Richard Weinberger
Linus, The following changes since commit 569dbb88e80deb68974ef6fdd6a13edb9d686261: Linux 4.13 (2017-09-03 13:56:17 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git for-linus-4.14-rc1 for you to fetch changes up to 6d20e6b235aad0be463b

[uml-devel] [GIT PULL] UML fixes for 4.13-rc7

2017-08-29 Thread Richard Weinberger
Linus, The following changes since commit 14ccee78fc82f5512908f4424f541549a5705b89: Linux 4.13-rc6 (2017-08-20 14:13:52 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git for-linus-4.13-rc7 for you to fetch changes up to 2fb44600fe784449

[uml-devel] [GIT PULL] UML updates for 4.13-rc1

2017-07-15 Thread Richard Weinberger
warning/error messages um: console: Ignore console= option Richard Weinberger (1): um: Correctly check for PTRACE_GETRESET/SETREGSET Thomas Meyer (5): um: userspace - be more verbose in ptrace set regs error um: stub-data.h: remove superfluous include um: Add kerneldoc

[uml-devel] [PATCH] um: Re-enable verbose panic()

2017-07-12 Thread Richard Weinberger
UG_BUGVERBOSE manually to have a verbose panic() again. Cc: Peter Zijlstra (Intel) Cc: Josh Poimboeuf Signed-off-by: Richard Weinberger --- arch/um/Kconfig.common | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/um/Kconfig.common b/arch/um/Kconfig.common index 85f6dd204ab6..3cb6cd80

Re: [uml-devel] [PATCH] um: v3: Fix FP register size for XSTATE/XSAVE

2017-07-12 Thread Richard Weinberger
Thomas, what about something like that? (untested) Still not very pretty but IMHO better. diff --git a/arch/um/include/asm/thread_info.h b/arch/um/include/asm/thread_info.h index 053baff03674..9300f7630d2a 100644 --- a/arch/um/include/asm/thread_info.h +++ b/arch/um/include/asm/thread_info.h @@

Re: [uml-devel] [PATCH] um: v3: Fix FP register size for XSTATE/XSAVE

2017-07-12 Thread Richard Weinberger
Thomas, Am 12.07.2017 um 17:11 schrieb Thomas Meyer: > Am 10.07.2017 9:06 nachm. schrieb Richard Weinberger : > > Thomas, > > Am 10.07.2017 um 00:33 schrieb Thomas Meyer: > > Hard code max size. Taken from > > > https://sourceware.org/git/?p=binuti

Re: [uml-devel] [PATCH] um: v3: Fix FP register size for XSTATE/XSAVE

2017-07-10 Thread Richard Weinberger
Thomas, Am 10.07.2017 um 00:33 schrieb Thomas Meyer: > Hard code max size. Taken from > https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=gdb/common/x86-xstate.h > > v3: use static fp_regs for get_skas_faultinfo > > Signed-off-by: Thomas Meyer > --- > arch/um/os-Linux/skas/process.c |

Re: [uml-devel] [PATCH] um: v2: Fix FP register size for XSTATE/XSAVE

2017-07-07 Thread Richard Weinberger
Thomas, On Fri, Jul 7, 2017 at 11:01 PM, Thomas Meyer wrote: > Hard code max size. Taken from > https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=gdb/common/x86-xstate.h > > Signed-off-by: Thomas Meyer > --- > arch/um/os-Linux/skas/process.c | 22 ++ > arch/x86/um/os-

Re: [uml-devel] [PATCH] um: Fix gcc-plugins dependency

2017-07-07 Thread Richard Weinberger
Thomas, Am 07.07.2017 um 23:10 schrieb Thomas Meyer: > Ensure to build the gcc-plugins for user-offsets.s > > Signed-off-by: Thomas Meyer Please describe the problem what this commit solves. IOW the compiler error. Thanks, //richard

Re: [uml-devel] [PATCH] um: Fix gcc 7 sys/sysmacros.h warning

2017-07-07 Thread Richard Weinberger
Am 07.07.2017 um 12:01 schrieb Thomas Meyer: > Should I resend with warning as v2? Yes, please. Thanks, //richard -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http

Re: [uml-devel] [PATCH] um: Fix FP register size for XSTATE/XSAVE

2017-07-07 Thread Richard Weinberger
On Fri, Jul 7, 2017 at 11:26 AM, Richard Weinberger wrote: > On Thu, Jul 6, 2017 at 11:04 PM, Thomas Meyer wrote: >> Hard code max size. Taken from >> https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=gdb/common/x86-xstate.h >> >> Signed-off-by: Thomas Meyer

Re: [uml-devel] [PATCH] um: v2: Use generic NOTES macro

2017-07-07 Thread Richard Weinberger
On Fri, Jul 7, 2017 at 11:17 AM, Thomas Meyer wrote: > Signed-off-by: Thomas Meyer > --- > arch/um/include/asm/common.lds.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied. -- Thanks, //richard -- Che

Re: [uml-devel] [PATCH] um: Fix FP register size for XSTATE/XSAVE

2017-07-07 Thread Richard Weinberger
On Thu, Jul 6, 2017 at 11:04 PM, Thomas Meyer wrote: > Hard code max size. Taken from > https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=gdb/common/x86-xstate.h > > Signed-off-by: Thomas Meyer > --- > arch/x86/um/os-Linux/registers.c | 9 - > arch/x86/um/user-offsets.c | 2 +

Re: [uml-devel] [PATCH] um: Fix gcc 7 sys/sysmacros.h warning

2017-07-07 Thread Richard Weinberger
On Thu, Jul 6, 2017 at 10:47 PM, Thomas Meyer wrote: > Signed-off-by: Thomas Meyer When fixing such a problem, always include die compiler warning. This has to wait for -rc2. -- Thanks, //richard -- Check out the vibr

Re: [uml-devel] [PATCH 3/3] um: Add kerneldoc for userspace_tramp() and start_userspace()

2017-07-07 Thread Richard Weinberger
On Thu, Jul 6, 2017 at 12:34 AM, Thomas Meyer wrote: > Also use correct function name spelling (stub_segv_handler) for better > grepping > > Signed-off-by: Thomas Meyer > --- > arch/um/os-Linux/skas/process.c | 31 ++- > 1 file changed, 30 insertions(+), 1 deletion(-

Re: [uml-devel] [PATCH] um: userspace - be more verbose in ptrace set regs error

2017-07-07 Thread Richard Weinberger
On Thu, Jul 6, 2017 at 12:31 AM, Thomas Meyer wrote: > When ptrace fails to set GP/FP regs for the target process, > log the error before crashing the UML kernel. > > Signed-off-by: Thomas Meyer > --- > arch/um/os-Linux/skas/process.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletio

Re: [uml-devel] [uml:linux-next 7/9] arch/um/os-Linux/skas/process.c:579:1: warning: control reaches end of non-void function

2017-07-06 Thread Richard Weinberger
Am 06.07.2017 um 07:48 schrieb kbuild test robot: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git linux-next > head: 1bcbfbfdeb0091036db7a32e1cd31b49cce5983a > commit: f44f1e7da7c8e3f4575d5d61c4df978496903fcc [7/9] um: Avoid > longjmp/setjmp symbol clashes with libpthread.a

Re: [uml-devel] [PATCH] um: userspace - be more verbose in ptrace set regs error

2017-07-05 Thread Richard Weinberger
Thomas, Am 06.07.2017 um 00:06 schrieb Thomas Meyer: >> This patch is also malformed. :-( > > I wonder why evolution is messing up my emails... > > will check and resend... Just use git send-email :) Thanks, //richard ---

Re: [uml-devel] [PATCH] um: userspace - be more verbose in ptrace set regs error

2017-07-05 Thread Richard Weinberger
Thomas, On Wed, May 24, 2017 at 12:45 AM, Thomas Meyer wrote: > When ptrace fails to set GP/FP regs for the target process, > log the error before crashing the UML kernel. > > Signed-off-by: Thomas Meyer > --- > arch/um/os-Linux/skas/process.c | 10 -- > 1 file changed, 8 insertions(+),

Re: [uml-devel] [PATCH 1/3] um: stub-data.h: remove superfluous include

2017-07-05 Thread Richard Weinberger
Thomas, On Sun, May 14, 2017 at 5:03 PM, Thomas Meyer wrote: > Signed-off-by: Thomas Meyer > --- > arch/um/include/shared/skas/stub-data.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/um/include/shared/skas/stub-data.h > b/arch/um/include/shared/skas/stub-data.h > index a9deec

Re: [uml-devel] [PATCH v3 0/6] um: Output messages to stderr and support quiet option

2017-07-05 Thread Richard Weinberger
Masami, On Wed, May 17, 2017 at 7:13 PM, Masami Hiramatsu wrote: > Hello, > > Here is version 3 of um-quiet series. In this version > I just fixed some printf format issues. > > V2 is here. > > https://lkml.org/lkml/2017/5/8/35 > > This series fixes some boot time printf output to stderr > by ad

Re: [uml-devel] [PATCH v2] um: Avoid longjmp/setjmp symbol clashes with libpthread.a

2017-06-29 Thread Richard Weinberger
Florian, Am 29.06.2017 um 00:40 schrieb Florian Fainelli: >> Hehe, yes. >> This patch is good, I like it. :) >> It will part of the next pull request. > > Humm okay, did you apply the patch in one of your kernel trees on > git.kernel.org or somewhere else? Will happen soon since the merge window

Re: [uml-devel] [PATCH v2] um: add dummy ioremap and iounmap functions

2017-06-21 Thread Richard Weinberger
Logan, Am 21.06.2017 um 23:25 schrieb Logan Gunthorpe: > Poke. > > On 08/06/17 01:17 PM, Richard Weinberger wrote: >> Am 08.06.2017 um 20:53 schrieb Logan Gunthorpe: >> IMHO an ifdef in scatterlist code does not hurt. >> It is equally ugly than mocking ioremap for U

Re: [uml-devel] um: PTRACE_SETREGSET failure with XSTATE on Kabylake CPU

2017-06-21 Thread Richard Weinberger
Thomas, Natale, Am 21.06.2017 um 11:44 schrieb Thomas Meyer: >> It is funny to see that this problem was firstly reported here [1] in >> February 2017 without being considered until someone else bought a >> new >> laptop :) sometimes mails/issues get lost... > Yes, I like my new laptop :-) > >>

Re: [uml-devel] um: PTRACE_SETREGSET failure with XSTATE on Kabylake CPU

2017-06-20 Thread Richard Weinberger
Yu-cheng, Am 20.06.2017 um 20:17 schrieb Richard Weinberger: > Yu-cheng, > > Am 20.06.2017 um 20:04 schrieb Yu-cheng Yu: >>>> So to summarize: >>>> >>>> - PTRACE_GETREGSET with NT_X86_XSTATE gets 832 and return 832, with no >>>> error. &g

Re: [uml-devel] um: PTRACE_SETREGSET failure with XSTATE on Kabylake CPU

2017-06-20 Thread Richard Weinberger
Yu-cheng, Am 20.06.2017 um 20:04 schrieb Yu-cheng Yu: >>> So to summarize: >>> >>> - PTRACE_GETREGSET with NT_X86_XSTATE gets 832 and return 832, with no >>> error. >>> >>> - PTRACE_SETREGSET get 832 (sizeof struct _xstate) but wants at least >>> 1088, otherwise it will fail with -EFAULT (why not

Re: [uml-devel] um: PTRACE_SETREGSET failure with XSTATE on Kabylake CPU

2017-06-20 Thread Richard Weinberger
[adding x86 folks] Am 20.06.2017 um 10:49 schrieb Thomas Meyer: > Am Dienstag, den 20.06.2017, 08:58 +0200 schrieb Richard Weinberger: >> Thomas, >> >> Am 20.06.2017 um 03:56 schrieb Thomas Meyer: >>> Hi, >>> >>> I finally did figure out where in

Re: [uml-devel] um: PTRACE_SETREGSET failure with XSTATE on Kabylake CPU

2017-06-19 Thread Richard Weinberger
Thomas, Am 20.06.2017 um 03:56 schrieb Thomas Meyer: > Hi, > > I finally did figure out where in the host kernel the ptrace syscall > fails with -EFAULT. Nice! Thanks a lot for digging into this. I still had no chance to setup Ipv6 to connect to your host and figure myself. ;-\ > In arch/x86/ke

Re: [uml-devel] [PATCH v2] um: add dummy ioremap and iounmap functions

2017-06-08 Thread Richard Weinberger
Am 08.06.2017 um 20:53 schrieb Logan Gunthorpe: > Any thoughts on this? My patches for the other architectures are already > in linux-next. um is the only one that remains. IMHO an ifdef in scatterlist code does not hurt. It is equally ugly than mocking ioremap for UML. So, I'm puzzled. Arnd, wha

Re: [uml-devel] [PATCH 22/35] um: defconfig: Cleanup from old Kconfig options

2017-06-08 Thread Richard Weinberger
Am 08.06.2017 um 18:10 schrieb Krzysztof Kozlowski: > Remove old, dead Kconfig option INET_LRO. It is gone since > commit 7bbf3cae65b6 ("ipv4: Remove inet_lro library"). > > Signed-off-by: Krzysztof Kozlowski Acked-by: Richard Weinberg

Re: [uml-devel] [PATCH v2] um: Avoid longjmp/setjmp symbol clashes with libpthread.a

2017-06-05 Thread Richard Weinberger
Florian, Am 05.06.2017 um 21:32 schrieb Florian Fainelli: > On 05/23/2017 05:32 PM, Florian Fainelli wrote: >> Building a statically linked UML kernel on a Centos 6.9 host resulted in >> the following linking failure (GCC 4.4, glibc-2.12): >> >> /usr/lib/gcc/x86_64-redhat-linux/4.4.7/../../../../l

Re: [uml-devel] [PATCH v2] um: Avoid longjmp/setjmp symbol clashes with libpthread.a

2017-06-01 Thread Richard Weinberger
Am 01.06.2017 um 22:15 schrieb Florian Fainelli: > On 06/01/2017 01:11 PM, Richard Weinberger wrote: >> Florian, >> >> Am 01.06.2017 um 21:38 schrieb Florian Fainelli: >>>> Presumably because we are not using the same glibc version? The one I >>>> hav

Re: [uml-devel] [PATCH v2] um: Avoid longjmp/setjmp symbol clashes with libpthread.a

2017-06-01 Thread Richard Weinberger
Florian, Am 01.06.2017 um 21:38 schrieb Florian Fainelli: >> Presumably because we are not using the same glibc version? The one I >> have installed on this machine is glibc-2.12, do you want me to attach a >> copy of it? > > Richard, what do we do with this? I'd like to see the issues that Thom

Re: [uml-devel] [PATCH v2] um: add dummy ioremap and iounmap functions

2017-05-25 Thread Richard Weinberger
Logan, Am 25.05.2017 um 17:42 schrieb Logan Gunthorpe: > The user mode architecture does not provide ioremap or iounmap, and > because of this, the arch won't build when the functions are used in some > core libraries. Which ones are failing? I thought we killed the problem by making CONFIG_COMPI

Re: [uml-devel] [PATCH v2] um: Avoid longjmp/setjmp symbol clashes with libpthread.a

2017-05-24 Thread Richard Weinberger
Florian, Am 24.05.2017 um 02:32 schrieb Florian Fainelli: > Building a statically linked UML kernel on a Centos 6.9 host resulted in > the following linking failure (GCC 4.4, glibc-2.12): > > /usr/lib/gcc/x86_64-redhat-linux/4.4.7/../../../../lib64/libpthread.a(libpthread.o): > In function `siglo

Re: [uml-devel] um: prinft patches from Masami Hiramatsu

2017-05-23 Thread Richard Weinberger
On Tue, May 23, 2017 at 7:56 PM, Thomas Meyer wrote: > Hi, > > > > did you see those patches? > > > > https://marc.info/?l=linux-kernel&m=149337486632399&w=2 Yes, they are on my TODO. -- Thanks, //richard -- Check out

Re: [uml-devel] um: xstate changes breaks my UML setup

2017-05-23 Thread Richard Weinberger
Thomas, On Tue, May 23, 2017 at 7:56 PM, Thomas Meyer wrote: > Hi, > > > > to make UML work again with the latest Fedora Installation I Need to revert > those commits: > > b6024b21fec8367ef961a771cc9dde31f1831965 > > a78ff1112263fdd871d3506dbcff44f6f12e8423 > > > > A reproducer script/config is a

Re: [uml-devel] Multiple longjmp definitions with STATIC_LINKING=y

2017-05-23 Thread Richard Weinberger
Florian, Am 23.05.2017 um 05:28 schrieb Florian Fainelli: > Hi Richard, > > I have been playing with UML again and trying to get it to statically > link on a CentOS 6.9 host that has: > > glibc-2.12-static > gcc-4.4 > > installed results in the following: > > /usr/lib/gcc/x86_64-redhat-linux/4

Re: [uml-devel] [PATCH] um: Add mark_rodata_ro support.

2017-05-22 Thread Richard Weinberger
Thomas, Am 22.05.2017 um 21:18 schrieb Thomas Meyer: > >> Am 22.05.2017 um 20:34 schrieb Richard Weinberger : >> >> Thomas, >> >>> Am 22.05.2017 um 20:14 schrieb Thomas Meyer: >>> It's purely cosmetic; to get rid of the boot message: "This a

Re: [uml-devel] [PATCH] um: Add mark_rodata_ro support.

2017-05-22 Thread Richard Weinberger
Thomas, Am 22.05.2017 um 20:14 schrieb Thomas Meyer: > It's purely cosmetic; to get rid of the boot message: "This architecture does > not have kernel memory protection." in init/main.c > > Which isn't true for UML as all read only stuff should end up in a read only > ELF section. Shouldn't it?

Re: [uml-devel] [RFC PATCH 1/7] um: Use printk instead of printf in make_uml_dir

2017-05-21 Thread Richard Weinberger
On Wed, May 17, 2017 at 10:35 AM, Thomas Meyer wrote: >> On Tue, 16 May 2017 17:46:47 +0200 >> Thomas Meyer wrote: >> >>> Hi, >>> >>> as far as I understand everything under os-Linux should be OS specific >>> and shouldn't rely on kernel functions. >> >> I see, but umid.c already uses many printk

Re: [uml-devel] [PATCH] um: Don't build arch/x86/um/user-offsets.s with gcc plugins

2017-05-21 Thread Richard Weinberger
Thomas, On Wed, May 17, 2017 at 10:41 PM, Thomas Meyer wrote: > For some reasons I don't know users-offsets.s get's build before the > gcc-plugins itself. Can you please figure? I want to make sure that we really fix the root cause and not just papering over a symptom. -- Thanks, //richard --

Re: [uml-devel] [PATCH] um: Add mark_rodata_ro support.

2017-05-21 Thread Richard Weinberger
Thomas, On Thu, May 18, 2017 at 12:11 AM, Thomas Meyer wrote: > This is actually a no-op as all read-only should be read-only in the ELF. What problem does this patch fix? Or what is the purpose? -- Thanks, //richard

[uml-devel] [RFC][PATCH] um: Remove proc command from mconsole

2017-05-21 Thread Richard Weinberger
This feature is another abuser of set_fs(). Reading proc files from the host side is a debugging feature with no security checks at all. The path is not sanitized, therefore any file could be read. Let's get rid of it. Signed-off-by: Richard Weinberger --- Hi! Unless I miss something is fe

[uml-devel] [GIT PULL] UML changes for v4.12-rc1

2017-05-13 Thread Richard Weinberger
Hiramatsu (1): um: Fix to call read_initrd after init_bootmem Matthias Kaehlcke (1): um: Include kbuild.h instead of duplicating its macros Nikola Kotur (1): um: Set number of CPUs Richard Weinberger (3): um: Fix _print_addr() um: Fix PTRACE_POKEUSER on x86_64 um

Re: [uml-devel] userfaultfd for UML userspace processes

2017-05-13 Thread Richard Weinberger
Thomas, On Sat, May 13, 2017 at 10:10 AM, Thomas Meyer wrote: > > Hi, > > after looking into using userfaultfd for the userspace UML process > page fault handling, I come to the conclusion that userfaultfd > *cannot* be used for above goal as it only operates on mmaped memory > areas. > Am I miss

Re: [uml-devel] [uml-user] UML on WSL

2017-05-09 Thread Richard Weinberger
Thomas, Am 09.05.2017 um 19:25 schrieb Thomas Meyer: >> IOW we write to 0xdeadbeef, catch the fault and fix it. > > I get this: > thomas@DESKTOP-DQBDJ0U:/mnt/c/Users/thomas/VmShare$ ./segtest > SIGSEGV at 0x0, fixing up > SIGSEGV at 0x0, fixing up > SIGSEGV at 0x0, fixing up > SIGSEGV at 0x0, fix

Re: [uml-devel] [uml-user] UML on WSL

2017-05-09 Thread Richard Weinberger
Thomas, Am 09.05.2017 um 10:15 schrieb Thomas Meyer: > attached patch work correctly under Linux. But no change under WSL. As stated > in the relevant GH issue, there seems to be far more road blockers to make > UML work under WSL. > > With you patch I get under WSL: > > thomas@DESKTOP-DQBDJ0U

Re: [uml-devel] [uml-user] UML on WSL

2017-05-08 Thread Richard Weinberger
Thomas, Can you please give the attached patch a try? Thanks, //richard >From b64c967e3960eff33e96f7dcff261635fffeb504 Mon Sep 17 00:00:00 2001 From: Richard Weinberger Date: Mon, 8 May 2017 21:43:27 +0200 Subject: [PATCH] um: Drop PTRACE_OLDSETOPTIONS usage IMHO in 2017 can assume that nob

Re: [uml-devel] warning at vma_merge

2017-05-08 Thread Richard Weinberger
Anton, Thomas, On Sun, May 7, 2017 at 10:27 PM, Anton Ivanov wrote: > Have a look at the list archive, this was covered a couple of weeks ago. > > I believe Richard is working on a fix. Yep, this reminds me that I have to ping mm folks about this. Please see: http://lkml.iu.edu/hypermail/linux/k

Re: [uml-devel] [uml-user] UML on WSL

2017-05-08 Thread Richard Weinberger
Thomas, Am 08.05.2017 um 18:09 schrieb Thomas Meyer: > Or asked he other way around: > > Is somewhere documented what's the minimum host kernel version that a UML > kernel will run on? > > E.g.: > building a UML kernel from 4.11 will need a host kernel version 2.6.18 with > features x, y and z

Re: [uml-devel] [uml-user] UML on WSL

2017-05-08 Thread Richard Weinberger
Thomas, Am 08.05.2017 um 17:40 schrieb Thomas Meyer: > " > Also, for a little context, the /only/software I can find /on the planet/ > that cares is User Mode Linux. Unless someone tries to run some statically > linked |strace| or > maybe |gdb| binary from the 2.4 era, this will simply never be

Re: [uml-devel] [uml-user] UML on WSL

2017-05-08 Thread Richard Weinberger
Thomas, Am 08.05.2017 um 17:32 schrieb Thomas Meyer: >> We could figure how to report issues to WSL, create self-hosting unit tests >> and ask them to add/fix >> these features. > > Turns out there was already a bug report by somebody about missing UML > support in WSL: > > https://github.com/

Re: [uml-devel] [uml-user] UML on WSL

2017-05-08 Thread Richard Weinberger
Thomas, Am 08.05.2017 um 17:02 schrieb Thomas Meyer: > Sadly, UML executable bails out very early. it Looks like WSL is missing some > PTRACE stuff: > > thomas@DESKTOP-DQBDJ0U:/mnt/c/Users/thomas/Downloads$ ./linux > Core dump limits : > soft - NONE > hard - NONE > Checking that

Re: [uml-devel] [uml-user] UML on WSL

2017-05-07 Thread Richard Weinberger
Thomas, On Sun, May 7, 2017 at 1:44 PM, Thomas Meyer wrote: > Hi, > > Did anybody try to run UML on the new Windows 10 subsystem for Linux? I > wonder what missing functions may hinder to run UML on WSL? No idea. Can you try? I don't have access to a Windows 10 system right now where I could tes

Re: [uml-devel] [uml:linux-next 2/5] arch/um/os-Linux/skas/process.c:236:19: error: 'NR_CPUS' undeclared here (not in a function)

2017-05-03 Thread Richard Weinberger
Am 04.05.2017 um 03:19 schrieb kbuild test robot: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git linux-next > head: 5b4236e17cc1bd9fa14b2b0c7a4ae632d41f2e20 > commit: 8bba077066d6d0a135b7be1970691522075bf905 [2/5] um: Set number of CPUs > config: um-x86_64_defconfig (attache

Re: [uml-devel] [uml-user] [PATCH] um: Fix _print_addr()

2017-05-03 Thread Richard Weinberger
On Sun, Dec 25, 2016 at 11:11 PM, Richard Weinberger wrote: > Recent changes to printk() broke UML's stack trace > output. Kill the root of the problem by using a single > printk() statement. > > Signed-off-by: Richard Weinberger > --- > arch/um/kernel/sysrq.c | 6 +

Re: [uml-devel] [PATCH v2] um: Set number of CPUs

2017-05-03 Thread Richard Weinberger
On Fri, Mar 3, 2017 at 9:11 AM, Richard Weinberger wrote: > Nikola, > > Am 02.03.2017 um 14:16 schrieb Nikola Kotur: >> Define NR_CPUS required by the timer subsystem. >> >> Fixes this make warning: >> >> scripts/kconfig/conf --oldconfig arch/x86/um

Re: [uml-devel] [PATCH] um: Fix PTRACE_POKEUSER on x86_64

2017-05-03 Thread Richard Weinberger
On Sat, Apr 1, 2017 at 12:41 AM, Richard Weinberger wrote: > This is broken since ever but sadly nobody noticed. > Recent versions of GDB set DR_CONTROL unconditionally and > UML dies due to a heap corruption. It turns out that > the PTRACE_POKEUSER was copy&pasted from i386 an

Re: [uml-devel] [PATCH] um: Include kbuild.h instead of duplicating its macros

2017-05-03 Thread Richard Weinberger
On Mon, Apr 3, 2017 at 9:54 PM, Matthias Kaehlcke wrote: > Signed-off-by: Matthias Kaehlcke > --- > arch/x86/um/shared/sysdep/kernel-offsets.h | 9 + > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/arch/x86/um/shared/sysdep/kernel-offsets.h > b/arch/x86/um/shared/sysde

Re: [uml-devel] [PATCH] um: Fix to call read_initrd after init_bootmem

2017-05-03 Thread Richard Weinberger
On Thu, Apr 27, 2017 at 5:15 AM, Masami Hiramatsu wrote: > Since read_initrd() invokes alloc_bootmem() for allocating > memory to load initrd image, it must be called after init_bootmem. > > This makes read_initrd() called directly from setup_arch() > after init_bootmem() and mem_total_pages(). >

Re: [uml-devel] [PATCH] um: Fix to call read_initrd after init_bootmem

2017-04-27 Thread Richard Weinberger
Masami, Am 28.04.2017 um 00:40 schrieb Masami Hiramatsu: > Finally, git bisect shows that below commit caused this issue. > > b63236972e1344b247750451e2be0a06cd125f21 is the first bad commit > commit b63236972e1344b247750451e2be0a06cd125f21 > Author: Richard Weinberger Meh,

  1   2   3   4   5   6   7   8   9   >