Re: [uml-devel] [PATCH] arch: configuration, deleting 'CONFIG_BUG' since always need it.

2013-05-23 Thread Russell King - ARM Linux
On Thu, May 23, 2013 at 02:09:02PM +0200, Arnd Bergmann wrote: > On Thursday 23 May 2013, Russell King - ARM Linux wrote: > > This is the problem you guys are missing - unreachable() means "we lose > > control of the CPU at this point". > > I'm absolute

Re: [uml-devel] [PATCH] arch: configuration, deleting 'CONFIG_BUG' since always need it.

2013-05-23 Thread Russell King - ARM Linux
On Thu, May 23, 2013 at 12:59:43PM +0200, Arnd Bergmann wrote: > On Thursday 23 May 2013, Russell King - ARM Linux wrote: > > So, if you want to use this, then you should update the CONFIG_BUG text > > to include a warning to this effect: > > > > Warning: if CO

Re: [uml-devel] [PATCH] arch: configuration, deleting 'CONFIG_BUG' since always need it.

2013-05-23 Thread Russell King - ARM Linux
On Thu, May 23, 2013 at 03:09:50AM -0700, Eric W. Biederman wrote: > Arnd Bergmann writes: > > > On Thursday 23 May 2013, Geert Uytterhoeven wrote: > >> > The problem is: trying to fix that will mean the result is a larger > >> > kernel than if you just do the usual arch-implemented thing of plac

Re: [uml-devel] [PATCH] arch: configuration, deleting 'CONFIG_BUG' since always need it.

2013-05-23 Thread Russell King - ARM Linux
On Thu, May 23, 2013 at 11:39:37AM +0200, Arnd Bergmann wrote: > On Thursday 23 May 2013, Geert Uytterhoeven wrote: > > > The problem is: trying to fix that will mean the result is a larger > > > kernel than if you just do the usual arch-implemented thing of placing > > > an defined faulting instru

Re: [uml-devel] [PATCH] arch: configuration, deleting 'CONFIG_BUG' since always need it.

2013-05-23 Thread Russell King - ARM Linux
On Thu, May 23, 2013 at 10:40:29AM +0200, Geert Uytterhoeven wrote: > On Thu, May 23, 2013 at 9:57 AM, Chen Gang wrote: > > -config BUG > > - bool "BUG() support" if EXPERT > > - default y > > - help > > - Disabling this option eliminates support for BUG and WARN, > > r

Re: [uml-devel] [PATCHv5] atomic: add *_dec_not_zero

2011-12-04 Thread Russell King - ARM Linux
On Sun, Dec 04, 2011 at 04:42:49PM +0100, Sven Eckelmann wrote: > diff --git a/arch/alpha/include/asm/atomic.h b/arch/alpha/include/asm/atomic.h > +#define atomic64_dec_not_zero(v) atomic64_add_unless((v), -1, 0) > diff --git a/arch/arm/include/asm/atomic.h b/arch/arm/include/asm/atomic.h > +#defin

Re: [uml-devel] [PATCHv5] atomic: add *_dec_not_zero

2011-12-04 Thread Russell King - ARM Linux
On Sun, Dec 04, 2011 at 10:49:10PM +0100, Sven Eckelmann wrote: > On Sunday 04 December 2011 21:33:16 Russell King - ARM Linux wrote: > [...] > > > +#define atomic64_dec_not_zero(v) atomic64_add_unless((v), -1LL, 0LL) > > > > I think this is rather silly - all these d

Re: [uml-devel] [PATCH] Remove remaining references of CONFIG_GENERIC_TIME

2011-08-01 Thread Russell King - ARM Linux
On Mon, Aug 01, 2011 at 01:41:32PM +0200, Zoltan Devai wrote: > 2011/8/1 Russell King - ARM Linux : > > On Sat, Jul 30, 2011 at 06:14:38PM +0200, Zoltan Devai wrote: > >> Commit 592913ecb87a9e06f98ddb55b298f1a66bf94c6b has killed off any > >> use of this config option lo

Re: [uml-devel] [PATCH] Remove remaining references of CONFIG_GENERIC_TIME

2011-08-01 Thread Russell King - ARM Linux
On Mon, Aug 01, 2011 at 12:09:02PM +0200, Geert Uytterhoeven wrote: > On Mon, Aug 1, 2011 at 10:36, Russell King - ARM Linux > wrote: > > On Sat, Jul 30, 2011 at 06:14:38PM +0200, Zoltan Devai wrote: > >> Commit 592913ecb87a9e06f98ddb55b298f1a66bf94c6b has killed off any &g

Re: [uml-devel] [PATCH] Remove remaining references of CONFIG_GENERIC_TIME

2011-08-01 Thread Russell King - ARM Linux
On Sat, Jul 30, 2011 at 06:14:38PM +0200, Zoltan Devai wrote: > Commit 592913ecb87a9e06f98ddb55b298f1a66bf94c6b has killed off any > use of this config option long ago. I don't see the point of this - we were free of GENERIC_TIME on ARM shortly after it was originally killed off. The problem is y

Re: [uml-devel] [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-01-17 Thread Russell King - ARM Linux
On Mon, Jan 17, 2011 at 12:07:13PM +0100, Peter Zijlstra wrote: > diff --git a/arch/alpha/kernel/smp.c b/arch/alpha/kernel/smp.c > index 42aa078..c4a570b 100644 > --- a/arch/alpha/kernel/smp.c > +++ b/arch/alpha/kernel/smp.c > @@ -587,6 +587,7 @@ handle_ipi(struct pt_regs *regs) > cas

Re: [uml-devel] [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-01-17 Thread Russell King - ARM Linux
e on the interrupt return path > - */ > + scheduler_ipi(); > break; > > case IPI_CALL_FUNC: Acked-by: Russell King -- Protect Your Site and Customers fro

[uml-devel] Re: [patch 18/39] remap_file_pages protection support: add VM_FAULT_SIGSEGV

2005-08-15 Thread Russell King
VM_FAULT_FAILED 0x20 > and make that bit present in VM_FAULT_OOM and VM_FAULT_SIGBUS, then > do an unlikely test for that bit in your handler and branch away to > the slow path. That'll do as well, thanks. -- Russell King Linux kernel2.6 ARM Linux - http://www.arm.linux.org.uk

[uml-devel] Re: [patch 18/39] remap_file_pages protection support: add VM_FAULT_SIGSEGV

2005-08-15 Thread Russell King
2 > +#define VM_FAULT_SIGSEGV 3 > > #define offset_in_page(p)((unsigned long)(p) & ~PAGE_MASK) > Please arrange for "success" values to be numerically larger than "failure" values. This will avoid breaking ARM. Is there a reason why we don't use -ve

[uml-devel] Re: [patch 11/39] remap_file_pages protection support: add MAP_NOINHERIT flag

2005-08-12 Thread Russell King
.git-paolo/include/asm-ppc64/mman.h |1 + > linux-2.6.git-paolo/include/asm-s390/mman.h |1 + > linux-2.6.git-paolo/include/asm-x86_64/mman.h |1 + > 6 files changed, 6 insertions(+) -- Russell King Linux kernel2.6 ARM

[uml-devel] Re: [patch 1/1] uml: fix lvalue for gcc4

2005-07-09 Thread Russell King
- 8; which will put the frame at 8 * sizeof(struct rt_sigframe) below the point which round_down() would return (which would be 1 struct rt_sigframe below stack_top, rounded down). -- Russell King Linux kernel2.6 ARM Linux - http://www.arm.linux.org.

[uml-devel] Re: [patch 1/1] unified spinlock initialization arch/um/drivers/port_kern.c

2005-03-09 Thread Russell King
On Wed, Mar 09, 2005 at 08:52:24PM +0100, Blaisorblade wrote: > On Wednesday 09 March 2005 18:12, Russell King wrote: > > On Wed, Mar 09, 2005 at 10:42:33AM +0100, [EMAIL PROTECTED] wrote: > > > From: <[EMAIL PROTECTED]> > > > Cc: , <[EMAIL PROTECTED]>, >

[uml-devel] Re: [patch 1/1] unified spinlock initialization arch/um/drivers/port_kern.c

2005-03-09 Thread Russell King
is really the best option in this instance? Sometimes, static data initialisation is more efficient than code-based manual initialisation, especially when the memory is written to anyway. -- Russell King Linux kernel2.6 ARM Linux - http://www.arm.linu