Re: [uml-devel] [RFC PATCH] vde network backend

2007-08-16 Thread Luca Bigliardi
On Wed, Aug 15, 2007 at 11:20 AM, Jeff Dike wrote: > What did you change? BB was right to comment on my changelog, but I > don't see any examples of if( blah ) { anywhere in the vde code. I've changed "if(blah)" into "if (blah)". > Since the main patch is in -mm, if you have changes, send incre

Re: [uml-devel] drivers/infiniband/mlx/mad.c misplaced ;

2007-08-16 Thread Heiko Carstens
On Wed, Aug 15, 2007 at 05:40:11PM -0700, Joe Perches wrote: > On Wed, 2007-08-15 at 19:58 -0400, Dave Jones wrote: > > Signed-off-by: Dave Jones <[EMAIL PROTECTED]> > > > > diff --git a/drivers/infiniband/hw/mlx4/mad.c > > b/drivers/infiniband/hw/mlx4/mad.c > > index 3330917..0ed02b7 100644 > >

Re: [uml-devel] drivers/infiniband/mlx/mad.c misplaced ;

2007-08-16 Thread Ilpo Järvinen
...I guess those guys hunting for broken busyloops in the other thread could also benefit from similar searching commands introduced in this thread... ...Ccing Satyam to caught their attention too. > On Wed, Aug 15, 2007 at 05:40:11PM -0700, Joe Perches wrote: > > > > There's more than a few

Re: [uml-devel] drivers/infiniband/mlx/mad.c misplaced ;

2007-08-16 Thread Karsten Keil
On Thu, Aug 16, 2007 at 01:22:04PM +0300, Ilpo Järvinen wrote: > > ...I guess those guys hunting for broken busyloops in the other thread > could also benefit from similar searching commands introduced in this > thread... ...Ccing Satyam to caught their attention too. > > > ./drivers/isdn/hisa

Re: [uml-devel] drivers/infiniband/mlx/mad.c misplaced ;

2007-08-16 Thread Satyam Sharma
Hi Ilpo, On Thu, 16 Aug 2007, Ilpo Järvinen wrote: > > ...I guess those guys hunting for broken busyloops in the other thread > could also benefit from similar searching commands introduced in this > thread... ...Ccing Satyam to caught their attention too. > > > > On Wed, Aug 15, 2007 at 05

Re: [uml-devel] [PATCH] UML: BLKGETSIZE takes a long, not an int

2007-08-16 Thread Jeff Dike
On Wed, Aug 15, 2007 at 11:38:25PM +0200, Nicolas George wrote: > Here is the hopefully correct patch, against current git. Thanks, I'll forward it upstream. Jeff -- Work email - jdike at linux dot intel dot com --

Re: [uml-devel] 2.6.21.5 crashes [was link failure, multiple definition of 'in6addr_any']

2007-08-16 Thread Antoine Martin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Antoine Martin wrote: > Antoine Martin wrote: >> Jeff Dike wrote: >>> On Tue, Jul 31, 2007 at 06:46:39PM +0100, Antoine Martin wrote: If it doesn't crash on emerge --sync (when I reboot it doesn't always crash), try building something big (

[uml-devel] [PATCH] UML - Fix previous request size limit fix

2007-08-16 Thread Jeff Dike
[ This is both 2.6.24 and -stable material ] The previous patch which limited the number of sectors in a single request to a COWed device was correct in concept, but the limit was implemented in the wrong place. By putting it in ubd_add, it covered the cases where the COWing was specified on the

[uml-devel] [PATCH] UML - Add a .note.SuSE section

2007-08-16 Thread Jeff Dike
[ This is both 2.6.24 and -stable material ] SuSE seems to require that binaries have a .note.SuSE section. Without it, UML segfaults if any parameters are passed on the command line. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/kernel/dyn.lds.S |1 + 1 file changed, 1 insertion(+

Re: [uml-devel] [stable] [PATCH] UML - Add a .note.SuSE section

2007-08-16 Thread Chris Wright
* Jeff Dike ([EMAIL PROTECTED]) wrote: > [ This is both 2.6.24 and -stable material ] > > SuSE seems to require that binaries have a .note.SuSE section. > Without it, UML segfaults if any parameters are passed on the command > line. Huh!? Why do we need a SuSE section? thanks, -chris --

Re: [uml-devel] drivers/infiniband/mlx/mad.c misplaced ;

2007-08-16 Thread Andy Whitcroft
Kok, Auke wrote: > Joe Perches wrote: >> On Wed, 2007-08-15 at 19:58 -0400, Dave Jones wrote: >>> Signed-off-by: Dave Jones <[EMAIL PROTECTED]> >>> >>> diff --git a/drivers/infiniband/hw/mlx4/mad.c >>> b/drivers/infiniband/hw/mlx4/mad.c >>> index 3330917..0ed02b7 100644 >>> --- a/drivers/infiniband

Re: [uml-devel] drivers/infiniband/mlx/mad.c misplaced ;

2007-08-16 Thread Jeff Dike
On Wed, Aug 15, 2007 at 05:40:11PM -0700, Joe Perches wrote: > fs/hostfs/hostfs_user.c:if(attrs->ia_valid & HOSTFS_ATTR_CTIME) ; This one can be deleted, but I think I did it for documentation reasons, to make it clear that ctime handling wasn't left out by mistake.

Re: [uml-devel] drivers/infiniband/mlx/mad.c misplaced ;

2007-08-16 Thread Paul Mundt
On Wed, Aug 15, 2007 at 05:40:11PM -0700, Joe Perches wrote: > $ egrep -r --include=*.c "\bif[[:space:]]*\([^\)]*\)[[:space:]]*\;" * > arch/sh/boards/se/7343/io.c:if (0) ; > drivers/atm/iphase.c: if (!desc1) ; > drivers/infiniband/hw/mlx4/mad.c: if (!err); > drivers/isdn/capi/capiuti

Re: [uml-devel] [stable] [PATCH] UML - Add a .note.SuSE section

2007-08-16 Thread Greg KH
On Thu, Aug 16, 2007 at 09:30:56AM -0700, Arjan van de Ven wrote: > > On Thu, 2007-08-16 at 12:24 -0400, Jeff Dike wrote: > > [ This is both 2.6.24 and -stable material ] > > > > SuSE seems to require that binaries have a .note.SuSE section. > > Without it, UML segfaults if any parameters are pas

Re: [uml-devel] [PATCH] UML - Add a .note.SuSE section

2007-08-16 Thread Arjan van de Ven
On Thu, 2007-08-16 at 12:24 -0400, Jeff Dike wrote: > [ This is both 2.6.24 and -stable material ] > > SuSE seems to require that binaries have a .note.SuSE section. > Without it, UML segfaults if any parameters are passed on the command > line. this sounds like something really stupid and bad.

Re: [uml-devel] [PATCH] UML - Add a .note.SuSE section

2007-08-16 Thread Jeff Dike
On Thu, Aug 16, 2007 at 09:30:56AM -0700, Arjan van de Ven wrote: > this sounds like something really stupid and bad... why would the kernel > need to have a per-distro note section??? On Thu, Aug 16, 2007 at 09:39:06AM -0700, Chris Wright wrote: > Huh!? Why do we need a SuSE section? On Thu, Au

Re: [uml-devel] [PATCH] UML - Add a .note.SuSE section

2007-08-16 Thread Jeff Dike
On Thu, Aug 16, 2007 at 10:04:55PM +0200, Sam Ravnborg wrote: > On Thu, Aug 16, 2007 at 03:26:39PM -0400, Jeff Dike wrote: > > > > The crash is in this section: > > > > __uml_setup_start = .; > > .uml.setup.init : { *(.uml.setup.init) } > > __uml_setup_end = .; > > This looks like a classi

[uml-devel] [PATCH] hostfs: Remove pointless if statement

2007-08-16 Thread Satyam Sharma
[ Cc: list heavily trimmed. ] On Thu, 16 Aug 2007, Jeff Dike wrote: > On Wed, Aug 15, 2007 at 05:40:11PM -0700, Joe Perches wrote: > > fs/hostfs/hostfs_user.c:if(attrs->ia_valid & HOSTFS_ATTR_CTIME) ; > > This one can be deleted, but I think I did it for documentation > reasons, to make