Re: [uml-devel] [PATCH 5/7] um: print info about fatal segfaults

2011-05-24 Thread Andrew Morton
On Sun, 22 May 2011 16:48:34 +0200 Richard Weinberger wrote: > +static void show_segv_info(struct uml_pt_regs *regs) > +{ > + struct task_struct *tsk = current; > + struct faultinfo *fi = UPT_FAULTINFO(regs); > + > + if (!unhandled_signal(tsk, SIGSEGV)) > + return; > + > +

[uml-devel] [PATCH] checkpatch: Add warning for uses of printk_ratelimit

2011-05-24 Thread Joe Perches
Warn about uses of printk_ratelimit because it uses a global state and can hide subsequent useful messages. Signed-off-by: Joe Perches --- scripts/checkpatch.pl |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d86708

Re: [uml-devel] [PATCH 5/7] um: print info about fatal segfaults

2011-05-24 Thread Richard Weinberger
Am Dienstag 24 Mai 2011, 21:34:33 schrieb Andrew Morton: > Please see the nice comment in printk.h > > /* > * Please don't use printk_ratelimit(), because it shares ratelimiting > state * with all other unrelated printk_ratelimit() callsites. Instead > use * printk_ratelimited() or plain old __r