On Sat, Oct 20, 2007 at 12:41:29PM +0100, Nix wrote:
>On 20 Oct 2007, Paolo Giarrusso told this:
>> Guess most people are not using SMP right now, and that the error disappears
>> without that setting
>
>It doesn't. It fails with non-SMP as well.
>
UML still doesn't build on 2.6.23-git16.
Gcc th
On Sun, Oct 21, 2007 at 09:08:48AM -0400, Jeff Dike wrote:
>On Sun, Oct 21, 2007 at 07:48:54PM +0800, WANG Cong wrote:
>> UML still doesn't build on 2.6.23-git16.
>>
>> Gcc threw out many errors, I put them in the web:
>> http://wangcong.org/down/errors.txt
On Sun, Oct 21, 2007 at 04:43:46PM +0100, Al Viro wrote:
>On Sun, Oct 21, 2007 at 09:20:32PM +0800, WANG Cong wrote:
>> On Sun, Oct 21, 2007 at 09:08:48AM -0400, Jeff Dike wrote:
>> >On Sun, Oct 21, 2007 at 07:48:54PM +0800, WANG Cong wrote:
>> >> UML still
On Mon, Oct 22, 2007 at 06:22:14AM +0100, Al Viro wrote:
>On Mon, Oct 22, 2007 at 12:37:46PM +0800, WANG Cong wrote:
>> >Fallout continues; I've got a preliminary patch for it. Basically, we
>> >need to stop doing -U__i386__ et.al.
>> >
>>
>> Hi,
On Mon, Oct 22, 2007 at 07:42:33AM +0100, Nix wrote:
>On 22 Oct 2007, WANG Cong uttered the following:
>> I build UML for non-SMP x86. But I don't know about UML_NET_VDE. ;(
>>
>> Errors threw out by gcc (too many) are put here:
>> http://wangcong.org/down
On Mon, Oct 22, 2007 at 08:59:43AM +0200, Sam Ravnborg wrote:
>On Mon, Oct 22, 2007 at 02:52:02PM +0800, WANG Cong wrote:
>> On Mon, Oct 22, 2007 at 07:42:33AM +0100, Nix wrote:
>> >On 22 Oct 2007, WANG Cong uttered the following:
>> >> I build UML for non-S
On Mon, Oct 22, 2007 at 12:36:00PM +0100, Al Viro wrote:
>On Mon, Oct 22, 2007 at 03:48:23PM +0800, WANG Cong wrote:
>> I just followed what Sam told me, errors are much fewer this time,
>> but still exist. Error messages are:
>>
>> CC arch/um/kernel/syscall.o
On Mon, Oct 22, 2007 at 02:30:41PM +0200, Ingo Molnar wrote:
>
>* WANG Cong <[EMAIL PROTECTED]> wrote:
>
>> On Mon, Oct 22, 2007 at 12:36:00PM +0100, Al Viro wrote:
>> >On Mon, Oct 22, 2007 at 03:48:23PM +0800, WANG Cong wrote:
>> >> I just followed wh
er from integer without a cast
make[1]: *** [arch/um/drivers/ubd_kern.o] Error 1
make: *** [arch/um/drivers] Error 2
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
arch/um/drivers/ubd_kern.c |1 +
1 file changed, 1 insertion(+)
diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drive
Fix an incompatible-pointer warning.
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
arch/um/drivers/ubd_kern.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
index e184b44..7e6cdde 100644
--- a/arch/um/d
Hi, Jeff, Sam!
I just pulled from Linus-tree, and got the following error when building uml.
$ make defconfig ARCH=um
/home/wangcong/projects/linux-2.6/arch/um/Makefile-i386:32:
/home/wangcong/projects/linux-2.6/arch/i386/Makefile.cpu: No such file or
directory
make: *** No rule to make target
On Sun, Oct 28, 2007 at 03:43:43AM +, Al Viro wrote:
>On Sun, Oct 28, 2007 at 11:24:41AM +0800, WANG Cong wrote:
>>
>> Hi, Jeff, Sam!
>>
>> I just pulled from Linus-tree, and got the following error when building uml.
>>
>> $ make defconfig ARCH=um
&g
Hi, Jeff.
This patch contains varied fixes and improvements for some files under
arch/um/os-Linux/, such as a typo fix in a perror message, a missing
argument fix for a printf, some constifying for pointers and so on.
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
Cc: Jeff Dike <[EMAIL
Hi, Jeff!
This patch also does some improvements for uml code. Improvements include
dropping unnecessary cast, killing some unnecessary code and still some
constifying for pointers etc..
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
Cc: Jeff Dike <[EMAIL PROTECTED]>
---
arc
Hi, Jeff!
I used today's linus-tree and defconfig to compile uml, but it failed. Error
messages are
things like:
In file included from include/asm/processor-generic.h:13,
from include/asm/processor.h:77,
from include/asm/thread_info.h:11,
from
include/asm-um/arch points to the non-existed include/asm-i386 directory.
This patch fixed it.
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
Cc: Jeff Dike <[EMAIL PROTECTED]>
---
diff --git a/arch/um/Makefile b/arch/um/Makefile
index 31999bc..ba6813a 100644
--- a/arch/um/Makefile
+
s of X86_32 and RWSEM_XCHGADD_ALGORITHM to
>the UML/i386 Kconfig.
>
>Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
Tested-by: WANG Cong <[EMAIL PROTECTED]>
Thanks, Jeff. With this and that patch[1], uml building works fine. ;)
[1]
On Fri, Nov 23, 2007 at 11:54:41AM +0100, Jiri Olsa wrote:
>Hi,
>
>after applying following changes, the mainline is working for me.
>
Hi,
I have already mentioned this. Follow this link[1]. ;^)
[1] http://lkml.org/lkml/2007/11/20/10
TOPDIR is obsolete, use objtree instead.
This patch removes TOPDIR from all UML Makefiles.
Cc: Jeff Dike <[EMAIL PROTECTED]>
Cc: Sam Ravnborg <[EMAIL PROTECTED]>
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
diff --git a/arch/um/Makefile b/arch/um/Makefile
index ba681
On Tue, Jan 01, 2008 at 11:49:42AM +0100, Sam Ravnborg wrote:
>On Tue, Jan 01, 2008 at 11:33:42AM +0100, Sam Ravnborg wrote:
>> On Tue, Jan 01, 2008 at 03:18:46PM +0800, WANG Cong wrote:
>> >
>> > TOPDIR is obsolete, use objtree instead.
>> > This patch r
This patch fixes this building error:
...
drivers/char/mem.c: In function ‘read_mem’:
drivers/char/mem.c:136: error: implicit declaration of function
‘unxlate_dev_mem_ptr’
...
Cc: Jeff Dike <[EMAIL PROTECTED]>
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
Index: linux/include
em.h:8:22: error: asm/nops.h: No such file or directory
...
Cc: Jeff Dike <[EMAIL PROTECTED]>
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
Index: linux/include/asm-um/nops.h
===
--- /dev/null
+++ linux/include/asm-u
once
arch/um/kernel/skas/syscall.c:33: error: for each function it appears in.)
make[2]: *** [arch/um/kernel/skas/syscall.o] Error 1
make[1]: *** [arch/um/kernel/skas] Error 2
make: *** [arch/um/kernel] Error 2
Cc: Jeff Dike <[EMAIL PROTECTED]>
Signed-off-by: WANG Cong <[EMAIL PROTECTED
This patch fixed the following build error in current -git tree.
arch/um/kernel/config.c:10: error: expected declaration specifiers or '...'
before '.' token
...
Cc: Jeff Dike <[EMAIL PROTECTED]>
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
diff --git a/
Fix a shadowed variable in arch/um/kernel/mem.c,
since there is a global variable has the same name.
Cc: Jeff Dike <[EMAIL PROTECTED]>
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
Index: linux/arch/um/
Fix a missed conversion specifier of a printk in
arch/um/kernel/initrd.c.
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
Cc: Jeff Dike <[EMAIL PROTECTED]>
---
Index: linux/arch/um/kernel/initrd.c
===
--- linux.orig/ar
Make some small improvements for arch/um/kernel/um_arch.c.
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
Cc: Jeff Dike <[EMAIL PROTECTED]>
---
diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c
index a6c1dd1..56deed6 100644
--- a/arch/um/kernel/um_arch.c
+++ b/ar
From: Jiri Olsa <[EMAIL PROTECTED]>
Subject: [PATCH] uml: use DIV_ROUND_UP
Date: Tue, 19 Feb 2008 22:49:33 +0100
Message-ID: <[EMAIL PROTECTED]>
> Hi,
>
> I just saw similar patches in the janitor kernel's list,
> and spotted place it fits.
>
> Signed-off-by: Jiri Olsa <[EMAIL PROTECTED]>
> ---
This patch
- lets ptrace_child become void
- adds checking for the return value of change_sig
- moves errors info into stderr instead of stdout.
Cc: [EMAIL PROTECTED]
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
arch/um/os-Linux/start_up.c | 14 ++
1 files chan
This patch fixes possible memory leaks in the main() function of
arch/um/os-Linux/main.c.
Cc: [EMAIL PROTECTED]
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
Index: linux-2.6/arch/um/os-Linux/main.c
===
--- linux-2.6.ori
From: Jeff Dike <[EMAIL PROTECTED]>
Date: Fri, 4 Apr 2008 11:49:01 -0400
> On Tue, Apr 01, 2008 at 11:06:41PM +0800, WANG Cong wrote:
> >
> > This patch fixes possible memory leaks in the main() function of
> > arch/um/os-Linux/main.c.
>
> I'm somewhat du
Improve this code a bit: check sigaction's return value and remove a useless
fflush().
Cc: Jeff Dike <[EMAIL PROTECTED]>
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
diff --git a/arch/um/os-Linux/sys-i386/task_size.c
b/arch/um/os-Linux/sys-i386/task_size.c
index 48d211
/um/kernel/smp.o] Error 1
make[1]: *** [arch/um/kernel] Error 2
make: *** [sub-make] Error 2
And since including in will break sparc,
we add this #include in uml's own header.
Cc: Jeff Dike <[EMAIL PROTECTED]>
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
diff --git a/inclu
arch/um/drivers/chan_kern.c::open_chan() can become static.
Compile testing passed.
Cc: Jeff Dike <[EMAIL PROTECTED]>
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
arch/um/drivers/chan_kern.c |2 +-
arch/um/include/chan_kern.h |1 -
2 files changed, 1 insertions(+),
arch/um/drivers/chan_kern.c::chan_out_fd() is not used by anyone.
Remove it.
Compile testing passed.
Cc: Jeff Dike <[EMAIL PROTECTED]>
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
arch/um/drivers/chan_kern.c | 13 -
arch/um/include/chan_kern.h |1 -
2 file
gned-off-by: WANG Cong <[EMAIL PROTECTED]>
---
arch/um/drivers/mcast_kern.c|2 +-
arch/um/drivers/mconsole_user.c |2 +-
arch/um/drivers/port_user.c |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/um/drivers/mcast_kern.c b/arch/um/drivers/m
definition of ‘mconsole_register_dev’ was here
make[2]: *** [arch/um/drivers/mconsole_kern.o] Error 1
make[1]: *** [arch/um/drivers/mconsole_kern.ko] Error 2
make: *** [sub-make] Error 2
Compile testing passed.
Cc: Jeff Dike <[EMAIL PROTECTED]>
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
Make several things static, because they no longer need to be global.
Cc: Jeff Dike <[EMAIL PROTECTED]>
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
arch/um/drivers/net_kern.c |6 +++---
arch/um/drivers/slip_kern.c |4 ++--
arch/um/drivers/stdio_console.c |
Make some global functions and variables static.
And remove some useless declarations for local functions, since we just
need to move their definitions ahead.
Compile testing passed.
Cc: Jeff Dike <[EMAIL PROTECTED]>
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
arch/um/driver
From: Jeff Dike <[EMAIL PROTECTED]>
Date: Tue, 15 Apr 2008 09:33:25 -0400
> On Mon, Apr 14, 2008 at 11:42:37PM -0700, Andrew Morton wrote:
> > omg, when checkpatch bit into this patch my CPU melted.
>
> Yeah, I've been scared to do a checkpatch run over that file. I think
> it's the only core fil
From: Jeff Dike <[EMAIL PROTECTED]>
Date: Mon, 14 Apr 2008 11:43:42 -0400
> On Sat, Apr 12, 2008 at 11:39:14PM +0800, WANG Cong wrote:
> >
> > This patch fixes the following build error.
> >
> > CC arch/um/drivers/mconsole_kern.o
> > /home/wang
From: Jeff Dike <[EMAIL PROTECTED]>
Date: Wed, 16 Apr 2008 11:20:19 -0400
> On Wed, Apr 16, 2008 at 01:39:19PM +0800, WANG Cong wrote:
> > From: Jeff Dike <[EMAIL PROTECTED]>
> > Date: Tue, 15 Apr 2008 09:33:25 -0400
> > > On Mon, Apr 14, 2008 at 11:42:37PM -07
Make activate_fd() and free_irq_by_irq_and_dev() static.
Remove init_aio_irq() since it has no users.
Compile testing passed.
Cc: Jeff Dike <[EMAIL PROTECTED]>
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
arch/um/include/irq_kern.h |2 --
arch/um/include/irq_user.h |2
Remove arch_validate(), because no one uses it.
Remove useless macro HAVE_ARCH_VALIDATE.
Make the variable 'empty_bad_page' static.
Compile testing passed.
Cc: Jeff Dike <[EMAIL PROTECTED]>
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
arch/um/kernel/ksyms.c |1 -
Make some variables and functions static, since they don't need
to be global.
And remove an unused function - arch/um/kernel/time.c::sched_clock().
Cc: Jeff Dike <[EMAIL PROTECTED]>
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
arch/um/include/skas/skas.h |1 -
From: WANG Cong <[EMAIL PROTECTED]>
Date: Thu, 24 Apr 2008 16:36:55 +0800 (CST)
>
> Make some variables and functions static, since they don't need
> to be global.
>
> And remove an unused function - arch/um/kernel/time.c::sched_clock().
>
Sorry, Andrew.
I forgot t
From: Jeff Dike <[EMAIL PROTECTED]>
Date: Fri, 25 Apr 2008 13:56:09 -0400
> hppfs tidying and fixes noticed during hch's get_inode work -
> style fixes
> a copy_to_user got its return value checked
> hppfs_write no longer fiddles file->f_pos because it gets and
> returns pos in it
From: Jeff Dike <[EMAIL PROTECTED]>
Date: Fri, 25 Apr 2008 13:56:09 -0400
> There's no reason for the _kern in hppfs_kern.c, so move it to hppfs.c.
>
> Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
> ---
> fs/hppfs/Makefile |6
> fs/hppfs/hppfs.c | 771
> +++
From: Jeff Dike <[EMAIL PROTECTED]>
Date: Fri, 25 Apr 2008 13:56:10 -0400
> Tidy the ptrace interface code. Removed a bunch of unused macros.
> Started converting register sets from arrays of longs to structures.
Could you please explain a bit why do this? I think long arrary is OK.
Thanks.
Con
From: Jeff Dike <[EMAIL PROTECTED]>
Date: Fri, 25 Apr 2008 13:56:06 -0400
> Restructure the stub management code to make it simpler.
>
> syscall_stub_done is extracted from do_syscall_stub.
>
> The counters are gone since I never looked at them.
>
> The common code in run_syscall_stub and syscal
On Mon, 28 Apr 2008, Jeff Dike wrote:
> On Sat, Apr 26, 2008 at 06:01:12PM +0800, WANG Cong wrote:
>> > + /*
>> > + * When the stub stops, we find the following values on the
>> > + * beginning of the stack:
>> > + * (long) return_value
>> >
On Mon, 28 Apr 2008, Jeff Dike wrote:
> On Sat, Apr 26, 2008 at 04:31:32PM +0800, WANG Cong wrote:
>> > + rem = copy_to_user(buf, &data->contents[off], count);
>> > + *ppos += count - rem;
>> > + if (rem > 0)
>> > +
On Mon, 28 Apr 2008, Jeff Dike wrote:
> On Sat, Apr 26, 2008 at 05:17:55PM +0800, WANG Cong wrote:
>> > +static struct inode *get_inode(struct super_block *, struct dentry *);
>> > +
>> > +struct hppfs_data {
>> > + struct list_head list;
>> > + c
On Mon, 28 Apr 2008, Jeff Dike wrote:
> On Sat, Apr 26, 2008 at 05:35:38PM +0800, WANG Cong wrote:
>> From: Jeff Dike <[EMAIL PROTECTED]>
>> Date: Fri, 25 Apr 2008 13:56:10 -0400
>> > Tidy the ptrace interface code. Removed a bunch of unused macros.
>> >
Make activate_fd() and free_irq_by_irq_and_dev() static.
Remove init_aio_irq() since it has no users.
Compile testing passed.
Cc: Jeff Dike <[EMAIL PROTECTED]>
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
arch/um/include/irq_kern.h |2 --
arch/um/include/irq_user.h |
Remove arch_validate(), because no one uses it.
Remove useless macro HAVE_ARCH_VALIDATE.
Make the variable 'empty_bad_page' static.
Compile testing passed.
Cc: Jeff Dike <[EMAIL PROTECTED]>
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
arch/um/kernel/ksyms.c |
Make some variables and functions static, since they don't need
to be global.
Remove an unused function - arch/um/kernel/time.c::sched_clock().
Clean the style a bit as complained by checkpatch.pl.
Cc: Jeff Dike <[EMAIL PROTECTED]>
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
'put_char' of 'struct tty_operations' has changed from 'void' into 'int'.
This can also shut up comipler warnings.
Cc: Jeff Dike <[EMAIL PROTECTED]>
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
---
diff --git a/arch/um/drivers/line.c b/arch/u
/line.c:367: error:
‘struct tty_ldisc’ has no member named ‘write_wakeup’
make[2]: *** [arch/um/drivers/line.o] Error 1
make[1]: *** [arch/um/drivers] Error 2
make: *** [sub-make] Error 2
Sigend-off-by: WANG Cong <[EMAIL PROTECTED]>
Cc: [EMAIL PROTECTED]
---
diff --git a/arch/um/drivers/line.c b/a
On Tue, Jul 22, 2008 at 11:53:54AM +0100, Alan Cox wrote:
>> Signed-off-by: Eric Sesterhenn <[EMAIL PROTECTED]>
>>
>> --- linux-2.6/arch/um/drivers/line.c.orig2008-07-22 12:06:17.0
>> +0200
>> +++ linux-2.6/arch/um/drivers/line.c 2008-07-22 12:06:49.0 +0200
>> @@ -362,10 +362,
wakeup != NULL))
>> -(tty->ldisc.write_wakeup)(tty);
>> -
>> +if (test_bit(TTY_DO_WRITE_WAKEUP, &tty->flags))
>> +tty_wakeup(tty);
>
>Sorry I should have been clearer - you don't want the test_bit either.
>
What about the below on
-2.6/arch/um/drivers/vde_user.c:81:
warning: assignment makes pointer from integer without a cast
make[2]: *** [arch/um/drivers/vde_user.o] Error 1
make[1]: *** [arch/um/drivers/vde_user.ko] Error 2
make: *** [sub-make] Error 2
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
Cc: [EMAIL PRO
l/bounds.c:9:
/home/wangcong/Projects/linux-2.6/include/linux/types.h:12:23: error:
asm/types.h: No such file or directory
In file included from
/home/wangcong/Projects/linux-2.6/include/linux/page-flags.h:8,
Below patch fixed it, note, it is only tested for x86 and um.
Signed-off-by: WANG Co
ewhat
>inconsistent API.
>
>Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
>Cc: WANG Cong <[EMAIL PROTECTED]>
>Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
>Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
Looks good. Thanks. :)
kov
>
> P.S. Google has blanket FSF copyright assignment.
>
>
> Signed-off-by: Paul Pluzhnikov
>
Acked-by: WANG Cong
Thanks.
--
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)
65 matches
Mail list logo
