On Tue, Jul 22, 2008 at 11:53:54AM +0100, Alan Cox wrote:
>> Signed-off-by: Eric Sesterhenn <[EMAIL PROTECTED]>
>>
>> --- linux-2.6/arch/um/drivers/line.c.orig 2008-07-22 12:06:17.000000000
>> +0200
>> +++ linux-2.6/arch/um/drivers/line.c 2008-07-22 12:06:49.000000000 +0200
>> @@ -362,10 +362,8 @@ static irqreturn_t line_write_interrupt(
>> if (tty == NULL)
>> return IRQ_NONE;
>>
>> - if (test_bit(TTY_DO_WRITE_WAKEUP, &tty->flags) &&
>> - (tty->ldisc.write_wakeup != NULL))
>> - (tty->ldisc.write_wakeup)(tty);
>> -
>> + if (test_bit(TTY_DO_WRITE_WAKEUP, &tty->flags))
>> + tty_wakeup(tty);
>
>Sorry I should have been clearer - you don't want the test_bit either.
>
Sure, tty_wakeup() already does that test.
And, tty_wakeup() also does wake_up_interruptible(), so I think
the wake_up_interruptible() below can also be removed, probably.
Thanks.
--
The opposite of love is not hate, but indifference.
--Elie Wiesel
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
