Thanks! I'll make sure these changes are applied for 2.1.
Matt
2009/3/30 tibi
> and pmd errors are gone too:
>
> changed these:
>
>* org.appfuse.webapp.action.UserAction
>
> * org.appfuse.webapp.listener.UserCounterListener
>
>* org.appfuse.webapp.taglib.CountryTag
>
>* org.appfu
and pmd errors are gone too:
changed these:
* org.appfuse.webapp.action.UserAction
* org.appfuse.webapp.listener.UserCounterListener
* org.appfuse.webapp.taglib.CountryTag
* org.appfuse.webapp.util.RequestUtil
this is the jira:
http://issues.appfuse.org/browse/APF-114
jira made:
http://issues.appfuse.org/browse/APF-1144
hope it can be added!
thanks
tibi wrote:
> ok done.
>
> i will add what i have done to the jira bug i will make.
>
> here is the list to get to 0 checkstyle errors:
>
>
> * Changed some self made classes in model
>
> * Moved to test tree
ok done.
i will add what i have done to the jira bug i will make.
here is the list to get to 0 checkstyle errors:
* Changed some self made classes in model
* Moved to test tree
* org.appfuse.service.BaseManagerTestCase
* org.appfuse.service.impl.BaseManagerMockTestCase
about the DateConverter. i see now one is a StrutsTypeConverter.
maybe it should use the DateConverter from the util package??
tibi
tibi wrote:
> ok thanks.
>
> for my own project i will move them to the test dir
> for appfuse i don't know if it is worth it.
> i you think so i will make a jira f
next issue:
i see two DateConverters. one more complete and better then the other.
i think this one can be deleted:
org.appfuse.webapp.action.DateConverter
and this one can stay:
org.appfuse.util.DateConverter
correct??
tibi
tibi wrote:
> ok thanks.
>
> for my own project i will move them to t
ok thanks.
for my own project i will move them to the test dir
for appfuse i don't know if it is worth it.
i you think so i will make a jira for it.
i will add java doc to the classes explaining the difference.
thanks
Matt Raible wrote:
> TestCase classes are in the source so projects that inhe
TestCase classes are in the source so projects that inherit AppFuse can use
them. Without this setup, we'd have to create an appfuse-test dependencies,
which is certainly a possibility.
The difference between them is the Mock one uses jMock and the other one is
an integration test that loads up Sp
ok working off all the checkstyl errors i see these two classes:
BaseManagerMockTestCase
BaseManagerTestCase
first there is no author but thats minor but more important there is no
class description.
and trying to write one... a notice i don't have enough knowledge.
what is de difference between
there are a lot of errors which will disappear with the right formatter.
is there an eclipse formatter included in appfuse?
mine took away about a 100 errors...
i will continu tweaking :D
tibi wrote:
> ok with the appfuse config file there are 'only' 178 errors ;D
>
> tibi wrote:
>
>> tibi wro
ok i will keep track of what i do and add the changes to the source an
make a patch.
then i need to only do it twice ;)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: users-h...
The best thing to do is checkout from trunk, do the fixes there, then create
a patch with your fixes in it. Create a new issue in JIRA and attach the
patch.
Matt
On Tue, Mar 24, 2009 at 6:21 AM, tibi wrote:
> ok done with my lunch
>
> there are many simpel errors which i can fix fast. but i'm n
ok done with my lunch
there are many simpel errors which i can fix fast. but i'm not looking
forward to fix them every appfuse project i will do.
so can i commit these kind of fixes??
tibi wrote:
> ok with the appfuse config file there are 'only' 178 errors ;D
>
> tibi wrote:
>
>> tibi wrot
ok with the appfuse config file there are 'only' 178 errors ;D
tibi wrote:
>
> tibi wrote:
>
>> i'm used to use checkstyle and pmd to push on writing nice code.
>> ...
>> i already added the request to the google summer school list.
>>
>>
> i will put here parts of my pom file. just as a s
Has anyone used findbugs too? Any good comparison articles on the three?
--- On Tue, 24/3/09, tibi wrote:
From: tibi
Subject: Re: [appfuse-user] checkstyle and PMD errors
To: [email protected]
Date: Tuesday, 24 March, 2009, 11:25 AM
tibi wrote:
>
> i'm used to use che
tibi wrote:
>
> i'm used to use checkstyle and pmd to push on writing nice code.
> ...
> i already added the request to the google summer school list.
>
i will put here parts of my pom file. just as a start:
first it is very irritating to not be able to build when there is some
stupid checksty
mraible wrote:
>
> Are you using our checkstyle configuration?
> https://appfuse.dev.java.net/checkstyle.xml
>
>
not jet. i used my own. but i will do it tomorrow immedeately after my cup
of thee ;)
--
View this message in context:
http://www.nabble.com/checkstyle-and-PMD-errors-tp2272s
Are you using our checkstyle configuration?
maven-checkstyle-plugin
https://appfuse.dev.java.net/checkstyle.xml
Matt
On Mon, Mar 23, 2009 at 12:49 PM, tibi wrote:
>
> hi list,
>
> i'm used to use c
hi list,
i'm used to use checkstyle and pmd to push on writing nice code.
when i use appfuse fullsource i get a lot off errors. 521 for the
struts2 basic model.
i can (and will) fix these but it would be nice i would not have to do
this for every appfuse project.
i already added the request to th
19 matches
Mail list logo
