Re: Proton C source reorg and removal of deprecated or obsolete code

2018-04-05 Thread Alan Conway
Well done, what a monster! Now to weed out the last of the messenger code... On Thu, Apr 5, 2018 at 3:40 PM, Justin Ross wrote: > Just a note to everyone that the Proton C source reorg has now landed on > master. Please let me know if you have any trouble. > >

Re: Proton C source reorg and removal of deprecated or obsolete code

2018-04-05 Thread Justin Ross
Just a note to everyone that the Proton C source reorg has now landed on master. Please let me know if you have any trouble. https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;a=tree;h=HEAD On Wed, Mar 14, 2018 at 5:40 AM, Alan Conway wrote: > On Mon, Mar 12, 2018

Re: Proton C source reorg and removal of deprecated or obsolete code

2018-03-14 Thread Alan Conway
On Mon, Mar 12, 2018 at 12:14 PM, Justin Ross wrote: > > src/messenger still there - oversight, or do we need to hold onto this? > > > > It's still used by one of the test tools. > > We can replace msgr-send.c and msgr-recv.c by copying from examples/c/[send.c, send-ssl.c,

Re: Proton C source reorg and removal of deprecated or obsolete code

2018-03-12 Thread Justin Ross
On Mon, Mar 12, 2018 at 8:57 AM, Alan Conway wrote: > Overall it's good. > > Things to consider - none are essential: > > drop 'binding/', put the language bindings directly in the root dir. It's > pretty obvious what they are - ruby, go, cpp etc. > > Possibility: a "c" or

Re: Proton C source reorg and removal of deprecated or obsolete code

2018-03-12 Thread Alan Conway
Overall it's good. Things to consider - none are essential: drop 'binding/', put the language bindings directly in the root dir. It's pretty obvious what they are - ruby, go, cpp etc. Possibility: a "c" or "core" subdir rather than having the core src/ directly in root - clarify that the

Proton C source reorg and removal of deprecated or obsolete code

2018-03-08 Thread Justin Ross
Hi, all. After we split Proton J out of Proton, the existing Proton C source tree no longer made sense. This proposed change moves the proton-c/* content to the top level and generally aligns the source tree with conventions we use in some of our other code bases. It also removes bindings,