[RESULT] [VOTE] Release Apache Qpid Proton-J 0.30.0
There were 5 binding +1 votes, with no other votes received. The vote has passed. I will add the files to the dist release repo and release the maven staging repo shortly, and update the website once things have had time to sync to the mirrors and maven central. Robbie - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
Re: [VOTE] Release Apache Qpid Proton-J 0.30.0
+1. My testing was: * Verified signatures and checksums * Checked for LICENCE and NOTICE files in the archives. * Built from source / ran tests on Mac OS X 10.13.6 * Ran Qpid Broker-J client integration tests using the staged proton artefacts and Qpid-JMS (master - 9c1afa9b3) * Ran Qpid JMS test suite (master - 9c1afa9b3) using the staged proton artefacts On Wed, 7 Nov 2018 at 16:33, Oleksandr Rudyy wrote: > > +1 > > Robbie, thanks for the detailed explanation about the nature of the > issue with qpid-jms-client 0.36.0. > I was able to run successfully Broker-J integration tests with > qpid-jms-client 0.37.0 and proton-j 0.30.0 RC. > Apart from running Qpid Broker-J integration tests I verified > signatures/checksums and built and ran tests successfully from > proton-j 0.30.0 sources. > On Wed, 7 Nov 2018 at 15:27, Robbie Gemmell wrote: > > > > After some investigation I found this actually stems from a bug in the > > older 0.36.0 qpid-jms client rather than in the proton-j 0.30.0 RC. > > The client had a bug in its implementation of a buffer interface, one > > which proton-j is now making use of in a way that exposes that bug in > > the older client. The particular bug was already fixed in 0.37.0, so > > using 0.37.0 or the 0.38.0-SNAPSHOT passes those tests, as did a > > modified 0.36.0. > > > > While it might have been nice to avoid this until a future point, > > given it was a client bug and the situation doesnt arise with the > > current release I believe we should proceed as-is. > > > > Robbie > > > > On Wed, 7 Nov 2018 at 10:12, Oleksandr Rudyy wrote: > > > > > > Hi, > > > > > > I tried to run Qpid Broker-J system tests with qpid-jms-client 0.36.0 > > > and staged org.apache.qpid:proton-j:0.30.0 but JMS 1.1 tests from > > > suite org.apache.qpid.systests.jms_1_1.message.LargeMessageTest failed > > > due to mismatch of received message text and sent message text. > > > The text messages with sizes 245KB, 512KM and 1MB are sent and > > > received as part of the test suite. > > > Somehow some characters at the end of the received messages have been > > > replaced with '\u0' characters. The tests are passing with proton-j > > > 0.29.0 and qpid-jms-client 0.36.0. > > > > > > Kind Regards, > > > Alex > > > On Tue, 6 Nov 2018 at 18:15, Robbie Gemmell > > > wrote: > > > > > > > > Hi folks, > > > > > > > > I have put together a spin for a Qpid Proton-J 0.30.0 release, please > > > > test it and vote accordingly. > > > > > > > > The files can be grabbed from: > > > > https://dist.apache.org/repos/dist/dev/qpid/proton-j/0.30.0-rc1/ > > > > > > > > The maven artifacts are staged for now at: > > > > https://repository.apache.org/content/repositories/orgapacheqpid-1160 > > > > > > > > The JIRAs assigned are: > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313720=12343875 > > > > > > > > Regards, > > > > Robbie > > > > > > > > P.S. If you want to test things out using maven with your own build > > > > you can temporarily add this to your poms to access the staging repo: > > > > > > > > > > > > > > > > staging > > > > > > > > https://repository.apache.org/content/repositories/orgapacheqpid-1160 > > > > > > > > > > > > > > > > The dependency for proton-j would then be: > > > > > > > > > > > > org.apache.qpid > > > > proton-j > > > > 0.30.0 > > > > > > > > > > > > - > > > > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > > > > For additional commands, e-mail: users-h...@qpid.apache.org > > > > > > > > > > - > > > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > > > For additional commands, e-mail: users-h...@qpid.apache.org > > > > > > > - > > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > > For additional commands, e-mail: users-h...@qpid.apache.org > > > > - > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > For additional commands, e-mail: users-h...@qpid.apache.org > - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
Re: [VOTE] Release Apache Qpid Proton-J 0.30.0
+1 Robbie, thanks for the detailed explanation about the nature of the issue with qpid-jms-client 0.36.0. I was able to run successfully Broker-J integration tests with qpid-jms-client 0.37.0 and proton-j 0.30.0 RC. Apart from running Qpid Broker-J integration tests I verified signatures/checksums and built and ran tests successfully from proton-j 0.30.0 sources. On Wed, 7 Nov 2018 at 15:27, Robbie Gemmell wrote: > > After some investigation I found this actually stems from a bug in the > older 0.36.0 qpid-jms client rather than in the proton-j 0.30.0 RC. > The client had a bug in its implementation of a buffer interface, one > which proton-j is now making use of in a way that exposes that bug in > the older client. The particular bug was already fixed in 0.37.0, so > using 0.37.0 or the 0.38.0-SNAPSHOT passes those tests, as did a > modified 0.36.0. > > While it might have been nice to avoid this until a future point, > given it was a client bug and the situation doesnt arise with the > current release I believe we should proceed as-is. > > Robbie > > On Wed, 7 Nov 2018 at 10:12, Oleksandr Rudyy wrote: > > > > Hi, > > > > I tried to run Qpid Broker-J system tests with qpid-jms-client 0.36.0 > > and staged org.apache.qpid:proton-j:0.30.0 but JMS 1.1 tests from > > suite org.apache.qpid.systests.jms_1_1.message.LargeMessageTest failed > > due to mismatch of received message text and sent message text. > > The text messages with sizes 245KB, 512KM and 1MB are sent and > > received as part of the test suite. > > Somehow some characters at the end of the received messages have been > > replaced with '\u0' characters. The tests are passing with proton-j > > 0.29.0 and qpid-jms-client 0.36.0. > > > > Kind Regards, > > Alex > > On Tue, 6 Nov 2018 at 18:15, Robbie Gemmell > > wrote: > > > > > > Hi folks, > > > > > > I have put together a spin for a Qpid Proton-J 0.30.0 release, please > > > test it and vote accordingly. > > > > > > The files can be grabbed from: > > > https://dist.apache.org/repos/dist/dev/qpid/proton-j/0.30.0-rc1/ > > > > > > The maven artifacts are staged for now at: > > > https://repository.apache.org/content/repositories/orgapacheqpid-1160 > > > > > > The JIRAs assigned are: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313720=12343875 > > > > > > Regards, > > > Robbie > > > > > > P.S. If you want to test things out using maven with your own build > > > you can temporarily add this to your poms to access the staging repo: > > > > > > > > > > > > staging > > > > > > https://repository.apache.org/content/repositories/orgapacheqpid-1160 > > > > > > > > > > > > The dependency for proton-j would then be: > > > > > > > > > org.apache.qpid > > > proton-j > > > 0.30.0 > > > > > > > > > - > > > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > > > For additional commands, e-mail: users-h...@qpid.apache.org > > > > > > > - > > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > > For additional commands, e-mail: users-h...@qpid.apache.org > > > > - > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > For additional commands, e-mail: users-h...@qpid.apache.org > - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
Re: [VOTE] Release Apache Qpid Proton-J 0.30.0
After some investigation I found this actually stems from a bug in the older 0.36.0 qpid-jms client rather than in the proton-j 0.30.0 RC. The client had a bug in its implementation of a buffer interface, one which proton-j is now making use of in a way that exposes that bug in the older client. The particular bug was already fixed in 0.37.0, so using 0.37.0 or the 0.38.0-SNAPSHOT passes those tests, as did a modified 0.36.0. While it might have been nice to avoid this until a future point, given it was a client bug and the situation doesnt arise with the current release I believe we should proceed as-is. Robbie On Wed, 7 Nov 2018 at 10:12, Oleksandr Rudyy wrote: > > Hi, > > I tried to run Qpid Broker-J system tests with qpid-jms-client 0.36.0 > and staged org.apache.qpid:proton-j:0.30.0 but JMS 1.1 tests from > suite org.apache.qpid.systests.jms_1_1.message.LargeMessageTest failed > due to mismatch of received message text and sent message text. > The text messages with sizes 245KB, 512KM and 1MB are sent and > received as part of the test suite. > Somehow some characters at the end of the received messages have been > replaced with '\u0' characters. The tests are passing with proton-j > 0.29.0 and qpid-jms-client 0.36.0. > > Kind Regards, > Alex > On Tue, 6 Nov 2018 at 18:15, Robbie Gemmell wrote: > > > > Hi folks, > > > > I have put together a spin for a Qpid Proton-J 0.30.0 release, please > > test it and vote accordingly. > > > > The files can be grabbed from: > > https://dist.apache.org/repos/dist/dev/qpid/proton-j/0.30.0-rc1/ > > > > The maven artifacts are staged for now at: > > https://repository.apache.org/content/repositories/orgapacheqpid-1160 > > > > The JIRAs assigned are: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313720=12343875 > > > > Regards, > > Robbie > > > > P.S. If you want to test things out using maven with your own build > > you can temporarily add this to your poms to access the staging repo: > > > > > > > > staging > > > > https://repository.apache.org/content/repositories/orgapacheqpid-1160 > > > > > > > > The dependency for proton-j would then be: > > > > > > org.apache.qpid > > proton-j > > 0.30.0 > > > > > > - > > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > > For additional commands, e-mail: users-h...@qpid.apache.org > > > > - > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > For additional commands, e-mail: users-h...@qpid.apache.org > - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
Re: [VOTE] Release Apache Qpid Proton-J 0.30.0
Hi, I tried to run Qpid Broker-J system tests with qpid-jms-client 0.36.0 and staged org.apache.qpid:proton-j:0.30.0 but JMS 1.1 tests from suite org.apache.qpid.systests.jms_1_1.message.LargeMessageTest failed due to mismatch of received message text and sent message text. The text messages with sizes 245KB, 512KM and 1MB are sent and received as part of the test suite. Somehow some characters at the end of the received messages have been replaced with '\u0' characters. The tests are passing with proton-j 0.29.0 and qpid-jms-client 0.36.0. Kind Regards, Alex On Tue, 6 Nov 2018 at 18:15, Robbie Gemmell wrote: > > Hi folks, > > I have put together a spin for a Qpid Proton-J 0.30.0 release, please > test it and vote accordingly. > > The files can be grabbed from: > https://dist.apache.org/repos/dist/dev/qpid/proton-j/0.30.0-rc1/ > > The maven artifacts are staged for now at: > https://repository.apache.org/content/repositories/orgapacheqpid-1160 > > The JIRAs assigned are: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313720=12343875 > > Regards, > Robbie > > P.S. If you want to test things out using maven with your own build > you can temporarily add this to your poms to access the staging repo: > > > > staging > > https://repository.apache.org/content/repositories/orgapacheqpid-1160 > > > > The dependency for proton-j would then be: > > > org.apache.qpid > proton-j > 0.30.0 > > > - > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > For additional commands, e-mail: users-h...@qpid.apache.org > - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
Re: [VOTE] Release Apache Qpid Proton-J 0.30.0
On 06/11/18 18:14, Robbie Gemmell wrote: Hi folks, I have put together a spin for a Qpid Proton-J 0.30.0 release, please test it and vote accordingly. +1 verified signature and checksum, built and installed from source including tests - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
Re: [VOTE] Release Apache Qpid Proton-J 0.30.0
On Tue, 6 Nov 2018 at 18:14, Robbie Gemmell wrote: > > Hi folks, > > I have put together a spin for a Qpid Proton-J 0.30.0 release, please test it > and vote accordingly. > > The files can be grabbed from: > https://dist.apache.org/repos/dist/dev/qpid/proton-j/0.30.0-rc1/ > > The maven artifacts are staged for now at: > https://repository.apache.org/content/repositories/orgapacheqpid-1160 > > The JIRAs assigned are: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313720=12343875 > > Regards, > Robbie > > P.S. If you want to test things out using maven with your own build > you can temporarily add this to your poms to access the staging repo: > > > > staging > > https://repository.apache.org/content/repositories/orgapacheqpid-1160 > > > > The dependency for proton-j would then be: > > > org.apache.qpid > proton-j > 0.30.0 > +1 I checked things out as follows: - Verified the signature and checksum files. - Checked for LICENCE and NOTICE files in the archives. - Ran mvn apache-rat:check to verify licence headers in the source archive. - Ran the build and tests from the source archive, all good. - Built Qpid JMS master and ran the tests using the staging repo bits. - Ran the ActiveMQ 5 master build and AMQP tests using earlier client. - Ran the ActiveMQ Artemis master build and AMQP tests using earlier client (3 tests failed, but did the same with the changes removed too). Robbie - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
[VOTE] Release Apache Qpid Proton-J 0.30.0
Hi folks, I have put together a spin for a Qpid Proton-J 0.30.0 release, please test it and vote accordingly. The files can be grabbed from: https://dist.apache.org/repos/dist/dev/qpid/proton-j/0.30.0-rc1/ The maven artifacts are staged for now at: https://repository.apache.org/content/repositories/orgapacheqpid-1160 The JIRAs assigned are: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313720=12343875 Regards, Robbie P.S. If you want to test things out using maven with your own build you can temporarily add this to your poms to access the staging repo: staging https://repository.apache.org/content/repositories/orgapacheqpid-1160 The dependency for proton-j would then be: org.apache.qpid proton-j 0.30.0 - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
