Re: Patch + jira vs pull request

Thank you Ganesh for the explanation! Regards, Adel From: Ganesh Murthy <gmur...@redhat.com> Sent: Tuesday, February 28, 2017 3:31:57 PM To: users@qpid.apache.org Subject: Re: Patch + jira vs pull request A few days back, I had emailed Travis support and

Re: Patch + jira vs pull request

@qpid.apache.org > Sent: Tuesday, February 28, 2017 9:10:26 AM > Subject: Re: Patch + jira vs pull request > > Hello, > > > I was testing this morning the pull request mechanism. I was able to perform > the pull request however it seems Travis has not built it yet. > >

Re: Patch + jira vs pull request

From: Robbie Gemmell <robbie.gemm...@gmail.com> Sent: Monday, February 6, 2017 4:08:13 PM To: users@qpid.apache.org Subject: Re: Patch + jira vs pull request As an aside, for anyone else wanting to do this type of thing, I used this to add a remote called 'github' to my existing ch

Re: Patch + jira vs pull request

As an aside, for anyone else wanting to do this type of thing, I used this to add a remote called 'github' to my existing checkout and make the PRs available at ref github/pr/: git remote add github https://github.com/apache/qpid-java.git git config --local --add remote.github.fetch

Re: Patch + jira vs pull request

Slight retraction...JIRA mails will be getting blocked again right now, JIRA will need restarted to adjust the mails going forward. Robbie On 31 January 2017 at 16:21, Robbie Gemmell wrote: > There was an issue with the github setup, with the 'qpid-java' mirror > repo

Re: Patch + jira vs pull request

There was an issue with the github setup, with the 'qpid-java' mirror repo combined with 'qpid' svn sub-repo complicating matters, but that should be fixed now. The dev@ list was blockingthe JIRA traffic due to the format of the JIRA mails changing during the upgrade, those mails should now also

Re: Patch + jira vs pull request

On Mon, 2017-01-30 at 10:56 +, Chris Richardson wrote: > I have been wondering about this too and would definitely give a +1 > to the > pull request approach if it's an option. I'd just like to add to what Robbie said: Either a patch attached to a JIRA issue or a github PR work well as a

Re: Patch + jira vs pull request

Thanks Robbie. On 30/01/17 13:19, Robbie Gemmell wrote: Saying that made me look, and it seems like the GitHub integration is indeed not enabled on the apache/qpid-java mirror. There are a few old open Pull Requests and one test PR open+closed (nice account Lorenz :P), none of which have been

Re: Patch + jira vs pull request

n our case we use basically Atlassian Stash (now known as Bitbucket > Server) when mirroring the Qpid repositories. > > > Regards, > > Adel > > > From: Robbie Gemmell <robbie.gemm...@gmail.com> > Sent: Monday, January 30, 2017 2

Re: Patch + jira vs pull request

rds, Adel From: Robbie Gemmell <robbie.gemm...@gmail.com> Sent: Monday, January 30, 2017 2:19:24 PM To: users@qpid.apache.org Subject: Re: Patch + jira vs pull request Saying that made me look, and it seems like the GitHub integration is indeed not enabled on

Re: Patch + jira vs pull request

Saying that made me look, and it seems like the GitHub integration is indeed not enabled on the apache/qpid-java mirror. There are a few old open Pull Requests and one test PR open+closed (nice account Lorenz :P), none of which have been visible on the list. I raised

Re: Patch + jira vs pull request

JIRA+PR or JIRA+patch, either approach is fine and works out largely the same for us in the end (almost identical if you really want, since you can get a patch by adding .patch to github pr/diff/commit URLs). Assuming the 'GitHub integration' stuff is enabled (and if it isn't, that would be an

Re: Patch + jira vs pull request

I think it is different for different components of Qpid. The Qpid broker for Java for example has not migrated its main repository to git. Also the GitHub mirror is treated as read-only. And it is quite possible that pull request might go unnoticed. So, for the Qpid broker for Java component

Re: Patch + jira vs pull request

I have been wondering about this too and would definitely give a +1 to the pull request approach if it's an option. /C On 28 January 2017 at 08:51, Adel Boutros wrote: > Hello, > > For some time we have been submitting jira issues with patches for > problems we have

Patch + jira vs pull request

Hello, For some time we have been submitting jira issues with patches for problems we have detected. However, it is also possible to perform a pull request on the github repositories. So I was wondering which method you prefer and why? Regards, Adel