Re: __PDS_FROM_2_EMAILS broken ?

2020-12-11 Thread John Hardin
On Fri, 11 Dec 2020, Benoit Branciard wrote: Le 10/12/2020 à 17:08, John Hardin a écrit : ...okay, I found the problem. None of my tests had a username with a period. Fixing. Good ! I cherry-picked your regex fix from

Re: __PDS_FROM_2_EMAILS broken ?

2020-12-11 Thread Benoit Branciard
Le 10/12/2020 à 17:08, John Hardin a écrit : ...okay, I found the problem. None of my tests had a username with a period. Fixing. Good ! I cherry-picked your regex fix from https://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox/jhardin/20_misc_testing.cf?r1=1884233=1884284, and

Re: __PDS_FROM_2_EMAILS broken ?

2020-12-10 Thread John Hardin
On Thu, 10 Dec 2020, Benoit Branciard wrote: Have there been any changes to the __PDS_FROM_2_EMAILS rule recently on 3.004002 branch ? Yes. I took another look at it prompted by the recent many-froms discussion and did a little tuning. Since latest update this night, we got significantly

Re: __PDS_FROM_2_EMAILS broken ?

2020-12-10 Thread Bill Cole
On 10 Dec 2020, at 5:25, Benoit Branciard wrote: Have there been any changes to the __PDS_FROM_2_EMAILS rule recently on 3.004002 branch ? SIDE NOTE: The default ruleset in only present on the "trunk" branch. Version dependencies within the ruleset are handled by conditional structures

Re: __PDS_FROM_2_EMAILS broken ?

2020-12-10 Thread Paul Stead
Sorry for the garbage in the signature from my $work email..

Re: __PDS_FROM_2_EMAILS broken ?

2020-12-10 Thread Paul Stead
There seems to have been - https://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox/jhardin/20_misc_testing.cf?r1=1884188=1884215_format=h Whilst this has my initials, it's actually in John's sandbox - I think this was a rule I submitted on the mailing list many moons ago. The

__PDS_FROM_2_EMAILS broken ?

2020-12-10 Thread Benoit Branciard
Hello, Have there been any changes to the __PDS_FROM_2_EMAILS rule recently on 3.004002 branch ? Since latest update this night, we got significantly more matches of meta rule PDS_FROM_2_EMAILS than previously, and for at least a dozen of them, the rule triggered despite the fact that both