Re: Increased memory consumption due to url encoding

2016-08-31 Thread Svetlin Zarev
Thanks Chris, I've created a pull request on github: https://github.com/apache/tomcat85/pull/3 > and then look at the diffs manually It's an almost complete rewrite and has very little in common with the old encoder Svetlin 2016-08-30 20:56 GMT+03:00 Christopher Schultz

Re: Increased memory consumption due to url encoding

2016-08-30 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Svetlin, On 8/28/16 12:57 PM, Svetlin Zarev wrote: > Hi, > > Today I had some free time, so I implemented a more (memory and > performance wise) efficient URLEncoder [1] and I'd like to > contribute it if there is interest for improvement in that

Re: Increased memory consumption due to url encoding

2016-08-28 Thread Svetlin Zarev
Hi, Today I had some free time, so I implemented a more (memory and performance wise) efficient URLEncoder [1] and I'd like to contribute it if there is interest for improvement in that area. My encoder has close to zero allocation rate (unless there is very high concurrency for the encode()

Re: Increased memory consumption due to url encoding

2016-08-12 Thread Rainer Jung
Am 11.08.2016 um 21:16 schrieb Jose María Zaragoza: 2016-08-10 14:29 GMT+02:00 Lazar Kirchev : Hello Christopher, I tried with 32 MB and even 24 MB heap and the CPU usage and response time remained the almost the same (the difference is negligible) as with 1 GB heap.

Re: Increased memory consumption due to url encoding

2016-08-11 Thread Jose María Zaragoza
2016-08-10 14:29 GMT+02:00 Lazar Kirchev : > Hello Christopher, > > I tried with 32 MB and even 24 MB heap and the CPU usage and response time > remained the almost the same (the difference is negligible) as with 1 GB > heap. The cumulative allocated memory for the

Re: Increased memory consumption due to url encoding

2016-08-10 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Lazar, On 8/10/16 8:29 AM, Lazar Kirchev wrote: > I tried with 32 MB and even 24 MB heap and the CPU usage and > response time remained the almost the same (the difference is > negligible) as with 1 GB heap. The cumulative allocated memory for >

Re: Increased memory consumption due to url encoding

2016-08-10 Thread Lazar Kirchev
Hello Christopher, I tried with 32 MB and even 24 MB heap and the CPU usage and response time remained the almost the same (the difference is negligible) as with 1 GB heap. The cumulative allocated memory for the HeapByteBuffer remains about 400 MB, but of course the frequency of GCs is

Re: Increased memory consumption due to url encoding

2016-08-09 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Lazar, On 8/9/16 8:40 AM, Lazar Kirchev wrote: > Hello! When handling requests which make use of request dispatcher, > Tomcat 7.0.70 allocates more memory in comparison to 7.0.69. This > seems to come from the encoding of the path introduced with

Increased memory consumption due to url encoding

2016-08-09 Thread Lazar Kirchev
Hello! When handling requests which make use of request dispatcher, Tomcat 7.0.70 allocates more memory in comparison to 7.0.69. This seems to come from the encoding of the path introduced with this change http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/